Protocol::queue() - Code Metrics - Inspection of "add connection class" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 14a217...c3bf76 )

by Baptiste

created 2017-09-03 13:06 UTC

Protocol::queue() A

↳ Parent: Protocol

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Protocol\v091;

use Innmind\AMQP\{
    Transport\Protocol as ProtocolInterface,
    Transport\Protocol\Version,
    Transport\Protocol\Connection as ConnectionInterface,
    Transport\Protocol\Channel as ChannelInterface,
    Transport\Protocol\Exchange as ExchangeInterface,
    Transport\Protocol\Queue as QueueInterface,
    Transport\Protocol\Basic as BasicInterface,
    Transport\Protocol\Transaction as TransactionInterface,
    Transport\Frame\Method,
    Exception\VersionNotUsable
};
use Innmind\Immutable\{
    Str,
    StreamInterface
};

final class Protocol implements ProtocolInterface
{
    private $version;
    private $read;
    private $connection;
    private $channel;
    private $exchange;
    private $queue;
    private $basic;
    private $transaction;

    public function __construct()
    {
        $this->version = new Version(0, 9, 1);
        $this->read = new Reader;
        $this->connection = new Connection;
        $this->channel = new Channel;
        $this->exchange = new Exchange;
        $this->queue = new Queue;
        $this->basic = new Basic;
        $this->transaction = new Transaction;
    }

    public function version(): Version
    {
        return $this->version;
    }

    public function use(Version $version): ProtocolInterface
    {
        if (!$version->compatibleWith($this->version)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            throw new VersionNotUsable($version);
        }

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritdoc}
     */
    public function read(Method $method, Str $arguments): StreamInterface
    {
        return ($this->read)($method, $arguments);
    }

    public function method(string $name): Method
    {
        return Methods::get($name);
    }

    public function connection(): ConnectionInterface
    {
        return $this->connection;
    }

    public function channel(): ChannelInterface
    {
        return $this->channel;
    }

    public function exchange(): ExchangeInterface
    {
        return $this->exchange;
    }

    public function queue(): QueueInterface
    {
        return $this->queue;
    }

    public function basic(): BasicInterface
    {
        return $this->basic;
    }

    public function transaction(): TransactionInterface
    {
        return $this->transaction;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport\Protocol\v091;
5
6		use Innmind\AMQP\{
7		Transport\Protocol as ProtocolInterface,
8		Transport\Protocol\Version,
9		Transport\Protocol\Connection as ConnectionInterface,
10		Transport\Protocol\Channel as ChannelInterface,
11		Transport\Protocol\Exchange as ExchangeInterface,
12		Transport\Protocol\Queue as QueueInterface,
13		Transport\Protocol\Basic as BasicInterface,
14		Transport\Protocol\Transaction as TransactionInterface,
15		Transport\Frame\Method,
16		Exception\VersionNotUsable
17		};
18		use Innmind\Immutable\{
19		Str,
20		StreamInterface
21		};
22
23		final class Protocol implements ProtocolInterface
24		{
25		private $version;
26		private $read;
27		private $connection;
28		private $channel;
29		private $exchange;
30		private $queue;
31		private $basic;
32		private $transaction;
33
34	63	public function __construct()
35		{
36	63	$this->version = new Version(0, 9, 1);
37	63	$this->read = new Reader;
38	63	$this->connection = new Connection;
39	63	$this->channel = new Channel;
40	63	$this->exchange = new Exchange;
41	63	$this->queue = new Queue;
42	63	$this->basic = new Basic;
43	63	$this->transaction = new Transaction;
44	63	}
45
46	3	public function version(): Version
47		{
48	3	return $this->version;
49		}
50
51	5	public function use(Version $version): ProtocolInterface
52		{
53	5	if (!$version->compatibleWith($this->version)) {
		1 ignored issue – show Documentation introduced 2017-09-03 13:09 UTC by Report Bug Copy Issue Report `$this->version` is of type `object<Innmind\AMQP\Transport\Protocol\Version>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54	2	throw new VersionNotUsable($version);
55		}
56
57	3	return $this;
		1 ignored issue – show Bug Best Practice introduced 2017-09-03 13:09 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`Innmind\AMQP\Transport\Protocol\v091\Protocol`) is incompatible with the return type declared by the interface `Innmind\AMQP\Transport\Protocol::use` of type `self`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
58		}
59
60		/**
61		* {@inheritdoc}
62		*/
63	3	public function read(Method $method, Str $arguments): StreamInterface
64		{
65	3	return ($this->read)($method, $arguments);
66		}
67
68	55	public function method(string $name): Method
69		{
70	55	return Methods::get($name);
71		}
72
73	3	public function connection(): ConnectionInterface
74		{
75	3	return $this->connection;
76		}
77
78	3	public function channel(): ChannelInterface
79		{
80	3	return $this->channel;
81		}
82
83	1	public function exchange(): ExchangeInterface
84		{
85	1	return $this->exchange;
86		}
87
88	1	public function queue(): QueueInterface
89		{
90	1	return $this->queue;
91		}
92
93	1	public function basic(): BasicInterface
94		{
95	1	return $this->basic;
96		}
97
98	1	public function transaction(): TransactionInterface
99		{
100	1	return $this->transaction;
101		}
102		}
103

Innmind / AMQP

GitHub Access Token became invalid

Push — develop ( 14a217...c3bf76 )

Protocol::queue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like