Innmind\AMQP\Transport\Frame\Value\UnsignedOctet::fromString()

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	UnsignedOctet::__toString()	0	3	1

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Frame\Value;

use Innmind\AMQP\Transport\Frame\Value;
use Innmind\Math\{
    Algebra\Integer,
    DefinitionSet\Set,
    DefinitionSet\Range,
};
use Innmind\Stream\Readable;

/**
 * Same as unsigned shortshort
 */
final class UnsignedOctet implements Value
{
    private static $definitionSet;

    private $value;
    private $original;

    public function __construct(Integer $octet)
    {
        $this->original = $octet;
    }

    public static function fromStream(Readable $stream): Value
    {
        [, $octet] = unpack('C', (string) $stream->read(1));

        return new self(new Integer($octet));
    }

    public function original(): Integer
    {
        return $this->original;
    }

    public function __toString(): string
    {
        return $this->value ?? $this->value = chr($this->original->value());

It seems like $this->original->value() can also be of type double; however, parameter $ascii of chr() does only seem to accept integer, maybe add an additional type check?

    }

    public static function definitionSet(): Set
    {
        return self::$definitionSet ?? self::$definitionSet = Range::inclusive(
            new Integer(0),
            new Integer(255)
        );
    }
}