Innmind\AMQP\Transport\Connection\FrameReader::__invoke()

Complexity

Conditions	10
Paths	8

Size

Total Lines	74
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	43
CRAP Score	10.001

Importance

Changes

0

<?php
    public function __invoke(Readable $stream, Protocol $protocol): Frame
    {
        $octet = UnsignedOctet::fromStream($stream);

        try {
            $type = Type::fromInt($octet->original()->value());
        } catch (UnknownFrameType $e) {
            throw new NoFrameDetected(new StringStream(
                (string) $stream->read()->prepend((string) $octet)
            ));
        }

        $channel = new Channel(
            UnsignedShortInteger::fromStream($stream)->original()->value()
        );
        $payload = $stream
            ->read(UnsignedLongInteger::fromStream($stream)->original()->value())
            ->toEncoding('ASCII');

        if (
            (
                $type === Type::method() ||
                $type === Type::header()
            ) &&
            $payload->length() < 4
        ) {
            throw new PayloadTooShort;
        }

        $end = UnsignedOctet::fromStream($stream)->original()->value();

        if ($end !== Frame::end()) {
            throw new ReceivedFrameNotDelimitedCorrectly;
        }

        $payload = new StringStream((string) $payload);

        switch ($type) {
            case Type::method():
                $method = new Method(
                    UnsignedShortInteger::fromStream($payload)
                        ->original()
                        ->value(),
                    UnsignedShortInteger::fromStream($payload)
                        ->original()
                        ->value()
                );

                return Frame::method(
                    $channel,
                    $method,
                    ...$protocol->read($method, $payload)
                );

            case Type::header():
                $class = UnsignedShortInteger::fromStream($payload)
                    ->original()
                    ->value();
                $payload->read(2); // walk over the weight definition

                return Frame::header(
                    $channel,
                    $class,

It seems like $class can also be of type double; however, parameter $class of Innmind\AMQP\Transport\Frame::header() does only seem to accept integer, maybe add an additional type check?

                    ...$protocol->readHeader($payload)
                );

            case Type::body():
                return Frame::body($channel, $payload->read());

            case Type::heartbeat():
                return Frame::heartbeat();

            default:
                throw new LogicException; //if reached then there's an implementation error
        }