Table::fromString() - Code Metrics - Inspection of "add classes to read all possible responses" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( faae32...638f88 )

by Baptiste

created 2017-08-15 15:32 UTC

Table::fromString() B

↳ Parent: Table

Complexity

Conditions	3
Paths	3

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	3.0021

Importance

Changes

Metric	Value
dl	0
loc	27
ccs	15
cts	16
cp	0.9375
rs	8.8571
c	0
b	0
f	0
cc	3
eloc	16
nc	3
nop	1
crap	3.0021

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Frame\Value;

use Innmind\AMQP\Transport\Frame\Value;
use Innmind\Math\Algebra\Integer;
use Innmind\Immutable\{
    Str,
    Sequence as Seq,
    MapInterface,
    Map
};

final class Table implements Value
{
    private $value;
    private $original;

    /**
     * @param MapInterface<string, Value> $map
     */
    public function __construct(MapInterface $map)
    {
        if (
            (string) $map->keyType() !== 'string' ||
            (string) $map->valueType() !== Value::class
        ) {
            throw new \TypeError(sprintf(
                'Argument 1 must be of type MapInterface<string, %s>',
                Value::class
            ));
        }

        $data = $map
            ->reduce(
                new Seq,
                static function(Seq $sequence, string $key, Value $value): Seq {
                    return $sequence
                        ->add(new ShortString(new Str($key)))
                        ->add(Symbols::symbol(get_class($value)))
                        ->add($value);
                }
            )
            ->join('')
            ->toEncoding('ASCII');

        $this->value = (string) new UnsignedLongInteger(
            new Integer($data->length())
        );
        $this->value .= $data;
        $this->original = $map;
    }

    public static function fromString(Str $string): Value
    {
        $string = $string->toEncoding('ASCII');
        $length = UnsignedLongInteger::fromString($string->substring(0, 4))->original();
        $string = $string->substring(4);

        if ($string->length() !== $length->value()) {
            throw new StringNotOfExpectedLength($string, $length->value());
        }

        $map = new Map('string', Value::class);

        while ($string->length() !== 0) {
            $key = ShortString::cut($string);
            $string = $string->toEncoding('ASCII')->substring($key->length());
            $key = ShortString::fromString($key)->original();

            $class = Symbols::class((string) $string->substring(0, 1));
            $element = [$class, 'cut']($string->substring(1))->toEncoding('ASCII');

            $map = $map->put((string) $key, [$class, 'fromString']($element));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $string = $string->substring($element->length() + 1);
        }

        return new self($map);
    }

    public static function cut(Str $string): Str
    {
        $string = $string->toEncoding('ASCII');
        $length = UnsignedLongInteger::fromString(
            UnsignedLongInteger::cut($string)
        )->original();

        return $string->substring(0, $length->value() + 4);
    }

    /**
     * @return MapInterface<string, Value>

     */
    public function original(): MapInterface
    {
        return $this->original;
    }

    public function __toString(): string
    {
        return $this->value;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport\Frame\Value;
5
6		use Innmind\AMQP\Transport\Frame\Value;
7		use Innmind\Math\Algebra\Integer;
8		use Innmind\Immutable\{
9		Str,
10		Sequence as Seq,
11		MapInterface,
12		Map
13		};
14
15		final class Table implements Value
16		{
17		private $value;
18		private $original;
19
20		/**
21		* @param MapInterface<string, Value> $map
22		*/
23	6	public function __construct(MapInterface $map)
24		{
25		if (
26	6	(string) $map->keyType() !== 'string' \|\|
27	6	(string) $map->valueType() !== Value::class
28		) {
29	1	throw new \TypeError(sprintf(
30	1	'Argument 1 must be of type MapInterface<string, %s>',
31	1	Value::class
32		));
33		}
34
35		$data = $map
36	5	->reduce(
37	5	new Seq,
38	5	static function(Seq $sequence, string $key, Value $value): Seq {
39		return $sequence
40	4	->add(new ShortString(new Str($key)))
41	4	->add(Symbols::symbol(get_class($value)))
42	4	->add($value);
43	5	}
44		)
45	5	->join('')
46	5	->toEncoding('ASCII');
47
48	5	$this->value = (string) new UnsignedLongInteger(
49	5	new Integer($data->length())
50		);
51	5	$this->value .= $data;
52	5	$this->original = $map;
53	5	}
54
55	2	public static function fromString(Str $string): Value
56		{
57	2	$string = $string->toEncoding('ASCII');
58	2	$length = UnsignedLongInteger::fromString($string->substring(0, 4))->original();
59	2	$string = $string->substring(4);
60
61	2	if ($string->length() !== $length->value()) {
62		throw new StringNotOfExpectedLength($string, $length->value());
63		}
64
65	2	$map = new Map('string', Value::class);
66
67	2	while ($string->length() !== 0) {
68	2	$key = ShortString::cut($string);
69	2	$string = $string->toEncoding('ASCII')->substring($key->length());
70	2	$key = ShortString::fromString($key)->original();
71
72	2	$class = Symbols::class((string) $string->substring(0, 1));
73	2	$element = [$class, 'cut']($string->substring(1))->toEncoding('ASCII');
74
75	2	$map = $map->put((string) $key, [$class, 'fromString']($element));
		1 ignored issue – show Documentation introduced 2017-08-15 15:36 UTC by Report Bug Copy Issue Report `(string) $key` is of type `string`, but the function expects a `object<Innmind\Immutable\T>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76
77	2	$string = $string->substring($element->length() + 1);
78		}
79
80	2	return new self($map);
81		}
82
83	2	public static function cut(Str $string): Str
84		{
85	2	$string = $string->toEncoding('ASCII');
86	2	$length = UnsignedLongInteger::fromString(
87	2	UnsignedLongInteger::cut($string)
88	2	)->original();
89
90	2	return $string->substring(0, $length->value() + 4);
91		}
92
93		/**
94		* @return MapInterface<string, Value>
		0 ignored issues – show Documentation introduced 2017-08-15 15:36 UTC by Report Bug Copy Issue Report The doc-type `MapInterface<string,` could not be parsed: Expected "\|" or "end of type", but got "<" at position 12. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
95		*/
96	4	public function original(): MapInterface
97		{
98	4	return $this->original;
99		}
100
101	4	public function __toString(): string
102		{
103	4	return $this->value;
104		}
105		}
106

Innmind / AMQP

GitHub Access Token became invalid

Push — develop ( faae32...638f88 )

Table::fromString() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like