SignedLongLongInteger::fromString() - Code Metrics - Inspection of "add classes to read all possible responses" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( faae32...638f88 )

by Baptiste

created 2017-08-15 15:32 UTC

SignedLongLongInteger::fromString() A

↳ Parent: SignedLongLongInteger

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1
crap	2

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Frame\Value;

use Innmind\AMQP\{
    Transport\Frame\Value,
    Exception\StringNotOfExpectedLength
};
use Innmind\Math\Algebra\Integer;
use Innmind\Immutable\Str;

final class SignedLongLongInteger implements Value
{
    private $value;
    private $original;

    public function __construct(Integer $value)
    {
        $this->value = pack('q', $value->value());
        $this->original = $value;
    }

    public static function fromString(Str $string): Value
    {
        $string = $string->toEncoding('ASCII');

        if ($string->length() !== 8) {
            throw new StringNotOfExpectedLength($string, 8);
        }

        [, $value] = unpack('q', (string) $string);


        return new self(new Integer($value));
    }

    public static function cut(Str $string): Str
    {
        return $string->toEncoding('ASCII')->substring(0, 8);
    }

    public function original(): Integer
    {
        return $this->original;
    }

    public function __toString(): string
    {
        return $this->value;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport\Frame\Value;
5
6		use Innmind\AMQP\{
7		Transport\Frame\Value,
8		Exception\StringNotOfExpectedLength
9		};
10		use Innmind\Math\Algebra\Integer;
11		use Innmind\Immutable\Str;
12
13		final class SignedLongLongInteger implements Value
14		{
15		private $value;
16		private $original;
17
18	13	public function __construct(Integer $value)
19		{
20	13	$this->value = pack('q', $value->value());
21	13	$this->original = $value;
22	13	}
23
24	7	public static function fromString(Str $string): Value
25		{
26	7	$string = $string->toEncoding('ASCII');
27
28	7	if ($string->length() !== 8) {
29	1	throw new StringNotOfExpectedLength($string, 8);
30		}
31
32	6	[, $value] = unpack('q', (string) $string);
		1 ignored issue – show Bug introduced 2017-08-15 15:36 UTC by Report Bug Copy Issue Report The variable `$value` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
33
34	6	return new self(new Integer($value));
35		}
36
37	6	public static function cut(Str $string): Str
38		{
39	6	return $string->toEncoding('ASCII')->substring(0, 8);
40		}
41
42	12	public function original(): Integer
43		{
44	12	return $this->original;
45		}
46
47	12	public function __toString(): string
48		{
49	12	return $this->value;
50		}
51		}
52

Innmind / AMQP

GitHub Access Token became invalid

Push — develop ( faae32...638f88 )

SignedLongLongInteger::fromString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like