Exchange::__invoke() - Code Metrics - Inspection of "fix frame construction" - Innmind/AMQP - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 638f88...e189ab )

by Baptiste

created 2017-08-15 15:37 UTC

Exchange::__invoke() A

↳ Parent: Exchange

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	11
nc	3
nop	2
crap	3

<?php
declare(strict_types = 1);

namespace Innmind\AMQP\Transport\Protocol\v091\Reader;

use Innmind\AMQP\{
    Transport\Frame\Method,
    Transport\Frame\Visitor\Arguments,
    Transport\Protocol\v091\Methods,
    Exception\UnknownMethod
};
use Innmind\Immutable\{
    Str,
    StreamInterface
};

final class Exchange
{
    /**
     * @return StreamInterface<Value>

     */
    public function __invoke(Method $method, Str $arguments): StreamInterface
    {
        switch (true) {
            case Methods::get('exchange.declare-ok')->equals($method):
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $visit = $this->declareOk();
                break;

            case Methods::get('exchange.delete-ok')->equals($method):
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $visit = $this->deleteOk();
                break;

            default:
                throw new UnknownMethod($method);
        }

        return $visit($arguments);
    }

    private function declareOk(): Arguments
    {
        return new Arguments; //no arguments
    }

    private function deleteOk(): Arguments
    {
        return new Arguments; //no arguments
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace Innmind\AMQP\Transport\Protocol\v091\Reader;
5
6		use Innmind\AMQP\{
7		Transport\Frame\Method,
8		Transport\Frame\Visitor\Arguments,
9		Transport\Protocol\v091\Methods,
10		Exception\UnknownMethod
11		};
12		use Innmind\Immutable\{
13		Str,
14		StreamInterface
15		};
16
17		final class Exchange
18		{
19		/**
20		* @return StreamInterface<Value>
		0 ignored issues – show Documentation introduced 2017-08-15 15:36 UTC by Report Bug Copy Issue Report The doc-type `StreamInterface<Value>` could not be parsed: Expected "\|" or "end of type", but got "<" at position 15. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
21		*/
22	5	public function __invoke(Method $method, Str $arguments): StreamInterface
23		{
24		switch (true) {
25	5	case Methods::get('exchange.declare-ok')->equals($method):
		1 ignored issue – show Documentation introduced 2017-08-15 15:38 UTC by Report Bug Copy Issue Report `$method` is of type `object<Innmind\AMQP\Transport\Frame\Method>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26	2	$visit = $this->declareOk();
27	2	break;
28
29	3	case Methods::get('exchange.delete-ok')->equals($method):
		1 ignored issue – show Documentation introduced 2017-08-15 15:38 UTC by Report Bug Copy Issue Report `$method` is of type `object<Innmind\AMQP\Transport\Frame\Method>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30	2	$visit = $this->deleteOk();
31	2	break;
32
33		default:
34	1	throw new UnknownMethod($method);
35		}
36
37	4	return $visit($arguments);
38		}
39
40	2	private function declareOk(): Arguments
41		{
42	2	return new Arguments; //no arguments
43		}
44
45	2	private function deleteOk(): Arguments
46		{
47	2	return new Arguments; //no arguments
48		}
49		}
50

Innmind / AMQP

GitHub Access Token became invalid

Push — develop ( 638f88...e189ab )

Exchange::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like