indigerd\scenarios\validation\validator\InValidator

Complexity

Total Complexity

17

Size/Duplication

Total Lines	49
Duplicated Lines	6.12 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setValidSet()	0	13	4
C	validate()	3	26	13

<?php declare(strict_types=1);

namespace indigerd\scenarios\validation\validator;

class InValidator extends AbstractValidator
{
    protected $validSet = [];

    protected $notIn = false;

    protected $message = 'Value do not belongs to valid set';

    public function setValidSet($value) : self
    {
        if (!\is_array($value)
            and !($value instanceof \Closure)
            and !($value instanceof \Traversable)
        ) {
            throw new \InvalidArgumentException(
                'Invalid validSet property value. Value must be either array or \Closure or \Traversable'
            );
        }
        $this->validSet = $value;

It seems like $value can also be of type object<Closure> or object<Traversable>. However, the property $validSet is declared as type array. Maybe add an additional type check?

        return $this;
    }

    public function validate($value, array $context = []) : bool
    {
        if ($this->skipOnEmpty and ($value === null || $value === [] || $value === '')) {

This code seems to be duplicated across your project.

            return true;
        }
        if ($this->validSet instanceof \Closure) {
            $this->validSet = $this->validSet();

The method validSet() does not exist on indigerd\scenarios\validation\validator\InValidator. Did you maybe mean setValidSet()?

            if (!\is_array($this->validSet) and !($this->validSet instanceof \Traversable)) {
                throw new \InvalidArgumentException(
                    'Invalid validSet callback.'
                );
            }
        }
        $in = false;
        if ($this->validSet instanceof \Traversable) {
            foreach ($this->validSet as $v) {
                if ($value == $v) {
                    $in = true;
                }
            }
        }
        if (\is_array($this->validSet)) {
            $in = \in_array($value, $this->validSet);
        }
        return $this->notIn !== $in ? true : false;
    }
}