Incenteev\TranslationCheckerBundle\Translator\Extractor\JsExtractor

Complexity

Total Complexity

12

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	extract()	0	28	6
B	extractTranslations()	0	32	5

<?php

namespace Incenteev\TranslationCheckerBundle\Translator\Extractor;

use Symfony\Component\Finder\Finder;
use Symfony\Component\Translation\MessageCatalogue;

class JsExtractor implements ExtractorInterface
{
    private $paths;
    private $defaultDomain;

    /**
     * @param string[] $paths
     * @param string   $defaultDomain
     */
    public function __construct(array $paths, $defaultDomain)
    {
        $this->paths = $paths;
        $this->defaultDomain = $defaultDomain;
    }

    public function extract(MessageCatalogue $catalogue)
    {
        $directories = array();

        foreach ($this->paths as $path) {
            if (is_dir($path)) {
                $directories[] = $path;

                continue;
            }

            if (is_file($path)) {
                $this->extractTranslations($catalogue, file_get_contents($path));
            }
        }

        if ($directories) {

The expression $directories of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $finder = new Finder();

            $finder->files()
                ->in($directories)
                ->name('*.js');

            foreach ($finder as $file) {
                $this->extractTranslations($catalogue, $file->getContents());
            }
        }
    }

    private function extractTranslations(MessageCatalogue $catalogue, $fileContent)
    {
        $pattern = <<<REGEXP
/
\.trans(?:Choice)?\s*+\(\s*+
(?:
    '([^']++)' # single-quoted string
    |
    "([^"]++)" # double-quoted string
)
\s*+[,)] # followed by a comma (for next arguments) or the closing parenthesis, to be sure we got the whole argument (no concatenation to something else)
/x
REGEXP;

        preg_match_all($pattern, $fileContent, $matches);

        foreach ($matches[1] as $match) {
            if (empty($match)) {
                continue;
            }

            $catalogue->set($match, $match, $this->defaultDomain);
        }

        foreach ($matches[2] as $match) {
            if (empty($match)) {
                continue;
            }

            $catalogue->set($match, $match, $this->defaultDomain);
        }
    }
}