Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | View Code Duplication | class PermissionResolver implements \ArrayAccess, \IteratorAggregate, PermissionResolverInterface |
|
15 | { |
||
16 | /** |
||
17 | * Synthesizes the `users_permission_resolver_list` config from `users` fragments. |
||
18 | * |
||
19 | * @param array $fragments |
||
20 | * |
||
21 | * @return array |
||
22 | */ |
||
23 | static public function synthesize_config(array $fragments) |
||
24 | { |
||
25 | $list = []; |
||
26 | $weight = []; |
||
27 | |||
28 | foreach ($fragments as $fragment) |
||
29 | { |
||
30 | if (empty($fragment['permission_resolver_list'])) |
||
31 | { |
||
32 | continue; |
||
33 | } |
||
34 | |||
35 | foreach ($fragment['permission_resolver_list'] as $resolver_id => $resolver) |
||
36 | { |
||
37 | $resolver = ((array) $resolver) + [ 'weight' => 0 ]; |
||
38 | |||
39 | $list[$resolver_id] = $resolver[0]; |
||
40 | $weight[$resolver_id] = $resolver['weight']; |
||
41 | } |
||
42 | } |
||
43 | |||
44 | return \ICanBoogie\sort_by_weight($list, function($v, $k) use($weight) { |
||
45 | |||
46 | return $weight[$k]; |
||
47 | |||
48 | }); |
||
49 | } |
||
50 | |||
51 | private $list = []; |
||
52 | |||
53 | /** |
||
54 | * Initializes the permission resolver list. |
||
55 | * |
||
56 | * @param array $resolver_list A permission resolver list, such as one created by |
||
57 | * {@link autoconfig()}. |
||
58 | */ |
||
59 | public function __construct(array $resolver_list = []) |
||
60 | { |
||
61 | foreach ($resolver_list as $resolver_id => $resolver) |
||
62 | { |
||
63 | $this[$resolver_id] = $resolver; |
||
64 | } |
||
65 | } |
||
66 | |||
67 | public function __invoke(User $user, $permission, $target = null) |
||
68 | { |
||
69 | $granted = false; |
||
70 | |||
71 | foreach ($this->list as $resolver_id => &$resolver) |
||
72 | { |
||
73 | if (!is_callable($resolver)) |
||
74 | { |
||
75 | $resolver = new $resolver; |
||
76 | } |
||
77 | |||
78 | $resolver_grant = call_user_func($resolver, $user, $permission, $target); |
||
79 | |||
80 | if ($resolver_grant === null) |
||
81 | { |
||
82 | continue; |
||
83 | } |
||
84 | |||
85 | $granted = $resolver_grant; |
||
86 | } |
||
87 | |||
88 | return $granted; |
||
89 | } |
||
90 | |||
91 | public function getIterator() |
||
95 | |||
96 | public function offsetExists($resolver_id) |
||
100 | |||
101 | public function offsetGet($resolver_id) |
||
105 | |||
106 | public function offsetSet($resolver_id, $resolver) |
||
110 | |||
111 | public function offsetUnset($resolver_id) |
||
115 | } |
||
116 | |||
117 | interface PermissionResolverInterface |
||
118 | { |
||
130 |