Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
25 | View Code Duplication | class DeactivateOperation extends Operation |
|
26 | { |
||
27 | /** |
||
28 | * @inheritdoc |
||
29 | */ |
||
30 | protected function get_controls() |
||
31 | { |
||
32 | return [ |
||
33 | |||
34 | self::CONTROL_PERMISSION => Module::PERMISSION_ADMINISTER, |
||
35 | self::CONTROL_RECORD => true, |
||
36 | self::CONTROL_OWNERSHIP => true |
||
37 | |||
38 | ] + parent::get_controls(); |
||
39 | } |
||
40 | |||
41 | /** |
||
42 | * @inheritdoc |
||
43 | */ |
||
44 | protected function validate(ErrorCollection $errors) |
||
48 | |||
49 | /** |
||
50 | * @inheritdoc |
||
51 | */ |
||
52 | protected function process() |
||
66 | } |
||
67 |