Completed
Push — 3.0 ( 146ff5...da916b )
by Olivier
04:40
created
lib/Hooks.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 class Hooks
20 20
 {
21 21
 	/**
22
-	 * @param Core|Binding\CoreBindings $app
22
+	 * @param Core $app
23 23
 	 *
24 24
 	 * @return FileStorageIndex
25 25
 	 */
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
 	}
32 32
 
33 33
 	/**
34
-	 * @param Core|Binding\CoreBindings $app
34
+	 * @param Core $app
35 35
 	 *
36 36
 	 * @return FileStorage
37 37
 	 */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
 	{
28 28
 		static $index;
29 29
 
30
-		return $index ?: $index = new FileStorageIndex(\ICanBoogie\REPOSITORY . 'files-index');
30
+		return $index ?: $index = new FileStorageIndex(\ICanBoogie\REPOSITORY.'files-index');
31 31
 	}
32 32
 
33 33
 	/**
@@ -39,6 +39,6 @@  discard block
 block discarded – undo
39 39
 	{
40 40
 		static $manager;
41 41
 
42
-		return $manager ?: $manager = new FileStorage(\ICanBoogie\REPOSITORY . 'files', $app->file_storage_index);
42
+		return $manager ?: $manager = new FileStorage(\ICanBoogie\REPOSITORY.'files', $app->file_storage_index);
43 43
 	}
44 44
 }
Please login to merge, or discard this patch.
lib/Storage/FileStorage.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
 	 *
106 106
 	 * If a file has no reference left it is deleted.
107 107
 	 *
108
-	 * @param $key_or_id_or_uuid_or_hash
108
+	 * @param string $key_or_id_or_uuid_or_hash
109 109
 	 */
110 110
 	public function release($key_or_id_or_uuid_or_hash)
111 111
 	{
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 			throw new \InvalidArgumentException("`\$root` parameter cannot be empty.");
53 53
 		}
54 54
 
55
-		$this->root = rtrim($root, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
55
+		$this->root = rtrim($root, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR;
56 56
 		$this->index = $index;
57 57
 	}
58 58
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 	{
70 70
 		$this->assert_hash_is_used($hash);
71 71
 
72
-		$key = IndexKey::from([ $nid, $uuid, $hash ]);
72
+		$key = IndexKey::from([$nid, $uuid, $hash]);
73 73
 
74 74
 		$this->index->add($key);
75 75
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 	protected function find_by_hash($hash)
166 166
 	{
167 167
 		$di = new \DirectoryIterator($this->root);
168
-		$di = new \RegexIterator($di, '#^' . preg_quote($hash) . '\-#');
168
+		$di = new \RegexIterator($di, '#^'.preg_quote($hash).'\-#');
169 169
 
170 170
 		foreach ($di as $file)
171 171
 		{
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 	{
205 205
 		$hash = $hash ?: $this->hash($pathname);
206 206
 
207
-		return Pathname::from([ $this->root, $hash ]);
207
+		return Pathname::from([$this->root, $hash]);
208 208
 	}
209 209
 
210 210
 	/**
Please login to merge, or discard this patch.
lib/Storage/FileStorageIndex.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@
 block discarded – undo
118 118
 	/**
119 119
 	 * Deletes key(s) from the index.
120 120
 	 *
121
-	 * @param IndexKey|int|string $key_or_id_or_uuid_or_hash
121
+	 * @param IndexKey $key_or_id_or_uuid_or_hash
122 122
 	 *
123 123
 	 * @throws \InvalidArgumentException if `$key_or_id_or_uuid_or_hash` is not of the expected type.
124 124
 	 */
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 */
81 81
 	public function __construct($root)
82 82
 	{
83
-		$this->root = rtrim($root, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR;
83
+		$this->root = rtrim($root, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR;
84 84
 	}
85 85
 
86 86
 	/**
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	 */
93 93
 	public function add(IndexKey $key)
94 94
 	{
95
-		touch($this->root . $key);
95
+		touch($this->root.$key);
96 96
 
97 97
 		foreach ($this->find_by_id($key->id) as $match)
98 98
 		{
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
 
134 134
 		foreach ($matching as $match)
135 135
 		{
136
-			unlink($this->root . $match);
136
+			unlink($this->root.$match);
137 137
 		}
138 138
 	}
139 139
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 
160 160
 		$type = $methods[self::resolve_matching_type($key_or_id_or_uuid_or_hash)];
161 161
 
162
-		return $this->{ 'find_by_' . $type }($key_or_id_or_uuid_or_hash);
162
+		return $this->{ 'find_by_'.$type }($key_or_id_or_uuid_or_hash);
163 163
 	}
164 164
 
165 165
 	/**
@@ -171,9 +171,9 @@  discard block
 block discarded – undo
171 171
 	 */
172 172
 	protected function find_by_key($key)
173 173
 	{
174
-		$pathname = $this->root . $key;
174
+		$pathname = $this->root.$key;
175 175
 
176
-		return file_exists($pathname) ? [ $key ] : null;
176
+		return file_exists($pathname) ? [$key] : null;
177 177
 	}
178 178
 
179 179
 	/**
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 	 */
186 186
 	protected function find_by_id($id)
187 187
 	{
188
-		return $this->matching('#^' . preg_quote(IndexKey::encode_id($id)) . '\-#');
188
+		return $this->matching('#^'.preg_quote(IndexKey::encode_id($id)).'\-#');
189 189
 	}
190 190
 
191 191
 	/**
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 	 */
198 198
 	protected function find_by_encoded_uuid($encoded_uuid)
199 199
 	{
200
-		return $this->matching("#^.{" . IndexKey::ENCODED_ID_LENGTH . '}\-' . preg_quote($encoded_uuid) . '\-#');
200
+		return $this->matching("#^.{".IndexKey::ENCODED_ID_LENGTH.'}\-'.preg_quote($encoded_uuid).'\-#');
201 201
 	}
202 202
 
203 203
 	/**
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 	 */
222 222
 	protected function find_by_hash($hash)
223 223
 	{
224
-		return $this->matching("#^.{" . IndexKey::ENCODED_ID_LENGTH . '}\-.{' . IndexKey::ENCODED_UUID_LENGTH . '}\-' . preg_quote($hash) . '#');
224
+		return $this->matching("#^.{".IndexKey::ENCODED_ID_LENGTH.'}\-.{'.IndexKey::ENCODED_UUID_LENGTH.'}\-'.preg_quote($hash).'#');
225 225
 	}
226 226
 
227 227
 	/**
Please login to merge, or discard this patch.
lib/Storage/IndexKey.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 	 *
70 70
 	 * @param string $key
71 71
 	 *
72
-	 * @return array
72
+	 * @return string[]
73 73
 	 */
74 74
 	static private function parse_key($key)
75 75
 	{
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 		$encoded_uuid = substr($key, self::ENCODED_ID_LENGTH + 1, self::ENCODED_UUID_LENGTH);
78 78
 		$hash = substr($key, self::ENCODED_ID_LENGTH + 1 + self::ENCODED_UUID_LENGTH + 1);
79 79
 
80
-		return [ $encoded_id, $encoded_uuid, $hash ];
80
+		return [$encoded_id, $encoded_uuid, $hash];
81 81
 	}
82 82
 
83 83
 	/**
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
 	 */
104 104
 	static public function encode_id($id)
105 105
 	{
106
-		return sprintf('%0' . self::ENCODED_ID_LENGTH . 'x', $id);
106
+		return sprintf('%0'.self::ENCODED_ID_LENGTH.'x', $id);
107 107
 	}
108 108
 
109 109
 	/**
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 			throw new \LogicException("Invalid UUID: $uuid.");
133 133
 		}
134 134
 
135
-		return Base64::encode_unpadded(hex2bin(strtr($uuid, [ '-' => '' ])));
135
+		return Base64::encode_unpadded(hex2bin(strtr($uuid, ['-' => ''])));
136 136
 	}
137 137
 
138 138
 	/**
Please login to merge, or discard this patch.
lib/Block/ManageBlock/DownloadColumn.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
  */
12 12
 class DownloadColumn extends ManageBlock\Column
13 13
 {
14
-	public function __construct(ManageBlock $manager, $id, array $options=[])
14
+	public function __construct(ManageBlock $manager, $id, array $options = [])
15 15
 	{
16 16
 		parent::__construct($manager, $id, [
17 17
 
Please login to merge, or discard this patch.
lib/Facets/SizeCriterion.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 		{
30 30
 			$value = $modifiers['size'];
31 31
 
32
-			if (in_array($value, [ 'l', 'm', 's' ]))
32
+			if (in_array($value, ['l', 'm', 's']))
33 33
 			{
34 34
 				$filters['size'] = $value;
35 35
 			}
Please login to merge, or discard this patch.
lib/Storage/Base64.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 	 */
26 26
 	static public function encode($data)
27 27
 	{
28
-		return strtr(base64_encode($data), [ '+' => '-', '/' => '_' ]);
28
+		return strtr(base64_encode($data), ['+' => '-', '/' => '_']);
29 29
 	}
30 30
 
31 31
 	/**
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
 	 */
38 38
 	static public function decode($data)
39 39
 	{
40
-		return base64_decode(strtr($data, [ '-' => '+', '_' => '/' ]));
40
+		return base64_decode(strtr($data, ['-' => '+', '_' => '/']));
41 41
 	}
42 42
 
43 43
 	/**
Please login to merge, or discard this patch.
updates.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
 		foreach ($model->select("nid, path")->mode(\PDO::FETCH_NUM) as list($nid, $path))
64 64
 		{
65
-			$update('.' . pathinfo($path, PATHINFO_EXTENSION), $nid);
65
+			$update('.'.pathinfo($path, PATHINFO_EXTENSION), $nid);
66 66
 		}
67 67
 	}
68 68
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
 		foreach ($model->select("nid, uuid, path")->mode(\PDO::FETCH_NUM) as list($nid, $uuid, $path))
86 86
 		{
87
-			$path = $document_root . $path;
87
+			$path = $document_root.$path;
88 88
 
89 89
 			if (!file_exists($path))
90 90
 			{
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 			}
95 95
 
96 96
 			$hash = $storage->add($path)->hash;
97
-			$index->add(IndexKey::from([ $nid, $uuid, $hash ]));
97
+			$index->add(IndexKey::from([$nid, $uuid, $hash]));
98 98
 		}
99 99
 
100 100
 		$model->remove_column('path');
Please login to merge, or discard this patch.
lib/Routing/FilesController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
 		return new FileResponse($pathname, $this->request, [
81 81
 
82 82
 			FileResponse::OPTION_ETAG => $pathname->hash,
83
-			FileResponse::OPTION_FILENAME => $record->title . $record->extension,
83
+			FileResponse::OPTION_FILENAME => $record->title.$record->extension,
84 84
 			FileResponse::OPTION_MIME => $record->mime
85 85
 
86 86
 		]);
Please login to merge, or discard this patch.