Issues in Folder.php (master) - Issues in master - IQParts/content - Measure and Improve Code Quality continuously with Scrutinizer

Issues (14)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Object/Folder.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace IQParts\Content\Object;

use League\Flysystem\Directory;

/**
 * Class Folder
 * @package IQParts\Content\Object
 */
final class Folder extends Item
{
    /**
     * @var Directory
     */
    private $directory;
    /**
     * @var string
     */
    private $path;
    /**
     * @var string|null
     */
    private $parent;
    /**
     * @var string
     */
    private $basename;
    /**
     * @var array
     */
    private $dirs;
    /**
     * @var array
     */
    private $files;

    /**
     * Folder constructor.
     * @param Directory $directory
     */
    public function __construct(Directory $directory = null)
    {
        if ($directory) {
            $this->directory = $directory;
            $this->path = $directory->getPath();
            $filesystem = $directory->getFilesystem();

            $parentSep = strrpos($this->path, '/');
            if ($parentSep !== false) {
                $parent = substr($this->path, 0, $parentSep);
            } else $parent = '/';
            $this->parent = base64_encode($parent);
            $this->basename = basename($this->path);

            $paths = $filesystem->listContents($this->path);
            $dirs = [];
            $files = [];

            foreach ($paths as $path) {
                $item = $filesystem->get($path['path']);
                if ($item instanceof Directory) {
                    $dirs[] = base64_encode($item->getPath());
                } else {
                    $files[] = base64_encode($item->getPath());
                }
            }
            $this->dirs = $dirs;
            $this->files = $files;
        }
    }

    /**
     * @return Directory
     */
    public function getDirectory(): Directory
    {
        return $this->directory;
    }

    /**
     * @return string
     */
    public function getId(): string
    {
        return base64_encode($this->getPath());
    }

    /**
     * @return string
     */
    public function getPath(): string
    {
        return $this->path;
    }

    /**
     * @return string|null
     */
    public function getParent()
    {
        return $this->parent;
    }

    /**
     * @return string
     */
    public function getBasename(): string
    {
        return $this->basename;
    }

    /**
     * @return array
     */
    public function getDirs(): array
    {
        return $this->dirs;
    }

    /**
     * @return array
     */
    public function getFiles(): array
    {
        return $this->files;
    }

    /**
     * @return array
     */
    public function toArray(): array
    {
        return [
            'id' => $this->getId(),
            'path' => $this->getPath(),
            'basename' => $this->getBasename(),
            'parent' => $this->getParent(),
            'dirs' => $this->getDirs(),
            'files' => $this->getFiles()
        ];
    }

    /**
     * @return bool
     */
    function isDir(): bool

    {
        return true;
    }

    /**
     * @return bool
     */
    function isFile(): bool

    {
        return false;
    }

    /**
     * @param string $id
     * @param string $path
     * @param string $basename
     * @param string|null $parent
     * @param array $dirs
     * @param array $files
     * @return Folder
     */
    public static function fromVariables(
        string $id,
        string $path,
        string $basename,
        $parent = null,
        array $dirs = [],
        array $files = []
    ): Folder
    {
        $dir = new self();
        $dir->id = $id;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $dir->path = $path;
        $dir->basename = $basename;
        $dir->parent = $parent;
        $dir->dirs = $dirs;
        $dir->files = $files;
        return $dir;
    }
}

1			<?php
2
3			namespace IQParts\Content\Object;
4
5			use League\Flysystem\Directory;
6
7			/**
8			* Class Folder
9			* @package IQParts\Content\Object
10			*/
11			final class Folder extends Item
12			{
13			/**
14			* @var Directory
15			*/
16			private $directory;
17			/**
18			* @var string
19			*/
20			private $path;
21			/**
22			* @var string\|null
23			*/
24			private $parent;
25			/**
26			* @var string
27			*/
28			private $basename;
29			/**
30			* @var array
31			*/
32			private $dirs;
33			/**
34			* @var array
35			*/
36			private $files;
37
38			/**
39			* Folder constructor.
40			* @param Directory $directory
41			*/
42			public function __construct(Directory $directory = null)
43			{
44			if ($directory) {
45			$this->directory = $directory;
46			$this->path = $directory->getPath();
47			$filesystem = $directory->getFilesystem();
48
49			$parentSep = strrpos($this->path, '/');
50			if ($parentSep !== false) {
51			$parent = substr($this->path, 0, $parentSep);
52			} else $parent = '/';
53			$this->parent = base64_encode($parent);
54			$this->basename = basename($this->path);
55
56			$paths = $filesystem->listContents($this->path);
57			$dirs = [];
58			$files = [];
59
60			foreach ($paths as $path) {
61			$item = $filesystem->get($path['path']);
62			if ($item instanceof Directory) {
63			$dirs[] = base64_encode($item->getPath());
64			} else {
65			$files[] = base64_encode($item->getPath());
66			}
67			}
68			$this->dirs = $dirs;
69			$this->files = $files;
70			}
71			}
72
73			/**
74			* @return Directory
75			*/
76			public function getDirectory(): Directory
77			{
78			return $this->directory;
79			}
80
81			/**
82			* @return string
83			*/
84			public function getId(): string
85			{
86			return base64_encode($this->getPath());
87			}
88
89			/**
90			* @return string
91			*/
92			public function getPath(): string
93			{
94			return $this->path;
95			}
96
97			/**
98			* @return string\|null
99			*/
100			public function getParent()
101			{
102			return $this->parent;
103			}
104
105			/**
106			* @return string
107			*/
108			public function getBasename(): string
109			{
110			return $this->basename;
111			}
112
113			/**
114			* @return array
115			*/
116			public function getDirs(): array
117			{
118			return $this->dirs;
119			}
120
121			/**
122			* @return array
123			*/
124			public function getFiles(): array
125			{
126			return $this->files;
127			}
128
129			/**
130			* @return array
131			*/
132			public function toArray(): array
133			{
134			return [
135			'id' => $this->getId(),
136			'path' => $this->getPath(),
137			'basename' => $this->getBasename(),
138			'parent' => $this->getParent(),
139			'dirs' => $this->getDirs(),
140			'files' => $this->getFiles()
141			];
142			}
143
144			/**
145			* @return bool
146			*/
147			function isDir(): bool
			0 ignored issues – show Best Practice introduced 2018-03-01 17:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
148			{
149			return true;
150			}
151
152			/**
153			* @return bool
154			*/
155			function isFile(): bool
			0 ignored issues – show Best Practice introduced 2018-03-01 17:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
156			{
157			return false;
158			}
159
160			/**
161			* @param string $id
162			* @param string $path
163			* @param string $basename
164			* @param string\|null $parent
165			* @param array $dirs
166			* @param array $files
167			* @return Folder
168			*/
169			public static function fromVariables(
170			string $id,
171			string $path,
172			string $basename,
173			$parent = null,
174			array $dirs = [],
175			array $files = []
176			): Folder
177			{
178			$dir = new self();
179			$dir->id = $id;
			0 ignored issues – show Bug introduced 2018-03-01 17:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
180			$dir->path = $path;
181			$dir->basename = $basename;
182			$dir->parent = $parent;
183			$dir->dirs = $dirs;
184			$dir->files = $files;
185			return $dir;
186			}
187			}

IQParts / content

Issues (14)

Security Analysis not enabled

src/Object/Folder.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like