IQParts / cache

src/Adapter/PredisAdapter.php

<?php

namespace IQParts\Cache\Adapter;

use IQParts\Cache\Serializer\SerializerInterface;
use Predis\Client;
use Predis\ClientInterface;

final class PredisAdapter implements CacheAdapterInterface
{
    /**
     * @var Client
     */
    private $client;
    /**
     * @var SerializerInterface
     */
    private $serializer;
    /**
     * @var null
     */
    private $defaultTtl;

    /**
     * PredisAdapter constructor.
     * @param ClientInterface $client
     * @param SerializerInterface $serializer
     * @param int $defaultTtl
     */
    public function __construct(ClientInterface $client, SerializerInterface $serializer, $defaultTtl = null)
    {
        $this->client = $client;

$client is of type Predis\ClientInterface, but the property $client was declared to be of type Predis\Client. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->serializer = $serializer;
        $this->defaultTtl = $defaultTtl;

It seems like $defaultTtl can also be of type integer. However, the property $defaultTtl is declared as type null. Maybe add an additional type check?

    }

    /**
     * @param string $key
     * @return mixed
     */
    public function get(string $key)
    {
        return $this->serializer->deserialize($this->client->get($key));
    }

    /**
     * @param string $key
     * @param $value
     * @param int|null $ttl TTL in seconds
     */
    public function set(string $key, $value, int $ttl = null): void
    {
        if ($ttl !== null && $ttl !== 0) {
            $this->client->setex($key, $ttl ?? $this->defaultTtl, $this->serializer->serialize($value));
        } else {
            $this->client->set($key, $this->serializer->serialize($value));
        }
    }

    /**
     * @param string $key
     * @return integer
     */
    public function delete(string $key): int
    {
        return $this->client->del([$key]);
    }

    /**
     * @param string $key
     * @return mixed
     */
    public function keys($key = '*')
    {
        return $this->client->keys($key);
    }

    /**
     * @param $key
     * @return int
     */
    public function ttl($key): int
    {
        return $this->client->ttl($key);
    }
}