| Total Complexity | 3 |
| Total Lines | 38 |
| Duplicated Lines | 100 % |
| Coverage | 80% |
| Changes | 3 | ||
| Bugs | 0 | Features | 1 |
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | # coding: utf-8 |
||
| 12 | 1 | View Code Duplication | @zope.interface.implementer(INISerializable) |
|
|
|||
| 13 | 1 | @zope.interface.implementer(DefaultProvider) |
|
| 14 | 1 | class Morse(Model): |
|
| 15 | 1 | allow_morse_as_text = BooleanType( |
|
| 16 | default=True, |
||
| 17 | required=True, |
||
| 18 | ) |
||
| 19 | 1 | show_morse_as_text = BooleanType( |
|
| 20 | default=False, |
||
| 21 | required=True, |
||
| 22 | ) |
||
| 23 | 1 | block_morse_chat = BooleanType( |
|
| 24 | default=False, |
||
| 25 | required=True, |
||
| 26 | ) |
||
| 27 | |||
| 28 | 1 | @classmethod |
|
| 29 | def from_ini(cls, ini): |
||
| 30 | return cls({ |
||
| 31 | 'allow_morse_as_text': field_from_ini( |
||
| 32 | cls.allow_morse_as_text, ini, |
||
| 33 | 'NET', 'allowMorseAsText', |
||
| 34 | ), |
||
| 35 | 'show_morse_as_text': field_from_ini( |
||
| 36 | cls.show_morse_as_text, ini, |
||
| 37 | 'game', 'ShowMorseAsText', |
||
| 38 | ), |
||
| 39 | 'block_morse_chat': field_from_ini( |
||
| 40 | cls.block_morse_chat, ini, |
||
| 41 | 'game', 'BlockMorseChat', |
||
| 42 | ), |
||
| 43 | }) |
||
| 44 | |||
| 45 | 1 | @classmethod |
|
| 46 | def default(cls): |
||
| 47 | return cls({ |
||
| 48 | field_name: field.default |
||
| 49 | for field_name, field in cls.fields.items() |
||
| 50 | }) |
||
| 51 |