Connection.from_ini() - Code Metrics - Inspection of "provide raw implementation of INI parsing" - IL2HorusTeam/il2fb-ds-config - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b95acc...a5fbcd )

by Oleksandr

created 2016-12-24 13:15 UTC

Connection.from_ini() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	2.5

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	17
ccs	1
cts	2
cp	0.5
rs	9.4285
cc	2
crap	2.5

# coding: utf-8

import zope.interface

from schematics.models import Model
from schematics.types import StringType, IntType
from schematics.types.compound import ListType, ModelType

from .interfaces import INISerializable


@zope.interface.implementer(INISerializable)
class Connection(Model):
    host = StringType(
        default="",
        required=True,
    )
    port = IntType(
        min_value=0,
        max_value=65000,
        default=0,
        required=True,
    )
    allowed_hosts = ListType(
        field=StringType,
        min_size=0,
        required=True,
        min_length=1,
    )

    @classmethod
    def from_ini(cls, ini):
        return cls({
            'host': ini.get(
                'DeviceLink', 'host',
                fallback=cls.host.default,
            ),
            'port': ini.getint(
                'DeviceLink', 'port',
                fallback=cls.port.default,
            ),
            'allowed_hosts': [
                x.strip()
                for x in
                (
                    ini
                    .get('DeviceLink', 'IPS', fallback="")
                    .split()
                )
            ],
        })


@zope.interface.implementer(INISerializable)
class DeviceLink(Model):
    connection = ModelType(
        model_spec=Connection,
        required=True,
    )

    @classmethod
    def from_ini(cls, ini):
        return cls({
            'connection': Connection.from_ini(ini),
        })


1		# coding: utf-8
2
3	1	import zope.interface
4
5	1	from schematics.models import Model
6	1	from schematics.types import StringType, IntType
7	1	from schematics.types.compound import ListType, ModelType
8
9	1	from .interfaces import INISerializable
10
11
12	1	@zope.interface.implementer(INISerializable)
13	1	class Connection(Model):
14	1	host = StringType(
15		default="",
16		required=True,
17		)
18	1	port = IntType(
19		min_value=0,
20		max_value=65000,
21		default=0,
22		required=True,
23		)
24	1	allowed_hosts = ListType(
25		field=StringType,
26		min_size=0,
27		required=True,
28		min_length=1,
29		)
30
31	1	@classmethod
32		def from_ini(cls, ini):
33		return cls({
34		'host': ini.get(
35		'DeviceLink', 'host',
36		fallback=cls.host.default,
37		),
38		'port': ini.getint(
39		'DeviceLink', 'port',
40		fallback=cls.port.default,
41		),
42		'allowed_hosts': [
43		x.strip()
44		for x in
45		(
46		ini
47		.get('DeviceLink', 'IPS', fallback="")
48		.split()
49		)
50		],
51		})
52
53
54	1	@zope.interface.implementer(INISerializable)
55	1	class DeviceLink(Model):
56	1	connection = ModelType(
57		model_spec=Connection,
58		required=True,
59		)
60
61	1	@classmethod
62		def from_ini(cls, ini):
63		return cls({
64		'connection': Connection.from_ini(ini),
65		})
66

IL2HorusTeam / il2fb-ds-config

Push — master ( b95acc...a5fbcd )

Connection.from_ini() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like