1 | <?php |
||
25 | trait ActionTrait |
||
26 | { |
||
27 | /** |
||
28 | * Returns the action being executed. |
||
29 | * |
||
30 | * @return string |
||
31 | */ |
||
32 | protected function get_action() |
||
36 | |||
37 | /** |
||
38 | * Dispatch the request to the appropriate method. |
||
39 | * |
||
40 | * The {@link $request} property is initialized. |
||
41 | * |
||
42 | * @param Request $request |
||
43 | * |
||
44 | * @return Response|mixed |
||
45 | */ |
||
46 | protected function action(Request $request) |
||
47 | { |
||
48 | $callable = $this->resolve_action($request); |
||
49 | |||
50 | return $callable(); |
||
51 | } |
||
52 | |||
53 | /** |
||
54 | * Resolves the action into a callable. |
||
55 | * |
||
56 | * @param Request $request |
||
57 | * |
||
58 | * @return callable |
||
59 | */ |
||
60 | protected function resolve_action(Request $request) |
||
61 | { |
||
62 | $action = $this->action; |
||
63 | |||
64 | if (!$action) |
||
65 | { |
||
66 | throw new ActionNotDefined("Action not defined in route {$this->route->id}."); |
||
67 | } |
||
68 | |||
69 | $method = $this->resolve_action_method($action, $request); |
||
70 | $args = $this->resolve_action_args($action, $request); |
||
71 | |||
72 | return function() use ($method, $args) { |
||
73 | |||
74 | return call_user_func_array([ $this, $method ], $args); |
||
75 | |||
76 | }; |
||
77 | } |
||
78 | |||
79 | /** |
||
80 | * Resolves the method associated with the action. |
||
81 | * |
||
82 | * @param string $action Action name. |
||
83 | * @param Request $request |
||
84 | * |
||
85 | * @return string The method name. |
||
86 | */ |
||
87 | protected function resolve_action_method($action, Request $request) |
||
88 | { |
||
89 | $action = strtr($action, '-', '_'); |
||
90 | $method = 'action_' . strtolower($request->method) . '_' . $action; |
||
91 | |||
92 | if (method_exists($this, $method)) |
||
93 | { |
||
94 | return $method; |
||
95 | } |
||
96 | |||
97 | $method = 'action_any_' . $action; |
||
98 | |||
99 | if (method_exists($this, $method)) |
||
100 | { |
||
101 | return $method; |
||
102 | } |
||
103 | |||
104 | return $method = 'action_' . $action; |
||
|
|||
105 | } |
||
106 | |||
107 | /** |
||
108 | * Resolves the arguments associated with the action. |
||
109 | * |
||
110 | * @param string $action Action name. |
||
111 | * @param Request $request |
||
112 | * |
||
113 | * @return array The arguments for the action. |
||
114 | */ |
||
115 | protected function resolve_action_args($action, Request $request) |
||
119 | } |
||
120 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.