ICanBoogie /
HTTP
| Conditions | 16 |
| Paths | 1 |
| Total Lines | 33 |
| Code Lines | 27 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 54 | protected function get_mappers() |
||
| 55 | { |
||
| 56 | return [ |
||
| 57 | |||
| 58 | self::OPTION_PATH_PARAMS => function($value) { return $value; }, |
||
| 59 | self::OPTION_QUERY_PARAMS => function($value) { return $value; }, |
||
| 60 | self::OPTION_REQUEST_PARAMS => function($value) { return $value; }, |
||
| 61 | self::OPTION_COOKIE => function($value) { return $value; }, |
||
| 62 | self::OPTION_FILES => function($value) { return $value; }, |
||
| 63 | self::OPTION_HEADERS => function($value) { return ($value instanceof Headers) ? $value : new Headers($value); }, |
||
| 64 | |||
| 65 | self::OPTION_CACHE_CONTROL => function($value, array &$env) { $env['HTTP_CACHE_CONTROL'] = $value; }, |
||
| 66 | self::OPTION_CONTENT_LENGTH => function($value, array &$env) { $env['CONTENT_LENGTH'] = $value; }, |
||
| 67 | self::OPTION_IP => function($value, array &$env) { if ($value) $env['REMOTE_ADDR'] = $value; }, |
||
| 68 | self::OPTION_IS_LOCAL => function($value, array &$env) { if ($value) $env['REMOTE_ADDR'] = '::1'; }, |
||
| 69 | self::OPTION_IS_DELETE => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_DELETE; }, |
||
| 70 | self::OPTION_IS_CONNECT => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_CONNECT; }, |
||
| 71 | self::OPTION_IS_GET => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_GET; }, |
||
| 72 | self::OPTION_IS_HEAD => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_HEAD; }, |
||
| 73 | self::OPTION_IS_OPTIONS => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_OPTIONS; }, |
||
| 74 | self::OPTION_IS_PATCH => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_PATCH; }, |
||
| 75 | self::OPTION_IS_POST => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_POST; }, |
||
| 76 | self::OPTION_IS_PUT => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_PUT; }, |
||
| 77 | self::OPTION_IS_TRACE => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = Request::METHOD_TRACE; }, |
||
| 78 | self::OPTION_IS_XHR => function($value, array &$env) { if ($value) $env['HTTP_X_REQUESTED_WITH'] = 'XMLHttpRequest'; else unset($env['HTTP_X_REQUESTED_WITH']); }, |
||
| 79 | self::OPTION_METHOD => function($value, array &$env) { if ($value) $env['REQUEST_METHOD'] = $value; }, |
||
| 80 | self::OPTION_PATH => function($value, array &$env) { $env['REQUEST_URI'] = $value; }, // TODO-20130521: handle query string |
||
| 81 | self::OPTION_REFERER => function($value, array &$env) { $env['HTTP_REFERER'] = $value; }, |
||
| 82 | self::OPTION_URI => function($value, array &$env) { $env['REQUEST_URI'] = $value; $qs = strpos($value, '?'); $env['QUERY_STRING'] = $qs === false ? '' : substr($value, $qs + 1); }, |
||
| 83 | self::OPTION_USER_AGENT => function($value, array &$env) { $env['HTTP_USER_AGENT'] = $value; } |
||
| 84 | |||
| 85 | ]; |
||
| 86 | } |
||
| 87 | } |
||
| 88 |
