mutis.astro.KnotsIdGUI()

Complexity

Conditions

24

Size

Total Lines	222
Code Lines	135

Duplication

Lines	46
Ratio	20.72 %

Importance

Changes

0

# Licensed under a 3-clause BSD style license - see LICENSE
def KnotsIdGUI(mod):

This function exceeds the maximum number of variables (27/15).

Function name "KnotsIdGUI" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

    """
        Prompt a GUI to select identified knots and alter their label, reprenting their
        time evolution.
        

Trailing whitespace

        It can be used inside jupyter notebooks, using '%matplotlib widget' first.
    

Trailing whitespace

             mod_data : a list containing a pandas.DataFrame for each epoch, with at least columns
             'X', 'Y' and 'Flux (Jy)'.
       

Trailing whitespace

        Parameters:
        -----------
         mod : :pd.DataFrame:
             pandas.DataFrame containing every knot, with at least columns 

Trailing whitespace

             'label', 'date', 'X', 'Y', 'Flux (Jy)'.
        

Trailing whitespace

        Returns:
        --------
         mod : :pd.DataFrame:
             pandas.DataFrame containing every knot with their altered labels, with 

Trailing whitespace

             at least columns 'label', 'date', 'X', 'Y', 'Flux (Jy)'.
    """
    

Trailing whitespace

    mod = mod.copy()
    

Trailing whitespace

    knots = dict(tuple(mod.groupby('label')))
    knots_names = list(knots.keys())
    knots_values = list(knots.values())
    knots_jyears = {k:Time(knots[k]['date'].to_numpy()).jyear for k in knots}
    knots_dates = {k:knots[k]['date'].to_numpy() for k in knots}
    knots_fluxes = {k:knots[k]['Flux (Jy)'].to_numpy() for k in knots}

    from matplotlib.widgets import TextBox, RectangleSelector

Unable to import 'matplotlib.widgets'

Import outside toplevel (matplotlib.widgets.TextBox, matplotlib.widgets.RectangleSelector)

    fig, ax = plt.subplots(nrows=1, ncols=1, figsize=(10,6))

Variable name "ax" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Exactly one space required after comma

Trailing whitespace

    lineas = list()
    textos = list()
    

Trailing whitespace

    def draw_all():
        nonlocal lineas, textos

The variable textos does not seem to be defined.

The variable lineas does not seem to be defined.

        for linea in lineas:
            if linea is not None:
                linea.remove()
        for texto in textos:
            if texto is not None:
                texto.remove()

        ax.set_prop_cycle(None)
        

Trailing whitespace

        lineas = list()
        textos = list()
        

Trailing whitespace

        #ax.clear() # either clear the whole axis or remove every artist separetly
        

Trailing whitespace

        for i, label in enumerate(knots_names):
            x, y = knots_jyears[label], knots_fluxes[label]

Variable name "y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Variable name "x" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            if len(x) > 0:
                lineas.append(ax.plot(x, y, '.-', linewidth=0.8, alpha=0.5, label=label)[0])
            else:
                lineas.append(None)
                

Trailing whitespace

            if len(x) > 0:
                #textos.append(ax.annotate(label, (x[0], y[0]), (-28,-10), textcoords='offset points', color=lineas[i].get_color(), fontsize=14))

This line is too long as per the coding-style (145/100).

                textos.append(ax.text(x[0], y[0], label, {'color':lineas[i].get_color(), 'fontsize':14}))

This line is too long as per the coding-style (105/100).

            else:
                textos.append(None)
                

Trailing whitespace

        fig.canvas.draw_idle() # if removed every artist separately instead of ax.clear()


    def update():
        nonlocal lineas, textos

The variable textos does not seem to be defined.

The variable lineas does not seem to be defined.

        for i, label in enumerate(knots_names):   

Trailing whitespace

            x, y = knots_jyears[label], knots_fluxes[label]

Variable name "y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Variable name "x" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            if lineas[i] is not None:
                if len(x) > 0:
                    lineas[i].set_xdata(x)
                    lineas[i].set_ydata(y)
                else:
                    lineas[i].remove()
                    lineas[i] = None
            else:
                if len(x) > 0:    

Trailing whitespace

                    lineas[i] = ax.plot(x, y, '.-', linewidth=0.8, alpha=0.5, label=label)[0]
        

Trailing whitespace

            if textos[i] is not None:
                if len(x) > 0:    

Trailing whitespace

                    textos[i].set_position((x[0], y[0]))
                    textos[i].set_text(label)
                else:
                    textos[i].remove()
                    textos[i] = None
                    #textos[i].set_position((10, 10))
            else:
                if len(x) > 0:    

Trailing whitespace

                    #textos[i] = ax.annotate(label, (x[0], y[0]), (-24,-10), textcoords='offset points', color=lineas[i].get_color(), fontsize=15)

This line is too long as per the coding-style (146/100).

                    textos[i] = ax.text(x[0], y[0], label, {'color':lineas[i].get_color(), 'fontsize':14})

This line is too long as per the coding-style (106/100).

Trailing whitespace

        fig.canvas.draw_idle()    

Trailing whitespace

Trailing whitespace

    selected_knot = None
    selected_ind = None
    selected_date = None
    selected_flux = None
    

Trailing whitespace

    def submit_textbox(text):

This code seems to be duplicated in your project.

        nonlocal mod, knots, knots_names, knots_values, knots_jyears, knots_dates, knots_fluxes

The variable knots_jyears does not seem to be defined.

The variable knots_fluxes does not seem to be defined.

The variable knots_dates does not seem to be defined.

The variable knots_names does not seem to be defined.

The variable knots_values does not seem to be defined.

The variable knots does not seem to be defined.

        log.debug('Submited with:')
        log.debug(f'   selected_knot {selected_knot}')

Use lazy % formatting in logging functions

        log.debug(f'   selected_ind {selected_ind}')

Use lazy % formatting in logging functions

        log.debug(f'   selected_flux {selected_flux}')

Use lazy % formatting in logging functions

        log.debug(f'   selected_date {selected_date}')

Use lazy % formatting in logging functions

        if selected_knot is not None:        

Trailing whitespace

            mod.loc[selected_ind, 'label'] = text.upper()

            knots = dict(tuple(mod.groupby('label')))
            knots_names = list(knots.keys())
            knots_values = list(knots.values())
            knots_jyears = {k:Time(knots[k]['date'].to_numpy()).jyear for k in knots}
            knots_dates = {k:knots[k]['date'].to_numpy() for k in knots}
            knots_fluxes = {k:knots[k]['Flux (Jy)'].to_numpy() for k in knots}

            print(f"Updated index {selected_ind} to {text.upper()}")
        else:
            pass
        

Trailing whitespace

        draw_all()

    def line_select_callback(eclick, erelease):

This function exceeds the maximum number of variables (19/15).

        nonlocal selected_knot,selected_date, selected_flux, selected_ind

The variable selected_flux does not seem to be defined.

The variable selected_knot does not seem to be defined.

Exactly one space required after comma

The variable selected_date does not seem to be defined.

The variable selected_ind does not seem to be defined.

        # 1 eclick and erelease are the press and release events
        x1, y1 = eclick.xdata, eclick.ydata

Variable name "x1" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Variable name "y1" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        x2, y2 = erelease.xdata, erelease.ydata

Variable name "x2" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Variable name "y2" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        log.debug("GUI: (%3.2f, %3.2f) --> (%3.2f, %3.2f)" % (x1, y1, x2, y2))

Use lazy % formatting in logging functions

        log.debug("GUI:  The button you used were: %s %s" % (eclick.button, erelease.button))

Use lazy % formatting in logging functions

        selected_knot = None
        selected_date = None
        selected_flux = None
        selected_ind = None

        for i, label in enumerate(knots_names):

The variable i seems to be unused.

            years = knots_jyears[label]
            fluxes = knots_fluxes[label]
            

Trailing whitespace

            # get points iside current rectangle for current date
            rect_idx = (x1 < years) & ( years < x2) & (y1 < fluxes) & ( fluxes < y2) 

Trailing whitespace

No space allowed after bracket

Trailing whitespace

            if np.sum(rect_idx) == 0:
                continue # we did not select any component from this component, next one

            x = np.array(years)

Variable name "x" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            y = np.array(fluxes)

Variable name "y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            if np.sum(rect_idx) > 0:

Unnecessary "else" after "break"

This code seems to be duplicated in your project.

                textbox.set_val(label)
                selected_knot = label
                selected_x = x[rect_idx].ravel()

The variable selected_x seems to be unused.

                selected_y = y[rect_idx].ravel()

The variable selected_y seems to be unused.

                selected_ind = knots[label].index[rect_idx]
                log.debug(f'Selected {label} points  rect_idx {rect_idx} date {x[rect_idx]}, flux {y[rect_idx]} with indices {selected_ind}')

This line is too long as per the coding-style (141/100).

Use lazy % formatting in logging functions

                break # if we find selected components in this epoch, continue with renaming
            else:
                pass

        update()


    def toggle_selector(event):

This code seems to be duplicated in your project.

        log.debug('GUI: Key pressed.')
        if event.key in ['Q', 'q'] and toggle_selector.RS.active:
            log.debug('Selector deactivated.')
            toggle_selector.RS.set_active(False)
        if event.key in ['S', 's'] and not toggle_selector.RS.active:
            log.debug('Selector activated.')
            toggle_selector.RS.set_active(True)
        if event.key in ['R', 'r']:
            log.debug('Selector deactivated.')
            toggle_selector.RS.set_active(False)
            textbox.begin_typing(None)
            #textbox.set_val('')


    toggle_selector.RS = RectangleSelector(ax, line_select_callback,
                                           drawtype='box', useblit=True,
                                           button=[1, 3],  # don't use middle button
                                           minspanx=0, minspany=0,
                                           spancoords='data',
                                           interactive=False)


    fig.canvas.mpl_connect('key_press_event', toggle_selector)
    

Trailing whitespace

    from mpl_toolkits.axes_grid1 import make_axes_locatable

Unable to import 'mpl_toolkits.axes_grid1'

Import outside toplevel (mpl_toolkits.axes_grid1.make_axes_locatable)

    divider_textbox = make_axes_locatable(ax)
    textbox_ax = divider_textbox.append_axes("bottom", size="10%", pad="15%") 

Trailing whitespace

    #textbox_ax = fig.add_axes([0.3,0,0.5,0.05])
    textbox = TextBox(textbox_ax, 'Knot name:', initial='None')
    textbox.on_submit(submit_textbox)
    

Trailing whitespace

    draw_all()
    

Trailing whitespace

    #ax.autoscale()
    ax.set_xlabel('date (year)')
    ax.set_ylabel('Flux (Jy)')
    ax.set_title('Flux from each component')
    

Trailing whitespace

    xlims = Time(np.amin(mod['date'])).jyear, Time(np.amax(mod['date'])).jyear
    ax.set_xlim((xlims[0]-0.03*np.abs(xlims[1]-xlims[0]), xlims[1]+0.03*np.abs(xlims[1]-xlims[0])))
    plt.show()

    return mod

Final newline missing