mutis.astro.KnotsId2dGUI()

Complexity

Conditions

26

Size

Total Lines	265
Code Lines	169

Duplication

Lines	47
Ratio	17.74 %

Importance

Changes

0

# Licensed under a 3-clause BSD style license - see LICENSE
def KnotsId2dGUI(mod, use_arrows=False, arrow_pos=1.0):

Function name "KnotsId2dGUI" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

This function exceeds the maximum number of variables (33/15).

    """
        Prompt a GUI to select identified knots and alter their label, reprenting their 2D
        spatial distribution in different times.
        

Trailing whitespace

        It can be used inside jupyter notebooks, using '%matplotlib widget' first.
        

Trailing whitespace

        Parameters:
        -----------
         mod : :pd.DataFrame:
             pandas.DataFrame containing every knot, with at least columns 

Trailing whitespace

             'label', 'date', 'X', 'Y', 'Flux (Jy)'.
        

Trailing whitespace

        Returns:
        --------
         mod : :pd.DataFrame:
             pandas.DataFrame containing every knot with their altered labels, with 

Trailing whitespace

             at least columns 'label', 'date', 'X', 'Y', 'Flux (Jy)'.
    """
    

Trailing whitespace

    mod = mod.copy()
    

Trailing whitespace

    knots = dict(tuple(mod.groupby('label')))
    knots_names = list(knots.keys())
    knots_values = list(knots.values())
    knots_jyears = {k:Time(knots[k]['date'].to_numpy()).jyear for k in knots}
    knots_X = {k:knots[k]['X'].to_numpy() for k in knots}

Variable name "knots_X" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

    knots_Y = {k:knots[k]['Y'].to_numpy() for k in knots}

Variable name "knots_Y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

    from matplotlib.widgets import Slider, Button, TextBox, RectangleSelector

Unused Button imported from matplotlib.widgets

Import outside toplevel (matplotlib.widgets.Slider, matplotlib.widgets.Button, matplotlib.widgets.TextBox, matplotlib.widgets.RectangleSelector)

Unable to import 'matplotlib.widgets'

    fig, ax = plt.subplots(nrows=1, ncols=1, figsize=(8,8))

Exactly one space required after comma

Variable name "ax" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

    lineas = list()
    flechas = list()
    textos = list()

    def draw_all(val=2008):
        nonlocal lineas, flechas, textos

The variable textos does not seem to be defined.

The variable flechas does not seem to be defined.

The variable lineas does not seem to be defined.

        # instead of clearing the whole axis, remove artists
        for linea in lineas:
            if linea is not None:
                linea.remove()
        for texto in textos:
            if texto is not None:
                texto.remove()
        for flecha in flechas:
            if flecha is not None:
                flecha.remove()
        ax.set_prop_cycle(None)
        

Trailing whitespace

        lineas = list()
        flechas = list()
        textos = list()

        xlim, ylim = ax.get_xlim(), ax.get_ylim()
        

Trailing whitespace

        #ax.clear() # either clear the whole axis or remove every artist separetly
            

Trailing whitespace

        for i, label in enumerate(knots_names):
            years = knots_jyears[label]
            idx = (val-1.5 < years) & (years < val)
            x = knots_X[label][idx]

Variable name "x" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            y = knots_Y[label][idx]

Variable name "y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            lineas.append(ax.plot(x, y, '.-', linewidth=0.6, alpha=0.4, label=label)[0])

            if use_arrows:
                if len(x) > 1:
                    flechas.append(ax.quiver(x[:-1], 

Trailing whitespace

                               y[:-1], 

Wrong continued indentation (add 14 spaces).

Trailing whitespace

                               arrow_pos*(x[1:] - x[:-1]), 

Wrong continued indentation (add 14 spaces).

Trailing whitespace

                               arrow_pos*(y[1:] - y[:-1]), 

Wrong continued indentation (add 14 spaces).

Trailing whitespace

                               scale_units='xy', angles='xy', scale=1, 

Wrong continued indentation (add 14 spaces).

Trailing whitespace

                               width=0.0015, headwidth=10, headlength=10, headaxislength=6,

Wrong continued indentation (add 14 spaces).

                               alpha=0.5, color=lineas[i].get_color()))

Wrong continued indentation (add 14 spaces).

                else:
                    flechas.append(None)

            if len(x) > 0:
                #textos.append(ax.annotate(label, (x[0], y[0]), (-28,-10), textcoords='offset points', color=lineas[i].get_color(), fontsize=14))

This line is too long as per the coding-style (145/100).

                textos.append(ax.text(x[-1]+0.015, y[-1]+0.015, label, {'color':lineas[i].get_color(), 'fontsize':14}))

This line is too long as per the coding-style (119/100).

            else:
                textos.append(None)

        ax.set_xlim(xlim)
        ax.set_ylim(ylim)
        ax.set_aspect('equal')
        

Trailing whitespace

        fig.canvas.draw_idle() # if removed every artist separately instead of ax.clear()

    draw_all()

    def update(val):
        nonlocal lineas, flechas, textos

The variable flechas does not seem to be defined.

The variable textos does not seem to be defined.

        for i, label in enumerate(knots_names):
            years = knots_jyears[label]
            idx = (val-1.5 < years) & (years < val)
            x = knots_X[label][idx]

Variable name "x" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            y = knots_Y[label][idx]

Variable name "y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            lineas[i].set_xdata(x)
            lineas[i].set_ydata(y)

            if textos[i] is not None:
                if len(x) > 0:    

Trailing whitespace

                    textos[i].set_position((x[-1]+0.015, y[-1]+0.015))
                    textos[i].set_text(label)
                else:
                    textos[i].remove()
                    textos[i] = None
                    #textos[i].set_position((10, 10))
            else:
                if len(x) > 0:    

Trailing whitespace

                    textos[i] = ax.text(x[-1]+0.02, y[-1]+0.02, label, {'color':lineas[i].get_color(), 'fontsize':14})

This line is too long as per the coding-style (118/100).

            if use_arrows:
                if flechas[i] is not None:
                    flechas[i].remove()
                    flechas[i] = None

                flechas[i] = ax.quiver(x[:-1], 

Trailing whitespace

                                   y[:-1], 

Wrong continued indentation (add 4 spaces).

Trailing whitespace

                                   arrow_pos*(x[1:] - x[:-1]), 

Trailing whitespace

Wrong continued indentation (add 4 spaces).

                                   arrow_pos*(y[1:] - y[:-1]), 

Trailing whitespace

Wrong continued indentation (add 4 spaces).

                                   scale_units='xy', angles='xy', scale=1, 

Wrong continued indentation (add 4 spaces).

Trailing whitespace

                                   width=0.0015, headwidth=10, headlength=10, headaxislength=6, 

Wrong continued indentation (add 4 spaces).

Trailing whitespace

                                   alpha=0.5, color=lineas[i].get_color())

Wrong continued indentation (add 4 spaces).

        fig.canvas.draw_idle()



    selected_knot = None
    selected_ind = None
    selected_x = None
    selected_y = None


    def submit_textbox(text):

This code seems to be duplicated in your project.

        nonlocal mod, knots, knots_names, knots_values, knots_jyears, knots_X, knots_Y

The variable knots_values does not seem to be defined.

The variable knots_names does not seem to be defined.

The variable knots_Y does not seem to be defined.

The variable knots does not seem to be defined.

The variable knots_X does not seem to be defined.

The variable knots_jyears does not seem to be defined.

        log.debug('Submited with:')
        log.debug(f'   selected_knot {selected_knot}')

Use lazy % formatting in logging functions

        log.debug(f'   selected_ind {selected_ind}')

Use lazy % formatting in logging functions

        log.debug(f'   selected_x {selected_x}')

Use lazy % formatting in logging functions

        log.debug(f'   selected_y {selected_y}')

Use lazy % formatting in logging functions

        if selected_knot is not None:        

Trailing whitespace

            mod.loc[selected_ind, 'label'] = text.upper()

            knots = dict(tuple(mod.groupby('label')))
            knots_names = list(knots.keys())
            knots_values = list(knots.values())
            knots_jyears = {k:Time(knots[k]['date'].to_numpy()).jyear for k in knots}
            knots_X = {k:knots[k]['X'].to_numpy() for k in knots}

Variable name "knots_X" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            knots_Y = {k:knots[k]['Y'].to_numpy() for k in knots}

Variable name "knots_Y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            print(f"Updated index {selected_ind} to {text.upper()}")
        else:
            pass

        draw_all(slider_date.val)

    def line_select_callback(eclick, erelease):

This function exceeds the maximum number of variables (17/15).

        nonlocal selected_knot,selected_x, selected_y, selected_ind

The variable selected_x does not seem to be defined.

The variable selected_knot does not seem to be defined.

The variable selected_ind does not seem to be defined.

Exactly one space required after comma

The variable selected_y does not seem to be defined.

        # 1 eclick and erelease are the press and release events
        x1, y1 = eclick.xdata, eclick.ydata

Variable name "x1" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Variable name "y1" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        x2, y2 = erelease.xdata, erelease.ydata

Variable name "y2" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Variable name "x2" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        log.debug("GUI: (%3.2f, %3.2f) --> (%3.2f, %3.2f)" % (x1, y1, x2, y2))

Use lazy % formatting in logging functions

        log.debug("GUI:  The button you used were: %s %s" % (eclick.button, erelease.button))

Use lazy % formatting in logging functions

        selected_knot = None
        selected_x = None
        selected_y = None
        selected_ind = None

        for i, label in enumerate(knots_names):

The variable i seems to be unused.

            years = knots_jyears[label]
            idx = (slider_date.val-1.5 < years) & (years < slider_date.val)

            if np.sum(idx) == 0:
                continue # we did not select any component from this component, next one

            x = np.array(knots_X[label])

Variable name "x" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            y = np.array(knots_Y[label])

Variable name "y" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

            # get points iside current rectangle for current date
            rect_idx = (x1 < x) & ( x < x2) & (y1 < y) & ( y < y2) & idx 

No space allowed after bracket

Trailing whitespace

            if np.sum(rect_idx) > 0:

Unnecessary "else" after "break"

This code seems to be duplicated in your project.

                textbox.set_val(label)
                selected_knot = label
                selected_x = x[rect_idx].ravel()
                selected_y = y[rect_idx].ravel()
                selected_ind = knots[label].index[rect_idx]
                log.debug(f'Selected {label} points  rect_idx {rect_idx} x {x[rect_idx]}, y {y[rect_idx]} with indices {selected_ind}')

This line is too long as per the coding-style (135/100).

Use lazy % formatting in logging functions

                textbox.begin_typing(None)
                break # if we find selected components in this epoch, continue with renaming
            else:
                pass

        update(slider_date.val)


    def toggle_selector(event):

This code seems to be duplicated in your project.

        log.debug('GUI: Key pressed.')
        if event.key in ['Q', 'q'] and toggle_selector.RS.active:
            log.debug('Selector deactivated.')
            toggle_selector.RS.set_active(False)
        if event.key in ['S', 's'] and not toggle_selector.RS.active:
            log.debug('Selector activated.')
            toggle_selector.RS.set_active(True)
        if event.key in ['R', 'r']:
            log.debug('Selector deactivated.')
            toggle_selector.RS.set_active(False)
            textbox.begin_typing(None)
            #textbox.set_val('')


    toggle_selector.RS = RectangleSelector(ax, line_select_callback,
                                           drawtype='box', useblit=True,
                                           button=[1, 3],  # don't use middle button
                                           minspanx=0, minspany=0,
                                           spancoords='data',
                                           interactive=False)


    #plt.connect('key_press_event', toggle_selector)
    fig.canvas.mpl_connect('key_press_event', toggle_selector)



    from mpl_toolkits.axes_grid1 import make_axes_locatable

Unable to import 'mpl_toolkits.axes_grid1'

Import outside toplevel (mpl_toolkits.axes_grid1.make_axes_locatable)

    divider_slider = make_axes_locatable(ax)
    slider_ax = divider_slider.append_axes("top", size="3%", pad="4%")  

Trailing whitespace

    slider_date = Slider(ax=slider_ax, label="Date", valmin=2007, valmax=2020, valinit=2008, valstep=0.2, orientation="horizontal")

This line is too long as per the coding-style (131/100).

    slider_date.on_changed(update)

    #divider_textbox = make_axes_locatable(ax)
    #textbox_ax = divider_textbox.append_axes("bottom", size="3%", pad="4%") 

Trailing whitespace

    textbox_ax = fig.add_axes([0.3,0.015,0.5,0.05])

Exactly one space required after comma

    textbox = TextBox(textbox_ax, 'Knot name:', initial='None')
    textbox.on_submit(submit_textbox)



    ax.set_xlim([-1.0, +1.0])
    ax.set_ylim([-1.0, +1.0])
    ax.set_aspect('equal')

    fig.suptitle('S to select, R to rename, Q to deactivate selector')

    print('S to select, R to rename, Q to deactivate selector')
    print('(you can select points from one component at a time)')
    print('(if you use the zoom or movement tools, remember to unselect them)')

    plt.show()
    

Trailing whitespace

    return mod

        data.to_csv(f'{path}/{label}.csv', index=False) 

Final newline missing