mutis.flares.bayblocks.BayesianBlocks.get_flares()

Complexity

Conditions

23

Size

Total Lines	92
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

""" Flare analysis """
    def get_flares(self, thresh=1):
        """ Get a list of flares following the algorithm proposed in 

Trailing whitespace

[Meyer, Scargle, Blandford (2019)]
(https://iopscience.iop.org/article/10.3847/1538-4357/ab1651/pdf):
        

Trailing whitespace

```There is no generally accepted consensus on the best way to
determine which data points belong to a flaring state and which
characterize the quiescent level. Nalewajko (2013)suggested
the simple definition that a flare is a continuous time interval
associated with a flux peak in which the flux is larger than half
the peak flux value. This definition is intuitive, however, and it
is unclear how to treat overlapping flares and identify flux
peaks in an objective way. Here we use a simple two-step
procedure tailored to the block representation: (1)identify a
block that is higher than both the previous and subsequent
blocks as a peak, and (2)proceed downward from the peak in
both directions as long as the blocks are successively lower.```
        """
        di_max = 5
        

Trailing whitespace

        # get list of local maxima
        # bad beheaviour at 0 and -1:
        #imaxL = sp.signal.argrelextrema(self.values, np.greater)[0]
        imaxL = list()

Variable name "imaxL" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

        for i in range(0,len(self.values)):

Exactly one space required after comma

            if i == 0 and thresh*self.values[0] > self.values[1]:
                imaxL.append(i)
            elif i == len(self.values)-1 and self.values[i-1] < thresh*self.values[i]:
                imaxL.append(i)
            elif self.values[i-1] < thresh*self.values[i] > self.values[i+1]:
                imaxL.append(i)
        imaxL = np.array(imaxL)

Variable name "imaxL" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Trailing whitespace

Trailing whitespace

        inflareL = np.full(self.values.shape, False)

Variable name "inflareL" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Trailing whitespace

        # get list of local maxima over a threshold (flare peaks)
        for imax in imaxL:
            inflare = True
            

Trailing whitespace

            if imax == 0:
                pass
            elif not (self.values[imax-1] < thresh*self.values[imax]):

There is an unnecessary parenthesis after not.

                inflare = False
            

Trailing whitespace

Trailing whitespace

            if imax == len(self.values)-1:
                pass
            elif  not (thresh*self.values[imax] > self.values[imax+1]):

There is an unnecessary parenthesis after not.

                inflare = False
                

Trailing whitespace

            inflareL[imax] = inflare
           

Trailing whitespace

        # extend the flare to adyacent blocks
        for imax in np.argwhere(inflareL):
            

Trailing whitespace

            if imax == 0:
                pass
            else:
                di = 1

Variable name "di" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                stop = False
                while not stop and di < di_max:
                    if imax-di-1 < 0:
                        break
                    

Trailing whitespace

                    if self.values[imax-di-1] < thresh*self.values[imax-di]:
                        inflareL[imax-di] = True
                    else:
                        stop = True
                    

Trailing whitespace

Trailing whitespace

                    di = di + 1

Variable name "di" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Trailing whitespace

            if imax == len(self.values)-1:
                pass
            else:
                di = 1

Variable name "di" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

                stop = False
                while not stop and di < di_max:
                    if imax+di+1 > len(self.values)-1:
                        break
                    

Trailing whitespace

                    if thresh*self.values[imax+di] > self.values[imax+di+1]:
                        inflareL[imax+di] = True
                    else:
                        stop = True
                    

Trailing whitespace

Trailing whitespace

                    di = di + 1

Variable name "di" doesn't conform to snake_case naming style ('([^\\W\\dA-Z][^\\WA-Z]2,|_[^\\WA-Z]*|__[^\\WA-Z\\d_][^\\WA-Z]+__)$' pattern)

Trailing whitespace

Trailing whitespace

        self.inflare = np.array(inflareL)
        
        return flareL

Final newline missing