pivotTemplate::renderSidebar() - Code Metrics - Inspection of "Wf load skin" - Hutchy68/pivot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Tom

created 2017-03-12 20:50 UTC

pivotTemplate::renderSidebar() B

↳ Parent: pivotTemplate

Complexity

Conditions	6
Paths	10

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	8.8571
c	0
b	0
f	0
cc	6
eloc	10
nc	10
nop	0

<?php

/**
 * Skin file for Pivot 
 *
 * @file
 * @ingroup Skins
 */
 

class SkinPivot extends SkinTemplate {
namespace YourVendor;

class YourClass { }
	public $skinname = 'pivot', $stylename = 'pivot', $template = 'pivotTemplate', $useHeadElement = true;


	public function setupSkinUserCss(OutputPage $out) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		parent::setupSkinUserCss($out);
		global $wgPivotFeatures;
function myFunction($a, $b) {
    // Do something
}
		$wgPivotFeaturesDefaults = array(
			'showActionsForAnon' => true,
			'fixedNavBar' => false,
			'usePivotTabs' => false,
			'showHelpUnderTools' => true,
			'showRecentChangesUnderTools' => true,
			'wikiName' => &$GLOBALS['wgSitename'],
			'wikiNameDesktop' => &$GLOBALS['wgSitename'],
			'navbarIcon' => false,
			'IeEdgeCode' => 1,
			'showFooterIcons' => false,
			'addThisPUBID' => '',
			'useAddThisShare' => false,
			'useAddThisFollow' => false
		);
		foreach ($wgPivotFeaturesDefaults as $fgOption => $fgOptionValue) {
			if ( !isset($wgPivotFeatures[$fgOption]) ) {
				$wgPivotFeatures[$fgOption] = $fgOptionValue;
			}
		}
		switch ($wgPivotFeatures['IeEdgeCode']) {
			case 1:
				$out->addHeadItem('ie-meta', '<meta http-equiv="X-UA-Compatible" content="IE=edge" />');
				break;
			case 2:
				if (isset($_SERVER['HTTP_USER_AGENT']) && (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== false))
					header('X-UA-Compatible: IE=edge');
				break;
		}
		$out->addModuleStyles('skins.pivot.styles');
	}

	public function initPage(OutputPage $out) {
		global $wgLocalStylePath;
function myFunction($a, $b) {
    // Do something
}
		parent::initPage($out);

		$viewport_meta = 'width=device-width, user-scalable=yes, initial-scale=1.0';
		$out->addMeta('viewport', $viewport_meta);
		$out->addModuleScripts('skins.pivot.js');
	}

}


class pivotTemplate extends BaseTemplate {
namespace YourVendor;

class YourClass { }
	public function execute() {
		global $wgUser;
function myFunction($a, $b) {
    // Do something
}
		global $wgPivotFeatures;
function myFunction($a, $b) {
    // Do something
}
		wfSuppressWarnings();
		$this->html('headelement');
		switch ($wgPivotFeatures['usePivotTabs']) {
			case true:
			    ob_start();
				$this->html('bodytext');
				$out = ob_get_contents();
				ob_end_clean();
				$markers = array("&lt;a", "&lt;/a", "&gt;");
				$tags = array("<a", "</a", ">");
				$body = str_replace($markers, $tags, $out);
				break;	
			default:
				$body = '';
				break;
		}
		switch ($wgPivotFeatures['showFooterIcons']) {
			case true:
				$poweredbyType = "icononly";
				$poweredbyMakeType = 'withImage';
				break;
			default:
				$poweredbyType = "nocopyright";
				$poweredbyMakeType = 'withoutImage';
				break;	
		}

?>
<!-- START PIVOTTEMPLATE -->
		<div class="off-canvas-wrap docs-wrap" data-offcanvas="">
			<div class="inner-wrap">
				<?php if ($wgPivotFeatures['fixedNavBar'] != false) echo "<div class='fixed'>"; ?>
				<nav class="tab-bar hide-for-print">
					<section id="left-nav-aside" class="left-small show-for-small">
						<a class="left-off-canvas-toggle"><span id="menu-user"><i class="fa fa-navicon fa-lg"></i></span></a>
					</section>
					
					<section id="middle-nav" class="middle tab-bar-section">
						<h1 class="title"><a href="<?php echo $this->data['nav_urls']['mainpage']['href']; ?>">
					<span class="show-for-medium-up"><?php echo $wgPivotFeatures['wikiNameDesktop']; ?></span>
						<span class="show-for-small-only">
						<?php if ($wgPivotFeatures['navbarIcon'] != false) { ?>
							<img alt="<?php echo $this->text('sitename'); ?>" src="<?php echo $this->text('logopath'); ?>" style="max-width: 64px;height:auto; max-height:36px; display: inline-block; vertical-align:middle;">
								<?php } ?>
						<?php echo $wgPivotFeatures['wikiName']; ?></span></a></h1>
					</section>
					
					<section id="right-nav-aside" class="right-small">
					<a class="right-off-canvas-toggle"><span id="menu-user"><i class="fa <?php if ($wgUser->isLoggedIn()): ?>fa-user<?php else: ?>fa-navicon<?php endif; ?> fa-lg"></i></span></a>
					</section>
				</nav>
				<?php if ($wgPivotFeatures['fixedNavBar'] != false) echo "</div>"; ?>
				    <aside class="left-off-canvas-menu">
      					<ul class="off-canvas-list">
						
								<li class="has-form">
									<form action="/w/index.php" id="searchform-offcanvas" class="mw-search">
										<div class="row collapse">
											<div class="small-12 columns">
												<input type="search" name="search" placeholder="Search" title="Search [alt-shift-f]" accesskey="f" id="searchInput-offcanvas" autocomplete="off">
											</div>
										</div>
									</form>
								</li>
								
							<?php $this->renderSidebar() ?>
						</ul>
					</aside>
					
					<aside class="right-off-canvas-menu">
					  <ul class="off-canvas-list">
					<?php if ($wgUser->isLoggedIn()): ?>
						<li id="personal-tools"><label>Personal</label></li>
						<?php foreach ($this->getPersonalTools() as $key => $item) { echo $this->makeListItem($key, $item); } ?>
							<?php else: ?>
								<?php if (isset($this->data['personal_urls']['anonlogin'])): ?>
									<li><a href="<?php echo $this->data['personal_urls']['anonlogin']['href']; ?>"><?php echo wfMessage( 'login' )->text() ?></a></li>
								<?php elseif (isset($this->data['personal_urls']['login'])): ?>
									<li><a href="<?php echo htmlspecialchars($this->data['personal_urls']['login']['href']); ?>"><?php echo wfMessage( 'login' )->text() ?></a></li>
										<?php else: ?>
											<li><?php echo Linker::link(Title::newFromText('Special:UserLogin'), wfMessage( 'login' )->text()); ?></li>
								<?php endif; ?>
							<?php endif; ?>
					  </ul>
					</aside>

					<section id="main-section" class="main-section" <?php if ($wgPivotFeatures['fixedNavBar'] != false) echo "style='margin-top:2.8125em'"; ?>>
					
						<div id="page-content">
							
							<div id="mw-js-message" style="display:none;"></div>

							<div class="row">
								
								<div id="sidebar" class="large-2 medium-3 columns hide-for-small hide-for-print">
										<ul class="side-nav">
											<li class="name logo">
											<a href="<?php echo $this->data['nav_urls']['mainpage']['href']; ?>">
												<img alt="<?php echo $this->text('sitename'); ?>" src="<?php echo $this->text('logopath') ?>" style="max-width: 100%;height: auto;display: inline-block; vertical-align: middle;"></a>		
											</li>
											<li class="has-form">
												<form action="/w/index.php" id="searchform" class="mw-search">
													<div class="row collapse">
														<div class="small-12 columns">
															<input type="search" name="search" placeholder="Search" title="Search [alt-shift-f]" accesskey="f" id="searchInput" autocomplete="off">
														</div>
													</div>
												</form>
											</li>
								
											<?php $this->renderSidebar() ?>
										</ul>
								</div>
								
								<div id="p-cactions" class="large-10 medium-9 columns">
								
									<div class="row">
										<div class="large-12 columns">
												<!--[if lt IE 9]>
												<div id="siteNotice" class="sitenotice panel radius"><?php echo $this->text('sitename') . ' '. wfMessage( 'pivot-browsermsg' )->text(); ?></div>
												<![endif]-->

												<?php if ( $this->data['sitenotice'] ) { ?><div id="siteNotice" class="sitenotice panel radius"><?php $this->html( 'sitenotice' ); ?></div><?php } ?>
												<?php if ( $this->data['newtalk'] ) { ?><div id="usermessage" class="newtalk panel radius"><?php $this->html( 'newtalk' ); ?></div><?php } ?>
										</div>
									</div>
								
									<?php if ($wgUser->isLoggedIn() || $wgPivotFeatures['showActionsForAnon']): ?>
										<a href="#" data-options="align:left" data-dropdown="drop1" class="button secondary small radius pull-right hide-for-print" id="drop"><i class="fa fa-navicon fa-lg"><span id="page-actions" class="show-for-medium-up">&nbsp;<?php echo wfMessage( 'actions' )->text() ?></span></i></a>
										<ul id="drop1" class="tiny content f-dropdown" data-dropdown-content>
											<?php foreach($this->data['content_actions'] as $key => $tab) { echo preg_replace(array('/\sprimary="1"/', '/\scontext="[a-z]+"/', '/\srel="archives"/'),'',$this->makeListItem($key, $tab)); } ?>
											<?php wfRunHooks( 'SkinTemplateToolboxEnd', array( &$this, true ));  ?>
										</ul>
										<?php if ($wgUser->isLoggedIn()): ?>
											<div id="echo-notifications"></div>
										<?php endif; ?>
									<?php endif;
									$namespace = str_replace('_', ' ', $this->getSkin()->getTitle()->getNsText());
									$displaytitle = $this->data['title'];
									if (!empty($namespace)) {
										$pagetitle = $this->getSkin()->getTitle();
										$newtitle = str_replace($namespace.':', '', $pagetitle);
										$displaytitle = str_replace($pagetitle, $newtitle, $displaytitle);
									?><h4 class="namespace label"><?php print $namespace; ?></h4><?php } ?>
									<h2 class="title"><?php print $displaytitle; ?></h2>
											<?php if ($wgPivotFeatures['useAddThisShare'] != false) { ?>
											<!-- Go to www.addthis.com/dashboard to customize your tools -->
											<div class="addthis_sharing_toolbox show-for-large-up hide-for-print"></div>
											<!-- Go to www.addthis.com/dashboard to customize your tools -->
											<?php } ?>
									<?php if ( $this->data['isarticle'] ) { ?><h3 id="tagline"><?php $this->msg( 'tagline' ) ?></h3><?php } ?>
									<h5 id="sitesub" class="subtitle"><?php $this->html('subtitle') ?></h5>
									<div id="contentSub" class="clear_both"></div>
									<div id="bodyContent" class="mw-bodytext">
									<?php 
									switch ($wgPivotFeatures['usePivotTabs']) {
										case true:
											echo $body;
											break;
										default:
										$this->html('bodytext');
											break;
											}
									?>
									<div class="clear_both"></div>
									</div>
									<div id="categories" class="row">
										<div class="small-12 columns">
											<div class="group"><?php $this->html('catlinks'); ?></div>
											<?php $this->html('dataAfterContent'); ?>
										</div>
									</div>	
													
									<footer class="row">

										<div id="footer">
											<div id="footer-left" class="small-12 medium-8 large-9 columns">
											<ul id="footer-left">
												<?php foreach ($this->getFooterLinks("flat") as $key) { ?>
													<li id="footer-<?php echo $key ?>"><?php $this->html($key) ?></li>
												<?php } ?>									
											</ul>
											</div>	
											<div id="footer-right-icons" class="small-12 medium-4 large-3 columns hide-for-print">
											<ul id="footer-right">
												<li class="social-follow hide-for-print">
													<?php if ($wgPivotFeatures['useAddThisFollow'] != false) { ?>
														<div class="social-links">
															<!-- Go to www.addthis.com/dashboard to customize your tools -->
															<div class="addthis_horizontal_follow_toolbox show-for-large-up"></div>
														</div>
													<?php } ?>
												</li>
												<?php foreach ($this->getFooterIcons($poweredbyType) as $blockName => $footerIcons) { ?>
													<li class="<?php echo $blockName ?>"><?php foreach ($footerIcons as $icon) { ?>
														<?php echo $this->getSkin()->makeFooterIcon($icon, $poweredbyMakeType); ?>
														<?php } ?>
													</li>
												<?php } ?>
											</ul>
											</div>		
										</div>			
									</footer>
								
								</div>
						</div>
					</div>
						
				</section>
				
			</div>
			</div>
			<a class="exit-off-canvas"></a>	
		</div>

		
		<?php $this->printTrail(); ?>

			<?php if ($wgPivotFeatures['addThisPUBID'] != '') { ?>
				<script type="text/javascript" src="//s7.addthis.com/js/300/addthis_widget.js#pubid=<?php echo $wgPivotFeatures['addThisPUBID']; ?>" async="async">></script>
			<?php } ?>	
		</body>
		</html>

<?php
		wfRestoreWarnings();
		
	}
	
	function renderSidebar() { 

		$sidebar = $this->getSidebar();
		$toolbox = $this->getToolbox();
		foreach ($sidebar as $boxName => $box) { if ( ($box['header'] != wfMessage( 'toolbox' )->text()) ) { 
			echo '<li id='.Sanitizer::escapeId( $box['id'] ); Linker::tooltip( $box['id'] ).'>';
			echo '<li><label>'.htmlspecialchars( $box['header'] ).'</label></li>';
					if ( is_array( $box['content'] ) ) {
							foreach ($box['content'] as $key => $item) { echo $this->makeListItem($key, $item); }
								} }
									}
			echo '<li><label>Toolbox</label></li>';
					foreach ($toolbox as $key => $tbitem) { echo $this->makeListItem($key, $tbitem); }
		}	
}
?>


Pull Request — master (#13)

pivotTemplate::renderSidebar() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2
3			/**
4			* Skin file for Pivot
5			*
6			* @file
7			* @ingroup Skins
8			*/
9
10
11			class SkinPivot extends SkinTemplate {
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12			public $skinname = 'pivot', $stylename = 'pivot', $template = 'pivotTemplate', $useHeadElement = true;
			0 ignored issues – show Coding Style introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history...
13
14			public function setupSkinUserCss(OutputPage $out) {
			0 ignored issues – show Coding Style introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report `setupSkinUserCss` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report `setupSkinUserCss` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
15			parent::setupSkinUserCss($out);
16			global $wgPivotFeatures;
			0 ignored issues – show Compatibility Best Practice introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
17			$wgPivotFeaturesDefaults = array(
18			'showActionsForAnon' => true,
19			'fixedNavBar' => false,
20			'usePivotTabs' => false,
21			'showHelpUnderTools' => true,
22			'showRecentChangesUnderTools' => true,
23			'wikiName' => &$GLOBALS['wgSitename'],
24			'wikiNameDesktop' => &$GLOBALS['wgSitename'],
25			'navbarIcon' => false,
26			'IeEdgeCode' => 1,
27			'showFooterIcons' => false,
28			'addThisPUBID' => '',
29			'useAddThisShare' => false,
30			'useAddThisFollow' => false
31			);
32			foreach ($wgPivotFeaturesDefaults as $fgOption => $fgOptionValue) {
33			if ( !isset($wgPivotFeatures[$fgOption]) ) {
34			$wgPivotFeatures[$fgOption] = $fgOptionValue;
35			}
36			}
37			switch ($wgPivotFeatures['IeEdgeCode']) {
38			case 1:
39			$out->addHeadItem('ie-meta', '<meta http-equiv="X-UA-Compatible" content="IE=edge" />');
40			break;
41			case 2:
42			if (isset($_SERVER['HTTP_USER_AGENT']) && (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') !== false))
43			header('X-UA-Compatible: IE=edge');
44			break;
45			}
46			$out->addModuleStyles('skins.pivot.styles');
47			}
48
49			public function initPage(OutputPage $out) {
50			global $wgLocalStylePath;
			0 ignored issues – show Compatibility Best Practice introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
51			parent::initPage($out);
52
53			$viewport_meta = 'width=device-width, user-scalable=yes, initial-scale=1.0';
54			$out->addMeta('viewport', $viewport_meta);
55			$out->addModuleScripts('skins.pivot.js');
56			}
57
58			}
59
60
61			class pivotTemplate extends BaseTemplate {
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
62			public function execute() {
63			global $wgUser;
			0 ignored issues – show Compatibility Best Practice introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
64			global $wgPivotFeatures;
			0 ignored issues – show Compatibility Best Practice introduced 2017-02-22 14:44 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
65			wfSuppressWarnings();
66			$this->html('headelement');
67			switch ($wgPivotFeatures['usePivotTabs']) {
68			case true:
69			ob_start();
70			$this->html('bodytext');
71			$out = ob_get_contents();
72			ob_end_clean();
73			$markers = array("<a", "</a", ">");
74			$tags = array("<a", "</a", ">");
75			$body = str_replace($markers, $tags, $out);
76			break;
77			default:
78			$body = '';
79			break;
80			}
81			switch ($wgPivotFeatures['showFooterIcons']) {
82			case true:
83			$poweredbyType = "icononly";
84			$poweredbyMakeType = 'withImage';
85			break;
86			default:
87			$poweredbyType = "nocopyright";
88			$poweredbyMakeType = 'withoutImage';
89			break;
90			}
91
92			?>
93			<!-- START PIVOTTEMPLATE -->
94			<div class="off-canvas-wrap docs-wrap" data-offcanvas="">
95			<div class="inner-wrap">
96			<?php if ($wgPivotFeatures['fixedNavBar'] != false) echo "<div class='fixed'>"; ?>
97			<nav class="tab-bar hide-for-print">
98			<section id="left-nav-aside" class="left-small show-for-small">
99			<a class="left-off-canvas-toggle"><span id="menu-user"><i class="fa fa-navicon fa-lg"></i></span></a>
100			</section>
101
102			<section id="middle-nav" class="middle tab-bar-section">
103			<h1 class="title"><a href="<?php echo $this->data['nav_urls']['mainpage']['href']; ?>">
104			<span class="show-for-medium-up"><?php echo $wgPivotFeatures['wikiNameDesktop']; ?></span>
105			<span class="show-for-small-only">
106			<?php if ($wgPivotFeatures['navbarIcon'] != false) { ?>
107			<img alt="<?php echo $this->text('sitename'); ?>" src="<?php echo $this->text('logopath'); ?>" style="max-width: 64px;height:auto; max-height:36px; display: inline-block; vertical-align:middle;">
108			<?php } ?>
109			<?php echo $wgPivotFeatures['wikiName']; ?></span></a></h1>
110			</section>
111
112			<section id="right-nav-aside" class="right-small">
113			<a class="right-off-canvas-toggle"><span id="menu-user"><i class="fa <?php if ($wgUser->isLoggedIn()): ?>fa-user<?php else: ?>fa-navicon<?php endif; ?> fa-lg"></i></span></a>
114			</section>
115			</nav>
116			<?php if ($wgPivotFeatures['fixedNavBar'] != false) echo "</div>"; ?>
117			<aside class="left-off-canvas-menu">
118			<ul class="off-canvas-list">
119
120			<li class="has-form">
121			<form action="/w/index.php" id="searchform-offcanvas" class="mw-search">
122			<div class="row collapse">
123			<div class="small-12 columns">
124			<input type="search" name="search" placeholder="Search" title="Search [alt-shift-f]" accesskey="f" id="searchInput-offcanvas" autocomplete="off">
125			</div>
126			</div>
127			</form>
128			</li>
129
130			<?php $this->renderSidebar() ?>
131			</ul>
132			</aside>
133
134			<aside class="right-off-canvas-menu">
135			<ul class="off-canvas-list">
136			<?php if ($wgUser->isLoggedIn()): ?>
137			<li id="personal-tools"><label>Personal</label></li>
138			<?php foreach ($this->getPersonalTools() as $key => $item) { echo $this->makeListItem($key, $item); } ?>
139			<?php else: ?>
140			<?php if (isset($this->data['personal_urls']['anonlogin'])): ?>
141			<li><a href="<?php echo $this->data['personal_urls']['anonlogin']['href']; ?>"><?php echo wfMessage( 'login' )->text() ?></a></li>
142			<?php elseif (isset($this->data['personal_urls']['login'])): ?>
143			<li><a href="<?php echo htmlspecialchars($this->data['personal_urls']['login']['href']); ?>"><?php echo wfMessage( 'login' )->text() ?></a></li>
144			<?php else: ?>
145			<li><?php echo Linker::link(Title::newFromText('Special:UserLogin'), wfMessage( 'login' )->text()); ?></li>
146			<?php endif; ?>
147			<?php endif; ?>
148			</ul>
149			</aside>
150
151			<section id="main-section" class="main-section" <?php if ($wgPivotFeatures['fixedNavBar'] != false) echo "style='margin-top:2.8125em'"; ?>>
152
153			<div id="page-content">
154
155			<div id="mw-js-message" style="display:none;"></div>
156
157			<div class="row">
158
159			<div id="sidebar" class="large-2 medium-3 columns hide-for-small hide-for-print">
160			<ul class="side-nav">
161			<li class="name logo">
162			<a href="<?php echo $this->data['nav_urls']['mainpage']['href']; ?>">
163			<img alt="<?php echo $this->text('sitename'); ?>" src="<?php echo $this->text('logopath') ?>" style="max-width: 100%;height: auto;display: inline-block; vertical-align: middle;"></a>
164			</li>
165			<li class="has-form">
166			<form action="/w/index.php" id="searchform" class="mw-search">
167			<div class="row collapse">
168			<div class="small-12 columns">
169			<input type="search" name="search" placeholder="Search" title="Search [alt-shift-f]" accesskey="f" id="searchInput" autocomplete="off">
170			</div>
171			</div>
172			</form>
173			</li>
174
175			<?php $this->renderSidebar() ?>
176			</ul>
177			</div>
178
179			<div id="p-cactions" class="large-10 medium-9 columns">
180
181			<div class="row">
182			<div class="large-12 columns">
183			<!--[if lt IE 9]>
184			<div id="siteNotice" class="sitenotice panel radius"><?php echo $this->text('sitename') . ' '. wfMessage( 'pivot-browsermsg' )->text(); ?></div>
185			<![endif]-->
186
187			<?php if ( $this->data['sitenotice'] ) { ?><div id="siteNotice" class="sitenotice panel radius"><?php $this->html( 'sitenotice' ); ?></div><?php } ?>
188			<?php if ( $this->data['newtalk'] ) { ?><div id="usermessage" class="newtalk panel radius"><?php $this->html( 'newtalk' ); ?></div><?php } ?>
189			</div>
190			</div>
191
192			<?php if ($wgUser->isLoggedIn() \|\| $wgPivotFeatures['showActionsForAnon']): ?>
193			<a href="#" data-options="align:left" data-dropdown="drop1" class="button secondary small radius pull-right hide-for-print" id="drop"><i class="fa fa-navicon fa-lg"><span id="page-actions" class="show-for-medium-up"> <?php echo wfMessage( 'actions' )->text() ?></span></i></a>
194			<ul id="drop1" class="tiny content f-dropdown" data-dropdown-content>
195			<?php foreach($this->data['content_actions'] as $key => $tab) { echo preg_replace(array('/\sprimary="1"/', '/\scontext="[a-z]+"/', '/\srel="archives"/'),'',$this->makeListItem($key, $tab)); } ?>
196			<?php wfRunHooks( 'SkinTemplateToolboxEnd', array( &$this, true )); ?>
197			</ul>
198			<?php if ($wgUser->isLoggedIn()): ?>
199			<div id="echo-notifications"></div>
200			<?php endif; ?>
201			<?php endif;
202			$namespace = str_replace('_', ' ', $this->getSkin()->getTitle()->getNsText());
203			$displaytitle = $this->data['title'];
204			if (!empty($namespace)) {
205			$pagetitle = $this->getSkin()->getTitle();
206			$newtitle = str_replace($namespace.':', '', $pagetitle);
207			$displaytitle = str_replace($pagetitle, $newtitle, $displaytitle);
208			?><h4 class="namespace label"><?php print $namespace; ?></h4><?php } ?>
209			<h2 class="title"><?php print $displaytitle; ?></h2>
210			<?php if ($wgPivotFeatures['useAddThisShare'] != false) { ?>
211			<!-- Go to www.addthis.com/dashboard to customize your tools -->
212			<div class="addthis_sharing_toolbox show-for-large-up hide-for-print"></div>
213			<!-- Go to www.addthis.com/dashboard to customize your tools -->
214			<?php } ?>
215			<?php if ( $this->data['isarticle'] ) { ?><h3 id="tagline"><?php $this->msg( 'tagline' ) ?></h3><?php } ?>
216			<h5 id="sitesub" class="subtitle"><?php $this->html('subtitle') ?></h5>
217			<div id="contentSub" class="clear_both"></div>
218			<div id="bodyContent" class="mw-bodytext">
219			<?php
220			switch ($wgPivotFeatures['usePivotTabs']) {
221			case true:
222			echo $body;
223			break;
224			default:
225			$this->html('bodytext');
226			break;
227			}
228			?>
229			<div class="clear_both"></div>
230			</div>
231			<div id="categories" class="row">
232			<div class="small-12 columns">
233			<div class="group"><?php $this->html('catlinks'); ?></div>
234			<?php $this->html('dataAfterContent'); ?>
235			</div>
236			</div>
237
238			<footer class="row">
239
240			<div id="footer">
241			<div id="footer-left" class="small-12 medium-8 large-9 columns">
242			<ul id="footer-left">
243			<?php foreach ($this->getFooterLinks("flat") as $key) { ?>
244			<li id="footer-<?php echo $key ?>"><?php $this->html($key) ?></li>
245			<?php } ?>
246			</ul>
247			</div>
248			<div id="footer-right-icons" class="small-12 medium-4 large-3 columns hide-for-print">
249			<ul id="footer-right">
250			<li class="social-follow hide-for-print">
251			<?php if ($wgPivotFeatures['useAddThisFollow'] != false) { ?>
252			<div class="social-links">
253			<!-- Go to www.addthis.com/dashboard to customize your tools -->
254			<div class="addthis_horizontal_follow_toolbox show-for-large-up"></div>
255			</div>
256			<?php } ?>
257			</li>
258			<?php foreach ($this->getFooterIcons($poweredbyType) as $blockName => $footerIcons) { ?>
259			<li class="<?php echo $blockName ?>"><?php foreach ($footerIcons as $icon) { ?>
260			<?php echo $this->getSkin()->makeFooterIcon($icon, $poweredbyMakeType); ?>
261			<?php } ?>
262			</li>
263			<?php } ?>
264			</ul>
265			</div>
266			</div>
267			</footer>
268
269			</div>
270			</div>
271			</div>
272
273			</section>
274
275			</div>
276			</div>
277			<a class="exit-off-canvas"></a>
278			</div>
279
280
281			<?php $this->printTrail(); ?>
282
283			<?php if ($wgPivotFeatures['addThisPUBID'] != '') { ?>
284			<script type="text/javascript" src="//s7.addthis.com/js/300/addthis_widget.js#pubid=<?php echo $wgPivotFeatures['addThisPUBID']; ?>" async="async">></script>
285			<?php } ?>
286			</body>
287			</html>
288
289			<?php
290			wfRestoreWarnings();
291
292			}
293
294			function renderSidebar() {
			0 ignored issues – show Best Practice introduced 2017-03-12 20:52 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
295			$sidebar = $this->getSidebar();
296			$toolbox = $this->getToolbox();
297			foreach ($sidebar as $boxName => $box) { if ( ($box['header'] != wfMessage( 'toolbox' )->text()) ) {
298			echo '<li id='.Sanitizer::escapeId( $box['id'] ); Linker::tooltip( $box['id'] ).'>';
299			echo '<li><label>'.htmlspecialchars( $box['header'] ).'</label></li>';
300			if ( is_array( $box['content'] ) ) {
301			foreach ($box['content'] as $key => $item) { echo $this->makeListItem($key, $item); }
302			} }
303			}
304			echo '<li><label>Toolbox</label></li>';
305			foreach ($toolbox as $key => $tbitem) { echo $this->makeListItem($key, $tbitem); }
306			}
307			}
308			?>
309

Hutchy68 / pivot

Pull Request — master (#13)

pivotTemplate::renderSidebar() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like