HustleWorks\Chute\ImageEditor

Complexity

Total Complexity

7

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	crop()	0	6	1
A	resize()	0	10	3
A	setQuality()	0	6	1
A	getStream()	0	4	1

<?php


namespace HustleWorks\Chute;

use HustleWorks\Chute\Contracts\ImageEditingInterface;
use Intervention\Image\Constraint;
use Intervention\Image\ImageManager;

class ImageEditor implements ImageEditingInterface
{
    /**
     * @var \Intervention\Image\Image
     */
    private $image;

    /**
     * @var int
     */
    private $quality = 100;

    /**
     * ImageEditor constructor.
     *
     * @param $file
     */
    public function __construct($file)
    {
        $this->image = (new ImageManager())->make($file);
    }

    /**
     * Crop Image
     *
     * @param      $width
     * @param      $height
     * @param null $x_pos
     * @param null $y_pos
     * @return ImageEditingInterface
     */
    public function crop($width, $height, $x_pos = null, $y_pos = null): ImageEditingInterface
    {
        $this->image->crop($width, $height, $x_pos, $y_pos);

        return $this;
    }

    /**
     * @param $width
     * @param $height
     * @return ImageEditingInterface
     */
    public function resize($width, $height): ImageEditingInterface
    {
        $this->image->resize(
            $width,
            $height,
            !($width and $height) ? function (Constraint $constraint) { $constraint->aspectRatio(); } : null

It seems like !($width and $height) ? function (\Intervention\Image\Constraint $constraint) { $constraint->aspectRatio(); } : null can be null; however, resize() does not accept null, maybe add an additional type check?

Using logical operators such as and instead of && is generally not recommended.

        );

        return $this;
    }

    /**
     * Set Quality
     *
     * @param $quality
     * @return ImageEditingInterface
     */
    public function setQuality($quality): ImageEditingInterface
    {
        $this->quality = $quality;

        return $this;
    }

    /**
     * Get Stream
     *
     * Finalize edits and get the finished product.
     *
     * @return string
     */
    public function getStream(): string
    {
        return $this->image->stream(null, $this->quality);
    }
}