Conditions | 20 |
Paths | 28 |
Total Lines | 81 |
Code Lines | 48 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
165 | public function __construct($container) |
||
166 | { |
||
167 | $availableLanguages = $this->availableLanguages; |
||
168 | $appLangFiles = $this->appLangFiles; |
||
169 | $appClasses = $this->appClasses; |
||
170 | $_language = $this->_language; |
||
171 | $conf = $container->conf; |
||
172 | |||
173 | $languages_iso_code = $this->languages_iso_code; |
||
174 | |||
175 | if (!isset($conf['default_lang'])) { |
||
176 | $conf['default_lang'] = 'english'; |
||
177 | } |
||
178 | |||
179 | // 1. Check for the language from a request var |
||
180 | if (isset($_REQUEST['language'], $appLangFiles[$_REQUEST['language']])) { |
||
181 | /* save the selected language in cookie for a year */ |
||
182 | setcookie('webdbLanguage', $_REQUEST['language'], time() + 31536000); |
||
183 | $_language = $_REQUEST['language']; |
||
184 | } elseif (!isset($_language) && isset($_SESSION['webdbLanguage'], $appLangFiles[$_SESSION['webdbLanguage']])) { |
||
185 | // 2. Check for language session var |
||
186 | $_language = $_SESSION['webdbLanguage']; |
||
187 | } elseif (!isset($_language) && isset($_COOKIE['webdbLanguage'], $appLangFiles[$_COOKIE['webdbLanguage']])) { |
||
188 | // 3. Check for language in cookie var |
||
189 | $_language = $_COOKIE['webdbLanguage']; |
||
190 | } elseif (!isset($_language) && $conf['default_lang'] == 'auto' && isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) { |
||
191 | // 4. Check for acceptable languages in HTTP_ACCEPT_LANGUAGE var |
||
192 | // extract acceptable language tags |
||
193 | // (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.4) |
||
194 | preg_match_all( |
||
195 | '/\s*([a-z]{1,8}(?:-[a-z]{1,8})*)(?:;q=([01](?:.[0-9]{0,3})?))?\s*(?:,|$)/', |
||
196 | strtolower($_SERVER['HTTP_ACCEPT_LANGUAGE']), |
||
197 | $_m, |
||
198 | PREG_SET_ORDER |
||
199 | ); |
||
200 | foreach ($_m as $_l) { |
||
201 | // $_l[1] = language tag, [2] = quality |
||
202 | if (!isset($_l[2])) { |
||
203 | $_l[2] = 1; |
||
204 | } |
||
205 | // Default quality to 1 |
||
206 | if ($_l[2] > 0 && $_l[2] <= 1 && isset($availableLanguages[$_l[1]])) { |
||
207 | // Build up array of (quality => language_file) |
||
208 | $_acceptLang[$_l[2]] = $availableLanguages[$_l[1]]; |
||
209 | } |
||
210 | } |
||
211 | unset($_m, $_l); |
||
212 | |||
213 | if (isset($_acceptLang)) { |
||
214 | // Sort acceptable languages by quality |
||
215 | krsort($_acceptLang, SORT_NUMERIC); |
||
216 | $_language = reset($_acceptLang); |
||
217 | unset($_acceptLang); |
||
218 | } |
||
219 | } elseif (!isset($_language) && $conf['default_lang'] != 'auto' && isset($appLangFiles[$conf['default_lang']])) { |
||
220 | // 5. Otherwise resort to the default set in the config file |
||
221 | $_language = $conf['default_lang']; |
||
222 | } else { |
||
223 | // 6. Otherwise, default to english. |
||
224 | $_language = 'english'; |
||
225 | } |
||
226 | |||
227 | $_type = '\PHPPgAdmin\Translations\\' . $appClasses[$_language]; |
||
228 | |||
229 | $langClass = new $_type(); |
||
230 | |||
231 | $_SESSION['webdbLanguage'] = $_language; |
||
232 | |||
233 | if (array_key_exists($_language, $languages_iso_code)) { |
||
234 | $_isolang = $languages_iso_code[$_language]; |
||
235 | } else { |
||
236 | $_isolang = 'en'; |
||
237 | } |
||
238 | $_SESSION['isolang'] = $_isolang; |
||
239 | |||
240 | $container->offsetSet('appLangFiles', $appLangFiles); |
||
241 | $container->offsetSet('language', $_language); |
||
242 | $container->offsetSet('isolang', $_isolang); |
||
243 | |||
244 | $this->lang = $langClass->getLang(); |
||
245 | $this->lang['isolang'] = $_isolang; |
||
246 | } |
||
248 |