TreeController::printTreeJSON() - Code Metrics - Inspection of "Testing bug" - HuasoFoundries/phpPgAdmin6 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#267)

by Felipe

created 2020-03-05 18:39 UTC

TreeController::printTreeJSON() B

↳ Parent: TreeController

Complexity

Conditions	10
Paths	9

Size

Total Lines	65
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	43
c	0
b	0
f	0
nc	9
nop	3
dl	0
loc	65
rs	7.6666

How to fix Long Method Complexity

<?php

/**
 * PHPPgAdmin v6.0.0-RC9-3-gd93ec300
 */

namespace PHPPgAdmin\Controller;

use PHPPgAdmin\Decorators\Decorator;

/**
 * Base TreeController controller class.
 */
class TreeController extends BaseController
{
    use \PHPPgAdmin\Traits\HelperTrait;

    public $form = '';

    public $href = '';

    public $lang = [];

    public $action = '';

    public $controller_name = 'TreeController';

    public $controller_title = 'base';

    public $misc;

    public $conf;

    public $appThemes;

    public $view;

    public $appVersion;

    public $appLangFiles;

    protected $container;

    // Constructor
    public function __construct(\Slim\Container $container, $controller_name = null)
    {
        $this->container = $container;
        $this->lang      = $container->get('lang');
        //$this->conf           = $container->get('conf');
        $this->view = $container->get('view');

        $this->appName      = $container->get('settings')['appName'];
        $this->appVersion   = $container->get('settings')['appVersion'];
        $this->appLangFiles = $container->get('appLangFiles');
        $this->misc         = $container->get('misc');
        $this->conf         = $this->misc->getConf();
        $this->appThemes    = $container->get('appThemes');
        $this->action       = $container->get('action');

        if (null !== $controller_name) {
            $this->controller_name = $controller_name;
        }
    }

    /**
     * Produce JSON data for the browser tree.
     *
     * @param \PHPPgAdmin\ArrayRecordSet $_treedata a set of records to populate the tree
     * @param array                      $attrs     Attributes for tree items
     *                                              'text' - the text for the tree node
     *                                              'icon' - an icon for node
     *                                              'openIcon' - an alternative icon when the node is expanded
     *                                              'toolTip' - tool tip text for the node
     *                                              'action' - URL to visit when single clicking the node
     *                                              'iconAction' - URL to visit when single clicking the icon node
     *                                              'branch' - URL for child nodes (tree XML)
     *                                              'expand' - the action to return XML for the subtree
     *                                              'nodata' - message to display when node has no children
     * @param string                     $section   The section where the branch is linked in the tree
     * @param bool                       $print     either to return or echo the result
     *
     * @return \Slim\Http\Response|string the json rendered tree
     */
    public function printTree(&$_treedata, &$attrs, $section, $print = true)
    {
        $treedata = [];

        if (0 < $_treedata->recordCount()) {
            while (!$_treedata->EOF) {
                $treedata[] = $_treedata->fields;
                $_treedata->moveNext();
            }
        }

        $tree_params = [

            'treedata' => &$treedata,
            'attrs'    => &$attrs,
            'section'  => $section,
        ];

        return $this->printTreeJSON($treedata, $attrs, $print);
    }

    /**
     * Hides or show tree tabs according to their properties.
     *
     * @param array $tabs The tabs
     *
     * @return \PHPPgAdmin\ArrayRecordSet filtered tabs in the form of an ArrayRecordSet
     */
    public function adjustTabsForTree(&$tabs)
    {
        foreach ($tabs as $i => $tab) {
            if ((isset($tab['hide']) && true === $tab['hide']) || (isset($tab['tree']) && false === $tab['tree'])) {
                unset($tabs[$i]);
            }
        }

        return new \PHPPgAdmin\ArrayRecordSet($tabs);
    }

    /**
     * Produce JSON data for the browser tree.
     *
     * @param array $treedata a set of records to populate the tree
     * @param array $attrs    Attributes for tree items
     *                        'text' - the text for the tree node
     *                        'icon' - an icon for node
     *                        'openIcon' - an alternative icon when the node is expanded
     *                        'toolTip' - tool tip text for the node
     *                        'action' - URL to visit when single clicking the node
     *                        'iconAction' - URL to visit when single clicking the icon node
     *                        'branch' - URL for child nodes (tree JSON)
     *                        'expand' - the action to return JSON for the subtree
     *                        'nodata' - message to display when node has no children
     * @param bool  $print    either to return or echo the result
     *
     * @return \Slim\Http\Response|string the json rendered tree
     */
    private function printTreeJSON(&$treedata, &$attrs, $print = true)
    {
        $parent = [];

        if (isset($attrs['is_root'])) {
            $parent = [
                'id'       => 'root',
                'children' => true,
                'icon'     => self::SUBFOLDER . '/assets/images/themes/default/Servers.png',
                'state'    => ['opened' => true],
                'a_attr'   => ['href' => \str_replace('//', '/', self::SUBFOLDER . '/src/views/servers')],
                'url'      => \str_replace('//', '/', self::SUBFOLDER . '/src/views/servers?action=tree'),
                'text'     => 'Servers',
            ];
        } elseif (0 < \count($treedata)) {
            foreach ($treedata as $rec) {
                $icon = $this->misc->icon(Decorator::get_sanitized_value($attrs['icon'], $rec));

                if (!empty($attrs['openicon'])) {
                    $icon = $this->misc->icon(Decorator::get_sanitized_value($attrs['openIcon'], $rec));
                }

                $tree = [
                    'text'       => Decorator::get_sanitized_value($attrs['text'], $rec),
                    'id'         => \sha1(Decorator::get_sanitized_value($attrs['action'], $rec)),
                    'icon'       => Decorator::get_sanitized_value($icon, $rec),
                    'iconaction' => Decorator::get_sanitized_value($attrs['iconAction'], $rec),
                    'openicon'   => Decorator::get_sanitized_value($icon, $rec),
                    'tooltip'    => Decorator::get_sanitized_value($attrs['toolTip'], $rec),
                    'a_attr'     => ['href' => Decorator::get_sanitized_value($attrs['action'], $rec)],
                    'children'   => false,
                ];
                $url = Decorator::get_sanitized_value($attrs['branch'], $rec);

                if ($url && false === \mb_strpos($url, '/src/views')) {
                    $url = \str_replace('//', '/', self::SUBFOLDER . '/src/views/' . $url);
                }

                if ($url) {
                    $tree['url']      = $url;
                    $tree['children'] = true;
                }

                //$tree['text'] = '<a href="' . $tree['id'] . '" target="detail">' . $tree['text'] . '</a>';

                $parent[] = $tree;
            }
        } else {
            $parent = ['children' => false];
        }

        if (true === $print) {
            if (isset($_REQUEST['children'])) {
                $children = $parent;
                $parent   = ['children' => $children];
            }

            return $this
                ->container
                ->responseobj
                ->withStatus(200)
                ->withJson($parent);
        }

        return $parent;
    }
}


1			<?php
2
3			/**
4			* PHPPgAdmin v6.0.0-RC9-3-gd93ec300
5			*/
6
7			namespace PHPPgAdmin\Controller;
8
9			use PHPPgAdmin\Decorators\Decorator;
10
11			/**
12			* Base TreeController controller class.
13			*/
14			class TreeController extends BaseController
15			{
16			use \PHPPgAdmin\Traits\HelperTrait;
17
18			public $form = '';
19
20			public $href = '';
21
22			public $lang = [];
23
24			public $action = '';
25
26			public $controller_name = 'TreeController';
27
28			public $controller_title = 'base';
29
30			public $misc;
31
32			public $conf;
33
34			public $appThemes;
35
36			public $view;
37
38			public $appVersion;
39
40			public $appLangFiles;
41
42			protected $container;
43
44			// Constructor
45			public function __construct(\Slim\Container $container, $controller_name = null)
46			{
47			$this->container = $container;
48			$this->lang = $container->get('lang');
49			//$this->conf = $container->get('conf');
50			$this->view = $container->get('view');
51
52			$this->appName = $container->get('settings')['appName'];
53			$this->appVersion = $container->get('settings')['appVersion'];
54			$this->appLangFiles = $container->get('appLangFiles');
55			$this->misc = $container->get('misc');
56			$this->conf = $this->misc->getConf();
57			$this->appThemes = $container->get('appThemes');
58			$this->action = $container->get('action');
59
60			if (null !== $controller_name) {
61			$this->controller_name = $controller_name;
62			}
63			}
64
65			/**
66			* Produce JSON data for the browser tree.
67			*
68			* @param \PHPPgAdmin\ArrayRecordSet $_treedata a set of records to populate the tree
69			* @param array $attrs Attributes for tree items
70			* 'text' - the text for the tree node
71			* 'icon' - an icon for node
72			* 'openIcon' - an alternative icon when the node is expanded
73			* 'toolTip' - tool tip text for the node
74			* 'action' - URL to visit when single clicking the node
75			* 'iconAction' - URL to visit when single clicking the icon node
76			* 'branch' - URL for child nodes (tree XML)
77			* 'expand' - the action to return XML for the subtree
78			* 'nodata' - message to display when node has no children
79			* @param string $section The section where the branch is linked in the tree
80			* @param bool $print either to return or echo the result
81			*
82			* @return \Slim\Http\Response\|string the json rendered tree
83			*/
84			public function printTree(&$_treedata, &$attrs, $section, $print = true)
85			{
86			$treedata = [];
87
88			if (0 < $_treedata->recordCount()) {
89			while (!$_treedata->EOF) {
90			$treedata[] = $_treedata->fields;
91			$_treedata->moveNext();
92			}
93			}
94
95			$tree_params = [
			0 ignored issues – show Unused Code introduced 2020-02-25 17:42 UTC by Report Bug Copy Issue Report The assignment to `$tree_params` is dead and can be removed. Loading history...
96			'treedata' => &$treedata,
97			'attrs' => &$attrs,
98			'section' => $section,
99			];
100
101			return $this->printTreeJSON($treedata, $attrs, $print);
102			}
103
104			/**
105			* Hides or show tree tabs according to their properties.
106			*
107			* @param array $tabs The tabs
108			*
109			* @return \PHPPgAdmin\ArrayRecordSet filtered tabs in the form of an ArrayRecordSet
110			*/
111			public function adjustTabsForTree(&$tabs)
112			{
113			foreach ($tabs as $i => $tab) {
114			if ((isset($tab['hide']) && true === $tab['hide']) \|\| (isset($tab['tree']) && false === $tab['tree'])) {
115			unset($tabs[$i]);
116			}
117			}
118
119			return new \PHPPgAdmin\ArrayRecordSet($tabs);
120			}
121
122			/**
123			* Produce JSON data for the browser tree.
124			*
125			* @param array $treedata a set of records to populate the tree
126			* @param array $attrs Attributes for tree items
127			* 'text' - the text for the tree node
128			* 'icon' - an icon for node
129			* 'openIcon' - an alternative icon when the node is expanded
130			* 'toolTip' - tool tip text for the node
131			* 'action' - URL to visit when single clicking the node
132			* 'iconAction' - URL to visit when single clicking the icon node
133			* 'branch' - URL for child nodes (tree JSON)
134			* 'expand' - the action to return JSON for the subtree
135			* 'nodata' - message to display when node has no children
136			* @param bool $print either to return or echo the result
137			*
138			* @return \Slim\Http\Response\|string the json rendered tree
139			*/
140			private function printTreeJSON(&$treedata, &$attrs, $print = true)
141			{
142			$parent = [];
143
144			if (isset($attrs['is_root'])) {
145			$parent = [
146			'id' => 'root',
147			'children' => true,
148			'icon' => self::SUBFOLDER . '/assets/images/themes/default/Servers.png',
149			'state' => ['opened' => true],
150			'a_attr' => ['href' => \str_replace('//', '/', self::SUBFOLDER . '/src/views/servers')],
151			'url' => \str_replace('//', '/', self::SUBFOLDER . '/src/views/servers?action=tree'),
152			'text' => 'Servers',
153			];
154			} elseif (0 < \count($treedata)) {
155			foreach ($treedata as $rec) {
156			$icon = $this->misc->icon(Decorator::get_sanitized_value($attrs['icon'], $rec));
157
158			if (!empty($attrs['openicon'])) {
159			$icon = $this->misc->icon(Decorator::get_sanitized_value($attrs['openIcon'], $rec));
160			}
161
162			$tree = [
163			'text' => Decorator::get_sanitized_value($attrs['text'], $rec),
164			'id' => \sha1(Decorator::get_sanitized_value($attrs['action'], $rec)),
165			'icon' => Decorator::get_sanitized_value($icon, $rec),
166			'iconaction' => Decorator::get_sanitized_value($attrs['iconAction'], $rec),
167			'openicon' => Decorator::get_sanitized_value($icon, $rec),
168			'tooltip' => Decorator::get_sanitized_value($attrs['toolTip'], $rec),
169			'a_attr' => ['href' => Decorator::get_sanitized_value($attrs['action'], $rec)],
170			'children' => false,
171			];
172			$url = Decorator::get_sanitized_value($attrs['branch'], $rec);
173
174			if ($url && false === \mb_strpos($url, '/src/views')) {
175			$url = \str_replace('//', '/', self::SUBFOLDER . '/src/views/' . $url);
176			}
177
178			if ($url) {
179			$tree['url'] = $url;
180			$tree['children'] = true;
181			}
182
183			//$tree['text'] = '<a href="' . $tree['id'] . '" target="detail">' . $tree['text'] . '</a>';
184
185			$parent[] = $tree;
186			}
187			} else {
188			$parent = ['children' => false];
189			}
190
191			if (true === $print) {
192			if (isset($_REQUEST['children'])) {
193			$children = $parent;
194			$parent = ['children' => $children];
195			}
196
197			return $this
198			->container
199			->responseobj
200			->withStatus(200)
201			->withJson($parent);
202			}
203
204			return $parent;
205			}
206			}
207

HuasoFoundries / phpPgAdmin6

Pull Request — master (#267)

TreeController::printTreeJSON() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like