OperatorsController::doProperties() - Code Metrics - Inspection of "styling improvements" - HuasoFoundries/phpPgAdmin6 - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — develop ( 51bd2c...501708 )

by Felipe
created 2018-04-20 11:40 UTC
OperatorsController::doProperties() C

↳ Parent: OperatorsController
Complexity

Conditions	7
Paths	3
Size

Total Lines	68
Code Lines	53
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	68
rs	6.9654
c	0
b	0
f	0
cc	7
eloc	53
nc	3
nop	1
How to fix Long Method

<?php

/**
 * PHPPgAdmin v6.0.0-beta.40
 */

namespace PHPPgAdmin\Controller;

use PHPPgAdmin\Decorators\Decorator;

/**
 * Base controller class.
 *
 * @package PHPPgAdmin
 */
class OperatorsController extends BaseController
{
    public $controller_name = 'OperatorsController';

    /**
     * Default method to render the controller according to the action parameter.
     */
    public function render()
    {
        if ('tree' == $this->action) {
            return $this->doTree();
        }

        $this->printHeader($this->lang['stroperators']);
        $this->printBody();

        switch ($this->action) {
            case 'save_create':
                if (isset($_POST['cancel'])) {
                    $this->doDefault();
                } else {
                    $this->doSaveCreate();
                           doSaveCreate();
                }

                break;
            case 'create':
                $this->doCreate();
                       doCreate();

                break;
            case 'drop':
                if (isset($_POST['cancel'])) {
                    $this->doDefault();
                } else {
                    $this->doDrop(false);
                }

                break;
            case 'confirm_drop':
                $this->doDrop(true);

                break;
            case 'properties':
                $this->doProperties();

                break;
            default:
                $this->doDefault();

                break;
        }

        $this->printFooter();
    }

    /**
     * Generate XML for the browser tree.
     */
    public function doTree()
    {
        $data = $this->misc->getDatabaseAccessor();

        $operators = $data->getOperators();

        // Operator prototype: "type operator type"
        $proto = Decorator::concat(Decorator::field('oprleftname'), ' ', Decorator::field('oprname'), ' ', Decorator::field('oprrightname'));

        $reqvars = $this->misc->getRequestVars('operator');

        $attrs = [
            'text'    => $proto,
            'icon'    => 'Operator',
            'toolTip' => Decorator::field('oprcomment'),
            'action'  => Decorator::actionurl(
                'operators',
                $reqvars,
                [
                    'action'       => 'properties',
                    'operator'     => $proto,
                    'operator_oid' => Decorator::field('oid'),
                ]
            ),
        ];

        return $this->printTree($operators, $attrs, 'operators');
    }

    /**
     * Show default list of operators in the database.
     *
     * @param mixed $msg
     */
    public function doDefault($msg = '')
    {
        $data = $this->misc->getDatabaseAccessor();

        $this->printTrail('schema');
        $this->printTabs('schema', 'operators');
        $this->printMsg($msg);

        $operators = $data->getOperators();

        $columns = [
            'operator' => [
                'title' => $this->lang['stroperator'],
                'field' => Decorator::field('oprname'),
                'url'   => "operators?action=properties&amp;{$this->misc->href}&amp;",
                'vars'  => ['operator' => 'oprname', 'operator_oid' => 'oid'],
            ],
            'leftarg'  => [
                'title' => $this->lang['strleftarg'],
                'field' => Decorator::field('oprleftname'),
            ],
            'rightarg' => [
                'title' => $this->lang['strrightarg'],
                'field' => Decorator::field('oprrightname'),
            ],
            'returns'  => [
                'title' => $this->lang['strreturns'],
                'field' => Decorator::field('resultname'),
            ],
            'actions'  => [
                'title' => $this->lang['stractions'],
            ],
            'comment'  => [
                'title' => $this->lang['strcomment'],
                'field' => Decorator::field('oprcomment'),
            ],
        ];

        $actions = [
            'drop' => [
                // 'title' => $this->lang['strdrop'],
                // 'url'   => "operators?action=confirm_drop&amp;{$this->misc->href}&amp;",
                // 'vars'  => array('operator' => 'oprname', 'operator_oid' => 'oid'),
                'content' => $this->lang['strdrop'],
                'attr'    => [
                    'href' => [
                        'url'     => 'operators',
                        'urlvars' => [
                            'action'       => 'confirm_drop',
                            'operator'     => Decorator::field('oprname'),
                            'operator_oid' => Decorator::field('oid'),
                        ],
                    ],
                ],
            ],
        ];

        echo $this->printTable($operators, $columns, $actions, 'operators-operators', $this->lang['strnooperators']);

        //        TODO operators action=create $this->lang['strcreateoperator']
    }

    /**
     * Show read only properties for an operator.
     *
     * @param mixed $msg
     */
    public function doProperties($msg = '')
    {
        $data = $this->misc->getDatabaseAccessor();

        $this->printTrail('operator');
        $this->printTitle($this->lang['strproperties'], 'pg.operator');
        $this->printMsg($msg);

        $oprdata                       = $data->getOperator($_REQUEST['operator_oid']);
        $oprdata->fields['oprcanhash'] = $data->phpBool($oprdata->fields['oprcanhash']);

        if ($oprdata->recordCount() > 0) {
            echo "<table>\n";
            echo "<tr><th class=\"data left\">{$this->lang['strname']}</th>\n";
            echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprname']), "</td></tr>\n";
            echo "<tr><th class=\"data left\">{$this->lang['strleftarg']}</th>\n";
            echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprleftname']), "</td></tr>\n";
            echo "<tr><th class=\"data left\">{$this->lang['strrightarg']}</th>\n";
            echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprrightname']), "</td></tr>\n";
            echo "<tr><th class=\"data left\">{$this->lang['strcommutator']}</th>\n";
            echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprcom']), "</td></tr>\n";
            echo "<tr><th class=\"data left\">{$this->lang['strnegator']}</th>\n";
            echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprnegate']), "</td></tr>\n";
            echo "<tr><th class=\"data left\">{$this->lang['strjoin']}</th>\n";
            echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprjoin']), "</td></tr>\n";
            echo "<tr><th class=\"data left\">{$this->lang['strhashes']}</th>\n";
            echo '<td class="data1">', ($oprdata->fields['oprcanhash']) ? $this->lang['stryes'] : $this->lang['strno'], "</td></tr>\n";

            // these field only exists in 8.2 and before in pg_catalog
            if (isset($oprdata->fields['oprlsortop'])) {
                echo "<tr><th class=\"data left\">{$this->lang['strmerges']}</th>\n";
                echo '<td class="data1">', ('0' !== $oprdata->fields['oprlsortop'] && '0' !== $oprdata->fields['oprrsortop']) ? $this->lang['stryes'] : $this->lang['strno'], "</td></tr>\n";
                echo "<tr><th class=\"data left\">{$this->lang['strrestrict']}</th>\n";
                echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprrest']), "</td></tr>\n";
                echo "<tr><th class=\"data left\">{$this->lang['strleftsort']}</th>\n";
                echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprlsortop']), "</td></tr>\n";
                echo "<tr><th class=\"data left\">{$this->lang['strrightsort']}</th>\n";
                echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprrsortop']), "</td></tr>\n";
                echo "<tr><th class=\"data left\">{$this->lang['strlessthan']}</th>\n";
                echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprltcmpop']), "</td></tr>\n";
                echo "<tr><th class=\"data left\">{$this->lang['strgreaterthan']}</th>\n";
                echo '<td class="data1">', $this->misc->printVal($oprdata->fields['oprgtcmpop']), "</td></tr>\n";
            } else {
                echo "<tr><th class=\"data left\">{$this->lang['strmerges']}</th>\n";
                echo '<td class="data1">', $data->phpBool($oprdata->fields['oprcanmerge']) ? $this->lang['stryes'] : $this->lang['strno'], "</td></tr>\n";
            }
            echo "</table>\n";

            $this->printNavLinks(
                [
                    'showall' => [
                        'attr'    => [
                            'href' => [
                                'url'     => 'operators',
                                'urlvars' => [
                                    'server'   => $_REQUEST['server'],
                                    'database' => $_REQUEST['database'],
                                    'schema'   => $_REQUEST['schema'],
                                ],
                            ],
                        ],
                        'content' => $this->lang['strshowalloperators'],
                    ], ],
                'operators-properties',
                get_defined_vars()
            );
        } else {
            $this->doDefault($this->lang['strinvalidparam']);
        }
    }

    /**
     * Show confirmation of drop and perform actual drop.
     *
     * @param mixed $confirm
     */
    public function doDrop($confirm)
    {
        $data = $this->misc->getDatabaseAccessor();

        if ($confirm) {
            $this->printTrail('operator');
            $this->printTitle($this->lang['strdrop'], 'pg.operator.drop');

            echo '<p>', sprintf($this->lang['strconfdropoperator'], $this->misc->printVal($_REQUEST['operator'])), "</p>\n";

            echo '<form action="'.\SUBFOLDER."/src/views/operators\" method=\"post\">\n";
            echo "<p><input type=\"checkbox\" id=\"cascade\" name=\"cascade\" /> <label for=\"cascade\">{$this->lang['strcascade']}</label></p>\n";
            echo "<p><input type=\"hidden\" name=\"action\" value=\"drop\" />\n";
            echo '<input type="hidden" name="operator" value="', htmlspecialchars($_REQUEST['operator']), "\" />\n";
            echo '<input type="hidden" name="operator_oid" value="', htmlspecialchars($_REQUEST['operator_oid']), "\" />\n";
            echo $this->misc->form;
            echo "<input type=\"submit\" name=\"drop\" value=\"{$this->lang['strdrop']}\" />\n";
            echo "<input type=\"submit\" name=\"cancel\" value=\"{$this->lang['strcancel']}\" /></p>\n";
            echo "</form>\n";
        } else {
            $status = $data->dropOperator($_POST['operator_oid'], isset($_POST['cascade']));
            if (0 == $status) {
                $this->doDefault($this->lang['stroperatordropped']);
            } else {
                $this->doDefault($this->lang['stroperatordroppedbad']);
            }
        }
    }
}

HuasoFoundries / phpPgAdmin6

Push — develop ( 51bd2c...501708 )

OperatorsController::doProperties() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
