Issues in HistoryController.php - New Issues - Inspection of "Php cs fixer" - HuasoFoundries/phpPgAdmin6 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#92)

by Felipe

created 2018-02-15 19:18 UTC

src/controllers/HistoryController.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

<?php


/*
 * PHPPgAdmin v6.0.0-beta.30
 */

namespace PHPPgAdmin\Controller;

use PHPPgAdmin\Decorators\Decorator;

/**
 * Base controller class.
 */
class HistoryController extends BaseController
{
    public $controller_name = 'HistoryController';

    /**
     * Default method to render the controller according to the action parameter.
     */
    public function render()
    {
        $conf = $this->conf;

        $lang   = $this->lang;
        $action = $this->action;

        $data = $this->misc->getDatabaseAccessor();

        $this->scripts = '<script type="text/javascript">window.inPopUp=true;</script>';

        switch ($action) {
            case 'confdelhistory':
                $this->doDelHistory($_REQUEST['queryid'], true);

                break;
            case 'delhistory':
                if (isset($_POST['yes'])) {
                    $this->doDelHistory($_REQUEST['queryid'], false);
                }

                $this->doDefault();

                break;
            case 'confclearhistory':
                $this->doClearHistory(true);

                break;
            case 'clearhistory':
                if (isset($_POST['yes'])) {
                    $this->doClearHistory(false);
                }

                $this->doDefault();

                break;
            case 'download':
                return $this->doDownloadHistory();
            default:
                $this->doDefault();
        }

        // Set the name of the window
        $this->setWindowName('history');

        return $this->printFooter();
    }

    public function doDefault()
    {
        $conf = $this->conf;

        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        $onchange = "onchange=\"location.href='".\SUBFOLDER."/src/views/history.php?server=' + encodeURI(server.options[server.selectedIndex].value) + '&amp;database=' + encodeURI(database.options[database.selectedIndex].value) + '&amp;'\"";

        $this->printHeader($lang['strhistory'], $this->scripts, true, 'header.twig');

        // Bring to the front always
        echo "<body onload=\"window.focus();\">\n";

        echo '<form action="'.\SUBFOLDER."/src/views/history.php\" method=\"post\">\n";
        $this->misc->printConnection($onchange);
        echo '</form><br />';

        if (!isset($_REQUEST['database'])) {
            echo "<p>{$lang['strnodatabaseselected']}</p>\n";

            return;
        }

        if (isset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']])) {
            $history = new \PHPPgAdmin\ArrayRecordSet($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']]);

            //Kint::dump($history);
            $columns = [
                'query' => [
                    'title' => $lang['strsql'],
                    'field' => Decorator::field('query'),
                ],
                'paginate' => [
                    'title' => $lang['strpaginate'],
                    'field' => Decorator::field('paginate'),
                    'type'  => 'yesno',
                ],
                'actions' => [
                    'title' => $lang['stractions'],
                ],
            ];

            $actions = [
                'run' => [
                    'content' => $lang['strexecute'],
                    'attr'    => [
                        'href' => [
                            'url'     => 'sql.php',
                            'urlvars' => [
                                'subject'   => 'history',
                                'nohistory' => 't',
                                'queryid'   => Decorator::field('queryid'),
                                'paginate'  => Decorator::field('paginate'),
                            ],
                        ],
                        'target' => 'detail',
                    ],
                ],
                'remove' => [
                    'content' => $lang['strdelete'],
                    'attr'    => [
                        'href' => [
                            'url'     => 'history.php',
                            'urlvars' => [
                                'action'  => 'confdelhistory',
                                'queryid' => Decorator::field('queryid'),
                            ],
                        ],
                    ],
                ],
            ];

            echo $this->printTable($history, $columns, $actions, 'history-history', $lang['strnohistory']);
        } else {
            echo "<p>{$lang['strnohistory']}</p>\n";
        }

        $navlinks = [
            'refresh' => [
                'attr' => [
                    'href' => [
                        'url'     => 'history.php',
                        'urlvars' => [
                            'action'   => 'history',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                        ],
                    ],
                ],
                'content' => $lang['strrefresh'],
            ],
        ];

        if (isset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']])
            && count($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']])) {
            $navlinks['download'] = [
                'attr' => [
                    'href' => [
                        'url'     => 'history.php',
                        'urlvars' => [
                            'action'   => 'download',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                        ],
                    ],
                ],
                'content' => $lang['strdownload'],
            ];
            $navlinks['clear'] = [
                'attr' => [
                    'href' => [
                        'url'     => 'history.php',
                        'urlvars' => [
                            'action'   => 'confclearhistory',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                        ],
                    ],
                ],
                'content' => $lang['strclearhistory'],
            ];
        }

        $this->printNavLinks($navlinks, 'history-history', get_defined_vars());
    }

    public function doDelHistory($qid, $confirm)
    {
        $conf = $this->conf;

        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        if ($confirm) {
            $this->printHeader($lang['strhistory'], $this->scripts);

            // Bring to the front always
            echo "<body onload=\"window.focus();\">\n";

            echo "<h3>{$lang['strdelhistory']}</h3>\n";
            echo "<p>{$lang['strconfdelhistory']}</p>\n";

            echo '<pre>', htmlentities($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']][$qid]['query'], ENT_QUOTES, 'UTF-8'), '</pre>';
            echo '<form action="'.\SUBFOLDER."/src/views/history.php\" method=\"post\">\n";
            echo "<input type=\"hidden\" name=\"action\" value=\"delhistory\" />\n";
            echo "<input type=\"hidden\" name=\"queryid\" value=\"${qid}\" />\n";
            echo $this->misc->form;
            echo "<input type=\"submit\" name=\"yes\" value=\"{$lang['stryes']}\" />\n";
            echo "<input type=\"submit\" name=\"no\" value=\"{$lang['strno']}\" />\n";
            echo "</form>\n";
        } else {
            unset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']][$qid]);
        }
    }

    public function doClearHistory($confirm)
    {
        $conf = $this->conf;

        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        if ($confirm) {
            $this->printHeader($lang['strhistory'], $this->scripts);

            // Bring to the front always
            echo "<body onload=\"window.focus();\">\n";

            echo "<h3>{$lang['strclearhistory']}</h3>\n";
            echo "<p>{$lang['strconfclearhistory']}</p>\n";

            echo '<form action="'.\SUBFOLDER."/src/views/history.php\" method=\"post\">\n";
            echo "<input type=\"hidden\" name=\"action\" value=\"clearhistory\" />\n";
            echo $this->misc->form;
            echo "<input type=\"submit\" name=\"yes\" value=\"{$lang['stryes']}\" />\n";
            echo "<input type=\"submit\" name=\"no\" value=\"{$lang['strno']}\" />\n";
            echo "</form>\n";
        } else {
            unset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']]);
        }
    }

    public function doDownloadHistory()
    {
        header('Content-Type: application/download');
        $datetime = date('YmdHis');
        header("Content-Disposition: attachment; filename=history{$datetime}.sql");

        foreach ($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']] as $queries) {
            $query = rtrim($queries['query']);
            echo $query;
            if (';' != substr($query, -1)) {
                echo ';';
            }

            echo "\n";
        }
    }
}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2018-02-15 15:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this You must use "/**" style comments for a file comment Loading history...
3			/*
4			* PHPPgAdmin v6.0.0-beta.30
5			*/
6
7			namespace PHPPgAdmin\Controller;
8
9			use PHPPgAdmin\Decorators\Decorator;
10
11			/**
12			* Base controller class.
13			*/
14			class HistoryController extends BaseController
15			{
16			public $controller_name = 'HistoryController';
17
18			/**
19			* Default method to render the controller according to the action parameter.
20			*/
21			public function render()
22			{
23			$conf = $this->conf;
24
25			$lang = $this->lang;
26			$action = $this->action;
27
28			$data = $this->misc->getDatabaseAccessor();
29
30			$this->scripts = '<script type="text/javascript">window.inPopUp=true;</script>';
31
32			switch ($action) {
33			case 'confdelhistory':
34			$this->doDelHistory($_REQUEST['queryid'], true);
35
36			break;
37			case 'delhistory':
38			if (isset($_POST['yes'])) {
39			$this->doDelHistory($_REQUEST['queryid'], false);
40			}
41
42			$this->doDefault();
43
44			break;
45			case 'confclearhistory':
46			$this->doClearHistory(true);
47
48			break;
49			case 'clearhistory':
50			if (isset($_POST['yes'])) {
51			$this->doClearHistory(false);
52			}
53
54			$this->doDefault();
55
56			break;
57			case 'download':
58			return $this->doDownloadHistory();
59			default:
60			$this->doDefault();
61			}
62
63			// Set the name of the window
64			$this->setWindowName('history');
65
66			return $this->printFooter();
67			}
68
69			public function doDefault()
70			{
71			$conf = $this->conf;
72
73			$lang = $this->lang;
74			$data = $this->misc->getDatabaseAccessor();
75
76			$onchange = "onchange=\"location.href='".\SUBFOLDER."/src/views/history.php?server=' + encodeURI(server.options[server.selectedIndex].value) + '&database=' + encodeURI(database.options[database.selectedIndex].value) + '&'\"";
77
78			$this->printHeader($lang['strhistory'], $this->scripts, true, 'header.twig');
79
80			// Bring to the front always
81			echo "<body onload=\"window.focus();\">\n";
82
83			echo '<form action="'.\SUBFOLDER."/src/views/history.php\" method=\"post\">\n";
84			$this->misc->printConnection($onchange);
85			echo '</form><br />';
86
87			if (!isset($_REQUEST['database'])) {
88			echo "<p>{$lang['strnodatabaseselected']}</p>\n";
89
90			return;
91			}
92
93			if (isset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']])) {
94			$history = new \PHPPgAdmin\ArrayRecordSet($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']]);
95
96			//Kint::dump($history);
97			$columns = [
98			'query' => [
99			'title' => $lang['strsql'],
100			'field' => Decorator::field('query'),
101			],
102			'paginate' => [
103			'title' => $lang['strpaginate'],
104			'field' => Decorator::field('paginate'),
105			'type' => 'yesno',
106			],
107			'actions' => [
108			'title' => $lang['stractions'],
109			],
110			];
111
112			$actions = [
113			'run' => [
114			'content' => $lang['strexecute'],
115			'attr' => [
116			'href' => [
117			'url' => 'sql.php',
118			'urlvars' => [
119			'subject' => 'history',
120			'nohistory' => 't',
121			'queryid' => Decorator::field('queryid'),
122			'paginate' => Decorator::field('paginate'),
123			],
124			],
125			'target' => 'detail',
126			],
127			],
128			'remove' => [
129			'content' => $lang['strdelete'],
130			'attr' => [
131			'href' => [
132			'url' => 'history.php',
133			'urlvars' => [
134			'action' => 'confdelhistory',
135			'queryid' => Decorator::field('queryid'),
136			],
137			],
138			],
139			],
140			];
141
142			echo $this->printTable($history, $columns, $actions, 'history-history', $lang['strnohistory']);
143			} else {
144			echo "<p>{$lang['strnohistory']}</p>\n";
145			}
146
147			$navlinks = [
148			'refresh' => [
149			'attr' => [
150			'href' => [
151			'url' => 'history.php',
152			'urlvars' => [
153			'action' => 'history',
154			'server' => $_REQUEST['server'],
155			'database' => $_REQUEST['database'],
156			],
157			],
158			],
159			'content' => $lang['strrefresh'],
160			],
161			];
162
163			if (isset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']])
164			&& count($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']])) {
165			$navlinks['download'] = [
166			'attr' => [
167			'href' => [
168			'url' => 'history.php',
169			'urlvars' => [
170			'action' => 'download',
171			'server' => $_REQUEST['server'],
172			'database' => $_REQUEST['database'],
173			],
174			],
175			],
176			'content' => $lang['strdownload'],
177			];
178			$navlinks['clear'] = [
179			'attr' => [
180			'href' => [
181			'url' => 'history.php',
182			'urlvars' => [
183			'action' => 'confclearhistory',
184			'server' => $_REQUEST['server'],
185			'database' => $_REQUEST['database'],
186			],
187			],
188			],
189			'content' => $lang['strclearhistory'],
190			];
191			}
192
193			$this->printNavLinks($navlinks, 'history-history', get_defined_vars());
194			}
195
196			public function doDelHistory($qid, $confirm)
197			{
198			$conf = $this->conf;
199
200			$lang = $this->lang;
201			$data = $this->misc->getDatabaseAccessor();
202
203			if ($confirm) {
204			$this->printHeader($lang['strhistory'], $this->scripts);
205
206			// Bring to the front always
207			echo "<body onload=\"window.focus();\">\n";
208
209			echo "<h3>{$lang['strdelhistory']}</h3>\n";
210			echo "<p>{$lang['strconfdelhistory']}</p>\n";
211
212			echo '<pre>', htmlentities($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']][$qid]['query'], ENT_QUOTES, 'UTF-8'), '</pre>';
213			echo '<form action="'.\SUBFOLDER."/src/views/history.php\" method=\"post\">\n";
214			echo "<input type=\"hidden\" name=\"action\" value=\"delhistory\" />\n";
215			echo "<input type=\"hidden\" name=\"queryid\" value=\"${qid}\" />\n";
216			echo $this->misc->form;
217			echo "<input type=\"submit\" name=\"yes\" value=\"{$lang['stryes']}\" />\n";
218			echo "<input type=\"submit\" name=\"no\" value=\"{$lang['strno']}\" />\n";
219			echo "</form>\n";
220			} else {
221			unset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']][$qid]);
222			}
223			}
224
225			public function doClearHistory($confirm)
226			{
227			$conf = $this->conf;
228
229			$lang = $this->lang;
230			$data = $this->misc->getDatabaseAccessor();
231
232			if ($confirm) {
233			$this->printHeader($lang['strhistory'], $this->scripts);
234
235			// Bring to the front always
236			echo "<body onload=\"window.focus();\">\n";
237
238			echo "<h3>{$lang['strclearhistory']}</h3>\n";
239			echo "<p>{$lang['strconfclearhistory']}</p>\n";
240
241			echo '<form action="'.\SUBFOLDER."/src/views/history.php\" method=\"post\">\n";
242			echo "<input type=\"hidden\" name=\"action\" value=\"clearhistory\" />\n";
243			echo $this->misc->form;
244			echo "<input type=\"submit\" name=\"yes\" value=\"{$lang['stryes']}\" />\n";
245			echo "<input type=\"submit\" name=\"no\" value=\"{$lang['strno']}\" />\n";
246			echo "</form>\n";
247			} else {
248			unset($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']]);
249			}
250			}
251
252			public function doDownloadHistory()
253			{
254			header('Content-Type: application/download');
255			$datetime = date('YmdHis');
256			header("Content-Disposition: attachment; filename=history{$datetime}.sql");
257
258			foreach ($_SESSION['history'][$_REQUEST['server']][$_REQUEST['database']] as $queries) {
259			$query = rtrim($queries['query']);
260			echo $query;
261			if (';' != substr($query, -1)) {
262			echo ';';
263			}
264
265			echo "\n";
266			}
267			}
268			}
269

HuasoFoundries / phpPgAdmin6

Pull Request — develop (#92)

src/controllers/HistoryController.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like