Conditions | 73 |
Paths | 7752 |
Total Lines | 270 |
Code Lines | 243 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
161 | public function doFind($confirm = true, $msg = '') |
||
162 | { |
||
163 | $conf = $this->conf; |
||
164 | $misc = $this->misc; |
||
165 | $lang = $this->lang; |
||
166 | $data = $misc->getDatabaseAccessor(); |
||
167 | |||
168 | if (!isset($_REQUEST['term'])) { |
||
169 | $_REQUEST['term'] = ''; |
||
170 | } |
||
171 | |||
172 | if (!isset($_REQUEST['filter'])) { |
||
173 | $_REQUEST['filter'] = ''; |
||
174 | } |
||
175 | |||
176 | $this->printTrail('database'); |
||
177 | $this->printTabs('database', 'find'); |
||
178 | $this->printMsg($msg); |
||
179 | |||
180 | echo '<form action="' . SUBFOLDER . "/src/views/database.php\" method=\"post\">\n"; |
||
181 | echo '<p><input name="term" value="', htmlspecialchars($_REQUEST['term']), |
||
182 | "\" size=\"32\" maxlength=\"{$data->_maxNameLen}\" />\n"; |
||
183 | // Output list of filters. This is complex due to all the 'has' and 'conf' feature possibilities |
||
184 | echo "<select name=\"filter\">\n"; |
||
185 | echo "\t<option value=\"\"", ($_REQUEST['filter'] == '') ? ' selected="selected"' : '', ">{$lang['strallobjects']}</option>\n"; |
||
186 | echo "\t<option value=\"SCHEMA\"", ($_REQUEST['filter'] == 'SCHEMA') ? ' selected="selected"' : '', ">{$lang['strschemas']}</option>\n"; |
||
187 | echo "\t<option value=\"TABLE\"", ($_REQUEST['filter'] == 'TABLE') ? ' selected="selected"' : '', ">{$lang['strtables']}</option>\n"; |
||
188 | echo "\t<option value=\"VIEW\"", ($_REQUEST['filter'] == 'VIEW') ? ' selected="selected"' : '', ">{$lang['strviews']}</option>\n"; |
||
189 | echo "\t<option value=\"SEQUENCE\"", ($_REQUEST['filter'] == 'SEQUENCE') ? ' selected="selected"' : '', ">{$lang['strsequences']}</option>\n"; |
||
190 | echo "\t<option value=\"COLUMN\"", ($_REQUEST['filter'] == 'COLUMN') ? ' selected="selected"' : '', ">{$lang['strcolumns']}</option>\n"; |
||
191 | echo "\t<option value=\"RULE\"", ($_REQUEST['filter'] == 'RULE') ? ' selected="selected"' : '', ">{$lang['strrules']}</option>\n"; |
||
192 | echo "\t<option value=\"INDEX\"", ($_REQUEST['filter'] == 'INDEX') ? ' selected="selected"' : '', ">{$lang['strindexes']}</option>\n"; |
||
193 | echo "\t<option value=\"TRIGGER\"", ($_REQUEST['filter'] == 'TRIGGER') ? ' selected="selected"' : '', ">{$lang['strtriggers']}</option>\n"; |
||
194 | echo "\t<option value=\"CONSTRAINT\"", ($_REQUEST['filter'] == 'CONSTRAINT') ? ' selected="selected"' : '', ">{$lang['strconstraints']}</option>\n"; |
||
195 | echo "\t<option value=\"FUNCTION\"", ($_REQUEST['filter'] == 'FUNCTION') ? ' selected="selected"' : '', ">{$lang['strfunctions']}</option>\n"; |
||
196 | echo "\t<option value=\"DOMAIN\"", ($_REQUEST['filter'] == 'DOMAIN') ? ' selected="selected"' : '', ">{$lang['strdomains']}</option>\n"; |
||
197 | if ($conf['show_advanced']) { |
||
198 | echo "\t<option value=\"AGGREGATE\"", ($_REQUEST['filter'] == 'AGGREGATE') ? ' selected="selected"' : '', ">{$lang['straggregates']}</option>\n"; |
||
199 | echo "\t<option value=\"TYPE\"", ($_REQUEST['filter'] == 'TYPE') ? ' selected="selected"' : '', ">{$lang['strtypes']}</option>\n"; |
||
200 | echo "\t<option value=\"OPERATOR\"", ($_REQUEST['filter'] == 'OPERATOR') ? ' selected="selected"' : '', ">{$lang['stroperators']}</option>\n"; |
||
201 | echo "\t<option value=\"OPCLASS\"", ($_REQUEST['filter'] == 'OPCLASS') ? ' selected="selected"' : '', ">{$lang['stropclasses']}</option>\n"; |
||
202 | echo "\t<option value=\"CONVERSION\"", ($_REQUEST['filter'] == 'CONVERSION') ? ' selected="selected"' : '', ">{$lang['strconversions']}</option>\n"; |
||
203 | echo "\t<option value=\"LANGUAGE\"", ($_REQUEST['filter'] == 'LANGUAGE') ? ' selected="selected"' : '', ">{$lang['strlanguages']}</option>\n"; |
||
204 | } |
||
205 | echo "</select>\n"; |
||
206 | echo "<input type=\"submit\" value=\"{$lang['strfind']}\" />\n"; |
||
207 | echo $misc->form; |
||
208 | echo "<input type=\"hidden\" name=\"action\" value=\"find\" /></p>\n"; |
||
209 | echo "</form>\n"; |
||
210 | |||
211 | // Default focus |
||
212 | $this->setFocus('forms[0].term'); |
||
213 | |||
214 | // If a search term has been specified, then perform the search |
||
215 | // and display the results, grouped by object type |
||
216 | if ($_REQUEST['term'] != '') { |
||
217 | $rs = $data->findObject($_REQUEST['term'], $_REQUEST['filter']); |
||
218 | if ($rs->recordCount() > 0) { |
||
219 | $curr = ''; |
||
220 | while (!$rs->EOF) { |
||
221 | // Output a new header if the current type has changed, but not if it's just changed the rule type |
||
222 | if ($rs->fields['type'] != $curr) { |
||
223 | // Short-circuit in the case of changing from table rules to view rules; table cols to view cols; |
||
224 | // table constraints to domain constraints |
||
225 | if ($rs->fields['type'] == 'RULEVIEW' && $curr == 'RULETABLE') { |
||
226 | $curr = $rs->fields['type']; |
||
227 | } elseif ($rs->fields['type'] == 'COLUMNVIEW' && $curr == 'COLUMNTABLE') { |
||
228 | $curr = $rs->fields['type']; |
||
229 | } elseif ($rs->fields['type'] == 'CONSTRAINTTABLE' && $curr == 'CONSTRAINTDOMAIN') { |
||
230 | $curr = $rs->fields['type']; |
||
231 | } else { |
||
232 | if ($curr != '') { |
||
233 | echo "</ul>\n"; |
||
234 | } |
||
235 | |||
236 | $curr = $rs->fields['type']; |
||
237 | echo '<h3>'; |
||
238 | switch ($curr) { |
||
239 | case 'SCHEMA': |
||
240 | echo $lang['strschemas']; |
||
241 | break; |
||
242 | case 'TABLE': |
||
243 | echo $lang['strtables']; |
||
244 | break; |
||
245 | case 'VIEW': |
||
246 | echo $lang['strviews']; |
||
247 | break; |
||
248 | case 'SEQUENCE': |
||
249 | echo $lang['strsequences']; |
||
250 | break; |
||
251 | case 'COLUMNTABLE': |
||
252 | case 'COLUMNVIEW': |
||
253 | echo $lang['strcolumns']; |
||
254 | break; |
||
255 | case 'INDEX': |
||
256 | echo $lang['strindexes']; |
||
257 | break; |
||
258 | case 'CONSTRAINTTABLE': |
||
259 | case 'CONSTRAINTDOMAIN': |
||
260 | echo $lang['strconstraints']; |
||
261 | break; |
||
262 | case 'TRIGGER': |
||
263 | echo $lang['strtriggers']; |
||
264 | break; |
||
265 | case 'RULETABLE': |
||
266 | case 'RULEVIEW': |
||
267 | echo $lang['strrules']; |
||
268 | break; |
||
269 | case 'FUNCTION': |
||
270 | echo $lang['strfunctions']; |
||
271 | break; |
||
272 | case 'TYPE': |
||
273 | echo $lang['strtypes']; |
||
274 | break; |
||
275 | case 'DOMAIN': |
||
276 | echo $lang['strdomains']; |
||
277 | break; |
||
278 | case 'OPERATOR': |
||
279 | echo $lang['stroperators']; |
||
280 | break; |
||
281 | case 'CONVERSION': |
||
282 | echo $lang['strconversions']; |
||
283 | break; |
||
284 | case 'LANGUAGE': |
||
285 | echo $lang['strlanguages']; |
||
286 | break; |
||
287 | case 'AGGREGATE': |
||
288 | echo $lang['straggregates']; |
||
289 | break; |
||
290 | case 'OPCLASS': |
||
291 | echo $lang['stropclasses']; |
||
292 | break; |
||
293 | } |
||
294 | echo '</h3>'; |
||
295 | echo "<ul>\n"; |
||
296 | } |
||
297 | } |
||
298 | |||
299 | switch ($curr) { |
||
300 | case 'SCHEMA': |
||
301 | echo '<li><a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", $misc->printVal($rs->fields['name']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
302 | break; |
||
303 | case 'TABLE': |
||
304 | echo '<li>'; |
||
305 | echo "<a href=\"tables.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
306 | echo '<a href="' . SUBFOLDER . "/redirect/table?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&table=', |
||
307 | urlencode($rs->fields['name']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
308 | break; |
||
309 | case 'VIEW': |
||
310 | echo '<li>'; |
||
311 | echo "<a href=\"views.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
312 | echo '<a href="' . SUBFOLDER . "/redirect/view?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&view=', |
||
313 | urlencode($rs->fields['name']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
314 | break; |
||
315 | case 'SEQUENCE': |
||
316 | echo '<li>'; |
||
317 | echo "<a href=\"sequences.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
318 | echo "<a href=\"sequences.php?subject=sequence&action=properties&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), |
||
319 | '&sequence=', urlencode($rs->fields['name']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
320 | break; |
||
321 | case 'COLUMNTABLE': |
||
322 | echo '<li>'; |
||
323 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
324 | echo "<a href=\"tblproperties.php?subject=table&{$misc->href}&table=", urlencode($rs->fields['relname']), '&schema=', urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['relname']), '</a>.'; |
||
325 | echo "<a href=\"colproperties.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&table=', |
||
326 | urlencode($rs->fields['relname']), '&column=', urlencode($rs->fields['name']), '">', |
||
327 | $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
328 | break; |
||
329 | case 'COLUMNVIEW': |
||
330 | echo '<li>'; |
||
331 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
332 | echo "<a href=\"viewproperties.php?subject=view&{$misc->href}&view=", urlencode($rs->fields['relname']), '&schema=', urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['relname']), '</a>.'; |
||
333 | echo "<a href=\"colproperties.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&view=', |
||
334 | urlencode($rs->fields['relname']), '&column=', urlencode($rs->fields['name']), '">', |
||
335 | $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
336 | break; |
||
337 | case 'INDEX': |
||
338 | echo '<li>'; |
||
339 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
340 | echo '<a href="' . SUBFOLDER . "/redirect/table?{$misc->href}&table=", urlencode($rs->fields['relname']), '&schema=', urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['relname']), '</a>.'; |
||
341 | echo "<a href=\"indexes.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&table=', urlencode($rs->fields['relname']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
342 | break; |
||
343 | case 'CONSTRAINTTABLE': |
||
344 | echo '<li>'; |
||
345 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
346 | echo '<a href="' . SUBFOLDER . "/redirect/table?{$misc->href}&table=", urlencode($rs->fields['relname']), '&schema=', urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['relname']), '</a>.'; |
||
347 | echo "<a href=\"constraints.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&table=', |
||
348 | urlencode($rs->fields['relname']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
349 | break; |
||
350 | case 'CONSTRAINTDOMAIN': |
||
351 | echo '<li>'; |
||
352 | echo "<a href=\"domains.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
353 | echo "<a href=\"domains.php?action=properties&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&domain=', urlencode($rs->fields['relname']), '">', |
||
354 | $misc->printVal($rs->fields['relname']), '.', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
355 | break; |
||
356 | case 'TRIGGER': |
||
357 | echo '<li>'; |
||
358 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
359 | echo '<a href="' . SUBFOLDER . "/redirect/table?{$misc->href}&table=", urlencode($rs->fields['relname']), '&schema=', urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['relname']), '</a>.'; |
||
360 | echo "<a href=\"triggers.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&table=', urlencode($rs->fields['relname']), '">', |
||
361 | $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
362 | break; |
||
363 | case 'RULETABLE': |
||
364 | echo '<li>'; |
||
365 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
366 | echo '<a href="' . SUBFOLDER . "/redirect/table?{$misc->href}&table=", urlencode($rs->fields['relname']), '&schema=', urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['relname']), '</a>.'; |
||
367 | echo "<a href=\"rules.php?subject=table&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&reltype=table&table=', |
||
368 | urlencode($rs->fields['relname']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
369 | break; |
||
370 | case 'RULEVIEW': |
||
371 | echo '<li>'; |
||
372 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
373 | echo '<a href="' . SUBFOLDER . "/redirect/view?{$misc->href}&view=", urlencode($rs->fields['relname']), '&schema=', urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['relname']), '</a>.'; |
||
374 | echo "<a href=\"rules.php?subject=view&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&reltype=view&view=', |
||
375 | urlencode($rs->fields['relname']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
376 | break; |
||
377 | case 'FUNCTION': |
||
378 | echo '<li>'; |
||
379 | echo "<a href=\"functions.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
380 | echo "<a href=\"functions.php?action=properties&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&function=', |
||
381 | urlencode($rs->fields['name']), '&function_oid=', urlencode($rs->fields['oid']), '">', |
||
382 | $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
383 | break; |
||
384 | case 'TYPE': |
||
385 | echo '<li>'; |
||
386 | echo "<a href=\"types.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
387 | echo "<a href=\"types.php?action=properties&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&type=', |
||
388 | urlencode($rs->fields['name']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
389 | break; |
||
390 | case 'DOMAIN': |
||
391 | echo '<li>'; |
||
392 | echo "<a href=\"domains.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
393 | echo "<a href=\"domains.php?action=properties&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&domain=', |
||
394 | urlencode($rs->fields['name']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
395 | break; |
||
396 | case 'OPERATOR': |
||
397 | echo '<li>'; |
||
398 | echo "<a href=\"operators.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
399 | echo "<a href=\"operators.php?action=properties&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '&operator=', |
||
400 | urlencode($rs->fields['name']), '&operator_oid=', urlencode($rs->fields['oid']), '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
401 | break; |
||
402 | case 'CONVERSION': |
||
403 | echo '<li>'; |
||
404 | echo "<a href=\"conversions.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
405 | echo "<a href=\"conversions.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), |
||
406 | '">', $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
407 | break; |
||
408 | case 'LANGUAGE': |
||
409 | echo "<li><a href=\"languages.php?{$misc->href}\">", $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
410 | break; |
||
411 | case 'AGGREGATE': |
||
412 | echo '<li>'; |
||
413 | echo "<a href=\"aggregates.php?subject=schema&{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
414 | echo "<a href=\"aggregates.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', |
||
415 | $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
416 | break; |
||
417 | case 'OPCLASS': |
||
418 | echo '<li>'; |
||
419 | echo '<a href="' . SUBFOLDER . "/redirect/schema?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', $misc->printVal($rs->fields['schemaname']), '</a>.'; |
||
420 | echo "<a href=\"opclasses.php?{$misc->href}&schema=", urlencode($rs->fields['schemaname']), '">', |
||
421 | $this->_highlight($misc->printVal($rs->fields['name']), $_REQUEST['term']), "</a></li>\n"; |
||
422 | break; |
||
423 | } |
||
424 | $rs->moveNext(); |
||
425 | } |
||
426 | echo "</ul>\n"; |
||
427 | |||
428 | echo '<p>', $rs->recordCount(), ' ', $lang['strobjects'], "</p>\n"; |
||
429 | } else { |
||
430 | echo "<p>{$lang['strnoobjects']}</p>\n"; |
||
431 | } |
||
798 |