HuasoFoundries / phpPgAdmin6

index.php

Spacing +8 added lines, -8 removed lines

@@ -5,7 +5,7 @@ 
  */
 require_once './src/lib.inc.php';
 
-$app->post('/redirect[/{subject}]', function ($request, $response, $args) {
+$app->post('/redirect[/{subject}]', function($request, $response, $args) {
     $body         = $response->getBody();
     $query_string = $request->getUri()->getQuery();
     $misc         = $this->misc;
@@ -50,33 +50,33 @@ 
     }
 });
 
-$app->get('/redirect[/{subject}]', function ($request, $response, $args) {
+$app->get('/redirect[/{subject}]', function($request, $response, $args) {
     $subject        = (isset($args['subject'])) ? $args['subject'] : 'root';
     $destinationurl = $this->utils->getDestinationWithLastTab($subject);
     return $response->withStatus(302)->withHeader('Location', $destinationurl);
 });
 
-$app->get('/src/views/browser', function ($request, $response, $args) {
+$app->get('/src/views/browser', function($request, $response, $args) {
     $controller = new \PHPPgAdmin\Controller\BrowserController($this, true);
     return $controller->render();
 });
 
-$app->get('/src/views/login', function ($request, $response, $args) {
+$app->get('/src/views/login', function($request, $response, $args) {
     $controller = new \PHPPgAdmin\Controller\LoginController($this, true);
     return $controller->render();
 });
 
-$app->get('/src/views/servers', function ($request, $response, $args) {
+$app->get('/src/views/servers', function($request, $response, $args) {
     $controller = new \PHPPgAdmin\Controller\ServersController($this, true);
     return $controller->render();
 });
 
-$app->get('/src/views/intro', function ($request, $response, $args) {
+$app->get('/src/views/intro', function($request, $response, $args) {
     $controller = new \PHPPgAdmin\Controller\IntroController($this, true);
     return $controller->render();
 });
 
-$app->map(['GET', 'POST'], '/src/views/{subject}', function ($request, $response, $args) {
+$app->map(['GET', 'POST'], '/src/views/{subject}', function($request, $response, $args) {
     if ($this->misc->getServerId() === null) {
         return $response->withStatus(302)->withHeader('Location', SUBFOLDER . '/src/views/servers');
     }
@@ -94,7 +94,7 @@ 
     return $controller->render();
 });
 
-$app->get('/[{subject}]', function ($request, $response, $args) {
+$app->get('/[{subject}]', function($request, $response, $args) {
     $subject      = (isset($args['subject'])) ? $args['subject'] : 'intro';
     $_server_info = $this->misc->getServerInfo();
     $query_string = $request->getUri()->getQuery();

src/controllers/ConstraintsController.php

Spacing +1 added lines, -1 removed lines

@@ -113,7 +113,7 @@
         $lang = $this->lang;
         $data = $misc->getDatabaseAccessor();
 
-        $cnPre = function (&$rowdata) use ($data) {
+        $cnPre = function(&$rowdata) use ($data) {
             if (is_null($rowdata->fields['consrc'])) {
                 $atts                           = $data->getAttributeNames($_REQUEST['table'], explode(' ', $rowdata->fields['indkey']));
                 $rowdata->fields['+definition'] = ($rowdata->fields['contype'] == 'u' ? 'UNIQUE (' : 'PRIMARY KEY (') . join(',', $atts) . ')';

Doc Comments +4 added lines

@@ -472,6 +472,8 @@ 
 
     /**
      * Confirm and then actually add a PRIMARY KEY or UNIQUE constraint
+     * @param string $type
+     * @param boolean $confirm
      */
     public function addPrimaryOrUniqueKey($type, $confirm, $msg = '')
     {
@@ -615,6 +617,7 @@ 
 
     /**
      * Confirm and then actually add a CHECK constraint
+     * @param boolean $confirm
      */
     public function addCheck($confirm, $msg = '')
     {
@@ -671,6 +674,7 @@ 
 
     /**
      * Show confirmation of drop and perform actual drop
+     * @param boolean $confirm
      */
     public function doDrop($confirm)
     {

src/controllers/TblpropertiesController.php

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
         $lang = $this->lang;
         $data = $misc->getDatabaseAccessor();
 
-        $attPre = function (&$rowdata, $actions) use ($data) {
+        $attPre = function(&$rowdata, $actions) use ($data) {
             $rowdata->fields['+type'] = $data->formatType($rowdata->fields['type'], $rowdata->fields['atttypmod']);
             $attname                  = $rowdata->fields['attname'];
             $table                    = $_REQUEST['table'];
@@ -111,7 +111,7 @@ 
             return $actions;
         };
 
-        $cstrRender = function ($s, $p) use ($misc, $data) {
+        $cstrRender = function($s, $p) use ($misc, $data) {
             $str = '';
             foreach ($p['keys'] as $k => $c) {
                 if (is_null($p['keys'][$k]['consrc'])) {

Doc Comments +1 added lines

@@ -840,6 +840,7 @@
 
     /**
      * Show confirmation of drop column and perform actual drop
+     * @param boolean $confirm
      */
     public function doDrop($confirm)
     {

src/lib.inc.php

Spacing +10 added lines, -10 removed lines

@@ -103,12 +103,12 @@ 
 $container['requestobj']  = $container['request'];
 $container['responseobj'] = $container['response'];
 
-$container['utils'] = function ($c) {
+$container['utils'] = function($c) {
     $utils = new \PHPPgAdmin\ContainerUtils($c);
     return $utils;
 };
 
-$container['conf'] = function ($c) use ($conf) {
+$container['conf'] = function($c) use ($conf) {
 
     //\Kint::dump($conf);
     // Plugins are removed
@@ -117,7 +117,7 @@ 
     return $conf;
 };
 
-$container['lang'] = function ($c) {
+$container['lang'] = function($c) {
     include_once BASE_PATH . '/src/translations.php';
 
     $c['appLangFiles'] = $appLangFiles;
@@ -127,12 +127,12 @@ 
     return $lang;
 };
 
-$container['plugin_manager'] = function ($c) {
+$container['plugin_manager'] = function($c) {
     $plugin_manager = new \PHPPgAdmin\PluginManager($c);
     return $plugin_manager;
 };
 
-$container['serializer'] = function ($c) {
+$container['serializer'] = function($c) {
     $serializerbuilder = \JMS\Serializer\SerializerBuilder::create();
     $serializer        = $serializerbuilder
         ->setCacheDir(BASE_PATH . '/temp/jms')
@@ -142,7 +142,7 @@ 
 };
 
 // Create Misc class references
-$container['misc'] = function ($c) {
+$container['misc'] = function($c) {
     $misc = new \PHPPgAdmin\Misc($c);
 
     $conf = $c->get('conf');
@@ -240,7 +240,7 @@ 
 };
 
 // Register Twig View helper
-$container['view'] = function ($c) {
+$container['view'] = function($c) {
     $conf = $c->get('conf');
     $misc = $c->misc;
 
@@ -276,8 +276,8 @@ 
     return $view;
 };
 
-$container['haltHandler'] = function ($c) {
-    return function ($request, $response, $exits, $status = 500) use ($c) {
+$container['haltHandler'] = function($c) {
+    return function($request, $response, $exits, $status = 500) use ($c) {
         $title = 'PHPPgAdmin Error';
 
         $html = '<p>The application could not run because of the following error:</p>';
@@ -307,7 +307,7 @@ 
 
 // Set the requestobj and responseobj properties of the container
 // as the value of $request and $response, which already contain the route
-$app->add(function ($request, $response, $next) {
+$app->add(function($request, $response, $next) {
     $this['requestobj']  = $request;
     $this['responseobj'] = $response;
 

src/classes/ADOdbException.php

Doc Comments +5 added lines

@@ -25,6 +25,11 @@
     public $host     = '';
     public $database = '';
 
+    /**
+     * @param string $errmsg
+     * @param string $p1
+     * @param string $p2
+     */
     public function __construct($dbms, $fn, $errno, $errmsg, $p1, $p2, $thisConnection)
     {
         switch ($fn) {

src/classes/Misc.php

Doc Comments +5 added lines, -2 removed lines

@@ -120,7 +120,7 @@ 
     /**
      * Displays link to the context help.
      * @param $str   - the string that the context help is related to (already escaped)
-     * @param $help  - help section identifier
+     * @param string $help  - help section identifier
      * @param $do_print true to echo, false to return
      */
     public function printHelp($str, $help = null, $do_print = true)
@@ -345,6 +345,9 @@ 
         return $this->data;
     }
 
+    /**
+     * @param string $server_id
+     */
     public function getConnection($database = '', $server_id = null)
     {
         $lang = $this->lang;
@@ -449,7 +452,7 @@ 
 
     /**
      * Set server information.
-     * @param $key parameter name to set, or null to replace all
+     * @param null|string $key parameter name to set, or null to replace all
      *             params with the assoc-array in $value.
      * @param $value the new value, or null to unset the parameter
      * @param $server_id the server identifier, or null for current

src/controllers/AggregatesController.php

Doc Comments +1 added lines

@@ -388,6 +388,7 @@
 
     /**
      * Show confirmation of drop and perform actual drop of the aggregate function selected
+     * @param boolean $confirm
      */
     public function doDrop($confirm)
     {

src/controllers/AlldbController.php

Doc Comments +2 added lines

@@ -239,6 +239,7 @@ 
 
     /**
      * Display a form for alter and perform actual alter
+     * @param boolean $confirm
      */
     public function doAlter($confirm)
     {
@@ -311,6 +312,7 @@ 
 
     /**
      * Show confirmation of drop and perform actual drop
+     * @param boolean $confirm
      */
     public function doDrop($confirm)
     {

src/controllers/BaseController.php

Doc Comments +31 added lines, -4 removed lines

@@ -162,9 +162,9 @@ 
      * @param  [type] &$tabledata [description]
      * @param  [type] &$columns   [description]
      * @param  [type] &$actions   [description]
-     * @param  [type] $place      [description]
+     * @param  string $place      [description]
      * @param  [type] $nodata     [description]
-     * @param  [type] $pre_fn     [description]
+     * @param  \Closure $pre_fn     [description]
      * @return [type]             [description]
      */
     public function printTable(&$tabledata, &$columns, &$actions, $place, $nodata = null, $pre_fn = null)
@@ -179,6 +179,9 @@ 
         return $tree->adjustTabsForTree($tabs);
     }
 
+    /**
+     * @param string $section
+     */
     public function printTree(&$_treedata, &$attrs, $section, $print = true)
     {
         $tree = $this->getTreeController();
@@ -192,6 +195,9 @@ 
         return $html_trail->printTrail($trail, $do_print, $from);
     }
 
+    /**
+     * @param string $place
+     */
     public function printNavLinks($navlinks, $place, $env = [], $do_print = true)
     {
         $from       = __METHOD__;
@@ -199,6 +205,9 @@ 
         return $html_trail->printNavLinks($navlinks, $place, $env, $do_print, $from);
     }
 
+    /**
+     * @param string $activetab
+     */
     public function printTabs($tabs, $activetab, $do_print = true)
     {
         $from       = __METHOD__;
@@ -212,6 +221,9 @@ 
         return $html_trail->getLastTabURL($section);
     }
 
+    /**
+     * @param string $from
+     */
     public function printLink($link, $do_print = true, $from = null)
     {
         if ($from === null) {
@@ -222,12 +234,18 @@ 
         return $html_trail->printLink($link, $do_print, $from);
     }
 
+    /**
+     * @param boolean $flag
+     */
     public function setReloadDropDatabase($flag)
     {
         $footer_controller = $this->getFooterController();
         return $footer_controller->setReloadDropDatabase($flag);
     }
 
+    /**
+     * @param boolean $flag
+     */
     public function setNoBottomLink($flag)
     {
         $footer_controller = $this->getFooterController();
@@ -248,7 +266,7 @@ 
 
     /**
      * Outputs JavaScript to set default focus
-     * @param $object eg. forms[0].username
+     * @param string $object eg. forms[0].username
      */
     public function setFocus($object)
     {
@@ -258,7 +276,7 @@ 
 
     /**
      * Outputs JavaScript to set the name of the browser window.
-     * @param $name the window name
+     * @param string $name the window name
      * @param $addServer if true (default) then the server id is
      *        attached to the name.
      */
@@ -268,12 +286,18 @@ 
         return $footer_controller->setWindowName($name, $addServer);
     }
 
+    /**
+     * @param boolean $flag
+     */
     public function setNoOutput($flag)
     {
         $header_controller = $this->getHeaderController();
         return $header_controller->setNoOutput(boolval($flag));
     }
 
+    /**
+     * @param string $script
+     */
     public function printHeader($title = '', $script = null, $do_print = true, $template = 'header.twig')
     {
         $header_controller = $this->getHeaderController();
@@ -286,6 +310,9 @@ 
         return $header_controller->printBody($doBody, $bodyClass);
     }
 
+    /**
+     * @param string $help
+     */
     public function printTitle($title, $help = null, $do_print = true)
     {
         $header_controller = $this->getHeaderController();