Issues in IndexesController.php - New Issues - Inspection of "Merge pull request #104 from HuasoFoundries/analys..." - HuasoFoundries/phpPgAdmin6 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 442876...4ec1bc )

by Felipe

created 2018-03-09 23:17 UTC

src/controllers/IndexesController.php (5 issues)

Labels

Severity

<?php


/*
 * PHPPgAdmin v6.0.0-beta.30
 */

namespace PHPPgAdmin\Controller;

use PHPPgAdmin\Decorators\Decorator;

/**
 * Base controller class.
 */
class IndexesController extends BaseController
{
    public $controller_name = 'IndexesController';

    /**
     * Default method to render the controller according to the action parameter.
     */
    public function render()
    {
        $lang = $this->lang;

        $action = $this->action;
        if ('tree' == $action) {
            return $this->doTree();
        }

        $this->printHeader($lang['strindexes'], '<script src="' . \SUBFOLDER . '/js/indexes.js" type="text/javascript"></script>');

        if ('create_index' == $action || 'save_create_index' == $action) {
            echo '<body onload="init();">';
        } else {
            $this->printBody();
        }

        switch ($action) {
            case 'cluster_index':
                if (isset($_POST['cluster'])) {
                    $this->doClusterIndex(false);
                } else {
                    $this->doDefault();
                }

                break;
            case 'confirm_cluster_index':
                $this->doClusterIndex(true);

                break;
            case 'reindex':
                $this->doReindex();

                break;
            case 'save_create_index':
                if (isset($_POST['cancel'])) {
                    $this->doDefault();
                } else {
                    $this->doSaveCreateIndex();
                }

                break;
            case 'create_index':
                $this->doCreateIndex();

                break;
            case 'drop_index':
                if (isset($_POST['drop'])) {
                    $this->doDropIndex(false);
                } else {
                    $this->doDefault();
                }

                break;
            case 'confirm_drop_index':
                $this->doDropIndex(true);

                break;
            default:
                $this->doDefault();

                break;
        }

        return $this->printFooter();
    }

    public function doDefault($msg = '')
    {
        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        $indPre = function (&$rowdata, $actions) use ($data, $lang) {
            if ($data->phpBool($rowdata->fields['indisprimary'])) {
                $rowdata->fields['+constraints'] = $lang['strprimarykey'];
                $actions['drop']['disable']      = true;
            } elseif ($data->phpBool($rowdata->fields['indisunique'])) {
                $rowdata->fields['+constraints'] = $lang['struniquekey'];
                $actions['drop']['disable']      = true;
            } else {
                $rowdata->fields['+constraints'] = '';
            }

            return $actions;
        };
        if (!isset($_REQUEST['subject'])) {
            $_REQUEST['subject'] = 'table';
        }

        $subject = urlencode($_REQUEST['subject']);
        $object  = urlencode($_REQUEST[$_REQUEST['subject']]);

        $this->printTrail($subject);
        $this->printTabs($subject, 'indexes');
        $this->printMsg($msg);

        $indexes = $data->getIndexes($_REQUEST[$_REQUEST['subject']]);

        $columns = [
            'index'       => [
                'title' => $lang['strname'],
                'field' => Decorator::field('indname'),
            ],
            'definition'  => [
                'title' => $lang['strdefinition'],
                'field' => Decorator::field('inddef'),
            ],
            'constraints' => [
                'title'  => $lang['strconstraints'],
                'field'  => Decorator::field('+constraints'),
                'type'   => 'verbatim',
                'params' => ['align' => 'center'],
            ],
            'clustered'   => [
                'title' => $lang['strclustered'],
                'field' => Decorator::field('indisclustered'),
                'type'  => 'yesno',
            ],
            'actions'     => [
                'title' => $lang['stractions'],
            ],
            'comment'     => [
                'title' => $lang['strcomment'],
                'field' => Decorator::field('idxcomment'),
            ],
        ];

        $actions = [
            'cluster' => [
                'content' => $lang['strclusterindex'],
                'attr'    => [
                    'href' => [
                        'url'     => 'indexes.php',
                        'urlvars' => [
                            'action' => 'confirm_cluster_index',
                            $subject => $object,
                            'index'  => Decorator::field('indname'),
                        ],
                    ],
                ],
            ],
            'reindex' => [
                'content' => $lang['strreindex'],
                'attr'    => [
                    'href' => [
                        'url'     => 'indexes.php',
                        'urlvars' => [
                            'action' => 'reindex',
                            $subject => $object,
                            'index'  => Decorator::field('indname'),
                        ],
                    ],
                ],
            ],
            'drop'    => [
                'content' => $lang['strdrop'],
                'attr'    => [
                    'href' => [
                        'url'     => 'indexes.php',
                        'urlvars' => [
                            'action' => 'confirm_drop_index',
                            $subject => $object,
                            'index'  => Decorator::field('indname'),
                        ],
                    ],
                ],
            ],
        ];

        echo $this->printTable($indexes, $columns, $actions, 'indexes-indexes', $lang['strnoindexes'], $indPre);

        $this->printNavLinks([
            'create' => [
                'attr'    => [
                    'href' => [
                        'url'     => 'indexes.php',
                        'urlvars' => [
                            'action'   => 'create_index',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                            'schema'   => $_REQUEST['schema'],
                            $subject   => $object,
                            'subject'  => $subject,
                        ],
                    ],
                ],
                'content' => $lang['strcreateindex'],
            ],
        ], 'indexes-indexes', get_defined_vars());
    }

    public function doTree()
    {
        $lang = $this->lang;

        $data = $this->misc->getDatabaseAccessor();
        if (!isset($_REQUEST['subject'])) {
            $_REQUEST['subject'] = 'table';
        }

        $subject = urlencode($_REQUEST['subject']);
        $object  = urlencode($_REQUEST[$_REQUEST['subject']]);

        $indexes = $data->getIndexes($object);

        $reqvars = $this->misc->getRequestVars($subject);

        $getIcon = function ($f) {
            if ('t' == $f['indisprimary']) {
                return 'PrimaryKey';
            }

            if ('t' == $f['indisunique']) {
                return 'UniqueConstraint';
            }

            return 'Index';
        };

        $attrs = [
            'text' => Decorator::field('indname'),
            'icon' => Decorator::callback($getIcon),
        ];

        return $this->printTree($indexes, $attrs, 'indexes');
    }

    /**
     * Show confirmation of cluster index and perform actual cluster.
     *
     * @param mixed $confirm

     */
    public function doClusterIndex($confirm)
    {
        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        if ($confirm) {
            // Default analyze to on
            $_REQUEST['analyze'] = true;

            $this->printTrail('index');
            $this->printTitle($lang['strclusterindex'], 'pg.index.cluster');

            echo '<p>', sprintf($lang['strconfcluster'], $this->misc->printVal($_REQUEST['index'])), '</p>' . "\n";

            echo '<form action="' . \SUBFOLDER . '/src/views/indexes.php" method="post">' . "\n";
            echo '<p><input type="checkbox" id="analyze" name="analyze"', (isset($_REQUEST['analyze']) ? ' checked="checked"' : ''), ' />';
            echo "<label for=\"analyze\">{$lang['stranalyze']}</label></p>" . "\n";
            echo '<input type="hidden" name="action" value="cluster_index" />' . "\n";
            echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), '" />' . "\n";
            echo '<input type="hidden" name="index" value="', htmlspecialchars($_REQUEST['index']), '" />' . "\n";
            echo $this->misc->form;
            echo "<input type=\"submit\" name=\"cluster\" value=\"{$lang['strclusterindex']}\" />" . "\n";
            echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" />" . "\n";
            echo '</form>' . "\n";
        } else {
            $status = $data->clusterIndex($_POST['table'], $_POST['index']);
            if (0 == $status) {
                if (isset($_POST['analyze'])) {
                    $status = $data->analyzeDB($_POST['table']);
                    if (0 == $status) {
                        $this->doDefault($lang['strclusteredgood'] . ' ' . $lang['stranalyzegood']);
                    } else {
                        $this->doDefault($lang['stranalyzebad']);
                    }
                } else {
                    $this->doDefault($lang['strclusteredgood']);
                }
            } else {
                $this->doDefault($lang['strclusteredbad']);
            }
        }
    }

    public function doReindex()
    {
        $lang   = $this->lang;
        $data   = $this->misc->getDatabaseAccessor();
        $status = $data->reindex('INDEX', $_REQUEST['index']);
        if (0 == $status) {
            $this->doDefault($lang['strreindexgood']);
        } else {
            $this->doDefault($lang['strreindexbad']);
        }
    }

    /**
     * Displays a screen where they can enter a new index.
     *
     * @param mixed $msg

     */
    public function doCreateIndex($msg = '')
    {
        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        if (!isset($_REQUEST['subject'])) {
            $_REQUEST['subject'] = 'table';
        }
        $subject = urlencode($_REQUEST['subject']);
        $object  = urlencode($_REQUEST[$subject]);

        if (!isset($_POST['formIndexName'])) {
            $_POST['formIndexName'] = '';
        }

        if (!isset($_POST['formIndexType'])) {
            $_POST['formIndexType'] = null;
        }

        if (!isset($_POST['formCols'])) {
            $_POST['formCols'] = '';
        }

        if (!isset($_POST['formWhere'])) {
            $_POST['formWhere'] = '';
        }

        if (!isset($_POST['formSpc'])) {
            $_POST['formSpc'] = '';
        }

        $attrs = $data->getTableAttributes($object);
        // Fetch all tablespaces from the database
        if ($data->hasTablespaces()) {
            $tablespaces = $data->getTablespaces();
        }

        $this->printTrail($subject);
        $this->printTitle($lang['strcreateindex'], 'pg.index.create');
        $this->printMsg($msg);

        $selColumns = new \PHPPgAdmin\XHtml\XHtmlSelect('TableColumnList', true, 10);
        $selColumns->set_style('width: 10em;');

        if ($attrs->recordCount() > 0) {
            while (!$attrs->EOF) {
                $attname = new \PHPPgAdmin\XHtml\XHtmlOption($attrs->fields['attname']);
                $selColumns->add($attname);
                $attrs->moveNext();
            }
        }

        $selIndex = new \PHPPgAdmin\XHtml\XHtmlSelect('IndexColumnList[]', true, 10);
        $selIndex->set_style('width: 10em;');
        $selIndex->set_attribute('id', 'IndexColumnList');
        $buttonAdd = new \PHPPgAdmin\XHtml\XHtmlButton('add', '>>');
        $buttonAdd->set_attribute('onclick', 'buttonPressed(this);');
        $buttonAdd->set_attribute('type', 'button');

        $buttonRemove = new \PHPPgAdmin\XHtml\XHtmlButton('remove', '<<');
        $buttonRemove->set_attribute('onclick', 'buttonPressed(this);');
        $buttonRemove->set_attribute('type', 'button');

        echo '<form onsubmit="doSelectAll();" name="formIndex" action="indexes.php" method="post">' . "\n";

        echo '<table>' . "\n";
        echo '<tr><th class="data required" colspan="3">' . $lang['strindexname'] . '</th></tr>';
        echo '<tr>';
        echo '<td class="data1" colspan="3">';
        echo '<input type="text" name="formIndexName" size="32" maxlength="' . $data->_maxNameLen . '" value="' . htmlspecialchars($_POST['formIndexName']) . '" />';
        echo '</td></tr>';
        echo '<tr><th class="data">' . $lang['strtablecolumnlist'] . '</th><th class="data">&nbsp;</th>';
        echo '<th class="data required">' . $lang['strindexcolumnlist'] . '</th></tr>' . "\n";
        echo '<tr><td class="data1">' . $selColumns->fetch() . '</td>' . "\n";
        echo '<td class="data1">' . $buttonRemove->fetch() . $buttonAdd->fetch() . '</td>';
        echo '<td class="data1">' . $selIndex->fetch() . '</td></tr>' . "\n";
        echo '</table>' . "\n";

        echo '<table> ' . "\n";
        echo '<tr>';
        echo '<th class="data left required" scope="row">' . $lang['strindextype'] . '</th>';
        echo '<td class="data1"><select name="formIndexType">';
        foreach ($data->typIndexes as $v) {
            echo '<option value="', htmlspecialchars($v), '"',
            ($v == $_POST['formIndexType']) ? ' selected="selected"' : '', '>', htmlspecialchars($v), '</option>' . "\n";
        }
        echo '</select></td></tr>' . "\n";
        echo '<tr>';
        echo "<th class=\"data left\" scope=\"row\"><label for=\"formUnique\">{$lang['strunique']}</label></th>";
        echo '<td class="data1"><input type="checkbox" id="formUnique" name="formUnique"', (isset($_POST['formUnique']) ? 'checked="checked"' : ''), ' /></td>';
        echo '</tr>';
        echo '<tr>';
        echo "<th class=\"data left\" scope=\"row\">{$lang['strwhere']}</th>";
        echo '<td class="data1">(<input name="formWhere" size="32" maxlength="' . $data->_maxNameLen . '" value="' . htmlspecialchars($_POST['formWhere']) . '" />)</td>';
        echo '</tr>';

        // Tablespace (if there are any)
        if ($data->hasTablespaces() && $tablespaces->recordCount() > 0) {
            echo "\t<tr>\n\t\t<th class=\"data left\">{$lang['strtablespace']}</th>" . "\n";
            echo "\t\t<td class=\"data1\">\n\t\t\t<select name=\"formSpc\">" . "\n";
            // Always offer the default (empty) option
            echo "\t\t\t\t<option value=\"\"",
            ('' == $_POST['formSpc']) ? ' selected="selected"' : '', '></option>' . "\n";
            // Display all other tablespaces
            while (!$tablespaces->EOF) {
                $spcname = htmlspecialchars($tablespaces->fields['spcname']);
                echo "\t\t\t\t<option value=\"{$spcname}\"",
                ($spcname == $_POST['formSpc']) ? ' selected="selected"' : '', ">{$spcname}</option>" . "\n";
                $tablespaces->moveNext();
            }
            echo "\t\t\t</select>\n\t\t</td>\n\t</tr>" . "\n";
        }

        if ($data->hasConcurrentIndexBuild()) {
            echo '<tr>';
            echo "<th class=\"data left\" scope=\"row\"><label for=\"formConcur\">{$lang['strconcurrently']}</label></th>";
            echo '<td class="data1"><input type="checkbox" id="formConcur" name="formConcur"', (isset($_POST['formConcur']) ? 'checked="checked"' : ''), ' /></td>';
            echo '</tr>';
        }

        echo '</table>';

        echo '<p><input type="hidden" name="action" value="save_create_index" />' . "\n";
        echo $this->misc->form;
        echo '<input type="hidden" name="subject" value="', htmlspecialchars($subject), '" />' . "\n";
        echo '<input type="hidden" name="' . $subject . '" value="', htmlspecialchars($object), '" />' . "\n";
        echo "<input type=\"submit\" value=\"{$lang['strcreate']}\" />" . "\n";
        echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" /></p>" . "\n";
        echo '</form>' . "\n";
    }

    /**
     * Actually creates the new index in the database.
     *
     * @@ Note: this function can't handle columns with commas in them
     */
    public function doSaveCreateIndex()
    {
        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        if (!isset($_POST['subject'])) {
            $_POST['subject'] = 'table';
        }
        $subject = urlencode($_POST['subject']);
        $object  = urlencode($_POST[$subject]);

        // Handle databases that don't have partial indexes
        if (!isset($_POST['formWhere'])) {
            $_POST['formWhere'] = '';
        }

        // Default tablespace to null if it isn't set
        if (!isset($_POST['formSpc'])) {
            $_POST['formSpc'] = null;
        }

        // Check that they've given a name and at least one column
        if ('' == $_POST['formIndexName']) {
            $this->doCreateIndex($lang['strindexneedsname']);
        } elseif (!isset($_POST['IndexColumnList']) || '' == $_POST['IndexColumnList']) {
            $this->doCreateIndex($lang['strindexneedscols']);
        } else {
            $status = $data->createIndex(
                $_POST['formIndexName'],
                $object,
                $_POST['IndexColumnList'],
                $_POST['formIndexType'],
                isset($_POST['formUnique']),
                $_POST['formWhere'],
                $_POST['formSpc'],
                isset($_POST['formConcur'])
            );
            if (0 == $status) {
                $this->doDefault($lang['strindexcreated']);
            } else {
                $this->doCreateIndex($lang['strindexcreatedbad']);
            }
        }
    }

    /**
     * Show confirmation of drop index and perform actual drop.
     *
     * @param mixed $confirm

     */
    public function doDropIndex($confirm)
    {
        $lang = $this->lang;
        $data = $this->misc->getDatabaseAccessor();

        if (!isset($_REQUEST['subject'])) {
            $_REQUEST['subject'] = 'table';
        }
        $subject = urlencode($_REQUEST['subject']);
        $object  = urlencode($_REQUEST[$_REQUEST['subject']]);

        if ($confirm) {
            $this->printTrail('index');
            $this->printTitle($lang['strdrop'], 'pg.index.drop');

            echo '<p>', sprintf($lang['strconfdropindex'], $this->misc->printVal($_REQUEST['index'])), '</p>' . "\n";

            echo '<form action="' . \SUBFOLDER . '/src/views/indexes.php" method="post">' . "\n";
            echo '<input type="hidden" name="action" value="drop_index" />' . "\n";
            echo '<input type="hidden" name="table" value="', htmlspecialchars($object), '" />' . "\n";
            echo '<input type="hidden" name="index" value="', htmlspecialchars($_REQUEST['index']), '" />' . "\n";
            echo $this->misc->form;
            echo "<p><input type=\"checkbox\" id=\"cascade\" name=\"cascade\" /> <label for=\"cascade\">{$lang['strcascade']}</label></p>" . "\n";
            echo "<input type=\"submit\" name=\"drop\" value=\"{$lang['strdrop']}\" />" . "\n";
            echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" />" . "\n";
            echo '</form>' . "\n";
        } else {
            $status = $data->dropIndex($_POST['index'], isset($_POST['cascade']));
            if (0 == $status) {
                $this->doDefault($lang['strindexdropped']);
            } else {
                $this->doDefault($lang['strindexdroppedbad']);
            }
        }
    }
}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2018-02-15 15:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this You must use "/**" style comments for a file comment Loading history...
3			/*
4			* PHPPgAdmin v6.0.0-beta.30
5			*/
6
7			namespace PHPPgAdmin\Controller;
8
9			use PHPPgAdmin\Decorators\Decorator;
10
11			/**
12			* Base controller class.
13			*/
14			class IndexesController extends BaseController
15			{
16			public $controller_name = 'IndexesController';
17
18			/**
19			* Default method to render the controller according to the action parameter.
20			*/
21			public function render()
22			{
23			$lang = $this->lang;
24
25			$action = $this->action;
26			if ('tree' == $action) {
27			return $this->doTree();
28			}
29
30			$this->printHeader($lang['strindexes'], '<script src="' . \SUBFOLDER . '/js/indexes.js" type="text/javascript"></script>');
31
32			if ('create_index' == $action \|\| 'save_create_index' == $action) {
33			echo '<body onload="init();">';
34			} else {
35			$this->printBody();
36			}
37
38			switch ($action) {
39			case 'cluster_index':
40			if (isset($_POST['cluster'])) {
41			$this->doClusterIndex(false);
42			} else {
43			$this->doDefault();
44			}
45
46			break;
47			case 'confirm_cluster_index':
48			$this->doClusterIndex(true);
49
50			break;
51			case 'reindex':
52			$this->doReindex();
53
54			break;
55			case 'save_create_index':
56			if (isset($_POST['cancel'])) {
57			$this->doDefault();
58			} else {
59			$this->doSaveCreateIndex();
60			}
61
62			break;
63			case 'create_index':
64			$this->doCreateIndex();
65
66			break;
67			case 'drop_index':
68			if (isset($_POST['drop'])) {
69			$this->doDropIndex(false);
70			} else {
71			$this->doDefault();
72			}
73
74			break;
75			case 'confirm_drop_index':
76			$this->doDropIndex(true);
77
78			break;
79			default:
80			$this->doDefault();
81
82			break;
83			}
84
85			return $this->printFooter();
86			}
87
88			public function doDefault($msg = '')
89			{
90			$lang = $this->lang;
91			$data = $this->misc->getDatabaseAccessor();
92
93			$indPre = function (&$rowdata, $actions) use ($data, $lang) {
94			if ($data->phpBool($rowdata->fields['indisprimary'])) {
95			$rowdata->fields['+constraints'] = $lang['strprimarykey'];
96			$actions['drop']['disable'] = true;
97			} elseif ($data->phpBool($rowdata->fields['indisunique'])) {
98			$rowdata->fields['+constraints'] = $lang['struniquekey'];
99			$actions['drop']['disable'] = true;
100			} else {
101			$rowdata->fields['+constraints'] = '';
102			}
103
104			return $actions;
105			};
106			if (!isset($_REQUEST['subject'])) {
107			$_REQUEST['subject'] = 'table';
108			}
109
110			$subject = urlencode($_REQUEST['subject']);
111			$object = urlencode($_REQUEST[$_REQUEST['subject']]);
112
113			$this->printTrail($subject);
114			$this->printTabs($subject, 'indexes');
115			$this->printMsg($msg);
116
117			$indexes = $data->getIndexes($_REQUEST[$_REQUEST['subject']]);
118
119			$columns = [
120			'index' => [
121			'title' => $lang['strname'],
122			'field' => Decorator::field('indname'),
123			],
124			'definition' => [
125			'title' => $lang['strdefinition'],
126			'field' => Decorator::field('inddef'),
127			],
128			'constraints' => [
129			'title' => $lang['strconstraints'],
130			'field' => Decorator::field('+constraints'),
131			'type' => 'verbatim',
132			'params' => ['align' => 'center'],
133			],
134			'clustered' => [
135			'title' => $lang['strclustered'],
136			'field' => Decorator::field('indisclustered'),
137			'type' => 'yesno',
138			],
139			'actions' => [
140			'title' => $lang['stractions'],
141			],
142			'comment' => [
143			'title' => $lang['strcomment'],
144			'field' => Decorator::field('idxcomment'),
145			],
146			];
147
148			$actions = [
149			'cluster' => [
150			'content' => $lang['strclusterindex'],
151			'attr' => [
152			'href' => [
153			'url' => 'indexes.php',
154			'urlvars' => [
155			'action' => 'confirm_cluster_index',
156			$subject => $object,
157			'index' => Decorator::field('indname'),
158			],
159			],
160			],
161			],
162			'reindex' => [
163			'content' => $lang['strreindex'],
164			'attr' => [
165			'href' => [
166			'url' => 'indexes.php',
167			'urlvars' => [
168			'action' => 'reindex',
169			$subject => $object,
170			'index' => Decorator::field('indname'),
171			],
172			],
173			],
174			],
175			'drop' => [
176			'content' => $lang['strdrop'],
177			'attr' => [
178			'href' => [
179			'url' => 'indexes.php',
180			'urlvars' => [
181			'action' => 'confirm_drop_index',
182			$subject => $object,
183			'index' => Decorator::field('indname'),
184			],
185			],
186			],
187			],
188			];
189
190			echo $this->printTable($indexes, $columns, $actions, 'indexes-indexes', $lang['strnoindexes'], $indPre);
191
192			$this->printNavLinks([
193			'create' => [
194			'attr' => [
195			'href' => [
196			'url' => 'indexes.php',
197			'urlvars' => [
198			'action' => 'create_index',
199			'server' => $_REQUEST['server'],
200			'database' => $_REQUEST['database'],
201			'schema' => $_REQUEST['schema'],
202			$subject => $object,
203			'subject' => $subject,
204			],
205			],
206			],
207			'content' => $lang['strcreateindex'],
208			],
209			], 'indexes-indexes', get_defined_vars());
210			}
211
212			public function doTree()
213			{
214			$lang = $this->lang;
			0 ignored issues – show Unused Code introduced 2018-02-15 15:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$lang` is dead and can be removed. Loading history...
215			$data = $this->misc->getDatabaseAccessor();
216			if (!isset($_REQUEST['subject'])) {
217			$_REQUEST['subject'] = 'table';
218			}
219
220			$subject = urlencode($_REQUEST['subject']);
221			$object = urlencode($_REQUEST[$_REQUEST['subject']]);
222
223			$indexes = $data->getIndexes($object);
224
225			$reqvars = $this->misc->getRequestVars($subject);
226
227			$getIcon = function ($f) {
228			if ('t' == $f['indisprimary']) {
229			return 'PrimaryKey';
230			}
231
232			if ('t' == $f['indisunique']) {
233			return 'UniqueConstraint';
234			}
235
236			return 'Index';
237			};
238
239			$attrs = [
240			'text' => Decorator::field('indname'),
241			'icon' => Decorator::callback($getIcon),
242			];
243
244			return $this->printTree($indexes, $attrs, 'indexes');
245			}
246
247			/**
248			* Show confirmation of cluster index and perform actual cluster.
249			*
250			* @param mixed $confirm
			1 ignored issue – show Coding Style introduced 2018-02-15 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing parameter comment Loading history...
251			*/
252			public function doClusterIndex($confirm)
253			{
254			$lang = $this->lang;
255			$data = $this->misc->getDatabaseAccessor();
256
257			if ($confirm) {
258			// Default analyze to on
259			$_REQUEST['analyze'] = true;
260
261			$this->printTrail('index');
262			$this->printTitle($lang['strclusterindex'], 'pg.index.cluster');
263
264			echo '<p>', sprintf($lang['strconfcluster'], $this->misc->printVal($_REQUEST['index'])), '</p>' . "\n";
265
266			echo '<form action="' . \SUBFOLDER . '/src/views/indexes.php" method="post">' . "\n";
267			echo '<p><input type="checkbox" id="analyze" name="analyze"', (isset($_REQUEST['analyze']) ? ' checked="checked"' : ''), ' />';
268			echo "<label for=\"analyze\">{$lang['stranalyze']}</label></p>" . "\n";
269			echo '<input type="hidden" name="action" value="cluster_index" />' . "\n";
270			echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), '" />' . "\n";
271			echo '<input type="hidden" name="index" value="', htmlspecialchars($_REQUEST['index']), '" />' . "\n";
272			echo $this->misc->form;
273			echo "<input type=\"submit\" name=\"cluster\" value=\"{$lang['strclusterindex']}\" />" . "\n";
274			echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" />" . "\n";
275			echo '</form>' . "\n";
276			} else {
277			$status = $data->clusterIndex($_POST['table'], $_POST['index']);
278			if (0 == $status) {
279			if (isset($_POST['analyze'])) {
280			$status = $data->analyzeDB($_POST['table']);
281			if (0 == $status) {
282			$this->doDefault($lang['strclusteredgood'] . ' ' . $lang['stranalyzegood']);
283			} else {
284			$this->doDefault($lang['stranalyzebad']);
285			}
286			} else {
287			$this->doDefault($lang['strclusteredgood']);
288			}
289			} else {
290			$this->doDefault($lang['strclusteredbad']);
291			}
292			}
293			}
294
295			public function doReindex()
296			{
297			$lang = $this->lang;
298			$data = $this->misc->getDatabaseAccessor();
299			$status = $data->reindex('INDEX', $_REQUEST['index']);
300			if (0 == $status) {
301			$this->doDefault($lang['strreindexgood']);
302			} else {
303			$this->doDefault($lang['strreindexbad']);
304			}
305			}
306
307			/**
308			* Displays a screen where they can enter a new index.
309			*
310			* @param mixed $msg
			1 ignored issue – show Coding Style introduced 2018-02-15 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing parameter comment Loading history...
311			*/
312			public function doCreateIndex($msg = '')
313			{
314			$lang = $this->lang;
315			$data = $this->misc->getDatabaseAccessor();
316
317			if (!isset($_REQUEST['subject'])) {
318			$_REQUEST['subject'] = 'table';
319			}
320			$subject = urlencode($_REQUEST['subject']);
321			$object = urlencode($_REQUEST[$subject]);
322
323			if (!isset($_POST['formIndexName'])) {
324			$_POST['formIndexName'] = '';
325			}
326
327			if (!isset($_POST['formIndexType'])) {
328			$_POST['formIndexType'] = null;
329			}
330
331			if (!isset($_POST['formCols'])) {
332			$_POST['formCols'] = '';
333			}
334
335			if (!isset($_POST['formWhere'])) {
336			$_POST['formWhere'] = '';
337			}
338
339			if (!isset($_POST['formSpc'])) {
340			$_POST['formSpc'] = '';
341			}
342
343			$attrs = $data->getTableAttributes($object);
344			// Fetch all tablespaces from the database
345			if ($data->hasTablespaces()) {
346			$tablespaces = $data->getTablespaces();
347			}
348
349			$this->printTrail($subject);
350			$this->printTitle($lang['strcreateindex'], 'pg.index.create');
351			$this->printMsg($msg);
352
353			$selColumns = new \PHPPgAdmin\XHtml\XHtmlSelect('TableColumnList', true, 10);
354			$selColumns->set_style('width: 10em;');
355
356			if ($attrs->recordCount() > 0) {
357			while (!$attrs->EOF) {
358			$attname = new \PHPPgAdmin\XHtml\XHtmlOption($attrs->fields['attname']);
359			$selColumns->add($attname);
360			$attrs->moveNext();
361			}
362			}
363
364			$selIndex = new \PHPPgAdmin\XHtml\XHtmlSelect('IndexColumnList[]', true, 10);
365			$selIndex->set_style('width: 10em;');
366			$selIndex->set_attribute('id', 'IndexColumnList');
367			$buttonAdd = new \PHPPgAdmin\XHtml\XHtmlButton('add', '>>');
368			$buttonAdd->set_attribute('onclick', 'buttonPressed(this);');
369			$buttonAdd->set_attribute('type', 'button');
370
371			$buttonRemove = new \PHPPgAdmin\XHtml\XHtmlButton('remove', '<<');
372			$buttonRemove->set_attribute('onclick', 'buttonPressed(this);');
373			$buttonRemove->set_attribute('type', 'button');
374
375			echo '<form onsubmit="doSelectAll();" name="formIndex" action="indexes.php" method="post">' . "\n";
376
377			echo '<table>' . "\n";
378			echo '<tr><th class="data required" colspan="3">' . $lang['strindexname'] . '</th></tr>';
379			echo '<tr>';
380			echo '<td class="data1" colspan="3">';
381			echo '<input type="text" name="formIndexName" size="32" maxlength="' . $data->_maxNameLen . '" value="' . htmlspecialchars($_POST['formIndexName']) . '" />';
382			echo '</td></tr>';
383			echo '<tr><th class="data">' . $lang['strtablecolumnlist'] . '</th><th class="data"> </th>';
384			echo '<th class="data required">' . $lang['strindexcolumnlist'] . '</th></tr>' . "\n";
385			echo '<tr><td class="data1">' . $selColumns->fetch() . '</td>' . "\n";
386			echo '<td class="data1">' . $buttonRemove->fetch() . $buttonAdd->fetch() . '</td>';
387			echo '<td class="data1">' . $selIndex->fetch() . '</td></tr>' . "\n";
388			echo '</table>' . "\n";
389
390			echo '<table> ' . "\n";
391			echo '<tr>';
392			echo '<th class="data left required" scope="row">' . $lang['strindextype'] . '</th>';
393			echo '<td class="data1"><select name="formIndexType">';
394			foreach ($data->typIndexes as $v) {
395			echo '<option value="', htmlspecialchars($v), '"',
396			($v == $_POST['formIndexType']) ? ' selected="selected"' : '', '>', htmlspecialchars($v), '</option>' . "\n";
397			}
398			echo '</select></td></tr>' . "\n";
399			echo '<tr>';
400			echo "<th class=\"data left\" scope=\"row\"><label for=\"formUnique\">{$lang['strunique']}</label></th>";
401			echo '<td class="data1"><input type="checkbox" id="formUnique" name="formUnique"', (isset($_POST['formUnique']) ? 'checked="checked"' : ''), ' /></td>';
402			echo '</tr>';
403			echo '<tr>';
404			echo "<th class=\"data left\" scope=\"row\">{$lang['strwhere']}</th>";
405			echo '<td class="data1">(<input name="formWhere" size="32" maxlength="' . $data->_maxNameLen . '" value="' . htmlspecialchars($_POST['formWhere']) . '" />)</td>';
406			echo '</tr>';
407
408			// Tablespace (if there are any)
409			if ($data->hasTablespaces() && $tablespaces->recordCount() > 0) {
410			echo "\t<tr>\n\t\t<th class=\"data left\">{$lang['strtablespace']}</th>" . "\n";
411			echo "\t\t<td class=\"data1\">\n\t\t\t<select name=\"formSpc\">" . "\n";
412			// Always offer the default (empty) option
413			echo "\t\t\t\t<option value=\"\"",
414			('' == $_POST['formSpc']) ? ' selected="selected"' : '', '></option>' . "\n";
415			// Display all other tablespaces
416			while (!$tablespaces->EOF) {
417			$spcname = htmlspecialchars($tablespaces->fields['spcname']);
418			echo "\t\t\t\t<option value=\"{$spcname}\"",
419			($spcname == $_POST['formSpc']) ? ' selected="selected"' : '', ">{$spcname}</option>" . "\n";
420			$tablespaces->moveNext();
421			}
422			echo "\t\t\t</select>\n\t\t</td>\n\t</tr>" . "\n";
423			}
424
425			if ($data->hasConcurrentIndexBuild()) {
426			echo '<tr>';
427			echo "<th class=\"data left\" scope=\"row\"><label for=\"formConcur\">{$lang['strconcurrently']}</label></th>";
428			echo '<td class="data1"><input type="checkbox" id="formConcur" name="formConcur"', (isset($_POST['formConcur']) ? 'checked="checked"' : ''), ' /></td>';
429			echo '</tr>';
430			}
431
432			echo '</table>';
433
434			echo '<p><input type="hidden" name="action" value="save_create_index" />' . "\n";
435			echo $this->misc->form;
436			echo '<input type="hidden" name="subject" value="', htmlspecialchars($subject), '" />' . "\n";
437			echo '<input type="hidden" name="' . $subject . '" value="', htmlspecialchars($object), '" />' . "\n";
438			echo "<input type=\"submit\" value=\"{$lang['strcreate']}\" />" . "\n";
439			echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" /></p>" . "\n";
440			echo '</form>' . "\n";
441			}
442
443			/**
444			* Actually creates the new index in the database.
445			*
446			* @@ Note: this function can't handle columns with commas in them
447			*/
448			public function doSaveCreateIndex()
449			{
450			$lang = $this->lang;
451			$data = $this->misc->getDatabaseAccessor();
452
453			if (!isset($_POST['subject'])) {
454			$_POST['subject'] = 'table';
455			}
456			$subject = urlencode($_POST['subject']);
457			$object = urlencode($_POST[$subject]);
458
459			// Handle databases that don't have partial indexes
460			if (!isset($_POST['formWhere'])) {
461			$_POST['formWhere'] = '';
462			}
463
464			// Default tablespace to null if it isn't set
465			if (!isset($_POST['formSpc'])) {
466			$_POST['formSpc'] = null;
467			}
468
469			// Check that they've given a name and at least one column
470			if ('' == $_POST['formIndexName']) {
471			$this->doCreateIndex($lang['strindexneedsname']);
472			} elseif (!isset($_POST['IndexColumnList']) \|\| '' == $_POST['IndexColumnList']) {
473			$this->doCreateIndex($lang['strindexneedscols']);
474			} else {
475			$status = $data->createIndex(
476			$_POST['formIndexName'],
477			$object,
478			$_POST['IndexColumnList'],
479			$_POST['formIndexType'],
480			isset($_POST['formUnique']),
481			$_POST['formWhere'],
482			$_POST['formSpc'],
483			isset($_POST['formConcur'])
484			);
485			if (0 == $status) {
486			$this->doDefault($lang['strindexcreated']);
487			} else {
488			$this->doCreateIndex($lang['strindexcreatedbad']);
489			}
490			}
491			}
492
493			/**
494			* Show confirmation of drop index and perform actual drop.
495			*
496			* @param mixed $confirm
			1 ignored issue – show Coding Style introduced 2018-02-15 19:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing parameter comment Loading history...
497			*/
498			public function doDropIndex($confirm)
499			{
500			$lang = $this->lang;
501			$data = $this->misc->getDatabaseAccessor();
502
503			if (!isset($_REQUEST['subject'])) {
504			$_REQUEST['subject'] = 'table';
505			}
506			$subject = urlencode($_REQUEST['subject']);
507			$object = urlencode($_REQUEST[$_REQUEST['subject']]);
508
509			if ($confirm) {
510			$this->printTrail('index');
511			$this->printTitle($lang['strdrop'], 'pg.index.drop');
512
513			echo '<p>', sprintf($lang['strconfdropindex'], $this->misc->printVal($_REQUEST['index'])), '</p>' . "\n";
514
515			echo '<form action="' . \SUBFOLDER . '/src/views/indexes.php" method="post">' . "\n";
516			echo '<input type="hidden" name="action" value="drop_index" />' . "\n";
517			echo '<input type="hidden" name="table" value="', htmlspecialchars($object), '" />' . "\n";
518			echo '<input type="hidden" name="index" value="', htmlspecialchars($_REQUEST['index']), '" />' . "\n";
519			echo $this->misc->form;
520			echo "<p><input type=\"checkbox\" id=\"cascade\" name=\"cascade\" /> <label for=\"cascade\">{$lang['strcascade']}</label></p>" . "\n";
521			echo "<input type=\"submit\" name=\"drop\" value=\"{$lang['strdrop']}\" />" . "\n";
522			echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" />" . "\n";
523			echo '</form>' . "\n";
524			} else {
525			$status = $data->dropIndex($_POST['index'], isset($_POST['cascade']));
526			if (0 == $status) {
527			$this->doDefault($lang['strindexdropped']);
528			} else {
529			$this->doDefault($lang['strindexdroppedbad']);
530			}
531			}
532			}
533			}
534

HuasoFoundries / phpPgAdmin6

Push — master ( 442876...4ec1bc )

src/controllers/IndexesController.php (5 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like