PHPPgAdmin\Controller\AdminTrait::doCluster()

Complexity

Conditions	15
Paths	22

Size

Total Lines	80
Code Lines	56

Duplication

Lines	45
Ratio	56.25 %

Importance

Changes

0

<?php
    public function doCluster($type, $confirm = false)
    {
        $this->script = ($type == 'database') ? 'database.php' : 'tables.php';

The property script does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $script = $this->script;
        $misc   = $this->misc;

The property misc does not exist on PHPPgAdmin\Controller\AdminTrait. Did you maybe forget to declare it?

        $lang   = $this->lang;

The property lang does not exist on PHPPgAdmin\Controller\AdminTrait. Did you maybe forget to declare it?

        $data   = $misc->getDatabaseAccessor();

        if (($type == 'table') && empty($_REQUEST['table']) && empty($_REQUEST['ma'])) {

This code seems to be duplicated across your project.

            $this->doDefault($lang['strspecifytabletocluster']);

It seems like doDefault() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return;
        }

        if ($confirm) {
            if (isset($_REQUEST['ma'])) {

This code seems to be duplicated across your project.

                $this->printTrail('schema');

It seems like printTrail() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->printTitle($lang['strclusterindex'], 'pg.index.cluster');

It seems like printTitle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                echo '<form action="' . SUBFOLDER . "/src/views/{$script}\" method=\"post\">\n";
                foreach ($_REQUEST['ma'] as $v) {
                    $a = unserialize(htmlspecialchars_decode($v, ENT_QUOTES));

                    echo '<p>', sprintf($lang['strconfclustertable'], $misc->printVal($a['table'])), "</p>\n";
                    echo '<input type="hidden" name="table[]" value="', htmlspecialchars($a['table']), "\" />\n";
                }
            } // END if multi cluster
            else {
                $this->printTrail($type);

It seems like printTrail() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->printTitle($lang['strclusterindex'], 'pg.index.cluster');

It seems like printTitle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                echo '<form action="' . SUBFOLDER . "/src/views/{$script}\" method=\"post\">\n";

                if ($type == 'table') {
                    echo '<p>', sprintf($lang['strconfclustertable'], $misc->printVal($_REQUEST['object'])), "</p>\n";
                    echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['object']), "\" />\n";
                } else {
                    echo '<p>', sprintf($lang['strconfclusterdatabase'], $misc->printVal($_REQUEST['object'])), "</p>\n";
                    echo "<input type=\"hidden\" name=\"table\" value=\"\" />\n";
                }
            }
            echo "<input type=\"hidden\" name=\"action\" value=\"cluster\" />\n";

            echo $misc->form;

            echo "<input type=\"submit\" name=\"cluster\" value=\"{$lang['strcluster']}\" />\n"; //TODO
            echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" />\n";
            echo "</form>\n";
        } // END single cluster
        else {
            //If multi table cluster
            if ($type == 'table') {
                // cluster one or more table
                if (is_array($_REQUEST['table'])) {
                    $msg = '';
                    foreach ($_REQUEST['table'] as $o) {
                        $status = $data->clusterIndex($o);
                        if ($status == 0) {
                            $msg .= sprintf('%s: %s<br />', htmlentities($o, ENT_QUOTES, 'UTF-8'), $lang['strclusteredgood']);
                        } else {
                            $this->doDefault($type, sprintf('%s%s: %s<br />', $msg, htmlentities($o, ENT_QUOTES, 'UTF-8'), $lang['strclusteredbad']));

It seems like doDefault() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                            return;
                        }
                    }
                    // Everything went fine, back to the Default page....
                    $this->doDefault($msg);

It seems like doDefault() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                } else {

This code seems to be duplicated across your project.

                    $status = $data->clusterIndex($_REQUEST['object']);
                    if ($status == 0) {
                        $this->doAdmin($type, $lang['strclusteredgood']);
                    } else {
                        $this->doAdmin($type, $lang['strclusteredbad']);
                    }
                }
            } else {

This code seems to be duplicated across your project.

                // Cluster all tables in database
                $status = $data->clusterIndex();
                if ($status == 0) {
                    $this->doAdmin($type, $lang['strclusteredgood']);
                } else {
                    $this->doAdmin($type, $lang['strclusteredbad']);
                }