DataexportController::doDefault() - Code Metrics - Inspection of "scrutinizer build badge" - HuasoFoundries/phpPgAdmin6 - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — develop (db5506)

by Felipe

created 2017-10-08 18:16 UTC

DataexportController::doDefault() B

↳ Parent: DataexportController

Complexity

Conditions	8
Paths	32

Size

Total Lines	53
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	39
nc	32
nop	1
dl	0
loc	53
rs	7.1199
c	0
b	0
f	0

How to fix Long Method

<?php

namespace PHPPgAdmin\Controller;

/**
 * Base controller class
 */
class DataexportController extends BaseController
{
    public $_name      = 'DataexportController';
    public $extensions = [
        'sql'  => 'sql',
        'copy' => 'sql',
        'csv'  => 'csv',
        'tab'  => 'txt',
        'html' => 'html',
        'xml'  => 'xml',
    ];

    public function render()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf   = $this->conf;
        $misc   = $this->misc;
        $lang   = $this->lang;
        $data   = $misc->getDatabaseAccessor();
        $action = $this->action;

        set_time_limit(0);

        // if (!isset($_REQUEST['table']) && !isset($_REQUEST['query']))
        // What must we do in this case? Maybe redirect to the homepage?

        // If format is set, then perform the export
        if (isset($_REQUEST['what'])) {
            $this->prtrace("REQUEST['what']", $_REQUEST['what']);

            // Include application functions
            $this->setNoOutput(true);

            switch ($_REQUEST['what']) {
                case 'dataonly':
                    // Check to see if they have pg_dump set up and if they do, use that
                    // instead of custom dump code
                    if ($misc->isDumpEnabled() && ($_REQUEST['d_format'] == 'copy' || $_REQUEST['d_format'] == 'sql')) {
                        $this->prtrace('DUMP ENABLED, d_format is', $_REQUEST['d_format']);
                        $dbexport_controller = new \PHPPgAdmin\Controller\DbexportController($this->getContainer());
                        return $dbexport_controller->render();
                    } else {
                        $this->prtrace('d_format is', $_REQUEST['d_format'], 'd_oids is', isset($_REQUEST['d_oids']));
                        $format = $_REQUEST['d_format'];
                        $oids   = isset($_REQUEST['d_oids']);
                    }
                    break;
                case 'structureonly':
                    // Check to see if they have pg_dump set up and if they do, use that
                    // instead of custom dump code
                    if ($misc->isDumpEnabled()) {
                        $dbexport_controller = new \PHPPgAdmin\Controller\DbexportController($this->getContainer());
                        return $dbexport_controller->render();
                    } else {
                        $clean = isset($_REQUEST['s_clean']);
                    }

                    break;
                case 'structureanddata':
                    // Check to see if they have pg_dump set up and if they do, use that
                    // instead of custom dump code
                    if ($misc->isDumpEnabled()) {
                        $dbexport_controller = new \PHPPgAdmin\Controller\DbexportController($this->getContainer());
                        return $dbexport_controller->render();
                    } else {
                        $format = $_REQUEST['sd_format'];
                        $clean  = isset($_REQUEST['sd_clean']);
                        $oids   = isset($_REQUEST['sd_oids']);
                    }
                    break;
            }

            // Make it do a download, if necessary
            if ($_REQUEST['output'] == 'download') {
                // Set headers.  MSIE is totally broken for SSL downloading, so
                // we need to have it download in-place as plain text
                if (strstr($_SERVER['HTTP_USER_AGENT'], 'MSIE') && isset($_SERVER['HTTPS'])) {
                    header('Content-Type: text/plain');
                } else {
                    header('Content-Type: application/download');

                    if (isset($extensions[$format])) {
                        $ext = $extensions[$format];
                    } else {
                        $ext = 'txt';
                    }

                    header('Content-Disposition: attachment; filename=dump.' . $ext);
                }
            } else {
                header('Content-Type: text/plain');
            }

            if (isset($_REQUEST['query'])) {
                $_REQUEST['query'] = trim(urldecode($_REQUEST['query']));
            }

            // Set the schema search path
            if (isset($_REQUEST['search_path'])) {

                $data->setSearchPath(array_map('trim', explode(',', $_REQUEST['search_path'])));
            }

            // Set up the dump transaction
            $status = $data->beginDump();

            // If the dump is not dataonly then dump the structure prefix
            if ($_REQUEST['what'] != 'dataonly') {
                echo $data->getTableDefPrefix($_REQUEST['table'], $clean);
            }

            // If the dump is not structureonly then dump the actual data
            if ($_REQUEST['what'] != 'structureonly') {
                // Get database encoding
                $dbEncoding = $data->getDatabaseEncoding();

                // Set fetch mode to NUM so that duplicate field names are properly returned
                $data->conn->setFetchMode(ADODB_FETCH_NUM);

                // Execute the query, if set, otherwise grab all rows from the table
                if (isset($_REQUEST['table'])) {
                    $rs = $data->dumpRelation($_REQUEST['table'], $oids);
                } else {
                    $rs = $data->conn->Execute($_REQUEST['query']);
                }

                if ($format == 'copy') {
                    $data->fieldClean($_REQUEST['table']);
                    echo "COPY \"{$_REQUEST['table']}\"";
                    if ($oids) {
                        echo ' WITH OIDS';
                    }

                    echo " FROM stdin;\n";
                    while (!$rs->EOF) {
                        $first = true;
                        while (list($k, $v) = each($rs->fields)) {
                            // Escape value
                            $v = $data->escapeBytea($v);

                            // We add an extra escaping slash onto octal encoded characters
                            $v = preg_replace('/\\\\([0-7]{3})/', '\\\\\1', $v);
                            if ($first) {
                                echo (is_null($v)) ? '\\N' : $v;
                                $first = false;
                            } else {
                                echo "\t", (is_null($v)) ? '\\N' : $v;
                            }
                        }
                        echo "\n";
                        $rs->moveNext();
                    }
                    echo "\\.\n";
                } elseif ($format == 'html') {
                    echo "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\r\n";
                    echo "<html xmlns=\"http://www.w3.org/1999/xhtml\">\r\n";
                    echo "<head>\r\n";
                    echo "\t<title></title>\r\n";
                    echo "\t<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />\r\n";
                    echo "</head>\r\n";
                    echo "<body>\r\n";
                    echo "<table class=\"phppgadmin\">\r\n";
                    echo "\t<tr>\r\n";
                    if (!$rs->EOF) {
                        // Output header row
                        $j = 0;
                        foreach ($rs->fields as $k => $v) {

                            $finfo = $rs->fetchField($j++);
                            if ($finfo->name == $data->id && !$oids) {
                                continue;
                            }

                            echo "\t\t<th>", $misc->printVal($finfo->name, true), "</th>\r\n";
                        }
                    }
                    echo "\t</tr>\r\n";
                    while (!$rs->EOF) {
                        echo "\t<tr>\r\n";
                        $j = 0;
                        foreach ($rs->fields as $k => $v) {

                            $finfo = $rs->fetchField($j++);
                            if ($finfo->name == $data->id && !$oids) {
                                continue;
                            }

                            echo "\t\t<td>", $misc->printVal($v, true, $finfo->type), "</td>\r\n";
                        }
                        echo "\t</tr>\r\n";
                        $rs->moveNext();
                    }
                    echo "</table>\r\n";
                    echo "</body>\r\n";
                    echo "</html>\r\n";
                } elseif ($format == 'xml') {
                    echo "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n";
                    echo "<data>\n";
                    if (!$rs->EOF) {
                        // Output header row
                        $j = 0;
                        echo "\t<header>\n";
                        foreach ($rs->fields as $k => $v) {
                            $finfo = $rs->fetchField($j++);
                            $name  = htmlspecialchars($finfo->name);
                            $type  = htmlspecialchars($finfo->type);
                            echo "\t\t<column name=\"{$name}\" type=\"{$type}\" />\n";
                        }
                        echo "\t</header>\n";
                    }
                    echo "\t<records>\n";
                    while (!$rs->EOF) {
                        $j = 0;
                        echo "\t\t<row>\n";
                        foreach ($rs->fields as $k => $v) {
                            $finfo = $rs->fetchField($j++);
                            $name  = htmlspecialchars($finfo->name);
                            if (!is_null($v)) {
                                $v = htmlspecialchars($v);
                            }

                            echo "\t\t\t<column name=\"{$name}\"", (is_null($v) ? ' null="null"' : ''), ">{$v}</column>\n";
                        }
                        echo "\t\t</row>\n";
                        $rs->moveNext();
                    }
                    echo "\t</records>\n";
                    echo "</data>\n";
                } elseif ($format == 'sql') {
                    $data->fieldClean($_REQUEST['table']);
                    while (!$rs->EOF) {
                        echo "INSERT INTO \"{$_REQUEST['table']}\" (";
                        $first = true;
                        $j     = 0;
                        foreach ($rs->fields as $k => $v) {
                            $finfo = $rs->fetchField($j++);
                            $k     = $finfo->name;
                            // SQL (INSERT) format cannot handle oids
                            //                        if ($k == $data->id) continue;
                            // Output field
                            $data->fieldClean($k);
                            if ($first) {
                                echo "\"{$k}\"";
                            } else {
                                echo ", \"{$k}\"";
                            }

                            if (!is_null($v)) {
                                // Output value
                                // addCSlashes converts all weird ASCII characters to octal representation,
                                // EXCEPT the 'special' ones like \r \n \t, etc.
                                $v = addCSlashes($v, "\0..\37\177..\377");
                                // We add an extra escaping slash onto octal encoded characters
                                $v = preg_replace('/\\\\([0-7]{3})/', '\\\1', $v);
                                // Finally, escape all apostrophes
                                $v = str_replace("'", "''", $v);
                            }
                            if ($first) {

                                $values = (is_null($v) ? 'NULL' : "'{$v}'");
                                $first  = false;
                            } else {
                                $values .= ', ' . ((is_null($v) ? 'NULL' : "'{$v}'"));
                            }
                        }
                        echo ") VALUES ({$values});\n";
                        $rs->moveNext();
                    }
                } else {
                    switch ($format) {
                        case 'tab':
                            $sep = "\t";
                            break;
                        case 'csv':
                        default:
                            $sep = ',';
                            break;
                    }
                    if (!$rs->EOF) {
                        // Output header row
                        $first = true;
                        foreach ($rs->fields as $k => $v) {
                            $finfo = $rs->fetchField($k);
                            $v     = $finfo->name;
                            if (!is_null($v)) {
                                $v = str_replace('"', '""', $v);
                            }

                            if ($first) {
                                echo "\"{$v}\"";
                                $first = false;
                            } else {
                                echo "{$sep}\"{$v}\"";
                            }
                        }
                        echo "\r\n";
                    }
                    while (!$rs->EOF) {
                        $first = true;
                        foreach ($rs->fields as $k => $v) {
                            if (!is_null($v)) {
                                $v = str_replace('"', '""', $v);
                            }

                            if ($first) {

                                echo (is_null($v)) ? '"\\N"' : "\"{$v}\"";
                                $first = false;
                            } else {
                                echo is_null($v) ? "{$sep}\"\\N\"" : "{$sep}\"{$v}\"";
                            }
                        }
                        echo "\r\n";
                        $rs->moveNext();
                    }
                }
            }

            // If the dump is not dataonly then dump the structure suffix
            if ($_REQUEST['what'] != 'dataonly') {
                // Set fetch mode back to ASSOC for the table suffix to work
                $data->conn->setFetchMode(ADODB_FETCH_ASSOC);
                echo $data->getTableDefSuffix($_REQUEST['table']);
            }

            // Finish the dump transaction
            $status = $data->endDump();
        } else {
            return $this->doDefault();
        }
    }

    public function doDefault($msg = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf   = $this->conf;
        $misc   = $this->misc;
        $lang   = $this->lang;
        $data   = $misc->getDatabaseAccessor();
        $action = $this->action;

        if (!isset($_REQUEST['query']) or empty($_REQUEST['query'])) {
            $_REQUEST['query'] = $_SESSION['sqlquery'];
        }

        $this->printHeader($lang['strexport']);
        $this->printBody();
        $this->printTrail(isset($_REQUEST['subject']) ? $_REQUEST['subject'] : 'database');
        $this->printTitle($lang['strexport']);
        if (isset($msg)) {
            $this->printMsg($msg);
        }

        echo '<form action="' . SUBFOLDER . "/src/views/dataexport.php\" method=\"post\">\n";
        echo "<table>\n";
        echo "<tr><th class=\"data\">{$lang['strformat']}:</th><td><select name=\"d_format\">\n";
        // COPY and SQL require a table
        if (isset($_REQUEST['table'])) {
            echo "<option value=\"copy\">COPY</option>\n";
            echo "<option value=\"sql\">SQL</option>\n";
        }
        echo "<option value=\"csv\">CSV</option>\n";
        echo "<option value=\"tab\">{$lang['strtabbed']}</option>\n";
        echo "<option value=\"html\">XHTML</option>\n";
        echo "<option value=\"xml\">XML</option>\n";
        echo '</select></td></tr>';
        echo "</table>\n";

        echo "<h3>{$lang['stroptions']}</h3>\n";
        echo "<p><input type=\"radio\" id=\"output1\" name=\"output\" value=\"show\" checked=\"checked\" /><label for=\"output1\">{$lang['strshow']}</label>\n";
        echo "<br/><input type=\"radio\" id=\"output2\" name=\"output\" value=\"download\" /><label for=\"output2\">{$lang['strdownload']}</label></p>\n";

        echo "<p><input type=\"hidden\" name=\"action\" value=\"export\" />\n";
        echo "<input type=\"hidden\" name=\"what\" value=\"dataonly\" />\n";
        if (isset($_REQUEST['table'])) {
            echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), "\" />\n";
        }
        echo '<input type="hidden" name="query" value="', htmlspecialchars(urlencode($_REQUEST['query'])), "\" />\n";
        if (isset($_REQUEST['search_path'])) {
            echo '<input type="hidden" name="search_path" value="', htmlspecialchars($_REQUEST['search_path']), "\" />\n";
        }
        echo $misc->form;
        echo "<input type=\"submit\" value=\"{$lang['strexport']}\" /></p>\n";
        echo "</form>\n";

        $this->printFooter();
    }
}


1		<?php
2
3		namespace PHPPgAdmin\Controller;
4
5		/**
6		* Base controller class
7		*/
8		class DataexportController extends BaseController
9		{
10		public $_name = 'DataexportController';
11		public $extensions = [
12		'sql' => 'sql',
13		'copy' => 'sql',
14		'csv' => 'csv',
15		'tab' => 'txt',
16		'html' => 'html',
17		'xml' => 'xml',
18		];
19
20		public function render()
		0 ignored issues – show Coding Style introduced 2017-10-08 18:01 UTC by Report Bug Copy Issue Report `render` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-10-08 18:01 UTC by Report Bug Copy Issue Report `render` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
21		{
22		$conf = $this->conf;
23		$misc = $this->misc;
24		$lang = $this->lang;
25		$data = $misc->getDatabaseAccessor();
26		$action = $this->action;
27
28		set_time_limit(0);
29
30		// if (!isset($_REQUEST['table']) && !isset($_REQUEST['query']))
31		// What must we do in this case? Maybe redirect to the homepage?
32
33		// If format is set, then perform the export
34		if (isset($_REQUEST['what'])) {
35		$this->prtrace("REQUEST['what']", $_REQUEST['what']);
36
37		// Include application functions
38		$this->setNoOutput(true);
39
40		switch ($_REQUEST['what']) {
41		case 'dataonly':
42		// Check to see if they have pg_dump set up and if they do, use that
43		// instead of custom dump code
44		if ($misc->isDumpEnabled() && ($_REQUEST['d_format'] == 'copy' \|\| $_REQUEST['d_format'] == 'sql')) {
45		$this->prtrace('DUMP ENABLED, d_format is', $_REQUEST['d_format']);
46		$dbexport_controller = new \PHPPgAdmin\Controller\DbexportController($this->getContainer());
47		return $dbexport_controller->render();
48		} else {
49		$this->prtrace('d_format is', $_REQUEST['d_format'], 'd_oids is', isset($_REQUEST['d_oids']));
50		$format = $_REQUEST['d_format'];
51		$oids = isset($_REQUEST['d_oids']);
52		}
53		break;
54		case 'structureonly':
55		// Check to see if they have pg_dump set up and if they do, use that
56		// instead of custom dump code
57		if ($misc->isDumpEnabled()) {
58		$dbexport_controller = new \PHPPgAdmin\Controller\DbexportController($this->getContainer());
59		return $dbexport_controller->render();
60		} else {
61		$clean = isset($_REQUEST['s_clean']);
62		}
63
64		break;
65		case 'structureanddata':
66		// Check to see if they have pg_dump set up and if they do, use that
67		// instead of custom dump code
68		if ($misc->isDumpEnabled()) {
69		$dbexport_controller = new \PHPPgAdmin\Controller\DbexportController($this->getContainer());
70		return $dbexport_controller->render();
71		} else {
72		$format = $_REQUEST['sd_format'];
73		$clean = isset($_REQUEST['sd_clean']);
74		$oids = isset($_REQUEST['sd_oids']);
75		}
76		break;
77		}
78
79		// Make it do a download, if necessary
80		if ($_REQUEST['output'] == 'download') {
81		// Set headers. MSIE is totally broken for SSL downloading, so
82		// we need to have it download in-place as plain text
83		if (strstr($_SERVER['HTTP_USER_AGENT'], 'MSIE') && isset($_SERVER['HTTPS'])) {
84		header('Content-Type: text/plain');
85		} else {
86		header('Content-Type: application/download');
87
88		if (isset($extensions[$format])) {
89		$ext = $extensions[$format];
90		} else {
91		$ext = 'txt';
92		}
93
94		header('Content-Disposition: attachment; filename=dump.' . $ext);
95		}
96		} else {
97		header('Content-Type: text/plain');
98		}
99
100		if (isset($_REQUEST['query'])) {
101		$_REQUEST['query'] = trim(urldecode($_REQUEST['query']));
102		}
103
104		// Set the schema search path
105	View Code Duplication	if (isset($_REQUEST['search_path'])) {
		0 ignored issues – show Duplication introduced 2017-09-30 13:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		$data->setSearchPath(array_map('trim', explode(',', $_REQUEST['search_path'])));
107		}
108
109		// Set up the dump transaction
110		$status = $data->beginDump();
111
112		// If the dump is not dataonly then dump the structure prefix
113		if ($_REQUEST['what'] != 'dataonly') {
114		echo $data->getTableDefPrefix($_REQUEST['table'], $clean);
115		}
116
117		// If the dump is not structureonly then dump the actual data
118		if ($_REQUEST['what'] != 'structureonly') {
119		// Get database encoding
120		$dbEncoding = $data->getDatabaseEncoding();
121
122		// Set fetch mode to NUM so that duplicate field names are properly returned
123		$data->conn->setFetchMode(ADODB_FETCH_NUM);
124
125		// Execute the query, if set, otherwise grab all rows from the table
126		if (isset($_REQUEST['table'])) {
127		$rs = $data->dumpRelation($_REQUEST['table'], $oids);
128		} else {
129		$rs = $data->conn->Execute($_REQUEST['query']);
130		}
131
132		if ($format == 'copy') {
133		$data->fieldClean($_REQUEST['table']);
134		echo "COPY \"{$_REQUEST['table']}\"";
135		if ($oids) {
136		echo ' WITH OIDS';
137		}
138
139		echo " FROM stdin;\n";
140		while (!$rs->EOF) {
141		$first = true;
142		while (list($k, $v) = each($rs->fields)) {
143		// Escape value
144		$v = $data->escapeBytea($v);
145
146		// We add an extra escaping slash onto octal encoded characters
147		$v = preg_replace('/\\\\([0-7]{3})/', '\\\\\1', $v);
148		if ($first) {
149		echo (is_null($v)) ? '\\N' : $v;
150		$first = false;
151		} else {
152		echo "\t", (is_null($v)) ? '\\N' : $v;
153		}
154		}
155		echo "\n";
156		$rs->moveNext();
157		}
158		echo "\\.\n";
159		} elseif ($format == 'html') {
160		echo "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\">\r\n";
161		echo "<html xmlns=\"http://www.w3.org/1999/xhtml\">\r\n";
162		echo "<head>\r\n";
163		echo "\t<title></title>\r\n";
164		echo "\t<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />\r\n";
165		echo "</head>\r\n";
166		echo "<body>\r\n";
167		echo "<table class=\"phppgadmin\">\r\n";
168		echo "\t<tr>\r\n";
169		if (!$rs->EOF) {
170		// Output header row
171		$j = 0;
172	View Code Duplication	foreach ($rs->fields as $k => $v) {
		0 ignored issues – show Duplication introduced 2017-09-30 13:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
173		$finfo = $rs->fetchField($j++);
174		if ($finfo->name == $data->id && !$oids) {
175		continue;
176		}
177
178		echo "\t\t<th>", $misc->printVal($finfo->name, true), "</th>\r\n";
179		}
180		}
181		echo "\t</tr>\r\n";
182		while (!$rs->EOF) {
183		echo "\t<tr>\r\n";
184		$j = 0;
185	View Code Duplication	foreach ($rs->fields as $k => $v) {
		0 ignored issues – show Duplication introduced 2017-09-30 13:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
186		$finfo = $rs->fetchField($j++);
187		if ($finfo->name == $data->id && !$oids) {
188		continue;
189		}
190
191		echo "\t\t<td>", $misc->printVal($v, true, $finfo->type), "</td>\r\n";
192		}
193		echo "\t</tr>\r\n";
194		$rs->moveNext();
195		}
196		echo "</table>\r\n";
197		echo "</body>\r\n";
198		echo "</html>\r\n";
199		} elseif ($format == 'xml') {
200		echo "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n";
201		echo "<data>\n";
202		if (!$rs->EOF) {
203		// Output header row
204		$j = 0;
205		echo "\t<header>\n";
206		foreach ($rs->fields as $k => $v) {
207		$finfo = $rs->fetchField($j++);
208		$name = htmlspecialchars($finfo->name);
209		$type = htmlspecialchars($finfo->type);
210		echo "\t\t<column name=\"{$name}\" type=\"{$type}\" />\n";
211		}
212		echo "\t</header>\n";
213		}
214		echo "\t<records>\n";
215		while (!$rs->EOF) {
216		$j = 0;
217		echo "\t\t<row>\n";
218		foreach ($rs->fields as $k => $v) {
219		$finfo = $rs->fetchField($j++);
220		$name = htmlspecialchars($finfo->name);
221		if (!is_null($v)) {
222		$v = htmlspecialchars($v);
223		}
224
225		echo "\t\t\t<column name=\"{$name}\"", (is_null($v) ? ' null="null"' : ''), ">{$v}</column>\n";
226		}
227		echo "\t\t</row>\n";
228		$rs->moveNext();
229		}
230		echo "\t</records>\n";
231		echo "</data>\n";
232		} elseif ($format == 'sql') {
233		$data->fieldClean($_REQUEST['table']);
234		while (!$rs->EOF) {
235		echo "INSERT INTO \"{$_REQUEST['table']}\" (";
236		$first = true;
237		$j = 0;
238		foreach ($rs->fields as $k => $v) {
239		$finfo = $rs->fetchField($j++);
240		$k = $finfo->name;
241		// SQL (INSERT) format cannot handle oids
242		// if ($k == $data->id) continue;
243		// Output field
244		$data->fieldClean($k);
245		if ($first) {
246		echo "\"{$k}\"";
247		} else {
248		echo ", \"{$k}\"";
249		}
250
251		if (!is_null($v)) {
252		// Output value
253		// addCSlashes converts all weird ASCII characters to octal representation,
254		// EXCEPT the 'special' ones like \r \n \t, etc.
255		$v = addCSlashes($v, "\0..\37\177..\377");
256		// We add an extra escaping slash onto octal encoded characters
257		$v = preg_replace('/\\\\([0-7]{3})/', '\\\1', $v);
258		// Finally, escape all apostrophes
259		$v = str_replace("'", "''", $v);
260		}
261	View Code Duplication	if ($first) {
		0 ignored issues – show Duplication introduced 2017-09-30 13:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
262		$values = (is_null($v) ? 'NULL' : "'{$v}'");
263		$first = false;
264		} else {
265		$values .= ', ' . ((is_null($v) ? 'NULL' : "'{$v}'"));
266		}
267		}
268		echo ") VALUES ({$values});\n";
269		$rs->moveNext();
270		}
271		} else {
272		switch ($format) {
273		case 'tab':
274		$sep = "\t";
275		break;
276		case 'csv':
277		default:
278		$sep = ',';
279		break;
280		}
281		if (!$rs->EOF) {
282		// Output header row
283		$first = true;
284		foreach ($rs->fields as $k => $v) {
285		$finfo = $rs->fetchField($k);
286		$v = $finfo->name;
287		if (!is_null($v)) {
288		$v = str_replace('"', '""', $v);
289		}
290
291		if ($first) {
292		echo "\"{$v}\"";
293		$first = false;
294		} else {
295		echo "{$sep}\"{$v}\"";
296		}
297		}
298		echo "\r\n";
299		}
300		while (!$rs->EOF) {
301		$first = true;
302		foreach ($rs->fields as $k => $v) {
303		if (!is_null($v)) {
304		$v = str_replace('"', '""', $v);
305		}
306
307	View Code Duplication	if ($first) {
		0 ignored issues – show Duplication introduced 2017-09-30 13:55 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
308		echo (is_null($v)) ? '"\\N"' : "\"{$v}\"";
309		$first = false;
310		} else {
311		echo is_null($v) ? "{$sep}\"\\N\"" : "{$sep}\"{$v}\"";
312		}
313		}
314		echo "\r\n";
315		$rs->moveNext();
316		}
317		}
318		}
319
320		// If the dump is not dataonly then dump the structure suffix
321		if ($_REQUEST['what'] != 'dataonly') {
322		// Set fetch mode back to ASSOC for the table suffix to work
323		$data->conn->setFetchMode(ADODB_FETCH_ASSOC);
324		echo $data->getTableDefSuffix($_REQUEST['table']);
325		}
326
327		// Finish the dump transaction
328		$status = $data->endDump();
329		} else {
330		return $this->doDefault();
331		}
332		}
333
334		public function doDefault($msg = '')
		0 ignored issues – show Coding Style introduced 2017-10-08 18:01 UTC by Report Bug Copy Issue Report `doDefault` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-10-08 18:01 UTC by Report Bug Copy Issue Report `doDefault` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
335		{
336		$conf = $this->conf;
337		$misc = $this->misc;
338		$lang = $this->lang;
339		$data = $misc->getDatabaseAccessor();
340		$action = $this->action;
341
342		if (!isset($_REQUEST['query']) or empty($_REQUEST['query'])) {
343		$_REQUEST['query'] = $_SESSION['sqlquery'];
344		}
345
346		$this->printHeader($lang['strexport']);
347		$this->printBody();
348		$this->printTrail(isset($_REQUEST['subject']) ? $_REQUEST['subject'] : 'database');
349		$this->printTitle($lang['strexport']);
350		if (isset($msg)) {
351		$this->printMsg($msg);
352		}
353
354		echo '<form action="' . SUBFOLDER . "/src/views/dataexport.php\" method=\"post\">\n";
355		echo "<table>\n";
356		echo "<tr><th class=\"data\">{$lang['strformat']}:</th><td><select name=\"d_format\">\n";
357		// COPY and SQL require a table
358		if (isset($_REQUEST['table'])) {
359		echo "<option value=\"copy\">COPY</option>\n";
360		echo "<option value=\"sql\">SQL</option>\n";
361		}
362		echo "<option value=\"csv\">CSV</option>\n";
363		echo "<option value=\"tab\">{$lang['strtabbed']}</option>\n";
364		echo "<option value=\"html\">XHTML</option>\n";
365		echo "<option value=\"xml\">XML</option>\n";
366		echo '</select></td></tr>';
367		echo "</table>\n";
368
369		echo "<h3>{$lang['stroptions']}</h3>\n";
370		echo "<p><input type=\"radio\" id=\"output1\" name=\"output\" value=\"show\" checked=\"checked\" /><label for=\"output1\">{$lang['strshow']}</label>\n";
371		echo "<br/><input type=\"radio\" id=\"output2\" name=\"output\" value=\"download\" /><label for=\"output2\">{$lang['strdownload']}</label></p>\n";
372
373		echo "<p><input type=\"hidden\" name=\"action\" value=\"export\" />\n";
374		echo "<input type=\"hidden\" name=\"what\" value=\"dataonly\" />\n";
375		if (isset($_REQUEST['table'])) {
376		echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), "\" />\n";
377		}
378		echo '<input type="hidden" name="query" value="', htmlspecialchars(urlencode($_REQUEST['query'])), "\" />\n";
379		if (isset($_REQUEST['search_path'])) {
380		echo '<input type="hidden" name="search_path" value="', htmlspecialchars($_REQUEST['search_path']), "\" />\n";
381		}
382		echo $misc->form;
383		echo "<input type=\"submit\" value=\"{$lang['strexport']}\" /></p>\n";
384		echo "</form>\n";
385
386		$this->printFooter();
387		}
388		}
389

HuasoFoundries / phpPgAdmin6

Branch — develop (db5506)

DataexportController::doDefault() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like