ConstraintsController::doDrop() - Code Metrics - Inspection of "scrutinizer build badge" - HuasoFoundries/phpPgAdmin6 - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed
Branch — develop (db5506)

by Felipe
created 2017-10-08 18:16 UTC
ConstraintsController::doDrop() B

↳ Parent: ConstraintsController
Complexity

Conditions	3
Paths	3
Size

Total Lines	30
Code Lines	25
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	3
eloc	25
nc	3
nop	1
dl	0
loc	30
rs	8.8571
c	0
b	0
f	0
<?php

namespace PHPPgAdmin\Controller;

use \PHPPgAdmin\Decorators\Decorator;

/**
 * Base controller class
 */
class ConstraintsController extends BaseController
{
    public $_name = 'ConstraintsController';

    public function render()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf = $this->conf;

        $misc = $this->misc;

        $lang = $this->lang;

        $action = $this->action;
        if ($action == 'tree') {
            return $this->doTree();
            return $this->/** @scrutinizer ignore-call */ doTree();
        }

        $this->printHeader($lang['strtables'] . ' - ' . $_REQUEST['table'] . ' - ' . $lang['strconstraints'],
            '<script src="' . SUBFOLDER . '/js/indexes.js" type="text/javascript"></script>', true, 'header_select2.twig');

        if ($action == 'add_unique_key' || $action == 'save_add_unique_key'
            || $action == 'add_primary_key' || $action == 'save_add_primary_key'
            || $action == 'add_foreign_key' || $action == 'save_add_foreign_key') {
            echo '<body onload="init();">';
        } else {
            $this->printBody();
        }

        switch ($action) {
            case 'add_foreign_key':
                $this->addForeignKey(1);
                break;
            case 'save_add_foreign_key':
                if (isset($_POST['cancel'])) {
                    $this->doDefault();
                } else {
                    $this->addForeignKey($_REQUEST['stage']);
                }

                break;
            case 'add_unique_key':
                $this->addPrimaryOrUniqueKey('unique', true);
                break;
            case 'save_add_unique_key':
                if (isset($_POST['cancel'])) {
                    $this->doDefault();
                } else {
                    $this->addPrimaryOrUniqueKey('unique', false);
                }

                break;
            case 'add_primary_key':
                $this->addPrimaryOrUniqueKey('primary', true);
                break;
            case 'save_add_primary_key':
                if (isset($_POST['cancel'])) {
                    $this->doDefault();
                } else {
                    $this->addPrimaryOrUniqueKey('primary', false);
                }

                break;
            case 'add_check':
                $this->addCheck(true);
                break;
            case 'save_add_check':
                if (isset($_POST['cancel'])) {
                    $this->doDefault();
                } else {
                    $this->addCheck(false);
                }

                break;
            case 'save_create':
                $this->doSaveCreate();
                $this->/** @scrutinizer ignore-call */ doSaveCreate();
                break;
            case 'create':
                $this->doCreate();
                $this->/** @scrutinizer ignore-call */ doCreate();
                break;
            case 'drop':
                if (isset($_POST['drop'])) {
                    $this->doDrop(false);
                } else {
                    $this->doDefault();
                }

                break;
            case 'confirm_drop':
                $this->doDrop(true);
                break;
            default:
                $this->doDefault();
                break;
        }

        $this->printFooter();
    }

    /**
     * List all the constraints on the table
     */
    public function doDefault($msg = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf = $this->conf;
        $misc = $this->misc;
        $lang = $this->lang;
        $data = $misc->getDatabaseAccessor();

        $cnPre = function (&$rowdata) use ($data) {
            if (is_null($rowdata->fields['consrc'])) {
                $atts                           = $data->getAttributeNames($_REQUEST['table'], explode(' ', $rowdata->fields['indkey']));
                $rowdata->fields['+definition'] = ($rowdata->fields['contype'] == 'u' ? 'UNIQUE (' : 'PRIMARY KEY (') . join(',', $atts) . ')';
            } else {
                $rowdata->fields['+definition'] = $rowdata->fields['consrc'];
            }
        };

        $this->printTrail('table');
        $this->printTabs('table', 'constraints');
        $this->printMsg($msg);

        $constraints = $data->getConstraints($_REQUEST['table']);

        $columns = [
            'constraint' => [
                'title' => $lang['strname'],
                'field' => Decorator::field('conname'),
            ],
            'definition' => [
                'title' => $lang['strdefinition'],
                'field' => Decorator::field('+definition'),
                'type'  => 'pre',
            ],
            'actions'    => [
                'title' => $lang['stractions'],
            ],
            'comment'    => [
                'title' => $lang['strcomment'],
                'field' => Decorator::field('constcomment'),
            ],
        ];

        $actions = [
            'drop' => [
                'content' => $lang['strdrop'],
                'attr'    => [
                    'href' => [
                        'url'     => 'constraints.php',
                        'urlvars' => [
                            'action'     => 'confirm_drop',
                            'table'      => $_REQUEST['table'],
                            'constraint' => Decorator::field('conname'),
                            'type'       => Decorator::field('contype'),
                        ],
                    ],
                ],
            ],
        ];

        echo $this->printTable($constraints, $columns, $actions, 'constraints-constraints', $lang['strnoconstraints'], $cnPre);

        $navlinks = [
            'addcheck' => [
                'attr'    => [
                    'href' => [
                        'url'     => 'constraints.php',
                        'urlvars' => [
                            'action'   => 'add_check',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                            'schema'   => $_REQUEST['schema'],
                            'table'    => $_REQUEST['table'],
                        ],
                    ],
                ],
                'content' => $lang['straddcheck'],
            ],
            'adduniq'  => [
                'attr'    => [
                    'href' => [
                        'url'     => 'constraints.php',
                        'urlvars' => [
                            'action'   => 'add_unique_key',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                            'schema'   => $_REQUEST['schema'],
                            'table'    => $_REQUEST['table'],
                        ],
                    ],
                ],
                'content' => $lang['stradduniq'],
            ],
            'addpk'    => [
                'attr'    => [
                    'href' => [
                        'url'     => 'constraints.php',
                        'urlvars' => [
                            'action'   => 'add_primary_key',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                            'schema'   => $_REQUEST['schema'],
                            'table'    => $_REQUEST['table'],
                        ],
                    ],
                ],
                'content' => $lang['straddpk'],
            ],
            'addfk'    => [
                'attr'    => [
                    'href' => [
                        'url'     => 'constraints.php',
                        'urlvars' => [
                            'action'   => 'add_foreign_key',
                            'server'   => $_REQUEST['server'],
                            'database' => $_REQUEST['database'],
                            'schema'   => $_REQUEST['schema'],
                            'table'    => $_REQUEST['table'],
                        ],
                    ],
                ],
                'content' => $lang['straddfk'],
            ],
        ];
        $this->printNavLinks($navlinks, 'constraints-constraints', get_defined_vars());
    }

    /**
     * Confirm and then actually add a FOREIGN KEY constraint
     */
    public function addForeignKey($stage, $msg = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf = $this->conf;

        $misc = $this->misc;
        $lang = $this->lang;
        $data = $misc->getDatabaseAccessor();

        if (!isset($_POST['name'])) {
            $_POST['name'] = '';
        }

        if (!isset($_POST['target'])) {
            $_POST['target'] = '';
        }

        switch ($stage) {
            case 2:
                // Check that they've given at least one source column
                if (!isset($_REQUEST['SourceColumnList']) && (!isset($_POST['IndexColumnList']) || !is_array($_POST['IndexColumnList']) || sizeof($_POST['IndexColumnList']) == 0)) {
                    $this->addForeignKey(1, $lang['strfkneedscols']);
                } else {
                    // Copy the IndexColumnList variable from stage 1
                    if (isset($_REQUEST['IndexColumnList']) && !isset($_REQUEST['SourceColumnList'])) {
                        $_REQUEST['SourceColumnList'] = serialize($_REQUEST['IndexColumnList']);
                    }

                    // Initialise variables
                    if (!isset($_POST['upd_action'])) {
                        $_POST['upd_action'] = null;
                    }

                    if (!isset($_POST['del_action'])) {
                        $_POST['del_action'] = null;
                    }

                    if (!isset($_POST['match'])) {
                        $_POST['match'] = null;
                    }

                    if (!isset($_POST['deferrable'])) {
                        $_POST['deferrable'] = null;
                    }

                    if (!isset($_POST['initially'])) {
                        $_POST['initially'] = null;
                    }

                    $_REQUEST['target'] = unserialize($_REQUEST['target']);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}

                    $this->printTrail('table');
                    $this->printTitle($lang['straddfk'], 'pg.constraint.foreign_key');
                    $this->printMsg($msg);

                    // Unserialize target and fetch appropriate table. This is a bit messy
                    // because the table could be in another schema.
                    $data->setSchema($_REQUEST['target']['schemaname']);
                    $attrs = $data->getTableAttributes($_REQUEST['target']['tablename']);
                    $data->setSchema($_REQUEST['schema']);

                    $selColumns = new \PHPPgAdmin\XHtml\XHtmlSelect('TableColumnList', true, 10);
                    $selColumns->set_style('width: 15em;');

                    if ($attrs->recordCount() > 0) {

                        while (!$attrs->EOF) {
                            $selColumns->add(new \PHPPgAdmin\XHtml\XHtmlOption($attrs->fields['attname']));
                            $attrs->moveNext();
                        }
                    }

                    $selIndex = new \PHPPgAdmin\XHtml\XHtmlSelect('IndexColumnList[]', true, 10);
                    $selIndex->set_style('width: 15em;');
                    $selIndex->set_attribute('id', 'IndexColumnList');
                    $buttonAdd = new \PHPPgAdmin\XHtml\XHtmlButton('add', '>>');
                    $buttonAdd->set_attribute('onclick', 'buttonPressed(this);');
                    $buttonAdd->set_attribute('type', 'button');

                    $buttonRemove = new \PHPPgAdmin\XHtml\XHtmlButton('remove', '<<');
                    $buttonRemove->set_attribute('onclick', 'buttonPressed(this);');
                    $buttonRemove->set_attribute('type', 'button');

                    echo "<form onsubmit=\"doSelectAll();\" name=\"formIndex\" action=\"constraints.php\" method=\"post\">\n";

                    echo "<table>\n";
                    echo "<tr><th class=\"data\" colspan=\"3\">{$lang['strfktarget']}</th></tr>";
                    echo "<tr><th class=\"data\">{$lang['strtablecolumnlist']}</th><th class=\"data\">&nbsp;</th><th class=data>{$lang['strfkcolumnlist']}</th></tr>\n";
                    echo '<tr><td class="data1">' . $selColumns->fetch() . "</td>\n";
                    echo '<td class="data1" style="text-align: center">' . $buttonRemove->fetch() . $buttonAdd->fetch() . '</td>';
                    echo '<td class="data1">' . $selIndex->fetch() . "</td></tr>\n";
                    echo "<tr><th class=\"data\" colspan=\"3\">{$lang['stractions']}</th></tr>";
                    echo '<tr>';
                    echo "<td class=\"data1\" colspan=\"3\">\n";
                    // ON SELECT actions
                    echo "{$lang['stronupdate']} <select name=\"upd_action\">";
                    foreach ($data->fkactions as $v) {
                        echo "<option value=\"{$v}\"", ($_POST['upd_action'] == $v) ? ' selected="selected"' : '', ">{$v}</option>\n";
                    }

                    echo "</select><br />\n";

                    // ON DELETE actions
                    echo "{$lang['strondelete']} <select name=\"del_action\">";
                    foreach ($data->fkactions as $v) {
                        echo "<option value=\"{$v}\"", ($_POST['del_action'] == $v) ? ' selected="selected"' : '', ">{$v}</option>\n";
                    }

                    echo "</select><br />\n";

                    // MATCH options
                    echo '<select name="match">';
                    foreach ($data->fkmatches as $v) {
                        echo "<option value=\"{$v}\"", ($_POST['match'] == $v) ? ' selected="selected"' : '', ">{$v}</option>\n";
                    }

                    echo "</select><br />\n";

                    // DEFERRABLE options
                    echo '<select name="deferrable">';
                    foreach ($data->fkdeferrable as $v) {
                        echo "<option value=\"{$v}\"", ($_POST['deferrable'] == $v) ? ' selected="selected"' : '', ">{$v}</option>\n";
                    }

                    echo "</select><br />\n";

                    // INITIALLY options
                    echo '<select name="initially">';
                    foreach ($data->fkinitial as $v) {
                        echo "<option value=\"{$v}\"", ($_POST['initially'] == $v) ? ' selected="selected"' : '', ">{$v}</option>\n";
                    }

                    echo "</select>\n";
                    echo "</td></tr>\n";
                    echo "</table>\n";

                    echo "<p><input type=\"hidden\" name=\"action\" value=\"save_add_foreign_key\" />\n";
                    echo $misc->form;
                    echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), "\" />\n";
                    echo '<input type="hidden" name="name" value="', htmlspecialchars($_REQUEST['name']), "\" />\n";
                    echo '<input type="hidden" name="target" value="', htmlspecialchars(serialize($_REQUEST['target'])), "\" />\n";
                    echo '<input type="hidden" name="SourceColumnList" value="', htmlspecialchars($_REQUEST['SourceColumnList']), "\" />\n";
                    echo "<input type=\"hidden\" name=\"stage\" value=\"3\" />\n";
                    echo "<input type=\"submit\" value=\"{$lang['stradd']}\" />\n";
                    echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" /></p>\n";
                    echo "</form>\n";
                }
                break;
            case 3:
                // Unserialize target
                $_POST['target'] = unserialize($_POST['target']);

                // Check that they've given at least one column
                if (isset($_POST['SourceColumnList'])) {
                    $temp = unserialize($_POST['SourceColumnList']);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                }

                if (!isset($_POST['IndexColumnList']) || !is_array($_POST['IndexColumnList'])
                    || sizeof($_POST['IndexColumnList']) == 0 || !isset($temp)
                    || !is_array($temp) || sizeof($temp) == 0) {
                    $this->addForeignKey(2, $lang['strfkneedscols']);
                } else {
                    $status = $data->addForeignKey($_POST['table'], $_POST['target']['schemaname'], $_POST['target']['tablename'],
                        unserialize($_POST['SourceColumnList']), $_POST['IndexColumnList'], $_POST['upd_action'], $_POST['del_action'],
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                        $_POST['match'], $_POST['deferrable'], $_POST['initially'], $_POST['name']);
                    if ($status == 0) {
                        $this->doDefault($lang['strfkadded']);
                    } else {
                        $this->addForeignKey(2, $lang['strfkaddedbad']);
                    }
                }
                break;
            default:
                $this->printTrail('table');
                $this->printTitle($lang['straddfk'], 'pg.constraint.foreign_key');
                $this->printMsg($msg);

                $attrs  = $data->getTableAttributes($_REQUEST['table']);
                $tables = $data->getTables(true);

                $selColumns = new \PHPPgAdmin\XHtml\XHtmlSelect('TableColumnList', true, 10);
                $selColumns->set_style('width: 15em;');

                if ($attrs->recordCount() > 0) {

                    while (!$attrs->EOF) {
                        $selColumns->add(new \PHPPgAdmin\XHtml\XHtmlOption($attrs->fields['attname']));
                        $attrs->moveNext();
                    }
                }

                $selIndex = new \PHPPgAdmin\XHtml\XHtmlSelect('IndexColumnList[]', true, 10);
                $selIndex->set_style('width: 15em;');
                $selIndex->set_attribute('id', 'IndexColumnList');
                $buttonAdd = new \PHPPgAdmin\XHtml\XHtmlButton('add', '>>');
                $buttonAdd->set_attribute('onclick', 'buttonPressed(this);');
                $buttonAdd->set_attribute('type', 'button');

                $buttonRemove = new \PHPPgAdmin\XHtml\XHtmlButton('remove', '<<');
                $buttonRemove->set_attribute('onclick', 'buttonPressed(this);');
                $buttonRemove->set_attribute('type', 'button');

                echo "<form onsubmit=\"doSelectAll();\" name=\"formIndex\" action=\"constraints.php\" method=\"post\">\n";

                echo "<table>\n";
                echo "<tr><th class=\"data\" colspan=\"3\">{$lang['strname']}</th></tr>\n";
                echo "<tr><td class=\"data1\" colspan=\"3\"><input type=\"text\" name=\"name\" size=\"32\" maxlength=\"{$data->_maxNameLen}\" /></td></tr>\n";
                echo "<tr><th class=\"data\">{$lang['strtablecolumnlist']}</th><th class=\"data\">&nbsp;</th><th class=\"data required\">{$lang['strfkcolumnlist']}</th></tr>\n";
                echo '<tr><td class="data1">' . $selColumns->fetch() . "</td>\n";
                echo '<td class="data1" style="text-align: center">' . $buttonRemove->fetch() . $buttonAdd->fetch() . "</td>\n";
                echo '<td class=data1>' . $selIndex->fetch() . "</td></tr>\n";
                echo "<tr><th class=\"data\" colspan=\"3\">{$lang['strfktarget']}</th></tr>";
                echo '<tr>';
                echo '<td class="data1" colspan="3"><select class="select2" name="target">';
                while (!$tables->EOF) {
                    $key = ['schemaname' => $tables->fields['nspname'], 'tablename' => $tables->fields['relname']];
                    $key = serialize($key);
                    echo '<option value="', htmlspecialchars($key), '">';
                    if ($tables->fields['nspname'] != $_REQUEST['schema']) {
                        echo htmlspecialchars($tables->fields['nspname']), '.';
                    }
                    echo htmlspecialchars($tables->fields['relname']), "</option>\n";
                    $tables->moveNext();
                }
                echo "</select>\n";
                echo '</td></tr>';
                echo "</table>\n";

                echo "<p><input type=\"hidden\" name=\"action\" value=\"save_add_foreign_key\" />\n";
                echo $misc->form;
                echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), "\" />\n";
                echo "<input type=\"hidden\" name=\"stage\" value=\"2\" />\n";
                echo "<input type=\"submit\" value=\"{$lang['stradd']}\" />\n";
                echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" /></p>\n";
                echo "</form>\n";
                //echo "<script>jQuery('select[name=\"target\"]').select2()</script>";
                break;
        }
    }

    /**
     * Confirm and then actually add a PRIMARY KEY or UNIQUE constraint
     */
    public function addPrimaryOrUniqueKey($type, $confirm, $msg = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf = $this->conf;

        $misc = $this->misc;
        $lang = $this->lang;
        $data = $misc->getDatabaseAccessor();

        if (!isset($_POST['name'])) {
            $_POST['name'] = '';
        }

        if ($confirm) {
            if (!isset($_POST['name'])) {
                $_POST['name'] = '';
            }

            if (!isset($_POST['tablespace'])) {
                $_POST['tablespace'] = '';
            }

            $this->printTrail('table');

            switch ($type) {
                case 'primary':
                    $this->printTitle($lang['straddpk'], 'pg.constraint.primary_key');
                    break;
                case 'unique':
                    $this->printTitle($lang['stradduniq'], 'pg.constraint.unique_key');
                    break;
                default:
                    $this->doDefault($lang['strinvalidparam']);
                    return;
            }

            $this->printMsg($msg);

            $attrs = $data->getTableAttributes($_REQUEST['table']);
            // Fetch all tablespaces from the database
            if ($data->hasTablespaces()) {
                $tablespaces = $data->getTablespaces();
            }

            $selColumns = new \PHPPgAdmin\XHtml\XHtmlSelect('TableColumnList', true, 10);
            $selColumns->set_style('width: 15em;');

            if ($attrs->recordCount() > 0) {

                while (!$attrs->EOF) {
                    $new_option = new \PHPPgAdmin\XHtml\XHtmlOption($attrs->fields['attname']);
                    $selColumns->add($new_option);
                    $attrs->moveNext();
                }
            }

            $selIndex = new \PHPPgAdmin\XHtml\XHtmlSelect('IndexColumnList[]', true, 10);
            $selIndex->set_style('width: 15em;');
            $selIndex->set_attribute('id', 'IndexColumnList');
            $buttonAdd = new \PHPPgAdmin\XHtml\XHtmlButton('add', '>>');
            $buttonAdd->set_attribute('onclick', 'buttonPressed(this);');
            $buttonAdd->set_attribute('type', 'button');

            $buttonRemove = new \PHPPgAdmin\XHtml\XHtmlButton('remove', '<<');
            $buttonRemove->set_attribute('onclick', 'buttonPressed(this);');
            $buttonRemove->set_attribute('type', 'button');

            echo "<form onsubmit=\"doSelectAll();\" name=\"formIndex\" action=\"constraints.php\" method=\"post\">\n";

            echo "<table>\n";
            echo "<tr><th class=\"data\" colspan=\"3\">{$lang['strname']}</th></tr>";
            echo '<tr>';
            echo '<td class="data1" colspan="3"><input type="text" name="name" value="', htmlspecialchars($_POST['name']),
                "\" size=\"32\" maxlength=\"{$data->_maxNameLen}\" /></td></tr>";
            echo "<tr><th class=\"data\">{$lang['strtablecolumnlist']}</th><th class=\"data\">&nbsp;</th><th class=\"data required\">{$lang['strindexcolumnlist']}</th></tr>\n";
            echo '<tr><td class="data1">' . $selColumns->fetch() . "</td>\n";
            echo '<td class="data1" style="text-align: center">' . $buttonRemove->fetch() . $buttonAdd->fetch() . '</td>';
            echo '<td class=data1>' . $selIndex->fetch() . "</td></tr>\n";

            // Tablespace (if there are any)
            if ($data->hasTablespaces() && $tablespaces->recordCount() > 0) {

                echo "<tr><th class=\"data\" colspan=\"3\">{$lang['strtablespace']}</th></tr>";
                echo "<tr><td class=\"data1\" colspan=\"3\"><select name=\"tablespace\">\n";
                // Always offer the default (empty) option
                echo "\t\t\t\t<option value=\"\"",
                ($_POST['tablespace'] == '') ? ' selected="selected"' : '', "></option>\n";
                // Display all other tablespaces
                while (!$tablespaces->EOF) {
                    $spcname = htmlspecialchars($tablespaces->fields['spcname']);
                    echo "\t\t\t\t<option value=\"{$spcname}\"",
                    ($spcname == $_POST['tablespace']) ? ' selected="selected"' : '', ">{$spcname}</option>\n";
                    $tablespaces->moveNext();
                }
                echo "</select></td></tr>\n";
            }

            echo "</table>\n";

            echo "<p><input type=\"hidden\" name=\"action\" value=\"save_add_primary_key\" />\n";
            echo $misc->form;
            echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), "\" />\n";
            echo '<input type="hidden" name="type" value="', htmlspecialchars($type), "\" />\n";
            echo "<input type=\"submit\" value=\"{$lang['stradd']}\" />\n";
            echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" /></p>\n";
            echo "</form>\n";
        } else {
            // Default tablespace to empty if it isn't set
            if (!isset($_POST['tablespace'])) {
                $_POST['tablespace'] = '';
            }

            if ($_POST['type'] == 'primary') {
                // Check that they've given at least one column
                if (!isset($_POST['IndexColumnList']) || !is_array($_POST['IndexColumnList'])

                    || sizeof($_POST['IndexColumnList']) == 0) {
                    $this->addPrimaryOrUniqueKey($_POST['type'], true, $lang['strpkneedscols']);
                } else {
                    $status = $data->addPrimaryKey($_POST['table'], $_POST['IndexColumnList'], $_POST['name'], $_POST['tablespace']);
                    if ($status == 0) {
                        $this->doDefault($lang['strpkadded']);
                    } else {
                        $this->addPrimaryOrUniqueKey($_POST['type'], true, $lang['strpkaddedbad']);
                    }
                }
            } elseif ($_POST['type'] == 'unique') {

                // Check that they've given at least one column
                if (!isset($_POST['IndexColumnList']) || !is_array($_POST['IndexColumnList'])
                    || sizeof($_POST['IndexColumnList']) == 0) {
                    $this->addPrimaryOrUniqueKey($_POST['type'], true, $lang['struniqneedscols']);
                } else {
                    $status = $data->addUniqueKey($_POST['table'], $_POST['IndexColumnList'], $_POST['name'], $_POST['tablespace']);
                    if ($status == 0) {
                        $this->doDefault($lang['struniqadded']);
                    } else {
                        $this->addPrimaryOrUniqueKey($_POST['type'], true, $lang['struniqaddedbad']);
                    }
                }
            } else {
                $this->doDefault($lang['strinvalidparam']);
            }
        }
    }

    /**
     * Confirm and then actually add a CHECK constraint
     */
    public function addCheck($confirm, $msg = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf = $this->conf;

        $misc = $this->misc;
        $lang = $this->lang;
        $data = $misc->getDatabaseAccessor();

        if (!isset($_POST['name'])) {
            $_POST['name'] = '';
        }

        if (!isset($_POST['definition'])) {
            $_POST['definition'] = '';
        }

        if ($confirm) {
            $this->printTrail('table');
            $this->printTitle($lang['straddcheck'], 'pg.constraint.check');
            $this->printMsg($msg);

            echo '<form action="' . SUBFOLDER . "/src/views/constraints.php\" method=\"post\">\n";
            echo "<table>\n";
            echo "<tr><th class=\"data\">{$lang['strname']}</th>\n";
            echo "<th class=\"data required\">{$lang['strdefinition']}</th></tr>\n";

            echo "<tr><td class=\"data1\"><input name=\"name\" size=\"24\" maxlength=\"{$data->_maxNameLen}\" value=\"",
            htmlspecialchars($_POST['name']), "\" /></td>\n";

            echo '<td class="data1">(<input name="definition" size="64" value="',
            htmlspecialchars($_POST['definition']), "\" />)</td></tr>\n";
            echo "</table>\n";

            echo "<input type=\"hidden\" name=\"action\" value=\"save_add_check\" />\n";
            echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), "\" />\n";
            echo $misc->form;
            echo "<p><input type=\"submit\" name=\"ok\" value=\"{$lang['stradd']}\" />\n";
            echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" /></p>\n";
            echo "</form>\n";
        } else {
            if (trim($_POST['definition']) == '') {
                $this->addCheck(true, $lang['strcheckneedsdefinition']);
            } else {
                $status = $data->addCheckConstraint($_POST['table'],
                    $_POST['definition'], $_POST['name']);
                if ($status == 0) {
                    $this->doDefault($lang['strcheckadded']);
                } else {
                    $this->addCheck(true, $lang['strcheckaddedbad']);
                }
            }
        }
    }

    /**
     * Show confirmation of drop and perform actual drop
     */
    public function doDrop($confirm)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $conf = $this->conf;

        $misc = $this->misc;
        $lang = $this->lang;
        $data = $misc->getDatabaseAccessor();

        if ($confirm) {
            $this->printTrail('constraint');
            $this->printTitle($lang['strdrop'], 'pg.constraint.drop');

            echo '<p>', sprintf($lang['strconfdropconstraint'], $misc->printVal($_REQUEST['constraint']),
                $misc->printVal($_REQUEST['table'])), "</p>\n";

            echo '<form action="' . SUBFOLDER . "/src/views/constraints.php\" method=\"post\">\n";
            echo "<input type=\"hidden\" name=\"action\" value=\"drop\" />\n";
            echo '<input type="hidden" name="table" value="', htmlspecialchars($_REQUEST['table']), "\" />\n";
            echo '<input type="hidden" name="constraint" value="', htmlspecialchars($_REQUEST['constraint']), "\" />\n";
            echo '<input type="hidden" name="type" value="', htmlspecialchars($_REQUEST['type']), "\" />\n";
            echo $misc->form;
            echo "<p><input type=\"checkbox\" id=\"cascade\" name=\"cascade\" /> <label for=\"cascade\">{$lang['strcascade']}</label></p>\n";
            echo "<input type=\"submit\" name=\"drop\" value=\"{$lang['strdrop']}\" />\n";
            echo "<input type=\"submit\" name=\"cancel\" value=\"{$lang['strcancel']}\" />\n";
            echo "</form>\n";
        } else {
            $status = $data->dropConstraint($_POST['constraint'], $_POST['table'], $_POST['type'], isset($_POST['cascade']));
            if ($status == 0) {
                $this->doDefault($lang['strconstraintdropped']);
            } else {
                $this->doDefault($lang['strconstraintdroppedbad']);
            }
        }
    }
}

Branch — develop (db5506)

ConstraintsController::doDrop() B

Complexity

Size

Duplication

Importance

1 path for user data to reach this point

Preventing Object Injection Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Object Injection Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Object Injection Attacks

General Strategies to prevent injection

HuasoFoundries / phpPgAdmin6

Branch — develop (db5506)

ConstraintsController::doDrop() B

Complexity

Size

Duplication

Importance

1 path for user data to reach this point

Preventing Object Injection Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Object Injection Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Object Injection Attacks

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like
