PHPPgAdmin\Controller\GroupsController::doProperties()

Complexity

Conditions	4
Paths	4

Size

Total Lines	71
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function doProperties($msg = ''): void
    {
        $data = $this->misc->getDatabaseAccessor();

        $this->coalesceArr($_POST, 'user', '');

        $this->printTrail('group');
        $this->printTitle($this->lang['strproperties'], 'pg.group');
        $this->printMsg($msg);

        $groupdata = $data->getGroup($_REQUEST['group']);
        $users = $data->getUsers();

        if (0 < $groupdata->recordCount()) {
            $columns = [
                'members' => [
                    'title' => $this->lang['strmembers'],
                    'field' => Decorator::field('usename'),
                ],
                'actions' => [
                    'title' => $this->lang['stractions'],
                ],
            ];

            $actions = [
                'drop' => [
                    'content' => $this->lang['strdrop'],
                    'attr' => [
                        'href' => [
                            'url' => 'groups',
                            'urlvars' => [
                                'action' => 'confirm_drop_member',
                                'group' => $_REQUEST['group'],
                                'user' => Decorator::field('usename'),
                            ],
                        ],
                    ],
                ],
            ];

            echo $this->printTable($groupdata, $columns, $actions, 'groups-members', $this->lang['strnousers']);

It seems like $groupdata can also be of type integer; however, parameter $tabledata of PHPPgAdmin\Controller\BaseController::printTable() does only seem to accept ADORecordSet|PHPPgAdmin\ArrayRecordSet, maybe add an additional type check?

        }

        // Display form for adding a user to the group
        echo '<form action="' . \containerInstance()->subFolder . '/src/views/groups" method="post">' . \PHP_EOL;
        echo '<select name="user">';

        while (!$users->EOF) {
            $uname = $this->misc->printVal($users->fields['usename']);
            echo "<option value=\"{$uname}\"",
            ($uname === $_POST['user']) ? ' selected="selected"' : '', ">{$uname}</option>" . \PHP_EOL;
            $users->moveNext();
        }
        echo '</select>' . \PHP_EOL;
        echo "<input type=\"submit\" value=\"{$this->lang['straddmember']}\" />" . \PHP_EOL;
        echo $this->view->form;
        echo '<input type="hidden" name="group" value="', \htmlspecialchars($_REQUEST['group']), '" />' . \PHP_EOL;
        echo '<input type="hidden" name="action" value="add_member" />' . \PHP_EOL;
        echo '</form>' . \PHP_EOL;

        $this->printNavLinks(['showall' => [
            'attr' => [
                'href' => [
                    'url' => 'groups',
                    'urlvars' => [
                        'server' => $_REQUEST['server'],
                    ],
                ],
            ],
            'content' => $this->lang['strshowallgroups'],
        ]], 'groups-properties', \get_defined_vars());
    }