HuasoFoundries / jpgraph

src/util/JpGraphErrObject.php

<?php

/**
 * JPGraph v4.0.3
 */

namespace Amenadiel\JpGraph\Util;

//
// First of all set up a default error handler
//

/**
 * The default trivial text error handler.
 */
class JpGraphErrObject
{
    protected $iTitle = 'JpGraph error: ';
    protected $iDest  = false;

    public function __construct()
    {
        // Empty. Reserved for future use
    }

    public function SetTitle($aTitle)
    {
        $this->iTitle = $aTitle;
    }

    public function SetStrokeDest($aDest)
    {
        $this->iDest = $aDest;
    }

    // If aHalt is true then execution can't continue. Typical used for fatal errors
    public function Raise($aMsg, $aHalt = false)
    {
        if ($this->iDest != '') {
            if ($this->iDest == 'syslog') {
                error_log($this->iTitle . $aMsg);
            } else {
                $str = '[' . date('r') . '] ' . $this->iTitle . $aMsg . "\n";
                $f   = @fopen($this->iDest, 'a');

$this->iDest of type boolean is incompatible with the type string expected by parameter $filename of fopen().

                if ($f) {

$f is of type false|resource, thus it always evaluated to false.

                    @fwrite($f, $str);

It seems like you do not handle an error condition for fwrite(). This can introduce security issues, and is generally not recommended.

                    @fclose($f);

It seems like you do not handle an error condition for fclose(). This can introduce security issues, and is generally not recommended.

                }
            }
        } else {
            $aMsg = $this->iTitle . $aMsg;
            // Check SAPI and if we are called from the command line
            // send the error to STDERR instead
            if (PHP_SAPI == 'cli') {
                fwrite(STDERR, $aMsg);
            } else {
                echo $aMsg;
            }
        }
        if ($aHalt) {
            exit(1);

Using exit here is not recommended.

        }
    }
}