example2.js ➔ ... ➔ $(document).ready - Code Metrics - Inspection of "Tag v 2.9.4 adjusts shadow for transparent icons" - HuasoFoundries/ig_markerfactory - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e9e92d...7679d8 )

by Felipe

created 2016-07-08 18:49 UTC

example2.js ➔ ... ➔ $(document).ready B

↳ Parent: example2.js ➔ define

Complexity

Conditions	1
Paths	1

Size

Total Lines

128

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	128
rs	8.2857

How to fix Long Method

define(['jquery', 'lodash', 'ig_markerfactory'], function (jQuery, _, MarkerFactory) {

	console.debug('jQuery is', jQuery, 'MarkerFactory is', MarkerFactory);

	jQuery(document).ready(function () {

		var icons_fontello = {
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
				camera: MarkerFactory.autoIcon({
					label: 'e810',
					font: 'fontello',
					color: '#CC0000',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				}),
				retail: MarkerFactory.autoIcon({
					label: 'e896',
					font: 'fontello',
					color: '#33CCCC',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				}),
				plane: MarkerFactory.autoIcon({
					label: 'e892',
					font: 'fontello',
					color: '#CC00FF',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				}),
				taxi: MarkerFactory.autoIcon({
					label: 'e88c',
					font: 'fontello',
					color: '#33CC33',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				})
			},
			icons_fontawesome = {
				camera: MarkerFactory.autoIcon({
					label: 'f030',
					font: 'FontAwesome',
					color: '#CC0000',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				}),
				retail: MarkerFactory.autoIcon({
					label: 'f07a',
					font: 'FontAwesome',
					color: '#33CCCC',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				}),
				plane: MarkerFactory.autoIcon({
					label: 'f072',
					font: 'FontAwesome',
					color: '#CC00FF',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				}),
				taxi: MarkerFactory.autoIcon({
					label: 'f1ba',
					font: 'FontAwesome',
					color: '#33CC33',
					fontsize: 30,
					scale: 1,
					transparent_background: true
				})
			},
			icons_material = {
				camera: MarkerFactory.autoIcon({
					label: 'E3B0',
					font: 'Material Icons',
					color: '#CC0000',
					fontsize: 40,
					scale: 1,
					transparent_background: true
				}),
				retail: MarkerFactory.autoIcon({
					label: 'E8CC',
					font: 'Material Icons',
					color: '#33CCCC',
					fontsize: 40,
					scale: 1,
					transparent_background: true
				}),
				plane: MarkerFactory.autoIcon({
					label: 'E195',
					font: 'Material Icons',
					color: '#CC00FF',
					fontsize: 40,
					scale: 1,
					transparent_background: true
				}),
				taxi: MarkerFactory.autoIcon({
					label: 'e531',
					font: 'Material Icons',
					color: '#33CC33',
					fontsize: 40,
					scale: 1,
					transparent_background: true
				})
			};


		_.each(icons_fontello, function (icon, name) {
			var theimage = jQuery('<img>');
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			theimage.attr('src', icon.url);
			jQuery('#fontello').find('.' + name).append(theimage);
		});

		_.each(icons_fontawesome, function (icon, name) {
			var theimage = jQuery('<img>');
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			theimage.attr('src', icon.url);
			jQuery('#fontawesome').find('.' + name).append(theimage);
		});

		_.each(icons_material, function (icon, name) {
			var theimage = jQuery('<img>');
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			theimage.attr('src', icon.url);
			jQuery('#materialicons').find('.' + name).append(theimage);
		});




	});


});


1			define(['jquery', 'lodash', 'ig_markerfactory'], function (jQuery, _, MarkerFactory) {
2
3			console.debug('jQuery is', jQuery, 'MarkerFactory is', MarkerFactory);
4
5			jQuery(document).ready(function () {
6
7			var icons_fontello = {
			0 ignored issues – show Coding Style introduced 2016-07-08 18:50 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
8			camera: MarkerFactory.autoIcon({
9			label: 'e810',
10			font: 'fontello',
11			color: '#CC0000',
12			fontsize: 30,
13			scale: 1,
14			transparent_background: true
15			}),
16			retail: MarkerFactory.autoIcon({
17			label: 'e896',
18			font: 'fontello',
19			color: '#33CCCC',
20			fontsize: 30,
21			scale: 1,
22			transparent_background: true
23			}),
24			plane: MarkerFactory.autoIcon({
25			label: 'e892',
26			font: 'fontello',
27			color: '#CC00FF',
28			fontsize: 30,
29			scale: 1,
30			transparent_background: true
31			}),
32			taxi: MarkerFactory.autoIcon({
33			label: 'e88c',
34			font: 'fontello',
35			color: '#33CC33',
36			fontsize: 30,
37			scale: 1,
38			transparent_background: true
39			})
40			},
41			icons_fontawesome = {
42			camera: MarkerFactory.autoIcon({
43			label: 'f030',
44			font: 'FontAwesome',
45			color: '#CC0000',
46			fontsize: 30,
47			scale: 1,
48			transparent_background: true
49			}),
50			retail: MarkerFactory.autoIcon({
51			label: 'f07a',
52			font: 'FontAwesome',
53			color: '#33CCCC',
54			fontsize: 30,
55			scale: 1,
56			transparent_background: true
57			}),
58			plane: MarkerFactory.autoIcon({
59			label: 'f072',
60			font: 'FontAwesome',
61			color: '#CC00FF',
62			fontsize: 30,
63			scale: 1,
64			transparent_background: true
65			}),
66			taxi: MarkerFactory.autoIcon({
67			label: 'f1ba',
68			font: 'FontAwesome',
69			color: '#33CC33',
70			fontsize: 30,
71			scale: 1,
72			transparent_background: true
73			})
74			},
75			icons_material = {
76			camera: MarkerFactory.autoIcon({
77			label: 'E3B0',
78			font: 'Material Icons',
79			color: '#CC0000',
80			fontsize: 40,
81			scale: 1,
82			transparent_background: true
83			}),
84			retail: MarkerFactory.autoIcon({
85			label: 'E8CC',
86			font: 'Material Icons',
87			color: '#33CCCC',
88			fontsize: 40,
89			scale: 1,
90			transparent_background: true
91			}),
92			plane: MarkerFactory.autoIcon({
93			label: 'E195',
94			font: 'Material Icons',
95			color: '#CC00FF',
96			fontsize: 40,
97			scale: 1,
98			transparent_background: true
99			}),
100			taxi: MarkerFactory.autoIcon({
101			label: 'e531',
102			font: 'Material Icons',
103			color: '#33CC33',
104			fontsize: 40,
105			scale: 1,
106			transparent_background: true
107			})
108			};
109
110
111			_.each(icons_fontello, function (icon, name) {
112			var theimage = jQuery('<img>');
			0 ignored issues – show Coding Style introduced 2016-07-08 18:50 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
113			theimage.attr('src', icon.url);
114			jQuery('#fontello').find('.' + name).append(theimage);
115			});
116
117			_.each(icons_fontawesome, function (icon, name) {
118			var theimage = jQuery('<img>');
			0 ignored issues – show Coding Style introduced 2016-07-08 18:50 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
119			theimage.attr('src', icon.url);
120			jQuery('#fontawesome').find('.' + name).append(theimage);
121			});
122
123			_.each(icons_material, function (icon, name) {
124			var theimage = jQuery('<img>');
			0 ignored issues – show Coding Style introduced 2016-07-08 18:50 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
125			theimage.attr('src', icon.url);
126			jQuery('#materialicons').find('.' + name).append(theimage);
127			});
128
129
130
131
132			});
133
134
135			});
136

HuasoFoundries / ig_markerfactory

Push — master ( e9e92d...7679d8 )

example2.js ➔ ... ➔ $(document).ready B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like