_.extend._convert - Code Metrics - HuasoFoundries/backgrid_es6 - Measure and Improve Code Quality continuously with Scrutinizer

_.extend._convert F
last analyzed 2018-04-02 11:03 UTC

↳ Parent: src/backgrid_modules/formatters/datetime.js

Complexity

Conditions	22
Paths	749

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	22
c	2
b	0
f	0
nc	749
nop	2
dl	0
loc	53
rs	3.4603

How to fix Long Method Complexity

import _ from 'underscore';

import {
  lpad
} from '../core.js';
import {
  CellFormatter
} from './cell.js';
/**
   Formatter to converts between various datetime formats.

   This class only understands ISO-8601 formatted datetime strings and UNIX
   offset (number of milliseconds since UNIX Epoch). See
   Backgrid.Extension.MomentFormatter if you need a much more flexible datetime
   formatter.

   @class Backgrid.DatetimeFormatter
   @extends Backgrid.CellFormatter
   @constructor
   @throws {Error} If both `includeDate` and `includeTime` are false.
*/
var DatetimeFormatter = function (options) {
  _.extend(this, this.defaults, options || {});

  if (!this.includeDate && !this.includeTime) {
    throw new Error("Either includeDate or includeTime must be true");
  }
};
DatetimeFormatter.prototype = new CellFormatter();
_.extend(DatetimeFormatter.prototype, {

  /**
     @member Backgrid.DatetimeFormatter

     @cfg {Object} options

     @cfg {boolean} [options.includeDate=true] Whether the values include the
     date part.

     @cfg {boolean} [options.includeTime=true] Whether the values include the
     time part.

     @cfg {boolean} [options.includeMilli=false] If `includeTime` is true,
     whether to include the millisecond part, if it exists.
   */
  defaults: {
    includeDate: true,
    includeTime: true,
    includeMilli: false
  },

  DATE_RE: /^([+\-]?\d{4})-(\d{2})-(\d{2})$/,
  TIME_RE: /^(\d{2}):(\d{2}):(\d{2})(\.(\d{3}))?$/,
  ISO_SPLITTER_RE: /T|Z| +/,

  _convert: function (data, validate) {
    if ((data + '').trim() === '') return null;
if (a > 0)
    b = 42;

    var date, time = null;

    if (_.isNumber(data)) {
      var jsDate = new Date(data);
      date = lpad(jsDate.getUTCFullYear(), 4, 0) + '-' + lpad(jsDate.getUTCMonth() + 1, 2, 0) + '-' + lpad(jsDate.getUTCDate(), 2, 0);
      time = lpad(jsDate.getUTCHours(), 2, 0) + ':' + lpad(jsDate.getUTCMinutes(), 2, 0) + ':' + lpad(jsDate.getUTCSeconds(), 2, 0);
    } else {
      data = data.trim();
      var parts = data.split(this.ISO_SPLITTER_RE) || [];
      date = this.DATE_RE.test(parts[0]) ? parts[0] : '';
      time = date && parts[1] ? parts[1] : this.TIME_RE.test(parts[0]) ? parts[0] : '';

    }

    var YYYYMMDD = this.DATE_RE.exec(date) || [];
    var HHmmssSSS = this.TIME_RE.exec(time) || [];

    if (validate) {
      if (this.includeDate && _.isUndefined(YYYYMMDD[0])) return;
if (a > 0)
    b = 42;
      if (this.includeTime && _.isUndefined(HHmmssSSS[0])) return;
if (a > 0)
    b = 42;
      if (!this.includeDate && date) return;
if (a > 0)
    b = 42;
      if (!this.includeTime && time) return;
if (a > 0)
    b = 42;
    }

    var jsDate = new Date(Date.UTC(YYYYMMDD[1] * 1 || 0,

      YYYYMMDD[2] * 1 - 1 || 0,
      YYYYMMDD[3] * 1 || 0,
      HHmmssSSS[1] * 1 || null,
      HHmmssSSS[2] * 1 || null,
      HHmmssSSS[3] * 1 || null,
      HHmmssSSS[5] * 1 || null));

    var result = '';

    if (this.includeDate) {
      result = lpad(jsDate.getUTCFullYear(), 4, 0) + '-' + lpad(jsDate.getUTCMonth() + 1, 2, 0) + '-' + lpad(jsDate.getUTCDate(), 2, 0);
    }

    if (this.includeTime) {
      result = result + (this.includeDate ? 'T' : '') + lpad(jsDate.getUTCHours(), 2, 0) + ':' + lpad(jsDate.getUTCMinutes(), 2, 0) + ':' + lpad(jsDate.getUTCSeconds(), 2, 0);


      if (this.includeMilli) {
        result = result + '.' + lpad(jsDate.getUTCMilliseconds(), 3, 0);
      }
    }

    if (this.includeDate && this.includeTime) {
      result += "Z";
    }

    return result;
  },

  /**
     Converts an ISO-8601 formatted datetime string to a datetime string, date
     string or a time string. The timezone is ignored if supplied.

     @member Backgrid.DatetimeFormatter
     @param {string} rawData
     @param {Backbone.Model} model Used for more complicated formatting
     @return {string|null|undefined} ISO-8601 string in UTC. Null and undefined
     values are returned as is.
  */
  fromRaw: function (rawData, model) {

    if (_.isNull(rawData) || _.isUndefined(rawData)) return '';
if (a > 0)
    b = 42;
    return this._convert(rawData);
  },

  /**
     Converts an ISO-8601 formatted datetime string to a datetime string, date
     string or a time string. The timezone is ignored if supplied. This method
     parses the input values exactly the same way as
     Backgrid.Extension.MomentFormatter#fromRaw(), in addition to doing some
     sanity checks.

     @member Backgrid.DatetimeFormatter
     @param {string} formattedData
     @param {Backbone.Model} model Used for more complicated formatting
     @return {string|undefined} ISO-8601 string in UTC. Undefined if a date is
     found when `includeDate` is false, or a time is found when `includeTime` is
     false, or if `includeDate` is true and a date is not found, or if
     `includeTime` is true and a time is not found.
  */
  toRaw: function (formattedData, model) {

    return this._convert(formattedData, true);
  }

});

export {
  DatetimeFormatter
};


1			import _ from 'underscore';
			0 ignored issues – show introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Definition for rule 'keyword-spacing' was not found Loading history...
2			import {
3			lpad
4			} from '../core.js';
5			import {
6			CellFormatter
7			} from './cell.js';
8			/**
9			Formatter to converts between various datetime formats.
10
11			This class only understands ISO-8601 formatted datetime strings and UNIX
12			offset (number of milliseconds since UNIX Epoch). See
13			Backgrid.Extension.MomentFormatter if you need a much more flexible datetime
14			formatter.
15
16			@class Backgrid.DatetimeFormatter
17			@extends Backgrid.CellFormatter
18			@constructor
19			@throws {Error} If both `includeDate` and `includeTime` are false.
20			*/
21			var DatetimeFormatter = function (options) {
22			_.extend(this, this.defaults, options \|\| {});
23
24			if (!this.includeDate && !this.includeTime) {
25			throw new Error("Either includeDate or includeTime must be true");
26			}
27			};
28			DatetimeFormatter.prototype = new CellFormatter();
29			_.extend(DatetimeFormatter.prototype, {
30
31			/**
32			@member Backgrid.DatetimeFormatter
33
34			@cfg {Object} options
35
36			@cfg {boolean} [options.includeDate=true] Whether the values include the
37			date part.
38
39			@cfg {boolean} [options.includeTime=true] Whether the values include the
40			time part.
41
42			@cfg {boolean} [options.includeMilli=false] If `includeTime` is true,
43			whether to include the millisecond part, if it exists.
44			*/
45			defaults: {
46			includeDate: true,
47			includeTime: true,
48			includeMilli: false
49			},
50
51			DATE_RE: /^([+\-]?\d{4})-(\d{2})-(\d{2})$/,
52			TIME_RE: /^(\d{2}):(\d{2}):(\d{2})(\.(\d{3}))?$/,
53			ISO_SPLITTER_RE: /T\|Z\| +/,
54
55			_convert: function (data, validate) {
56			if ((data + '').trim() === '') return null;
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Expected { after 'if' condition. Loading history...
57
58			var date, time = null;
			0 ignored issues – show Unused Code introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report The assignment to `time` seems to be never used. If you intend to free memory here, this is not necessary since the variable leaves the scope anyway. Loading history...
59			if (_.isNumber(data)) {
60			var jsDate = new Date(data);
61			date = lpad(jsDate.getUTCFullYear(), 4, 0) + '-' + lpad(jsDate.getUTCMonth() + 1, 2, 0) + '-' + lpad(jsDate.getUTCDate(), 2, 0);
62			time = lpad(jsDate.getUTCHours(), 2, 0) + ':' + lpad(jsDate.getUTCMinutes(), 2, 0) + ':' + lpad(jsDate.getUTCSeconds(), 2, 0);
63			} else {
64			data = data.trim();
65			var parts = data.split(this.ISO_SPLITTER_RE) \|\| [];
66			date = this.DATE_RE.test(parts[0]) ? parts[0] : '';
67			time = date && parts[1] ? parts[1] : this.TIME_RE.test(parts[0]) ? parts[0] : '';
			0 ignored issues – show introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Do not nest ternary expressions Loading history...
68			}
69
70			var YYYYMMDD = this.DATE_RE.exec(date) \|\| [];
71			var HHmmssSSS = this.TIME_RE.exec(time) \|\| [];
72
73			if (validate) {
74			if (this.includeDate && _.isUndefined(YYYYMMDD[0])) return;
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Expected { after 'if' condition. Loading history...
75			if (this.includeTime && _.isUndefined(HHmmssSSS[0])) return;
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Expected { after 'if' condition. Loading history...
76			if (!this.includeDate && date) return;
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Expected { after 'if' condition. Loading history...
77			if (!this.includeTime && time) return;
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Expected { after 'if' condition. Loading history...
78			}
79
80			var jsDate = new Date(Date.UTC(YYYYMMDD[1] * 1 \|\| 0,
			0 ignored issues – show Comprehensibility Naming Best Practice introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report The variable `jsDate` already seems to be declared on line `60`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history... introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report "jsDate" is already defined Loading history...
81			YYYYMMDD[2] * 1 - 1 \|\| 0,
82			YYYYMMDD[3] * 1 \|\| 0,
83			HHmmssSSS[1] * 1 \|\| null,
84			HHmmssSSS[2] * 1 \|\| null,
85			HHmmssSSS[3] * 1 \|\| null,
86			HHmmssSSS[5] * 1 \|\| null));
87
88			var result = '';
89
90			if (this.includeDate) {
91			result = lpad(jsDate.getUTCFullYear(), 4, 0) + '-' + lpad(jsDate.getUTCMonth() + 1, 2, 0) + '-' + lpad(jsDate.getUTCDate(), 2, 0);
92			}
93
94			if (this.includeTime) {
95			result = result + (this.includeDate ? 'T' : '') + lpad(jsDate.getUTCHours(), 2, 0) + ':' + lpad(jsDate.getUTCMinutes(), 2, 0) + ':' + lpad(jsDate.getUTCSeconds(), 2, 0);
			0 ignored issues – show Coding Style introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report This line exceeds the maximum configured line length of 150. Loading history...
96
97			if (this.includeMilli) {
98			result = result + '.' + lpad(jsDate.getUTCMilliseconds(), 3, 0);
99			}
100			}
101
102			if (this.includeDate && this.includeTime) {
103			result += "Z";
104			}
105
106			return result;
107			},
108
109			/**
110			Converts an ISO-8601 formatted datetime string to a datetime string, date
111			string or a time string. The timezone is ignored if supplied.
112
113			@member Backgrid.DatetimeFormatter
114			@param {string} rawData
115			@param {Backbone.Model} model Used for more complicated formatting
116			@return {string\|null\|undefined} ISO-8601 string in UTC. Null and undefined
117			values are returned as is.
118			*/
119			fromRaw: function (rawData, model) {
			0 ignored issues – show Unused Code introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report The parameter `model` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
120			if (_.isNull(rawData) \|\| _.isUndefined(rawData)) return '';
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report Expected { after 'if' condition. Loading history...
121			return this._convert(rawData);
122			},
123
124			/**
125			Converts an ISO-8601 formatted datetime string to a datetime string, date
126			string or a time string. The timezone is ignored if supplied. This method
127			parses the input values exactly the same way as
128			Backgrid.Extension.MomentFormatter#fromRaw(), in addition to doing some
129			sanity checks.
130
131			@member Backgrid.DatetimeFormatter
132			@param {string} formattedData
133			@param {Backbone.Model} model Used for more complicated formatting
134			@return {string\|undefined} ISO-8601 string in UTC. Undefined if a date is
135			found when `includeDate` is false, or a time is found when `includeTime` is
136			false, or if `includeDate` is true and a date is not found, or if
137			`includeTime` is true and a time is not found.
138			*/
139			toRaw: function (formattedData, model) {
			0 ignored issues – show Unused Code introduced 2017-09-30 13:50 UTC by Report Bug Copy Issue Report The parameter `model` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
140			return this._convert(formattedData, true);
141			}
142
143			});
144
145			export {
146			DatetimeFormatter
147			};
148

HuasoFoundries / backgrid_es6

_.extend._convert F last analyzed 2018-04-02 11:03 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Complexity

Duplication Side-by-Side

Filter issues like

_.extend._convert F
last analyzed 2018-04-02 11:03 UTC