BootstrapGroup::bootstrap() - Code Metrics - Inspection of "Add docs for BootstrapGroup" - Horat1us/yii2-base - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ad7958...88028e )

by Alexander

created 2019-02-28 01:55 UTC

BootstrapGroup::bootstrap() A

↳ Parent: BootstrapGroup

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

namespace Horat1us\Yii;

use yii\base;
use yii\di;

/**
 * Class ComposeBootstrap
 * @package Horat1us\Yii
 */
class BootstrapGroup extends base\BaseObject implements base\BootstrapInterface
{
    /**
     * All of this bootstraps will be used.
     * @var array|string|base\BootstrapInterface references
     */
    public $items = [];

    /**
     * @param base\Application $app
     * @throws base\InvalidConfigException
     */
    public function bootstrap($app): void
    {
        foreach ($this->items as $reference) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            /** @var base\BootstrapInterface $bootstrap */
            $bootstrap = di\Instance::ensure($reference, base\BootstrapInterface::class);
            $bootstrap->bootstrap($app);
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Horat1us\Yii;
6
7		use yii\base;
8		use yii\di;
9
10		/**
11		* Class ComposeBootstrap
12		* @package Horat1us\Yii
13		*/
14		class BootstrapGroup extends base\BaseObject implements base\BootstrapInterface
15		{
16		/**
17		* All of this bootstraps will be used.
18		* @var array\|string\|base\BootstrapInterface references
19		*/
20		public $items = [];
21
22		/**
23		* @param base\Application $app
24		* @throws base\InvalidConfigException
25		*/
26	2	public function bootstrap($app): void
27		{
28	2	foreach ($this->items as $reference) {
		0 ignored issues – show Bug introduced 2019-02-28 01:56 UTC by Report Bug Copy Issue Report The expression `$this->items` of type `array\|string\|object<yii\base\BootstrapInterface>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
29		/** @var base\BootstrapInterface $bootstrap */
30	2	$bootstrap = di\Instance::ensure($reference, base\BootstrapInterface::class);
31	1	$bootstrap->bootstrap($app);
32		}
33	1	}
34		}
35

Horat1us / yii2-base

Push — master ( ad7958...88028e )

BootstrapGroup::bootstrap() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like