XmlEqualityService::__construct() - Code Metrics - Inspection of "Add XmlEqualityService" - Horat1us/php-xml-convertible - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bbd63b...04134d )

by Alexander

created 2017-05-11 15:23 UTC

XmlEqualityService::__construct() A

↳ Parent: XmlEqualityService

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	2
crap	1

<?php
/**
 * Created by PhpStorm.
 * User: horat1us
 * Date: 5/11/17
 * Time: 6:18 PM
 */

namespace Horat1us\Services;


use Horat1us\XmlConvertibleInterface;

/**
 * Class XmlEqualityService
 * @package Horat1us\Services
 */
class XmlEqualityService
{
    /**
     * @var XmlConvertibleInterface
     */
    public $first;

    /**
     * @var XmlConvertibleInterface
     */
    public $second;

    /**
     * XmlEqualityService constructor.
     * @param XmlConvertibleInterface|null $first
     * @param XmlConvertibleInterface|null $second
     */
    public function __construct(
        XmlConvertibleInterface $first = null,
        XmlConvertibleInterface $second = null
    )
    {
        $this->first = $first;
        $this->second = $second;
    }

    public function compare(): bool
    {
        if (
            !$this->first instanceof XmlConvertibleInterface
            || !$this->second instanceof XmlConvertibleInterface
        ) {
            return false;
        }

        $document = new \DOMDocument();
        $document->appendChild($this->first->toXml($document));
        $current = $document->saveXML();

        $document = new \DOMDocument();
        $document->appendChild($this->second->toXml($document));
        $compared = $document->saveXML();

        return $current === $compared;
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: horat1us
5		* Date: 5/11/17
6		* Time: 6:18 PM
7		*/
8
9		namespace Horat1us\Services;
10
11
12		use Horat1us\XmlConvertibleInterface;
13
14		/**
15		* Class XmlEqualityService
16		* @package Horat1us\Services
17		*/
18		class XmlEqualityService
19		{
20		/**
21		* @var XmlConvertibleInterface
22		*/
23		public $first;
24
25		/**
26		* @var XmlConvertibleInterface
27		*/
28		public $second;
29
30		/**
31		* XmlEqualityService constructor.
32		* @param XmlConvertibleInterface\|null $first
33		* @param XmlConvertibleInterface\|null $second
34		*/
35	4	public function __construct(
36		XmlConvertibleInterface $first = null,
37		XmlConvertibleInterface $second = null
38		)
39		{
40	4	$this->first = $first;
41	4	$this->second = $second;
42	4	}
43
44	4	public function compare(): bool
45		{
46		if (
47	4	!$this->first instanceof XmlConvertibleInterface
48	4	\|\| !$this->second instanceof XmlConvertibleInterface
49		) {
50	1	return false;
51		}
52
53	3	$document = new \DOMDocument();
54	3	$document->appendChild($this->first->toXml($document));
55	3	$current = $document->saveXML();
56
57	3	$document = new \DOMDocument();
58	3	$document->appendChild($this->second->toXml($document));
59	3	$compared = $document->saveXML();
60
61	3	return $current === $compared;
62		}
63		}

Horat1us / php-xml-convertible

Push — master ( bbd63b...04134d )

XmlEqualityService::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like