HexMakina / kadro

StateAgent.class.php

Braces +14 added lines, -10 removed lines

@@ -34,27 +34,31 @@
 
   public function filters($filter_name=null, $value=null)
   {
-    if(is_null($filter_name))
-      return $_SESSION[$this->index_filter];
+    if(is_null($filter_name)) {
+          return $_SESSION[$this->index_filter];
+    }
 
-    if(!is_null($value))
-      $_SESSION[$this->index_filter][$filter_name] = $value;
+    if(!is_null($value)) {
+          $_SESSION[$this->index_filter][$filter_name] = $value;
+    }
 
     return $_SESSION[$this->index_filter][$filter_name] ?? null;
   }
 
   public function reset_filters($filter_name=null)
   {
-    if(is_null($filter_name))
-      $_SESSION[$this->index_filter]=[];
-    else
-      unset($_SESSION[$this->index_filter][$filter_name]);
+    if(is_null($filter_name)) {
+          $_SESSION[$this->index_filter]=[];
+    } else {
+          unset($_SESSION[$this->index_filter][$filter_name]);
+    }
   }
 
   public function operator_id($setter = null)
   {
-    if(!is_null($setter))
-      $_SESSION[$this->index_operator] = ['id' => $setter, 'set_on' => time()];
+    if(!is_null($setter)) {
+          $_SESSION[$this->index_operator] = ['id' => $setter, 'set_on' => time()];
+    }
 
     return $_SESSION[$this->index_operator]['id'] ?? null;
   }

Auth/Operatorability.class.php

Braces +15 added lines, -9 removed lines

@@ -17,8 +17,10 @@ 
 
   public function load_operator($id = null)
   {
-    if(!is_null($operator_id = $id ?? $this->get('operator_id'))) // extraction failed but we have an fk
+    if(!is_null($operator_id = $id ?? $this->get('operator_id'))) {
+      // extraction failed but we have an fk
       $this->operator = Operator::exists($operator_id);
+    }
   }
 
   public function operator() : ?OperatorInterface
@@ -28,9 +30,10 @@ 
       $extract_attempt = $this->extract(new Operator(), true);
       if(!is_null($extract_attempt))
       {
-        foreach(['permission_names', 'permission_ids'] as $permission_marker)
-          if(property_exists($this, $permission_marker))
+        foreach(['permission_names', 'permission_ids'] as $permission_marker) {
+                  if(property_exists($this, $permission_marker))
             $extract_attempt->set($permission_marker, $this->$permission_marker);
+        }
 
         $this->operator = $extract_attempt;
       }
@@ -55,14 +58,17 @@ 
 
     $Query->select_also(['operator.name as operator_name', 'operator.active as operator_active']);
 
-    if(isset($filters['username']))
-      $Query->aw_eq('username', $filters['username'], 'operator');
+    if(isset($filters['username'])) {
+          $Query->aw_eq('username', $filters['username'], 'operator');
+    }
 
-    if(isset($filters['email']))
-      $Query->aw_eq('email', $filters['email'], 'operator');
+    if(isset($filters['email'])) {
+          $Query->aw_eq('email', $filters['email'], 'operator');
+    }
 
-    if(isset($filters['active']))
-      $Query->aw_eq('active', $filters['active'], 'operator');
+    if(isset($filters['active'])) {
+          $Query->aw_eq('active', $filters['active'], 'operator');
+    }
 
     return $Query;
   }

PSR4Autoloader.class.php

Indentation +45 added lines, -45 removed lines

@@ -7,18 +7,18 @@ 
 {
   
   /**
-  * An associative array where the key is a namespace prefix and the value
-  * is an array of base directories for classes in that namespace.
-  *
-  * @var array
-  */
+   * An associative array where the key is a namespace prefix and the value
+   * is an array of base directories for classes in that namespace.
+   *
+   * @var array
+   */
   protected $prefixes = [];
 
   /**
-  * Register loader with SPL autoloader stack.
-  *
-  * @return void
-  */
+   * Register loader with SPL autoloader stack.
+   *
+   * @return void
+   */
 
   public function register()
   {
@@ -26,28 +26,28 @@ 
   }
 
   /**
-  * Adds a base directory for a namespace prefix.
-  *
-  * @param string $prefix The namespace prefix.
-  * @param string $base_dir A base directory for class files in the
-  * namespace.
-  * @param bool $prepend If true, prepend the base directory to the stack
-  * instead of appending it; this causes it to be searched first rather
-  * than last.
-  * @return void
-  */
+   * Adds a base directory for a namespace prefix.
+   *
+   * @param string $prefix The namespace prefix.
+   * @param string $base_dir A base directory for class files in the
+   * namespace.
+   * @param bool $prepend If true, prepend the base directory to the stack
+   * instead of appending it; this causes it to be searched first rather
+   * than last.
+   * @return void
+   */
   public function addNamespaceTree($base_dir, $prepend = false)
   {
-  	$dir_content = FileSystem::preg_scandir($base_dir, '/^[A-Z]{1}[A-Za-z]+(?!\.class.\.php)$/');
+    $dir_content = FileSystem::preg_scandir($base_dir, '/^[A-Z]{1}[A-Za-z]+(?!\.class.\.php)$/');
     
-  	foreach($dir_content as $res)
-  	{
-  		if(is_dir($fullpath = $base_dir.'/'.$res))
-  		{
-  			$this->addNamespace('HexMakina\kadro\\'.$res, $fullpath);
+    foreach($dir_content as $res)
+    {
+      if(is_dir($fullpath = $base_dir.'/'.$res))
+      {
+        $this->addNamespace('HexMakina\kadro\\'.$res, $fullpath);
         $this->addNamespaceTree($fullpath);
-  		}
-  	}
+      }
+    }
   }
   
   public function addNamespace($prefix, $base_dir, $prepend = false)
@@ -73,12 +73,12 @@ 
   }
 
   /**
-  * Loads the class file for a given class name.
-  *
-  * @param string $class The fully-qualified class name.
-  * @return mixed The mapped file name on success, or boolean false on
-  * failure.
-  */
+   * Loads the class file for a given class name.
+   *
+   * @param string $class The fully-qualified class name.
+   * @return mixed The mapped file name on success, or boolean false on
+   * failure.
+   */
   public function loadClass($class)
   {
     // var_dump(__FUNCTION__."($class)");
@@ -110,13 +110,13 @@ 
   }
 
   /**
-  * Load the mapped file for a namespace prefix and relative class.
-  *
-  * @param string $prefix The namespace prefix.
-  * @param string $relative_class The relative class name.
-  * @return mixed Boolean false if no mapped file can be loaded, or the
-  * name of the mapped file that was loaded.
-  */
+   * Load the mapped file for a namespace prefix and relative class.
+   *
+   * @param string $prefix The namespace prefix.
+   * @param string $relative_class The relative class name.
+   * @return mixed Boolean false if no mapped file can be loaded, or the
+   * name of the mapped file that was loaded.
+   */
   protected function loadMappedFile($prefix, $relative_class)
   {
     // are there any base directories for this namespace prefix?
@@ -147,11 +147,11 @@ 
   }
 
   /**
-  * If a file exists, require it from the file system.
-  *
-  * @param string $file The file to require.
-  * @return bool True if the file exists, false if not.
-  */
+   * If a file exists, require it from the file system.
+   *
+   * @param string $file The file to require.
+   * @return bool True if the file exists, false if not.
+   */
   protected function requireFile($file)
   {
     // var_dump(__FUNCTION__."($file)");

Router/hopper.class.php

Indentation +2 added lines, -2 removed lines

@@ -192,8 +192,8 @@
 
   public function hop_url($url)
   {
-  	header('Cache-Control: no-cache, must-revalidate');
-  	header('Expires: Mon, 01 Jan 1970 00:00:00 GMT');
+    header('Cache-Control: no-cache, must-revalidate');
+    header('Expires: Mon, 01 Jan 1970 00:00:00 GMT');
     header('Location: '.$url);
     exit();
   }

Braces +41 added lines, -29 removed lines

@@ -17,8 +17,9 @@ 
   //----------------------------------------------------------- INITIALISATION
   public function __construct($settings)
   {
-    if(!isset($settings['route_home']))
-      throw new RouterException('ROUTE_HOME_UNDEFINED');
+    if(!isset($settings['route_home'])) {
+          throw new RouterException('ROUTE_HOME_UNDEFINED');
+    }
 
     parent::__construct();
 
@@ -44,13 +45,15 @@ 
   {
     $this->match = parent::match($requestUrl, $requestMethod);
 
-    if($this->match === false)
-      throw new RouterException('ROUTE_MATCH_FALSE');
+    if($this->match === false) {
+          throw new RouterException('ROUTE_MATCH_FALSE');
+    }
 
     $res = explode('::', self::target());
 
-    if($res === false || !isset($res[1]) || isset($ret[2]))
-      throw new RouterException('INVALID_TARGET');
+    if($res === false || !isset($res[1]) || isset($ret[2])) {
+          throw new RouterException('INVALID_TARGET');
+    }
 
     // if($this->match['name'] === 'akadok_controller_method')
     //   $res = [ucfirst(self::params('controller')).'Controller', ucfirst(self::params('method'))];
@@ -60,12 +63,14 @@ 
     $target_method = $res[1];
     $found = false;
 
-    foreach($this->controller_namespaces as $controller_ns)
-      if($found = class_exists($controller_class_name = "$controller_ns$target_controller"))
+    foreach($this->controller_namespaces as $controller_ns) {
+          if($found = class_exists($controller_class_name = "$controller_ns$target_controller"))
         break;
+    }
 
-    if($found === false)
-      throw new RouterException('INVALID_CONTROLLER_NAME');
+    if($found === false) {
+          throw new RouterException('INVALID_CONTROLLER_NAME');
+    }
 
     $this->match['target_controller'] = $controller_class_name;
     $this->match['target_method'] = $target_method;
@@ -87,16 +92,19 @@ 
   {
 
     // $key is null, returns $dat_ass or empty array
-    if(is_null($key))
-      return $dat_ass ?? [];
+    if(is_null($key)) {
+          return $dat_ass ?? [];
+    }
 
     // $dat_ass[$key] not set, returns null
-    if(!isset($dat_ass[$key]))
-      return null;
+    if(!isset($dat_ass[$key])) {
+          return null;
+    }
 
     // $dat_ass[$key] is a string, returns decoded value
-    if(is_string($dat_ass[$key]))
-      return urldecode($dat_ass[$key]);
+    if(is_string($dat_ass[$key])) {
+          return urldecode($dat_ass[$key]);
+    }
 
     // $dat_ass[$key] is not a string, return match[$key]
     return $dat_ass[$key];
@@ -146,7 +154,7 @@ 
   {
     try{
       $url = $this->generate($route, $route_params);
-    }catch(\Exception $e){
+    } catch(\Exception $e){
       $url = $this->prehop(self::ROUTE_HOME_NAME);
     }
 
@@ -169,12 +177,13 @@ 
   {
     $url = null;
 
-    if(is_null($route))
-      $url = $this->prehop(self::ROUTE_HOME_NAME, $route_params);
-    elseif(is_string($route) && $this->route_exists($route))
-      $url = $this->prehop($route, $route_params);
-    else
-      $url = $route;
+    if(is_null($route)) {
+          $url = $this->prehop(self::ROUTE_HOME_NAME, $route_params);
+    } elseif(is_string($route) && $this->route_exists($route)) {
+          $url = $this->prehop($route, $route_params);
+    } else {
+          $url = $route;
+    }
 
     $this->hop_url($url);
   }
@@ -182,8 +191,9 @@ 
   // hops back to previous page (referer()), or home if no referer
   public function hop_back()
   {
-    if(!is_null($back = $this->referer()))
-      $this->hop_url($back);
+    if(!is_null($back = $this->referer())) {
+          $this->hop_url($back);
+    }
 
     $this->hop();
   }
@@ -200,16 +210,18 @@ 
   // returns null if same as current URL (prevents endless redirection loop)
   public function referer()
   {
-    if(isset($_SERVER['HTTP_REFERER']) && $_SERVER['HTTP_REFERER'] != $this->web_host() .$_SERVER['REQUEST_URI'])
-      return $_SERVER['HTTP_REFERER'];
+    if(isset($_SERVER['HTTP_REFERER']) && $_SERVER['HTTP_REFERER'] != $this->web_host() .$_SERVER['REQUEST_URI']) {
+          return $_SERVER['HTTP_REFERER'];
+    }
 
     return null;
   }
 
   public function send_file($file_path)
   {
-    if(!file_exists($file_path))
-      throw new RouterException('SENDING_NON_EXISTING_FILE');
+    if(!file_exists($file_path)) {
+          throw new RouterException('SENDING_NON_EXISTING_FILE');
+    }
 
     $file_name = basename($file_path);
 

Router/AltoRouter.php

Indentation +261 added lines, -261 removed lines

@@ -2,266 +2,266 @@
 
 class AltoRouter {
 
-	/**
-	 * @var array Array of all routes (incl. named routes).
-	 */
-	protected $routes = [];
-
-	/**
-	 * @var array Array of all named routes.
-	 */
-	protected $namedRoutes = [];
-
-	/**
-	 * @var string Can be used to ignore leading part of the Request URL (if main file lives in subdirectory of host)
-	 */
-	protected $basePath = '';
-
-	/**
-	 * @var array Array of default match types (regex helpers)
-	 */
-	protected $matchTypes = array(
-		'i'  => '[0-9]++',
-		'a'  => '[0-9A-Za-z]++',
-		'h'  => '[0-9A-Fa-f]++',
-		'*'  => '.+?',
-		'**' => '.++',
-		''   => '[^/\.]++'
-	);
-
-	/**
-	  * Create router in one call from config.
-	  *
-	  * @param array $routes
-	  * @param string $basePath
-	  * @param array $matchTypes
-	  */
-	public function __construct( $routes = array(), $basePath = '', $matchTypes = array() ) {
-		$this->addRoutes($routes);
-		$this->setBasePath($basePath);
-		$this->addMatchTypes($matchTypes);
-	}
-
-	/**
-	 * Retrieves all routes.
-	 * Useful if you want to process or display routes.
-	 * @return array All routes.
-	 */
-	public function getRoutes() {
-		return $this->routes;
-	}
-
-	/**
-	 * Add multiple routes at once from array in the following format:
-	 *
-	 *   $routes = array(
-	 *      array($method, $route, $target, $name)
-	 *   );
-	 *
-	 * @param array $routes
-	 * @return void
-	 * @author Koen Punt
-	 * @throws Exception
-	 */
-	public function addRoutes($routes){
-		if(!is_array($routes) && !$routes instanceof Traversable) {
-			throw new \Exception('Routes should be an array or an instance of Traversable');
-		}
-		foreach($routes as $route) {
-			call_user_func_array(array($this, 'map'), $route);
-		}
-	}
-
-	/**
-	 * Set the base path.
-	 * Useful if you are running your application from a subdirectory.
-	 */
-	public function setBasePath($basePath) {
-		$this->basePath = $basePath;
-	}
-
-	/**
-	 * Add named match types. It uses array_merge so keys can be overwritten.
-	 *
-	 * @param array $matchTypes The key is the name and the value is the regex.
-	 */
-	public function addMatchTypes($matchTypes) {
-		$this->matchTypes = array_merge($this->matchTypes, $matchTypes);
-	}
-
-	/**
-	 * Map a route to a target
-	 *
-	 * @param string $method One of 5 HTTP Methods, or a pipe-separated list of multiple HTTP Methods (GET|POST|PATCH|PUT|DELETE)
-	 * @param string $route The route regex, custom regex must start with an @. You can use multiple pre-set regex filters, like [i:id]
-	 * @param mixed $target The target where this route should point to. Can be anything.
-	 * @param string $name Optional name of this route. Supply if you want to reverse route this url in your application.
-	 * @throws Exception
-	 */
-	public function map($method, $route, $target, $name = null) {
-
-		$this->routes[] = array($method, $route, $target, $name);
-
-		if($name) {
-			if(isset($this->namedRoutes[$name])) {
-				throw new \Exception("Can not redeclare route '{$name}'");
-			} else {
-				$this->namedRoutes[$name] = $route;
-			}
-
-		}
-
-		return;
-	}
-
-	/**
-	 * Reversed routing
-	 *
-	 * Generate the URL for a named route. Replace regexes with supplied parameters
-	 *
-	 * @param string $routeName The name of the route.
-	 * @param array @params Associative array of parameters to replace placeholders with.
-	 * @return string The URL of the route with named parameters in place.
-	 * @throws Exception
-	 */
-	public function generate($routeName, array $params = array()) {
-
-		// Check if named route exists
-		if(!isset($this->namedRoutes[$routeName])) {
-			throw new \Exception("Route '{$routeName}' does not exist.");
-		}
-
-		// Replace named parameters
-		$route = $this->namedRoutes[$routeName];
-
-		// prepend base path to route url again
-		$url = $this->basePath . $route;
-
-		if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
-
-			foreach($matches as $match) {
-				list($block, $pre, $type, $param, $optional) = $match;
-
-				if ($pre) {
-					$block = substr($block, 1);
-				}
-
-				if(isset($params[$param])) {
-					$url = str_replace($block, $params[$param], $url);
-				} elseif ($optional) {
-					$url = str_replace($pre . $block, '', $url);
-				}
-			}
-
-
-		}
-
-		return $url;
-	}
-
-	/**
-	 * Match a given Request Url against stored routes
-	 * @param string $requestUrl
-	 * @param string $requestMethod
-	 * @return array|boolean Array with route information on success, false on failure (no match).
-	 */
-	public function match($requestUrl = null, $requestMethod = null) {
-
-		$params = [];
-		$match = false;
-
-		// set Request Url if it isn't passed as parameter
-		if($requestUrl === null) {
-			$requestUrl = isset($_SERVER['REQUEST_URI']) ? $_SERVER['REQUEST_URI'] : '/';
-		}
-
-		// strip base path from request url
-		$requestUrl = substr($requestUrl, strlen($this->basePath));
+  /**
+   * @var array Array of all routes (incl. named routes).
+   */
+  protected $routes = [];
+
+  /**
+   * @var array Array of all named routes.
+   */
+  protected $namedRoutes = [];
+
+  /**
+   * @var string Can be used to ignore leading part of the Request URL (if main file lives in subdirectory of host)
+   */
+  protected $basePath = '';
+
+  /**
+   * @var array Array of default match types (regex helpers)
+   */
+  protected $matchTypes = array(
+    'i'  => '[0-9]++',
+    'a'  => '[0-9A-Za-z]++',
+    'h'  => '[0-9A-Fa-f]++',
+    '*'  => '.+?',
+    '**' => '.++',
+    ''   => '[^/\.]++'
+  );
+
+  /**
+   * Create router in one call from config.
+   *
+   * @param array $routes
+   * @param string $basePath
+   * @param array $matchTypes
+   */
+  public function __construct( $routes = array(), $basePath = '', $matchTypes = array() ) {
+    $this->addRoutes($routes);
+    $this->setBasePath($basePath);
+    $this->addMatchTypes($matchTypes);
+  }
+
+  /**
+   * Retrieves all routes.
+   * Useful if you want to process or display routes.
+   * @return array All routes.
+   */
+  public function getRoutes() {
+    return $this->routes;
+  }
+
+  /**
+   * Add multiple routes at once from array in the following format:
+   *
+   *   $routes = array(
+   *      array($method, $route, $target, $name)
+   *   );
+   *
+   * @param array $routes
+   * @return void
+   * @author Koen Punt
+   * @throws Exception
+   */
+  public function addRoutes($routes){
+    if(!is_array($routes) && !$routes instanceof Traversable) {
+      throw new \Exception('Routes should be an array or an instance of Traversable');
+    }
+    foreach($routes as $route) {
+      call_user_func_array(array($this, 'map'), $route);
+    }
+  }
+
+  /**
+   * Set the base path.
+   * Useful if you are running your application from a subdirectory.
+   */
+  public function setBasePath($basePath) {
+    $this->basePath = $basePath;
+  }
+
+  /**
+   * Add named match types. It uses array_merge so keys can be overwritten.
+   *
+   * @param array $matchTypes The key is the name and the value is the regex.
+   */
+  public function addMatchTypes($matchTypes) {
+    $this->matchTypes = array_merge($this->matchTypes, $matchTypes);
+  }
+
+  /**
+   * Map a route to a target
+   *
+   * @param string $method One of 5 HTTP Methods, or a pipe-separated list of multiple HTTP Methods (GET|POST|PATCH|PUT|DELETE)
+   * @param string $route The route regex, custom regex must start with an @. You can use multiple pre-set regex filters, like [i:id]
+   * @param mixed $target The target where this route should point to. Can be anything.
+   * @param string $name Optional name of this route. Supply if you want to reverse route this url in your application.
+   * @throws Exception
+   */
+  public function map($method, $route, $target, $name = null) {
+
+    $this->routes[] = array($method, $route, $target, $name);
+
+    if($name) {
+      if(isset($this->namedRoutes[$name])) {
+        throw new \Exception("Can not redeclare route '{$name}'");
+      } else {
+        $this->namedRoutes[$name] = $route;
+      }
+
+    }
+
+    return;
+  }
+
+  /**
+   * Reversed routing
+   *
+   * Generate the URL for a named route. Replace regexes with supplied parameters
+   *
+   * @param string $routeName The name of the route.
+   * @param array @params Associative array of parameters to replace placeholders with.
+   * @return string The URL of the route with named parameters in place.
+   * @throws Exception
+   */
+  public function generate($routeName, array $params = array()) {
+
+    // Check if named route exists
+    if(!isset($this->namedRoutes[$routeName])) {
+      throw new \Exception("Route '{$routeName}' does not exist.");
+    }
+
+    // Replace named parameters
+    $route = $this->namedRoutes[$routeName];
+
+    // prepend base path to route url again
+    $url = $this->basePath . $route;
+
+    if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
+
+      foreach($matches as $match) {
+        list($block, $pre, $type, $param, $optional) = $match;
+
+        if ($pre) {
+          $block = substr($block, 1);
+        }
+
+        if(isset($params[$param])) {
+          $url = str_replace($block, $params[$param], $url);
+        } elseif ($optional) {
+          $url = str_replace($pre . $block, '', $url);
+        }
+      }
+
+
+    }
+
+    return $url;
+  }
+
+  /**
+   * Match a given Request Url against stored routes
+   * @param string $requestUrl
+   * @param string $requestMethod
+   * @return array|boolean Array with route information on success, false on failure (no match).
+   */
+  public function match($requestUrl = null, $requestMethod = null) {
+
+    $params = [];
+    $match = false;
+
+    // set Request Url if it isn't passed as parameter
+    if($requestUrl === null) {
+      $requestUrl = isset($_SERVER['REQUEST_URI']) ? $_SERVER['REQUEST_URI'] : '/';
+    }
+
+    // strip base path from request url
+    $requestUrl = substr($requestUrl, strlen($this->basePath));
     
-		// Strip query string (?a=b) from Request Url
-		if (($strpos = strpos($requestUrl, '?')) !== false) {
-			$requestUrl = substr($requestUrl, 0, $strpos);
-		}
-
-		// set Request Method if it isn't passed as a parameter
-		if($requestMethod === null) {
-			$requestMethod = isset($_SERVER['REQUEST_METHOD']) ? $_SERVER['REQUEST_METHOD'] : 'GET';
-		}
-
-		foreach($this->routes as $handler) {
-			list($methods, $route, $target, $name) = $handler;
-			$method_match = (stripos($methods, $requestMethod) !== false);
-
-			// Method did not match, continue to next route.
-			if (!$method_match) continue;
-
-			if ($route === '*') {
-				// * wildcard (matches all)
-				$match = true;
-			} elseif (isset($route[0]) && $route[0] === '@') {
-				// @ regex delimiter
-				$pattern = '`' . substr($route, 1) . '`u';
-				$match = preg_match($pattern, $requestUrl, $params) === 1;
-			} elseif (($position = strpos($route, '[')) === false) {
-				// No params in url, do string comparison
-				$match = strcmp($requestUrl, $route) === 0;
-			} else {
-				// Compare longest non-param string with url
-				if (strncmp($requestUrl, $route, $position) !== 0) {
-					continue;
-				}
-				$regex = $this->compileRoute($route);
-				$match = preg_match($regex, $requestUrl, $params) === 1;
-			}
-
-			if ($match) {
-
-				if ($params) {
-					foreach($params as $key => $value) {
-						if(is_numeric($key)) unset($params[$key]);
-					}
-				}
-
-				return array(
-					'target' => $target,
-					'params' => $params,
-					'name' => $name
-				);
-			}
-		}
-		return false;
-	}
-
-	/**
-	 * Compile the regex for a given route (EXPENSIVE)
-	 */
-	private function compileRoute($route) {
-		if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
-
-			$matchTypes = $this->matchTypes;
-			foreach($matches as $match) {
-				list($block, $pre, $type, $param, $optional) = $match;
-
-				if (isset($matchTypes[$type])) {
-					$type = $matchTypes[$type];
-				}
-				if ($pre === '.') {
-					$pre = '\.';
-				}
-
-				//Older versions of PCRE require the 'P' in (?P<named>)
-				$pattern = '(?:'
-						. ($pre !== '' ? $pre : null)
-						. '('
-						. ($param !== '' ? "?P<$param>" : null)
-						. $type
-						. '))'
-						. ($optional !== '' ? '?' : null);
-
-				$route = str_replace($block, $pattern, $route);
-			}
-
-		}
-		return "`^$route$`u";
-	}
+    // Strip query string (?a=b) from Request Url
+    if (($strpos = strpos($requestUrl, '?')) !== false) {
+      $requestUrl = substr($requestUrl, 0, $strpos);
+    }
+
+    // set Request Method if it isn't passed as a parameter
+    if($requestMethod === null) {
+      $requestMethod = isset($_SERVER['REQUEST_METHOD']) ? $_SERVER['REQUEST_METHOD'] : 'GET';
+    }
+
+    foreach($this->routes as $handler) {
+      list($methods, $route, $target, $name) = $handler;
+      $method_match = (stripos($methods, $requestMethod) !== false);
+
+      // Method did not match, continue to next route.
+      if (!$method_match) continue;
+
+      if ($route === '*') {
+        // * wildcard (matches all)
+        $match = true;
+      } elseif (isset($route[0]) && $route[0] === '@') {
+        // @ regex delimiter
+        $pattern = '`' . substr($route, 1) . '`u';
+        $match = preg_match($pattern, $requestUrl, $params) === 1;
+      } elseif (($position = strpos($route, '[')) === false) {
+        // No params in url, do string comparison
+        $match = strcmp($requestUrl, $route) === 0;
+      } else {
+        // Compare longest non-param string with url
+        if (strncmp($requestUrl, $route, $position) !== 0) {
+          continue;
+        }
+        $regex = $this->compileRoute($route);
+        $match = preg_match($regex, $requestUrl, $params) === 1;
+      }
+
+      if ($match) {
+
+        if ($params) {
+          foreach($params as $key => $value) {
+            if(is_numeric($key)) unset($params[$key]);
+          }
+        }
+
+        return array(
+          'target' => $target,
+          'params' => $params,
+          'name' => $name
+        );
+      }
+    }
+    return false;
+  }
+
+  /**
+   * Compile the regex for a given route (EXPENSIVE)
+   */
+  private function compileRoute($route) {
+    if (preg_match_all('`(/|\.|)\[([^:\]]*+)(?::([^:\]]*+))?\](\?|)`', $route, $matches, PREG_SET_ORDER)) {
+
+      $matchTypes = $this->matchTypes;
+      foreach($matches as $match) {
+        list($block, $pre, $type, $param, $optional) = $match;
+
+        if (isset($matchTypes[$type])) {
+          $type = $matchTypes[$type];
+        }
+        if ($pre === '.') {
+          $pre = '\.';
+        }
+
+        //Older versions of PCRE require the 'P' in (?P<named>)
+        $pattern = '(?:'
+            . ($pre !== '' ? $pre : null)
+            . '('
+            . ($param !== '' ? "?P<$param>" : null)
+            . $type
+            . '))'
+            . ($optional !== '' ? '?' : null);
+
+        $route = str_replace($block, $pattern, $route);
+      }
+
+    }
+    return "`^$route$`u";
+  }
 }

Braces +6 added lines, -2 removed lines

@@ -193,7 +193,9 @@ 
 			$method_match = (stripos($methods, $requestMethod) !== false);
 
 			// Method did not match, continue to next route.
-			if (!$method_match) continue;
+			if (!$method_match) {
+			  continue;
+			}
 
 			if ($route === '*') {
 				// * wildcard (matches all)
@@ -218,7 +220,9 @@ 
 
 				if ($params) {
 					foreach($params as $key => $value) {
-						if(is_numeric($key)) unset($params[$key]);
+						if(is_numeric($key)) {
+						  unset($params[$key]);
+						}
 					}
 				}
 

Controllers/Paginator.class.php

Indentation +7 added lines, -7 removed lines

@@ -7,8 +7,8 @@ 
 {
   protected static function prepare_pagination($records_total)
   {
-  	global $settings;
-  	global $smarty;
+    global $settings;
+    global $smarty;
 
     $pages_max_on_each_side = 3;
     $pages_max_displayed = $pages_max_on_each_side*2+1;
@@ -35,12 +35,12 @@ 
     if($pages_last > $pages_total) // $pages_max_displayed greater than the total of pages
       $pages_last = $pages_total;
 
-  	$this->viewport("pages_total",     $pages_total);
-  	$this->viewport("pages_first",     $pages_first);
+    $this->viewport("pages_total",     $pages_total);
+    $this->viewport("pages_first",     $pages_first);
     $this->viewport("pages_previous",  $pages_current <= 1 ? $pages_total : $pages_current - 1);
-  	$this->viewport("pages_current",   $pages_current);
-  	$this->viewport("pages_next",      $pages_current >= $pages_total ? 1 : $pages_current + 1);
-  	$this->viewport("pages_last",      $pages_last);
+    $this->viewport("pages_current",   $pages_current);
+    $this->viewport("pages_next",      $pages_current >= $pages_total ? 1 : $pages_current + 1);
+    $this->viewport("pages_last",      $pages_last);
   }
 
 }

Braces +12 added lines, -6 removed lines

@@ -15,25 +15,31 @@
 
     // are we paginating ?
 
-    if(is_null($this->box('StateAgent')->filters('results_per_page')))
-      return;
+    if(is_null($this->box('StateAgent')->filters('results_per_page'))) {
+          return;
+    }
 
     $pages_range    = intval($this->box('StateAgent')->filters('results_per_page'));
     $pages_total    = $pages_range > 0 ? intval(ceil($records_total / $pages_range)) : 1;
     $pages_current  = intval($this->box('StateAgent')->filters('page'));
 
-    if($pages_current >= $pages_total)
-      $pages_current = $pages_total;
+    if($pages_current >= $pages_total) {
+          $pages_current = $pages_total;
+    }
 
     $pages_first = ($pages_current <= $pages_max_on_each_side)? 1 : $pages_current - $pages_max_on_each_side;
 
     $pages_last = $pages_current + $pages_max_on_each_side;
 
-    if($pages_last < $pages_max_displayed) // add the missing pages to fullfill $pages_max_displayed
+    if($pages_last < $pages_max_displayed) {
+      // add the missing pages to fullfill $pages_max_displayed
       $pages_last += $pages_max_displayed-$pages_last;
+    }
 
-    if($pages_last > $pages_total) // $pages_max_displayed greater than the total of pages
+    if($pages_last > $pages_total) {
+      // $pages_max_displayed greater than the total of pages
       $pages_last = $pages_total;
+    }
 
   	$this->viewport("pages_total",     $pages_total);
   	$this->viewport("pages_first",     $pages_first);

Controllers/KadroController.class.php

Indentation +13 added lines, -13 removed lines

@@ -107,18 +107,18 @@ 
     $custom_template = null;
 
     if(method_exists($this, 'prepare'))
-    	$this->prepare();
+      $this->prepare();
 
-  	if(method_exists($this, $method = $this->router()->target_method()))
+    if(method_exists($this, $method = $this->router()->target_method()))
     {
       $custom_template = $this->$method();
     }
 
     if(method_exists($this, 'conclude'))
-    	$this->conclude();
+      $this->conclude();
 
     if(method_exists($this, 'display'))
-    	$template = $this->display($custom_template);
+      $template = $this->display($custom_template);
   }
 
   public function conclude(){}
@@ -143,16 +143,16 @@ 
 
     $template = $this->find_template($smarty, $custom_template); // throws Exception if nothing found
 
-		$this->viewport('controller', $this);
+    $this->viewport('controller', $this);
 
     $this->viewport('user_messages', $this->logger()->get_user_report());
 
 
-  	$this->viewport('file_root', $this->router()->file_root());
-  	$this->viewport('view_path', $this->router()->file_root() . $this->box('settings.smarty.template_path').'app/');
-  	$this->viewport('web_root', $this->router()->web_root());
-  	$this->viewport('view_url', $this->router()->web_root() . $this->box('settings.smarty.template_path'));
-  	$this->viewport('images_url', $this->router()->web_root() . $this->box('settings.smarty.template_path') . 'images/');
+    $this->viewport('file_root', $this->router()->file_root());
+    $this->viewport('view_path', $this->router()->file_root() . $this->box('settings.smarty.template_path').'app/');
+    $this->viewport('web_root', $this->router()->web_root());
+    $this->viewport('view_url', $this->router()->web_root() . $this->box('settings.smarty.template_path'));
+    $this->viewport('images_url', $this->router()->web_root() . $this->box('settings.smarty.template_path') . 'images/');
 
     foreach($this->viewport() as $template_var_name => $value)
       $smarty->assign($template_var_name, $value);
@@ -227,12 +227,12 @@ 
    *
    */
   public function route_back($route_name=null, $route_params=[]) : string
-	{
+  {
     if(is_null($route_name))
-		  return $this->route_back ?? $this->router()->prehop(RouterInterface::ROUTE_HOME_NAME);
+      return $this->route_back ?? $this->router()->prehop(RouterInterface::ROUTE_HOME_NAME);
 
     return $this->route_back = $this->route_factory($route_name, $route_params);
-	}
+  }
 
   public function route_factory($route_name=null, $route_params=[]) : string
   {

Braces +49 added lines, -33 removed lines

@@ -31,8 +31,9 @@ 
   // shortcut for (un)boxing
   public function box($key, $instance=null)
   {
-    if(!is_null($instance))
-      $this->container->register($key, $instance);
+    if(!is_null($instance)) {
+          $this->container->register($key, $instance);
+    }
 
     // dd($this->container->get($key));
     return $this->container->get($key);
@@ -64,15 +65,18 @@ 
   public function authorize($permission=null)
   {
     // if(!$this->requires_operator() || is_null($permission))
-    if(!$this->requires_operator())
-      return true;
+    if(!$this->requires_operator()) {
+          return true;
+    }
 
     $operator = $this->operator();
-    if(is_null($operator) || $operator->is_new() || !$operator->is_active())
-      throw new AccessRefusedException();
+    if(is_null($operator) || $operator->is_new() || !$operator->is_active()) {
+          throw new AccessRefusedException();
+    }
 
-    if(!is_null($permission) && !$operator->has_permission($permission))
-      throw new AccessRefusedException();
+    if(!is_null($permission) && !$operator->has_permission($permission)) {
+          throw new AccessRefusedException();
+    }
 
     return true;
   }
@@ -80,22 +84,26 @@ 
   public function viewport($key=null, $value=null, $coercion=false)
   {
     // no key, returns all
-    if(is_null($key))
-      return $this->template_variables;
+    if(is_null($key)) {
+          return $this->template_variables;
+    }
 
     // got key, got null value, returns $[$key]
     if(is_null($value))
     {
-      if($coercion === true) // break rule 1 ?
+      if($coercion === true) {
+        // break rule 1 ?
         $this->template_variables[$key] = null;
+      }
 
       return $this->template_variables[$key] ?? null;
     }
 
     // got key, got value
     // sets or coerces $[$key]=$value and returns $[$key]
-    if(!isset($this->template_variables[$key]) || $coercion === true)
-      $this->template_variables[$key] = $value;
+    if(!isset($this->template_variables[$key]) || $coercion === true) {
+          $this->template_variables[$key] = $value;
+    }
 
     return $this->template_variables[$key] ?? null;
   }
@@ -106,19 +114,22 @@ 
 
     $custom_template = null;
 
-    if(method_exists($this, 'prepare'))
-    	$this->prepare();
+    if(method_exists($this, 'prepare')) {
+        	$this->prepare();
+    }
 
   	if(method_exists($this, $method = $this->router()->target_method()))
     {
       $custom_template = $this->$method();
     }
 
-    if(method_exists($this, 'conclude'))
-    	$this->conclude();
+    if(method_exists($this, 'conclude')) {
+        	$this->conclude();
+    }
 
-    if(method_exists($this, 'display'))
-    	$template = $this->display($custom_template);
+    if(method_exists($this, 'display')) {
+        	$template = $this->display($custom_template);
+    }
   }
 
   public function conclude(){}
@@ -133,8 +144,10 @@ 
     array_walk_recursive($_GET, function(&$value){$value = trim($value);});
     array_walk_recursive($_REQUEST, function(&$value){$value = trim($value);});
 
-    if($this->router()->submits())
-      array_walk_recursive($_POST, function(&$value){$value = trim($value);});
+    if($this->router()->submits()) {
+          array_walk_recursive($_POST, function(&$value){$value = trim($value);
+    }
+    });
   }
 
   public function display($custom_template = null, $standalone=false)
@@ -154,14 +167,14 @@ 
   	$this->viewport('view_url', $this->router()->web_root() . $this->box('settings.smarty.template_path'));
   	$this->viewport('images_url', $this->router()->web_root() . $this->box('settings.smarty.template_path') . 'images/');
 
-    foreach($this->viewport() as $template_var_name => $value)
-      $smarty->assign($template_var_name, $value);
+    foreach($this->viewport() as $template_var_name => $value) {
+          $smarty->assign($template_var_name, $value);
+    }
 
     if($standalone === false)
     {
       $smarty->display(sprintf('%s|%s', $this->box('settings.smarty.template_inclusion_path'), $template));
-    }
-    else
+    } else
     {
       $smarty->display($template);
     }
@@ -205,8 +218,9 @@ 
 
     while(!is_null($tpl_path = array_shift($templates)))
     {
-      if($smarty->templateExists($tpl_path))
-        return $tpl_path;
+      if($smarty->templateExists($tpl_path)) {
+              return $tpl_path;
+      }
     }
 
     throw new \Exception('KADRO_ERR_NO_TEMPLATE_TO_DISPLAY');
@@ -228,8 +242,9 @@ 
    */
   public function route_back($route_name=null, $route_params=[]) : string
 	{
-    if(is_null($route_name))
-		  return $this->route_back ?? $this->router()->prehop(RouterInterface::ROUTE_HOME_NAME);
+    if(is_null($route_name)) {
+    		  return $this->route_back ?? $this->router()->prehop(RouterInterface::ROUTE_HOME_NAME);
+    }
 
     return $this->route_back = $this->route_factory($route_name, $route_params);
 	}
@@ -240,10 +255,11 @@ 
 
     if(is_string($route_name) && !empty($route_name))
     {
-      if($this->router()->route_exists($route_name))
-        $route = $this->router()->prehop($route_name, $route_params);
-      else
-        $route = $route_name;
+      if($this->router()->route_exists($route_name)) {
+              $route = $this->router()->prehop($route_name, $route_params);
+      } else {
+              $route = $route_name;
+      }
 
       return $route;
     }

TableToForm.class.php

Braces +37 added lines, -41 removed lines

@@ -9,11 +9,13 @@ 
 {
   private static function compute_field_value($model,$field_name)
   {
-    if(method_exists($model,$field_name))
-      return $model->$field_name();
+    if(method_exists($model,$field_name)) {
+          return $model->$field_name();
+    }
 
-    if(property_exists($model,$field_name))
-      return $model->$field_name;
+    if(property_exists($model,$field_name)) {
+          return $model->$field_name;
+    }
 
     return '';
   }
@@ -51,74 +53,66 @@ 
 
     $table = get_class($model)::table();
 
-    if(is_null($table->column($field_name)))
-      return Form::input($field_name,$field_value,$attributes,$errors);
+    if(is_null($table->column($field_name))) {
+          return Form::input($field_name,$field_value,$attributes,$errors);
+    }
 
     $ret = '';
 
     $field = $table->column($field_name);
 
 
-    if(isset($attributes['required']) && $attributes['required'] === false)
-      unset($attributes['required']);
-
-    elseif(!$field->is_nullable())
-      $attributes[] = 'required';
+    if(isset($attributes['required']) && $attributes['required'] === false) {
+          unset($attributes['required']);
+    } elseif(!$field->is_nullable()) {
+          $attributes[] = 'required';
+    }
 
     if($field->is_auto_incremented())
     {
       $ret .= Form::hidden($field->name(),$field_value);
-    }
-    elseif($field->type()->is_boolean())
+    } elseif($field->type()->is_boolean())
     {
       $option_list = $attributes['values'] ?? [0 => 0, 1 => 1];
       $ret .= Form::select($field->name(), $option_list ,$field_value, $attributes); //
-    }
-    elseif($field->type()->is_integer())
+    } elseif($field->type()->is_integer())
     {
       $ret .= Form::input($field->name(),$field_value,$attributes,$errors);
-    }
-    elseif($field->type()->is_year())
+    } elseif($field->type()->is_year())
     {
       $attributes['size'] = $attributes['maxlength'] = 4;
       $ret .= Form::input($field->name(),$field_value,$attributes,$errors);
-    }
-    elseif($field->type()->is_date())
+    } elseif($field->type()->is_date())
     {
       $ret .= Form::date($field->name(),$field_value,$attributes,$errors);
-    }
-    elseif($field->type()->is_time())
+    } elseif($field->type()->is_time())
     {
       $ret .= Form::time($field->name(),$field_value,$attributes,$errors);
-    }
-    elseif($field->type()->is_datetime())
+    } elseif($field->type()->is_datetime())
     {
       $ret .= Form::datetime($field->name(),$field_value,$attributes,$errors);
-    }
-    elseif($field->type()->is_text())
+    } elseif($field->type()->is_text())
     {
       $ret .= Form::textarea($field->name(),$field_value,$attributes,$errors);
-    }
-    elseif($field->type()->is_enum())
+    } elseif($field->type()->is_enum())
     {
 
       $enum_values = [];
-      foreach($field->type()->enum_values() as $e_val)
-        $enum_values[$e_val] = $e_val;
+      foreach($field->type()->enum_values() as $e_val) {
+              $enum_values[$e_val] = $e_val;
+      }
 
       $selected = $attributes['value'] ?? $field_value ?? '';
       // foreach($field->)
       $ret .= Form::select($field->name(), $enum_values, $selected, $attributes); //
 
       // throw new \Exception('ENUM IS NOT HANDLED BY TableToFom');
-    }
-    elseif($field->type()->is_string())
+    } elseif($field->type()->is_string())
     {
       $max_length = $field->type()->length();
       $attributes['size'] = $attributes['maxlength'] = $max_length;
       $ret .= Form::input($field->name(),$field_value,$attributes,$errors);
-    }
-    else
+    } else
     {
       $ret .= Form::input($field->name(),$field_value,$attributes,$errors);
     }
@@ -130,8 +124,9 @@ 
   public static function field_with_label($model,$field_name,$attributes=[],$errors=[]) : string
   {
     $field_attributes = $attributes;
-    if(isset($attributes['label']))
-      unset($field_attributes['label']);
+    if(isset($attributes['label'])) {
+          unset($field_attributes['label']);
+    }
 
     return sprintf('%s %s', self::label($model,$field_name,$attributes,$errors), self::field($model,$field_name,$field_attributes,$errors));
   }
@@ -148,14 +143,15 @@ 
       $form_field = '';
       if($column->is_auto_incremented())
       {
-        if(!$model->is_new())
-          $form_field = self::field($model,$column_name);
-      }
-      else
+        if(!$model->is_new()) {
+                  $form_field = self::field($model,$column_name);
+        }
+      } else
       {
         $form_field = self::field_with_label($model,$column_name);
-        if(!is_null($group_class))
-          $form_field = new Element('div',$form_field, ['class' => $group_class]);
+        if(!is_null($group_class)) {
+                  $form_field = new Element('div',$form_field, ['class' => $group_class]);
+        }
       }
       $ret .= PHP_EOL.$form_field;
     }

Models/Lingvo.class.php

Indentation +7 added lines, -7 removed lines

@@ -31,10 +31,10 @@ 
     return $this->iso_name().' ('.$this->Part3.')';
   }
 
-	public function traceable() : bool
-	{
-		return false;
-	}
+  public function traceable() : bool
+  {
+    return false;
+  }
 
   public function iso_name()
   {
@@ -102,9 +102,9 @@ 
   public static function search_language($term, $authority=null)
   {
     $rows = self::query_retrieve(['term' => $term, 'requires_authority' => $authority])->ret_ass();
-		$ret = [];
-		foreach($rows as $row)
-		   $ret[$row[self::ISO_3]] = $row[self::ISO_NAME];
+    $ret = [];
+    foreach($rows as $row)
+        $ret[$row[self::ISO_3]] = $row[self::ISO_NAME];
 
     return $ret;
   }

Braces +6 added lines, -3 removed lines

@@ -103,8 +103,9 @@ 
   {
     $rows = self::query_retrieve(['term' => $term, 'requires_authority' => $authority])->ret_ass();
 		$ret = [];
-		foreach($rows as $row)
-		   $ret[$row[self::ISO_3]] = $row[self::ISO_NAME];
+		foreach($rows as $row) {
+				   $ret[$row[self::ISO_3]] = $row[self::ISO_NAME];
+		}
 
     return $ret;
   }
@@ -115,8 +116,10 @@ 
     $Query->aw_eq(self::ISO_3, $code);
     $rows = $Query->ret_col();
 
-    if(isset($rows[0])) // only 1 result
+    if(isset($rows[0])) {
+      // only 1 result
       return current($rows);
+    }
 
     return null; // no results
   }