HeshamMeneisi /
Lumener
| Conditions | 13 |
| Paths | 144 |
| Total Lines | 42 |
| Code Lines | 31 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 59 | public function handle() |
||
| 60 | { |
||
| 61 | $force = $this->option('force', false); |
||
|
1 ignored issue
–
show
|
|||
| 62 | if ($force) { |
||
| 63 | $this->error("Force mode active."); |
||
| 64 | } |
||
| 65 | $current_version = false; |
||
| 66 | try { |
||
| 67 | if (file_exists($this->filename)) { |
||
| 68 | $fn = fopen($this->filename, "r"); |
||
| 69 | for ($i=0; !$current_version && $i < 20 && !feof($fn); $i++) { |
||
| 70 | $line = fgets($fn, 30); |
||
| 71 | preg_match_all("/@version ((\d([\.-]|$))+)/", $line, $m); |
||
| 72 | if (!empty($m[1])) { |
||
| 73 | $current_version = $m[1][0]; |
||
| 74 | } |
||
| 75 | } |
||
| 76 | } |
||
| 77 | } catch (\Throwable $e) { |
||
| 78 | // current_version is false |
||
| 79 | } |
||
| 80 | if ($current_version) { |
||
| 81 | $this->info("Lumener: Current ".$current_version); |
||
| 82 | } else { |
||
| 83 | $this->error("Lumener: Adminer not found."); |
||
| 84 | } |
||
| 85 | $vsource = config( |
||
| 86 | 'lumener.adminer_version', |
||
| 87 | 'https://api.github.com/repos/vrana/adminer/releases/latest' |
||
| 88 | ); |
||
| 89 | if (config('lumener.adminer.version_type', 'url') == 'url') { |
||
| 90 | $version = $this->_getLatestAdminerVersion($vsource); |
||
| 91 | $this->info("Lumener: Latest Adminer Version " . $version); |
||
| 92 | } else { |
||
| 93 | $version = $vsource; |
||
| 94 | $this->info("Lumener: Required Adminer Version " . $version); |
||
| 95 | } |
||
| 96 | if ($force || !file_exists($this->filename) |
||
| 97 | || $version != $current_version) { |
||
| 98 | $this->_downloadVersion($version); |
||
| 99 | } else { |
||
| 100 | $this->info('Lumener: Up to date.'); |
||
| 101 | } |
||
| 174 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths