TournamentGenerator\Traits\WithCategories

Complexity

Total Complexity

4

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	category()	0	4	1
A	addCategory()	0	5	2
A	getCategories()	0	2	1

<?php


namespace TournamentGenerator\Traits;


use TournamentGenerator\Category;
use TournamentGenerator\Interfaces\WithCategories as WithCategoriesInterface;

/**
 * Definitions of methods for objects that contain categories
 *
 * @author  Tomáš Vojík <vojik@wboy.cz>
 * @package TournamentGenerator\Traits
 * @since   0.4
 */
trait WithCategories
{

	/** @var Category[] */
	protected array $categories = [];

	/**
	 * Get all categories
	 *
	 * @return Category[]
	 */
	public function getCategories() : array {
		return $this->categories;
	}


	/**
	 * Add one or more category to object
	 *
	 * @param Category ...$categories Category objects
	 *
	 * @return $this
	 */
	public function addCategory(Category ...$categories) : WithCategoriesInterface {
		foreach ($categories as $category) {
			$this->categories[] = $category;
		}
		return $this;

The expression return $this returns the type TournamentGenerator\Traits\WithCategories which is incompatible with the type-hinted return TournamentGenerator\Interfaces\WithCategories.

	}

	/**
	 * Creates a new category and adds it to the object
	 *
	 * @param string $name New category name
	 * @param null   $id   Id of the new category - if omitted -> it is generated automatically as unique string

Are you sure the doc-type for parameter $id is correct as it would always require null to be passed?

	 *
	 * @return Category New category
	 */
	public function category(string $name = '', $id = null) : Category {
		$c = new Category($name, $id);
		$this->categories[] = $c->setSkip($this->allowSkip);
		return $c;
	}

}