Heroyt / tournament-generator

src/functions.php

Braces +8 added lines, -2 removed lines

@@ -22,7 +22,10 @@ 
 function circle_genGames2(array $teams = [], Group $group = null) {
 	$bracket = []; // ARRAY OF GAMES
 
-	if (count($teams) % 2 != 0) $teams[] = DUMMY_TEAM; // IF NOT EVEN NUMBER OF TEAMS, ADD DUMMY
+	if (count($teams) % 2 != 0) {
+		$teams[] = DUMMY_TEAM;
+	}
+	// IF NOT EVEN NUMBER OF TEAMS, ADD DUMMY
 
 	shuffle($teams); // SHUFFLE TEAMS FOR MORE RANDOMNESS
 
@@ -47,7 +50,10 @@ 
 		$reverse = array_reverse($teams);
 		$away = $reverse[$i];
 
-		if (($home == DUMMY_TEAM || $away == DUMMY_TEAM)) continue; // SKIP WHEN DUMMY_TEAM IS PRESENT
+		if (($home == DUMMY_TEAM || $away == DUMMY_TEAM)) {
+			continue;
+		}
+		// SKIP WHEN DUMMY_TEAM IS PRESENT
 
 		$bracket[] = new Game([$home, $away], $group);
 

src/classes/tournament_presets/class_doubleElim.php

Braces +18 added lines, -10 removed lines

@@ -15,7 +15,9 @@ 
 
 		$countTeams = count($this->getTeams());
 
-		if ($countTeams < 3) throw new \Exception('Double elimination is possible for minimum of 3 teams - '.$countTeams.' teams given.');
+		if ($countTeams < 3) {
+			throw new \Exception('Double elimination is possible for minimum of 3 teams - '.$countTeams.' teams given.');
+		}
 
 
 		// CALCULATE BYES
@@ -79,15 +81,19 @@ 
 					if ($r === 2) { // FIRST LOSING ROUND
 						$previousGroups[2*($g-1)]->progression($group, 1, 1); // PROGRESS FROM STARTING GROUP
 						$previousGroups[(2*($g-1))+1]->progression($group, 1, 1); // PROGREESS FROM STARTING GROUP
-					}
-					elseif ($losingGroupTeamsCount >= 2) {
+					} elseif ($losingGroupTeamsCount >= 2) {
 						$previousLosingGroups[$g-1]->progression($group, 0, 1); // PROGRESS FROM LOSING GROUP BEFORE
-						if (isset(array_reverse($previousGroups)[$g-1])) array_reverse($previousGroups)[$g-1]->progression($group, 1, 1); // PROGREESS FROM WINNING GROUP BEFORE
-						else $previousLosingGroups[$g]->progression($group, 0, 1); // PROGRESS OTHER TEAM FROM LOSING GROUP BEEFORE
+						if (isset(array_reverse($previousGroups)[$g-1])) {
+							array_reverse($previousGroups)[$g-1]->progression($group, 1, 1);
+						}
+						// PROGREESS FROM WINNING GROUP BEFORE
+						else {
+							$previousLosingGroups[$g]->progression($group, 0, 1);
+						}
+						// PROGRESS OTHER TEAM FROM LOSING GROUP BEEFORE
 					}
 				}
-			}
-			else { // IF THE NUMBER OF TEAMS IS NOT A POWER OF 2, GENERATE GROUPS WITH BYES
+			} else { // IF THE NUMBER OF TEAMS IS NOT A POWER OF 2, GENERATE GROUPS WITH BYES
 				// LOOK FOR THE CLOSEST LOWER POWER OF 2
 				$losingByes = $losingGroupTeamsCount-bindec(str_pad(1, strlen(decbin($losingGroupTeamsCount)), 0, STR_PAD_RIGHT));
 				$n = (floor(count($previousLosingGroups)/2)+$losingByes);
@@ -111,10 +117,12 @@ 
 					if (in_array($g, $byesGroupsNums) && isset($previousGroups[$byesProgressed])) { // EMPTY GROUP FROM BYE
 						$previousGroups[$byesProgressed]->progression($group, 1, 1); // PROGRESS FROM WINNING GROUP BEFORE
 						$byesProgressed++;
-					}
-					else {
+					} else {
 						$previousLosingGroups[$lastGroup]->progression($group, 0, 1); // PROGRESS FROM LOSING GROUP BEFORE
-						if (isset($previousLosingGroups[$lastGroup + 1])) $previousLosingGroups[$lastGroup + 1]->progression($group, 0, 1); // PROGREESS FROM LOSING GROUP BEFORE
+						if (isset($previousLosingGroups[$lastGroup + 1])) {
+							$previousLosingGroups[$lastGroup + 1]->progression($group, 0, 1);
+						}
+						// PROGREESS FROM LOSING GROUP BEFORE
 						$lastGroup += 2;
 					}
 				}

src/classes/tournament_presets/class_2R2G.php

Braces +3 added lines, -1 removed lines

@@ -12,7 +12,9 @@
 
 	public function generate() {
 
-		if (count($this->getTeams()) === 0) throw new \Exception('Couldn\'t generate 2R2G tournament because there are no teams in the tournament.');
+		if (count($this->getTeams()) === 0) {
+			throw new \Exception('Couldn\'t generate 2R2G tournament because there are no teams in the tournament.');
+		}
 
 
 		$round1 = $this->round('Round 1');

src/classes/class_round.php

Braces +32 added lines, -13 removed lines

@@ -27,8 +27,11 @@ 
 
 	public function addGroup(Group ...$groups){
 		foreach ($groups as $group) {
-			if ($group instanceof Group) $this->groups[] = $group;
-			else throw new \Exception('Trying to add group which is not an instance of Group class.');
+			if ($group instanceof Group) {
+				$this->groups[] = $group;
+			} else {
+				throw new \Exception('Trying to add group which is not an instance of Group class.');
+			}
 		}
 		return $this;
 	}
@@ -78,7 +81,9 @@ 
 		while ($g > 0) {
 			foreach ($games as $key => $group) {
 				$this->games[] = array_shift($games[$key]);
-				if (count($games[$key]) === 0) unset($games[$key]);
+				if (count($games[$key]) === 0) {
+					unset($games[$key]);
+				}
 				$g--;
 			}
 		}
@@ -89,7 +94,9 @@ 
 	}
 	public function isPlayed(){
 		foreach ($this->groups as $group) {
-			if (!$group->isPlayed()) return false;
+			if (!$group->isPlayed()) {
+				return false;
+			}
 		}
 		return true;
 	}
@@ -98,10 +105,11 @@ 
 		foreach ($teams as $team) {
 			if ($team instanceof Team)  {
 				$this->teams[] = $team;
-			}
-			elseif (gettype($team) === 'array') {
+			} elseif (gettype($team) === 'array') {
 				foreach ($team as $team2) {
-					if ($team2 instanceof Team) $this->teams[] = $team2;
+					if ($team2 instanceof Team) {
+						$this->teams[] = $team2;
+					}
 					$team2->groupResults[$this->id] = [
 						'group' => $this,
 						'points' => 0,
@@ -113,8 +121,9 @@ 
 						'third'  => 0
 					];
 				}
+			} else {
+				throw new \Exception('Trying to add team which is not an instance of Team class');
 			}
-			else throw new \Exception('Trying to add team which is not an instance of Team class');
 		}
 		return $this;
 	}
@@ -124,7 +133,9 @@ 
 		return $t;
 	}
 	public function getTeams() {
-		if (count($this->teams) > 0) return $this->teams;
+		if (count($this->teams) > 0) {
+			return $this->teams;
+		}
 		$teams = [];
 		foreach ($this->groups as $group) {
 			$teams = array_merge($teams, $group->getTeams());
@@ -135,7 +146,9 @@ 
 
 	public function splitTeams(...$groups) {
 
-		if (count($groups) === 0) $groups = $this->getGroups();
+		if (count($groups) === 0) {
+			$groups = $this->getGroups();
+		}
 
 		foreach ($groups as $key => $value) {
 			if (gettype($value) === 'array') {
@@ -150,7 +163,9 @@ 
 		while (count($teams) > 0) {
 			foreach ($groups as $group) {
 				if ($group instanceof Group) {
-					if (count($teams) > 0) $group->addTeam(array_shift($teams));
+					if (count($teams) > 0) {
+						$group->addTeam(array_shift($teams));
+					}
 				}
 			}
 		}
@@ -165,7 +180,9 @@ 
 	}
 
 	public function progressBlank(){
-		if (!$this->isPlayed()) $this->simulate();
+		if (!$this->isPlayed()) {
+			$this->simulate();
+		}
 		foreach ($this->groups as $group) {
 			$group->progressBlank();
 		}
@@ -174,7 +191,9 @@ 
 
 	public function simulate() {
 		foreach ($this->groups as $group) {
-			if ($group->isPlayed()) continue;
+			if ($group->isPlayed()) {
+				continue;
+			}
 			$group->simulate([], false);
 		}
 		return $this;

src/classes/class_teamFilter.php

Braces +44 added lines, -21 removed lines

@@ -46,11 +46,19 @@ 
 	private $groups = [];
 
 	function __construct(string $what = 'points', string $how = '>', $val = 0, $groups = []){
-		if (in_array(strtolower($what), ['points', 'score', 'wins', 'draws', 'losses', 'second', 'third', 'team', 'notprogressed', 'progressed'])) $this->what = strtolower($what);
-		if (in_array($how, ['>', '<', '>=', '<=', '=', '!='])) $this->how = $how;
-		if ((gettype($val) === 'integer' && strtolower($what) !== 'team') || ($val instanceof Team && strtolower($what) === 'team')) $this->val = $val;
+		if (in_array(strtolower($what), ['points', 'score', 'wins', 'draws', 'losses', 'second', 'third', 'team', 'notprogressed', 'progressed'])) {
+			$this->what = strtolower($what);
+		}
+		if (in_array($how, ['>', '<', '>=', '<=', '=', '!='])) {
+			$this->how = $how;
+		}
+		if ((gettype($val) === 'integer' && strtolower($what) !== 'team') || ($val instanceof Team && strtolower($what) === 'team')) {
+			$this->val = $val;
+		}
 		foreach ($groups as $group) {
-			if ($group instanceof Group) $this->groups[] =  $group->id;
+			if ($group instanceof Group) {
+				$this->groups[] =  $group->id;
+			}
 		}
 	}
 	public function __toString() {
@@ -58,37 +66,54 @@ 
 	}
 
 	public function validate(Team $team, $groupsId, string $operation = 'sum', Group $from = null) {
-		if (count($this->groups) > 0) $groupsId = array_unique(array_merge($this->groups, (gettype($groupsId) === 'array' ? $groupsId : [$groupsId])), SORT_REGULAR);
+		if (count($this->groups) > 0) {
+			$groupsId = array_unique(array_merge($this->groups, (gettype($groupsId) === 'array' ? $groupsId : [$groupsId])), SORT_REGULAR);
+		}
 		if ($this->what == 'team') {
 			switch ($this->how) {
 				case '=':
-					if ($this->val === $team) return true;
+					if ($this->val === $team) {
+						return true;
+					}
 					break;
 				case '!=':
-					if ($this->val !== $team) return true;
+					if ($this->val !== $team) {
+						return true;
+					}
 					break;
 			}
 			return false;
-		}
-		elseif ($this->what == 'notprogressed') {
-			if ($from === null) throw new \Exception('Group $from was not defined.');
+		} elseif ($this->what == 'notprogressed') {
+			if ($from === null) {
+				throw new \Exception('Group $from was not defined.');
+			}
 			return !$from->progressed($team);
-		}
-		elseif ($this->what == 'progressed') {
-			if ($from === null) throw new \Exception('Group $from was not defined.');
+		} elseif ($this->what == 'progressed') {
+			if ($from === null) {
+				throw new \Exception('Group $from was not defined.');
+			}
 			return $from->progressed($team);
 		}
-		if (gettype($groupsId) === 'array' && !in_array(strtolower($operation), ['sum', 'avg', 'max', 'min'])) throw new \Exception('Unknown operation of '.$operation.'. Only "sum", "avg", "min", "max" possible.');
+		if (gettype($groupsId) === 'array' && !in_array(strtolower($operation), ['sum', 'avg', 'max', 'min'])) {
+			throw new \Exception('Unknown operation of '.$operation.'. Only "sum", "avg", "min", "max" possible.');
+		}
 		$comp = 0;
 		if (gettype($groupsId) === 'array' && count($groupsId) > 0) {
 			$sum = 0;
 			$max = null;
 			$min = null;
 			foreach ($groupsId as $id) {
-				if (!isset($team->groupResults[$id])) continue; // IF TEAM DIDN'T PLAY IN THAT GROUP -> SKIP
+				if (!isset($team->groupResults[$id])) {
+					continue;
+				}
+				// IF TEAM DIDN'T PLAY IN THAT GROUP -> SKIP
 				$sum += $team->groupResults[$id][$this->what];
-				if ($team->groupResults[$id][$this->what] > $max || $max === null) $max = $team->groupResults[$id][$this->what];
-				if ($team->groupResults[$id][$this->what] < $min || $min === null) $min = $team->groupResults[$id][$this->what];
+				if ($team->groupResults[$id][$this->what] > $max || $max === null) {
+					$max = $team->groupResults[$id][$this->what];
+				}
+				if ($team->groupResults[$id][$this->what] < $min || $min === null) {
+					$min = $team->groupResults[$id][$this->what];
+				}
 			}
 			switch (strtolower($operation)) {
 				case 'sum':
@@ -104,11 +129,9 @@ 
 					$comp = $min;
 					break;
 			}
-		}
-		elseif (gettype($groupsId) === 'string' && isset($team->groupResults[$groupsId])) {
+		} elseif (gettype($groupsId) === 'string' && isset($team->groupResults[$groupsId])) {
 			$comp = $team->groupResults[$groupsId][$this->what];
-		}
-		else {
+		} else {
 			throw new \Exception("Couldn't find group of id ".print_r($groupsId, true));
 		}
 

src/classes/class_category.php

Braces +20 added lines, -9 removed lines

@@ -23,8 +23,11 @@ 
 
 	public function addRound(Round ...$rounds){
 		foreach ($rounds as $round) {
-			if ($round instanceof Round) $this->rounds[] = $round;
-			else throw new \Exception('Trying to add round which is not an instance of Round class.');
+			if ($round instanceof Round) {
+				$this->rounds[] = $round;
+			} else {
+				throw new \Exception('Trying to add round which is not an instance of Round class.');
+			}
 		}
 		return $this;
 	}
@@ -57,13 +60,15 @@ 
 		foreach ($teams as $team) {
 			if ($team instanceof Team)  {
 				$this->teams[] = $team;
-			}
-			elseif (gettype($team) === 'array') {
+			} elseif (gettype($team) === 'array') {
 				foreach ($team as $team2) {
-					if ($team2 instanceof Team) $this->teams[] = $team2;
+					if ($team2 instanceof Team) {
+						$this->teams[] = $team2;
+					}
 				}
+			} else {
+				throw new \Exception('Trying to add team which is not an instance of Team class');
 			}
-			else throw new \Exception('Trying to add team which is not an instance of Team class');
 		}
 		return $this;
 	}
@@ -73,7 +78,9 @@ 
 		return $t;
 	}
 	public function getTeams() {
-		if (count($this->teams) > 0) return $this->teams;
+		if (count($this->teams) > 0) {
+			return $this->teams;
+		}
 		$teams = [];
 		foreach ($this->rounds as $round) {
 			$teams = array_merge($teams, $round->getTeams());
@@ -92,7 +99,9 @@ 
 
 	public function splitTeams(...$rounds) {
 
-		if (count($rounds) === 0) $rounds = $this->getRounds();
+		if (count($rounds) === 0) {
+			$rounds = $this->getRounds();
+		}
 
 		$teams = $this->getTeams();
 		shuffle($teams);
@@ -112,7 +121,9 @@ 
 
 	public function genGamesSimulate() {
 		$games = [];
-		if (count($this->rounds) <= 0) throw new \Exception('There are no rounds to simulate games from.');
+		if (count($this->rounds) <= 0) {
+			throw new \Exception('There are no rounds to simulate games from.');
+		}
 		foreach ($this->rounds as $round) {
 			$games = array_merge($games, $round->genGames());
 			$round->simulate()->progressBlank()->resetGames();

src/classes/class_progression.php

Braces +13 added lines, -5 removed lines

@@ -29,7 +29,9 @@ 
 
 	public function addFilter(...$filters) {
 		foreach ($filters as $filter) {
-			if (!$filter instanceof TeamFilter) throw new \Exception('Trying to add filter which is not an instance of TeamFilter.');
+			if (!$filter instanceof TeamFilter) {
+				throw new \Exception('Trying to add filter which is not an instance of TeamFilter.');
+			}
 			$this->filters[] = $filter;
 		}
 		return $this;
@@ -37,8 +39,11 @@ 
 
 	public function progress() {
 		$teams = $this->from->sortTeams($this->filters);
-		if (count($this->filters) === 0 || $this->len !== null || $this->start !== 0) $next = array_splice($teams, $this->start, ($this->len === null ? count($teams) : $this->len));
-		else $next = $teams;
+		if (count($this->filters) === 0 || $this->len !== null || $this->start !== 0) {
+			$next = array_splice($teams, $this->start, ($this->len === null ? count($teams) : $this->len));
+		} else {
+			$next = $teams;
+		}
 		$this->from->addProgressed($next);
 		$this->to->addTeam($next);
 		return $this;
@@ -46,8 +51,11 @@ 
 
 	public function progressBlank(){
 		$teams = $this->from->isPlayed() ? $this->from->sortTeams($this->filters) : $this->from->simulate($this->filters);
-		if (count($this->filters) === 0 || $this->len !== null || $this->start !== 0) $next = array_splice($teams, $this->start, ($this->len === null ? count($teams) : $this->len));
-		else $next = $teams;
+		if (count($this->filters) === 0 || $this->len !== null || $this->start !== 0) {
+			$next = array_splice($teams, $this->start, ($this->len === null ? count($teams) : $this->len));
+		} else {
+			$next = $teams;
+		}
 		$this->from->addProgressed($next);
 		$i = 1;
 		foreach ($next as $team) {

src/classes/class_group.php

Braces +147 added lines, -69 removed lines

@@ -33,27 +33,40 @@ 
 		foreach ($settings as $key => $value) {
 			switch ($key) {
 				case 'name':
-					if (gettype($value) !== 'string') throw new \Exception('Expected string as group name '.gettype($value).' given');
+					if (gettype($value) !== 'string') {
+						throw new \Exception('Expected string as group name '.gettype($value).' given');
+					}
 					$this->name = $value;
 					break;
 				case 'type':
-					if (!in_array($value, groupTypes)) throw new \Exception('Unknown group type: '.$value);
+					if (!in_array($value, groupTypes)) {
+						throw new \Exception('Unknown group type: '.$value);
+					}
 					$this->type = $value;
 					break;
 				case 'ordering':
-					if (!in_array($value, orderingTypes)) throw new \Exception('Unknown group ordering: '.$value);
+					if (!in_array($value, orderingTypes)) {
+						throw new \Exception('Unknown group ordering: '.$value);
+					}
 					$this->ordering = $value;
 					break;
 				case 'inGame':
-					if (gettype($value) !== 'integer') throw new \Exception('Expected integer as inGame '.gettype($value).' given');
-					else if ($value < 2 || $value > 4) throw new \Exception('Expected 2,3 or 4 as inGame '.$value.' given');
+					if (gettype($value) !== 'integer') {
+						throw new \Exception('Expected integer as inGame '.gettype($value).' given');
+					} else if ($value < 2 || $value > 4) {
+						throw new \Exception('Expected 2,3 or 4 as inGame '.$value.' given');
+					}
 					$this->inGame = $value;
 					break;
 				case 'maxSize':
-					if (gettype($value) === 'integer') $this->maxSize = $value;
+					if (gettype($value) === 'integer') {
+						$this->maxSize = $value;
+					}
 					break;
 				case 'order':
-					if (gettype($value) === 'integer') $this->order = $value;
+					if (gettype($value) === 'integer') {
+						$this->order = $value;
+					}
 					break;
 			}
 		}
@@ -92,10 +105,11 @@ 
 					'second' => 0,
 					'third'  => 0
 				];
-			}
-			elseif (gettype($team) === 'array') {
+			} elseif (gettype($team) === 'array') {
 				foreach ($team as $team2) {
-					if ($team2 instanceof Team) $this->teams[] = $team2;
+					if ($team2 instanceof Team) {
+						$this->teams[] = $team2;
+					}
 					$team2->groupResults[$this->id] = [
 						'group' => $this,
 						'points' => 0,
@@ -107,16 +121,20 @@ 
 						'third'  => 0
 					];
 				}
+			} else {
+				throw new \Exception('Trying to add team which is not an instance of Team class');
 			}
-			else throw new \Exception('Trying to add team which is not an instance of Team class');
 		}
 		return $this;
 	}
 	public function getTeams($filters = []) {
 		$teams = $this->teams;
 
-		if (gettype($filters) !== 'array' && $filters instanceof TeamFilter) $filters = [$filters];
-		elseif (gettype($filters) !== 'array') $filters = [];
+		if (gettype($filters) !== 'array' && $filters instanceof TeamFilter) {
+			$filters = [$filters];
+		} elseif (gettype($filters) !== 'array') {
+			$filters = [];
+		}
 
 		// APPLY FILTERS
 		foreach ($filters as $key => $filter) {
@@ -124,27 +142,31 @@ 
 				switch (strtolower($key)) {
 					case 'and':
 						foreach ($teams as $tkey => $team) {
-							if (!$this->filterAnd($team, $filter)) unset($teams[$tkey]); // IF FILTER IS NOT VALIDATED REMOVE TEAM FROM RETURN ARRAY
+							if (!$this->filterAnd($team, $filter)) {
+								unset($teams[$tkey]);
+							}
+							// IF FILTER IS NOT VALIDATED REMOVE TEAM FROM RETURN ARRAY
 						}
 						break;
 					case 'or':
 						foreach ($teams as $tkey => $team) {
-							if (!$this->filterOr($team, $filter)) unset($teams[$tkey]); // IF FILTER IS NOT VALIDATED REMOVE TEAM FROM RETURN ARRAY
+							if (!$this->filterOr($team, $filter)) {
+								unset($teams[$tkey]);
+							}
+							// IF FILTER IS NOT VALIDATED REMOVE TEAM FROM RETURN ARRAY
 						}
 						break;
 					default:
 						throw new \Exception('Unknown opperand type "'.$key.'". Expected "and" or "or".');
 						break;
 				}
-			}
-			elseif ($filter instanceof TeamFilter) {
+			} elseif ($filter instanceof TeamFilter) {
 				foreach ($teams as $tkey => $team) {
 					if (!$filter->validate($team, $this->id, 'sum', $this)) {
 						unset($teams[$tkey]); // IF FILTER IS NOT VALIDATED REMOVE TEAM FROM RETURN ARRAY
 					}
 				}
-			}
-			else {
+			} else {
 				throw new \Exception('Filer ['.$key.'] is not an instance of TeamFilter class');
 			}
 		}
@@ -155,20 +177,24 @@ 
 			if (gettype($value) === 'array') {
 				switch (strtolower($key)) {
 					case 'and':
-						if ($this->filterAnd($team, $value)) return false;
+						if ($this->filterAnd($team, $value)) {
+							return false;
+						}
 						break;
 					case 'or':
-						if ($this->filterOr($team, $value)) return false;
+						if ($this->filterOr($team, $value)) {
+							return false;
+						}
 						break;
 					default:
 						throw new \Exception('Unknown opperand type "'.$key.'". Expected "and" or "or".');
 						break;
 				}
-			}
-			elseif ($value instanceof TeamFilter) {
-				if (!$value->validate($team, $this->id, 'sum', $this)) return false;
-			}
-			else {
+			} elseif ($value instanceof TeamFilter) {
+				if (!$value->validate($team, $this->id, 'sum', $this)) {
+					return false;
+				}
+			} else {
 				throw new \Exception('Filer ['.$key.'] is not an instance of TeamFilter class');
 			}
 		}
@@ -179,20 +205,24 @@ 
 			if (gettype($value) === 'array') {
 				switch (strtolower($key)) {
 					case 'and':
-						if ($this->filterAnd($team, $value)) return true;
+						if ($this->filterAnd($team, $value)) {
+							return true;
+						}
 						break;
 					case 'or':
-						if ($this->filterOr($team, $value)) return true;
+						if ($this->filterOr($team, $value)) {
+							return true;
+						}
 						break;
 					default:
 						throw new \Exception('Unknown opperand type "'.$key.'". Expected "and" or "or".');
 						break;
 				}
-			}
-			elseif ($value instanceof TeamFilter) {
-				if (!$value->validate($team, $this->id, 'sum', $this)) return true;
-			}
-			else {
+			} elseif ($value instanceof TeamFilter) {
+				if (!$value->validate($team, $this->id, 'sum', $this)) {
+					return true;
+				}
+			} else {
 				throw new \Exception('Filer ['.$key.'] is not an instance of TeamFilter class');
 			}
 		}
@@ -214,16 +244,22 @@ 
 		return $t;
 	}
 	public function setType(string $type = R_R) {
-		if (in_array($type, groupTypes)) $this->type = $type;
-		else throw new \Exception('Unknown group type: '.$type);
+		if (in_array($type, groupTypes)) {
+			$this->type = $type;
+		} else {
+			throw new \Exception('Unknown group type: '.$type);
+		}
 		return $this;
 	}
 	public function getType() {
 		return $this->type;
 	}
 	public function setOrdering(string $ordering = POINTS) {
-		if (in_array($ordering, orderingTypes)) $this->ordering = $ordering;
-		else throw new \Exception('Unknown group ordering: '.$ordering);
+		if (in_array($ordering, orderingTypes)) {
+			$this->ordering = $ordering;
+		} else {
+			throw new \Exception('Unknown group ordering: '.$ordering);
+		}
 		return $this;
 	}
 	public function getOrdering() {
@@ -233,14 +269,20 @@ 
 		switch ($this->ordering) {
 			case POINTS:{
 				usort($this->teams, function($a, $b) {
-					if ($a->groupResults[$this->id]["points"] === $b->groupResults[$this->id]["points"] && $a->groupResults[$this->id]["score"] === $b->groupResults[$this->id]["score"]) return 0;
-					if ($a->groupResults[$this->id]["points"] === $b->groupResults[$this->id]["points"]) return ($a->groupResults[$this->id]["score"] > $b->groupResults[$this->id]["score"] ? -1 : 1);
+					if ($a->groupResults[$this->id]["points"] === $b->groupResults[$this->id]["points"] && $a->groupResults[$this->id]["score"] === $b->groupResults[$this->id]["score"]) {
+						return 0;
+					}
+					if ($a->groupResults[$this->id]["points"] === $b->groupResults[$this->id]["points"]) {
+						return ($a->groupResults[$this->id]["score"] > $b->groupResults[$this->id]["score"] ? -1 : 1);
+					}
 					return ($a->groupResults[$this->id]["points"] > $b->groupResults[$this->id]["points"] ? -1 : 1);
 				});
 				break;}
 			case SCORE:{
 				usort($this->teams, function($a, $b) {
-					if ($a->groupResults[$this->id]["score"] === $b->groupResults[$this->id]["score"]) return 0;
+					if ($a->groupResults[$this->id]["score"] === $b->groupResults[$this->id]["score"]) {
+						return 0;
+					}
 					return ($a->groupResults[$this->id]["score"] > $b->groupResults[$this->id]["score"] ? -1 : 1);
 				});
 				break;}
@@ -249,10 +291,14 @@ 
 	}
 	public function setInGame(int $inGame) {
 		if (gettype($inGame) === 'integer') {
-			if ($inGame === 2 || $inGame === 3 || $inGame === 4) $this->inGame = $inGame;
-			else throw new \Exception('Expected 2,3 or 4 as inGame '.$inGame.' given');
+			if ($inGame === 2 || $inGame === 3 || $inGame === 4) {
+				$this->inGame = $inGame;
+			} else {
+				throw new \Exception('Expected 2,3 or 4 as inGame '.$inGame.' given');
+			}
+		} else {
+			throw new \Exception('Expected integer as inGame '.gettype($inGame).' given');
 		}
-		else throw new \Exception('Expected integer as inGame '.gettype($inGame).' given');
 	}
 	public function getInGame() {
 		return $this->inGame;
@@ -280,16 +326,13 @@ 
 		foreach ($teams as $team) {
 			if ($team instanceOf Team) {
 				$this->progressed[] = $team->id;
-			}
-			elseif (gettype($team) === 'string' || gettype($team) === 'integer') {
+			} elseif (gettype($team) === 'string' || gettype($team) === 'integer') {
 				$this->progressed[] = $team;
-			}
-			elseif (gettype($team) === 'array') {
+			} elseif (gettype($team) === 'array') {
 				foreach ($team as $teamInner) {
 					if ($teamInner instanceOf Team) {
 						$this->progressed[] = $teamInner->id;
-					}
-					elseif (gettype($teamInner) === 'string' || gettype($teamInner) === 'integer') {
+					} elseif (gettype($teamInner) === 'string' || gettype($teamInner) === 'integer') {
 						$this->progressed[] = $teamInner;
 					}
 				}
@@ -325,7 +368,9 @@ 
 					$this->game($tInGame);
 				}
 
-				if (count($discard) > 0 && !$this->allowSkip) throw new \Exception('Couldn\'t make games with all teams. Expected k*'.$this->inGame.' teams '.$count.' teams given - discarting '.count($discard).' teams ('.implode(', ', $discard).') in group '.$this.' - allow skip '.($this->allowSkip ? 'True' : 'False'));
+				if (count($discard) > 0 && !$this->allowSkip) {
+					throw new \Exception('Couldn\'t make games with all teams. Expected k*'.$this->inGame.' teams '.$count.' teams given - discarting '.count($discard).' teams ('.implode(', ', $discard).') in group '.$this.' - allow skip '.($this->allowSkip ? 'True' : 'False'));
+				}
 				break;
 			case COND_SPLIT:
 				$games = [];
@@ -341,12 +386,15 @@ 
 					while ($g > 0) {
 						foreach ($games as $key => $group) {
 							$this->games[] = array_shift($games[$key]);
-							if (count($games[$key]) === 0) unset($games[$key]);
+							if (count($games[$key]) === 0) {
+								unset($games[$key]);
+							}
 							$g--;
 						}
 					}
+				} else {
+					$this->games = $this->r_rGames();
 				}
-				else $this->games = $this->r_rGames();
 				break;
 		}
 		return $this->games;
@@ -358,8 +406,11 @@ 
 	}
 	public function addGame(Game ...$games){
 		foreach ($games as $game) {
-			if ($game instanceof Game) $this->games[] = $game;
-			else throw new \Exception('Trying to add game which is not instance of Game object.');
+			if ($game instanceof Game) {
+				$this->games[] = $game;
+			} else {
+				throw new \Exception('Trying to add game which is not instance of Game object.');
+			}
 		}
 		return $this;
 	}
@@ -387,21 +438,30 @@ 
 				$teams[$team->id] = 0;
 			}
 			foreach (end($this->games)->getTeams() as $team) {
-				if (!isset($teams[$team->id])) $teams[$team->id] = 4;
-				else $teams[$team->id] += 4;
+				if (!isset($teams[$team->id])) {
+					$teams[$team->id] = 4;
+				} else {
+					$teams[$team->id] += 4;
+				}
 			}
 			$g = prev($this->games);
 			if ($g instanceof Game) {
 				foreach ($g->getTeams() as $team) {
-					if (!isset($teams[$team->id])) $teams[$team->id] = 2;
-					else $teams[$team->id] += 2;
+					if (!isset($teams[$team->id])) {
+						$teams[$team->id] = 2;
+					} else {
+						$teams[$team->id] += 2;
+					}
 				}
 			}
 			$g = prev($this->games);
 			if ($g instanceof Game) {
 				foreach ($g->getTeams() as $team) {
-					if (!isset($teams[$team->id])) $teams[$team->id] = 1;
-					else $teams[$team->id]++;
+					if (!isset($teams[$team->id])) {
+						$teams[$team->id] = 1;
+					} else {
+						$teams[$team->id]++;
+					}
 				}
 			}
 
@@ -423,7 +483,9 @@ 
 					break;
 				}
 			}
-			if ($found) continue;
+			if ($found) {
+				continue;
+			}
 
 			// CYCLE 2
 			// ! TEAM WHICH PLAYED IN LAST TWO GAMES (NOT 6 or 7)
@@ -444,7 +506,9 @@ 
 					break;
 				}
 			}
-			if ($found) continue;
+			if ($found) {
+				continue;
+			}
 
 			// CYCLE 3
 			// ! TEAM WHICH PLAYED IN LAST THREE GAMES (NOT 7)
@@ -475,7 +539,9 @@ 
 					break;
 				}
 			}
-			if ($found) continue;
+			if ($found) {
+				continue;
+			}
 
 			// CYCLE 4
 			// ! TEAM WHICH PLAYED IN LAST THREE GAMES (NOT 7)
@@ -496,7 +562,9 @@ 
 					break;
 				}
 			}
-			if ($found) continue;
+			if ($found) {
+				continue;
+			}
 
 			// CYCLE 5
 			// TEAMS THAT DIDN'T PLAY IN LAST GAME WILL PLAY THIS GAME (< 4)
@@ -521,7 +589,9 @@ 
 					break;
 				}
 			}
-			if ($found) continue;
+			if ($found) {
+				continue;
+			}
 
 			// CYCLE 6
 			// FIRST AVAILABLE GAME
@@ -532,7 +602,9 @@ 
 	}
 	public function r_rGames(array $teams = []) {
 		$games = [];
-		if (count($teams) === 0) $teams = $this->teams;
+		if (count($teams) === 0) {
+			$teams = $this->teams;
+		}
 		switch ($this->inGame) {
 			case 2:
 				$games = circle_genGames2($teams, $this);
@@ -580,7 +652,9 @@ 
 			$game->setResults($results);
 		}
 		$return = $this->sortTeams($filters);
-		if (!$reset) return $return;
+		if (!$reset) {
+			return $return;
+		}
 		foreach ($this->getGames() as $game) {
 			$game->resetResults();
 		}
@@ -588,13 +662,17 @@ 
 	}
 	public function resetGames() {
 		foreach ($this->getGames() as $game) {
-			if (isset($game)) $game->resetResults();
+			if (isset($game)) {
+				$game->resetResults();
+			}
 		}
 		return $this;
 	}
 	public function isPlayed(){
 		foreach ($this->games as $game) {
-			if ((isset($game) || !$this->getSkip()) && !$game->isPlayed()) return false;
+			if ((isset($game) || !$this->getSkip()) && !$game->isPlayed()) {
+				return false;
+			}
 		}
 		return true;
 	}

src/classes/class_team.php

Braces +30 added lines, -10 removed lines

@@ -44,70 +44,90 @@
 	}
 
 	public function addWin(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] += $this->groupResults[$groupId]['group']->winPoints;
 		$this->sumPoints += $this->groupResults[$groupId]['group']->winPoints;
 		$this->groupResults[$groupId]['wins']++;
 		return $this;
 	}
 	public function removeWin(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] -= $this->groupResults[$groupId]['group']->winPoints;
 		$this->sumPoints -= $this->groupResults[$groupId]['group']->winPoints;
 		$this->groupResults[$groupId]['wins']--;
 		return $this;
 	}
 	public function addDraw(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] += $this->groupResults[$groupId]['group']->drawPoints;
 		$this->sumPoints += $this->groupResults[$groupId]['group']->drawPoints;
 		$this->groupResults[$groupId]['draws']++;
 		return $this;
 	}
 	public function removeDraw(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] -= $this->groupResults[$groupId]['group']->drawPointsPoints;
 		$this->sumPoints -= $this->groupResults[$groupId]['group']->drawPoints;
 		$this->groupResults[$groupId]['draws']--;
 		return $this;
 	}
 	public function addLoss(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] += $this->groupResults[$groupId]['group']->lostPoints;
 		$this->sumPoints += $this->groupResults[$groupId]['group']->lostPoints;
 		$this->groupResults[$groupId]['losses']++;
 		return $this;
 	}
 	public function removeLoss(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] -= $this->groupResults[$groupId]['group']->lostPoints;
 		$this->sumPoints -= $this->groupResults[$groupId]['group']->lostPoints;
 		$this->groupResults[$groupId]['losses']--;
 		return $this;
 	}
 	public function addSecond(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] += $this->groupResults[$groupId]['group']->secondPoints;
 		$this->sumPoints += $this->groupResults[$groupId]['group']->secondPoints;
 		$this->groupResults[$groupId]['second']++;
 		return $this;
 	}
 	public function removeSecond(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] -= $this->groupResults[$groupId]['group']->secondPoints;
 		$this->sumPoints -= $this->groupResults[$groupId]['group']->secondPoints;
 		$this->groupResults[$groupId]['second']--;
 		return $this;
 	}
 	public function addThird(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] += $this->groupResults[$groupId]['group']->thirdPoints;
 		$this->sumPoints += $this->groupResults[$groupId]['group']->thirdPoints;
 		$this->groupResults[$groupId]['third']++;
 		return $this;
 	}
 	public function removeThird(string $groupId = ''){
-		if (!isset($this->groupResults[$groupId])) throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		if (!isset($this->groupResults[$groupId])) {
+			throw new \Exception('Group '.$groupId.' is not set for this team ('.$this->name.')');
+		}
 		$this->groupResults[$groupId]['points'] -= $this->groupResults[$groupId]['group']->thirdPoints;
 		$this->sumPoints -= $this->groupResults[$groupId]['group']->thirdPoints;
 		$this->groupResults[$groupId]['third']--;