Validator::validate() - Code Metrics - Inspection of ":tada: add .scrutinizer .yml" - HavenShen/slim-born - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( bab0de...1a0dda )

by Haven

created 2017-03-23 02:44 UTC

Validator::validate() A

↳ Parent: Validator

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	2

<?php 

namespace App\Validation;

use Respect\Validation\Validator as Respect;
use Respect\Validation\Exceptions\NestedValidationException;

/**
* 
*/
class Validator
{
	protected $errors;
	
	public function validate($request,array $rules)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		foreach ($rules as $field => $rule) {
			try {
				$rule->setName(ucfirst($field))->assert($request->getParam($field));
			} catch (NestedValidationException $e) {
				$this->errors[$field] = $e->getMessages();
			}
			
		}

		$_SESSION['errors'] = $this->errors;
		return $this;
	}

	public function failed()
	{
		return !empty($this->errors);
	}
}

1			<?php
2
3			namespace App\Validation;
4
5			use Respect\Validation\Validator as Respect;
6			use Respect\Validation\Exceptions\NestedValidationException;
7
8			/**
9			*
10			*/
11			class Validator
12			{
13			protected $errors;
14
15			public function validate($request,array $rules)
			0 ignored issues – show Coding Style introduced 2017-03-23 02:54 UTC by Report Bug Copy Issue Report `validate` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
16			{
17			foreach ($rules as $field => $rule) {
18			try {
19			$rule->setName(ucfirst($field))->assert($request->getParam($field));
20			} catch (NestedValidationException $e) {
21			$this->errors[$field] = $e->getMessages();
22			}
23
24			}
25
26			$_SESSION['errors'] = $this->errors;
27			return $this;
28			}
29
30			public function failed()
31			{
32			return !empty($this->errors);
33			}
34			}

HavenShen / slim-born

GitHub Access Token became invalid

Push — master ( bab0de...1a0dda )

Validator::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like