ValidationErrorsMiddleware - Code Metrics - Inspection of ":tada: add .scrutinizer .yml" - HavenShen/slim-born - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( bab0de...1a0dda )

by Haven

created 2017-03-23 02:44 UTC

ValidationErrorsMiddleware A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	14
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	1
dl	14
loc	14
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	10	10	2

How to fix Duplicated Code

<?php

namespace App\Middleware;

/**
* 
*/
class ValidationErrorsMiddleware extends Middleware

{
	
	public function __invoke($request,$response,$next)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		// var_dump(isset($_SESSION['errors']));die();

		$this->container->view->getEnvironment()->addGlobal('errors',isset($_SESSION['errors']) ? $_SESSION['errors'] : '');
		unset($_SESSION['errors']);

		$response = $next($request,$response);
		return $response;
		
	}
}

1		<?php
2
3		namespace App\Middleware;
4
5		/**
6		*
7		*/
8	View Code Duplication	class ValidationErrorsMiddleware extends Middleware
		0 ignored issues – show Duplication introduced 2017-03-23 02:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10
11		public function __invoke($request,$response,$next)
		0 ignored issues – show Coding Style introduced 2017-03-23 02:54 UTC by Report Bug Copy Issue Report `__invoke` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
12		{
13		// var_dump(isset($_SESSION['errors']));die();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-23 02:54 UTC by Report Bug Copy Issue Report `88%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
14		$this->container->view->getEnvironment()->addGlobal('errors',isset($_SESSION['errors']) ? $_SESSION['errors'] : '');
15		unset($_SESSION['errors']);
16
17		$response = $next($request,$response);
18		return $response;
19
20		}
21		}

HavenShen / slim-born

GitHub Access Token became invalid

Push — master ( bab0de...1a0dda )

ValidationErrorsMiddleware A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like