Harborn-digital /
timechimp-bundle
| Conditions | 67 |
| Paths | > 20000 |
| Total Lines | 92 |
| Code Lines | 71 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 4556 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 34 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 35 | { |
||
| 36 | if (!is_object($data)) { |
||
| 37 | return null; |
||
| 38 | } |
||
| 39 | $object = new \ConnectHolland\TimechimpBundle\Api\Model\User(); |
||
| 40 | if (property_exists($data, 'id') && $data->{'id'} !== null) { |
||
| 41 | $object->setId($data->{'id'}); |
||
| 42 | } elseif (property_exists($data, 'id') && $data->{'id'} === null) { |
||
| 43 | $object->setId(null); |
||
| 44 | } |
||
| 45 | if (property_exists($data, 'userName') && $data->{'userName'} !== null) { |
||
| 46 | $object->setUserName($data->{'userName'}); |
||
| 47 | } elseif (property_exists($data, 'userName') && $data->{'userName'} === null) { |
||
| 48 | $object->setUserName(null); |
||
| 49 | } |
||
| 50 | if (property_exists($data, 'displayName') && $data->{'displayName'} !== null) { |
||
| 51 | $object->setDisplayName($data->{'displayName'}); |
||
| 52 | } elseif (property_exists($data, 'displayName') && $data->{'displayName'} === null) { |
||
| 53 | $object->setDisplayName(null); |
||
| 54 | } |
||
| 55 | if (property_exists($data, 'accountType') && $data->{'accountType'} !== null) { |
||
| 56 | $object->setAccountType($data->{'accountType'}); |
||
| 57 | } elseif (property_exists($data, 'accountType') && $data->{'accountType'} === null) { |
||
| 58 | $object->setAccountType(null); |
||
| 59 | } |
||
| 60 | if (property_exists($data, 'isLocked') && $data->{'isLocked'} !== null) { |
||
| 61 | $object->setIsLocked($data->{'isLocked'}); |
||
| 62 | } elseif (property_exists($data, 'isLocked') && $data->{'isLocked'} === null) { |
||
| 63 | $object->setIsLocked(null); |
||
| 64 | } |
||
| 65 | if (property_exists($data, 'picture') && $data->{'picture'} !== null) { |
||
| 66 | $object->setPicture($data->{'picture'}); |
||
| 67 | } elseif (property_exists($data, 'picture') && $data->{'picture'} === null) { |
||
| 68 | $object->setPicture(null); |
||
| 69 | } |
||
| 70 | if (property_exists($data, 'tagNames') && $data->{'tagNames'} !== null) { |
||
| 71 | $values = []; |
||
| 72 | foreach ($data->{'tagNames'} as $value) { |
||
| 73 | $values[] = $value; |
||
| 74 | } |
||
| 75 | $object->setTagNames($values); |
||
| 76 | } elseif (property_exists($data, 'tagNames') && $data->{'tagNames'} === null) { |
||
| 77 | $object->setTagNames(null); |
||
| 78 | } |
||
| 79 | if (property_exists($data, 'language') && $data->{'language'} !== null) { |
||
| 80 | $object->setLanguage($data->{'language'}); |
||
| 81 | } elseif (property_exists($data, 'language') && $data->{'language'} === null) { |
||
| 82 | $object->setLanguage(null); |
||
| 83 | } |
||
| 84 | if (property_exists($data, 'contractHours') && $data->{'contractHours'} !== null) { |
||
| 85 | $object->setContractHours($data->{'contractHours'}); |
||
| 86 | } elseif (property_exists($data, 'contractHours') && $data->{'contractHours'} === null) { |
||
| 87 | $object->setContractHours(null); |
||
| 88 | } |
||
| 89 | if (property_exists($data, 'contractHourlyRate') && $data->{'contractHourlyRate'} !== null) { |
||
| 90 | $object->setContractHourlyRate($data->{'contractHourlyRate'}); |
||
| 91 | } elseif (property_exists($data, 'contractHourlyRate') && $data->{'contractHourlyRate'} === null) { |
||
| 92 | $object->setContractHourlyRate(null); |
||
| 93 | } |
||
| 94 | if (property_exists($data, 'contractCostHourlyRate') && $data->{'contractCostHourlyRate'} !== null) { |
||
| 95 | $object->setContractCostHourlyRate($data->{'contractCostHourlyRate'}); |
||
| 96 | } elseif (property_exists($data, 'contractCostHourlyRate') && $data->{'contractCostHourlyRate'} === null) { |
||
| 97 | $object->setContractCostHourlyRate(null); |
||
| 98 | } |
||
| 99 | if (property_exists($data, 'contractStartDate') && $data->{'contractStartDate'} !== null) { |
||
| 100 | $object->setContractStartDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'contractStartDate'})); |
||
|
Bug
introduced
by
|
|||
| 101 | } elseif (property_exists($data, 'contractStartDate') && $data->{'contractStartDate'} === null) { |
||
| 102 | $object->setContractStartDate(null); |
||
| 103 | } |
||
| 104 | if (property_exists($data, 'contractEndDate') && $data->{'contractEndDate'} !== null) { |
||
| 105 | $object->setContractEndDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'contractEndDate'})); |
||
| 106 | } elseif (property_exists($data, 'contractEndDate') && $data->{'contractEndDate'} === null) { |
||
| 107 | $object->setContractEndDate(null); |
||
| 108 | } |
||
| 109 | if (property_exists($data, 'created') && $data->{'created'} !== null) { |
||
| 110 | $object->setCreated(\DateTime::createFromFormat('Y-m-d\\TH:i:s.v', $data->{'created'})); |
||
| 111 | } elseif (property_exists($data, 'created') && $data->{'created'} === null) { |
||
| 112 | $object->setCreated(null); |
||
| 113 | } |
||
| 114 | if (property_exists($data, 'teamName') && $data->{'teamName'} !== null) { |
||
| 115 | $object->setTeamName($data->{'teamName'}); |
||
| 116 | } elseif (property_exists($data, 'teamName') && $data->{'teamName'} === null) { |
||
| 117 | $object->setTeamName(null); |
||
| 118 | } |
||
| 119 | if (property_exists($data, 'employeeNumber') && $data->{'employeeNumber'} !== null) { |
||
| 120 | $object->setEmployeeNumber($data->{'employeeNumber'}); |
||
| 121 | } elseif (property_exists($data, 'employeeNumber') && $data->{'employeeNumber'} === null) { |
||
| 122 | $object->setEmployeeNumber(null); |
||
| 123 | } |
||
| 124 | |||
| 125 | return $object; |
||
| 126 | } |
||
| 219 |
Loading history...