Harborn-digital /
timechimp-bundle
| Conditions | 34 |
| Paths | 6562 |
| Total Lines | 48 |
| Code Lines | 36 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 1190 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 34 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 35 | { |
||
| 36 | if (!is_object($data)) { |
||
| 37 | return null; |
||
| 38 | } |
||
| 39 | $object = new \ConnectHolland\TimechimpBundle\Api\Model\ProjectSubscription(); |
||
| 40 | if (property_exists($data, 'id') && $data->{'id'} !== null) { |
||
| 41 | $object->setId($data->{'id'}); |
||
| 42 | } elseif (property_exists($data, 'id') && $data->{'id'} === null) { |
||
| 43 | $object->setId(null); |
||
| 44 | } |
||
| 45 | if (property_exists($data, 'frequency') && $data->{'frequency'} !== null) { |
||
| 46 | $object->setFrequency($data->{'frequency'}); |
||
| 47 | } elseif (property_exists($data, 'frequency') && $data->{'frequency'} === null) { |
||
| 48 | $object->setFrequency(null); |
||
| 49 | } |
||
| 50 | if (property_exists($data, 'startDate') && $data->{'startDate'} !== null) { |
||
| 51 | $object->setStartDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'startDate'})); |
||
|
Bug
introduced
by
|
|||
| 52 | } elseif (property_exists($data, 'startDate') && $data->{'startDate'} === null) { |
||
| 53 | $object->setStartDate(null); |
||
| 54 | } |
||
| 55 | if (property_exists($data, 'endDate') && $data->{'endDate'} !== null) { |
||
| 56 | $object->setEndDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'endDate'})); |
||
| 57 | } elseif (property_exists($data, 'endDate') && $data->{'endDate'} === null) { |
||
| 58 | $object->setEndDate(null); |
||
| 59 | } |
||
| 60 | if (property_exists($data, 'description') && $data->{'description'} !== null) { |
||
| 61 | $object->setDescription($data->{'description'}); |
||
| 62 | } elseif (property_exists($data, 'description') && $data->{'description'} === null) { |
||
| 63 | $object->setDescription(null); |
||
| 64 | } |
||
| 65 | if (property_exists($data, 'code') && $data->{'code'} !== null) { |
||
| 66 | $object->setCode($data->{'code'}); |
||
| 67 | } elseif (property_exists($data, 'code') && $data->{'code'} === null) { |
||
| 68 | $object->setCode(null); |
||
| 69 | } |
||
| 70 | if (property_exists($data, 'amount') && $data->{'amount'} !== null) { |
||
| 71 | $object->setAmount($data->{'amount'}); |
||
| 72 | } elseif (property_exists($data, 'amount') && $data->{'amount'} === null) { |
||
| 73 | $object->setAmount(null); |
||
| 74 | } |
||
| 75 | if (property_exists($data, 'rate') && $data->{'rate'} !== null) { |
||
| 76 | $object->setRate($data->{'rate'}); |
||
| 77 | } elseif (property_exists($data, 'rate') && $data->{'rate'} === null) { |
||
| 78 | $object->setRate(null); |
||
| 79 | } |
||
| 80 | |||
| 81 | return $object; |
||
| 82 | } |
||
| 131 |
Loading history...