Harborn-digital /
timechimp-bundle
| Conditions | 142 |
| Paths | 1 |
| Total Lines | 194 |
| Code Lines | 152 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 20306 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 34 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 35 | { |
||
| 36 | if (!is_object($data)) { |
||
| 37 | return null; |
||
| 38 | } |
||
| 39 | $object = new \ConnectHolland\TimechimpBundle\Api\Model\Project(); |
||
| 40 | if (property_exists($data, 'remainingBudgetHours') && $data->{'remainingBudgetHours'} !== null) { |
||
| 41 | $object->setRemainingBudgetHours($data->{'remainingBudgetHours'}); |
||
| 42 | } elseif (property_exists($data, 'remainingBudgetHours') && $data->{'remainingBudgetHours'} === null) { |
||
| 43 | $object->setRemainingBudgetHours(null); |
||
| 44 | } |
||
| 45 | if (property_exists($data, 'tagIds') && $data->{'tagIds'} !== null) { |
||
| 46 | $values = []; |
||
| 47 | foreach ($data->{'tagIds'} as $value) { |
||
| 48 | $values[] = $value; |
||
| 49 | } |
||
| 50 | $object->setTagIds($values); |
||
| 51 | } elseif (property_exists($data, 'tagIds') && $data->{'tagIds'} === null) { |
||
| 52 | $object->setTagIds(null); |
||
| 53 | } |
||
| 54 | if (property_exists($data, 'tagNames') && $data->{'tagNames'} !== null) { |
||
| 55 | $values_1 = []; |
||
| 56 | foreach ($data->{'tagNames'} as $value_1) { |
||
| 57 | $values_1[] = $value_1; |
||
| 58 | } |
||
| 59 | $object->setTagNames($values_1); |
||
| 60 | } elseif (property_exists($data, 'tagNames') && $data->{'tagNames'} === null) { |
||
| 61 | $object->setTagNames(null); |
||
| 62 | } |
||
| 63 | if (property_exists($data, 'unspecified') && $data->{'unspecified'} !== null) { |
||
| 64 | $object->setUnspecified($data->{'unspecified'}); |
||
| 65 | } elseif (property_exists($data, 'unspecified') && $data->{'unspecified'} === null) { |
||
| 66 | $object->setUnspecified(null); |
||
| 67 | } |
||
| 68 | if (property_exists($data, 'invoiceDate') && $data->{'invoiceDate'} !== null) { |
||
| 69 | $object->setInvoiceDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'invoiceDate'})); |
||
|
Bug
introduced
by
|
|||
| 70 | } elseif (property_exists($data, 'invoiceDate') && $data->{'invoiceDate'} === null) { |
||
| 71 | $object->setInvoiceDate(null); |
||
| 72 | } |
||
| 73 | if (property_exists($data, 'invoiceInInstallments') && $data->{'invoiceInInstallments'} !== null) { |
||
| 74 | $object->setInvoiceInInstallments($data->{'invoiceInInstallments'}); |
||
| 75 | } elseif (property_exists($data, 'invoiceInInstallments') && $data->{'invoiceInInstallments'} === null) { |
||
| 76 | $object->setInvoiceInInstallments(null); |
||
| 77 | } |
||
| 78 | if (property_exists($data, 'budgetNotificationPercentage') && $data->{'budgetNotificationPercentage'} !== null) { |
||
| 79 | $object->setBudgetNotificationPercentage($data->{'budgetNotificationPercentage'}); |
||
| 80 | } elseif (property_exists($data, 'budgetNotificationPercentage') && $data->{'budgetNotificationPercentage'} === null) { |
||
| 81 | $object->setBudgetNotificationPercentage(null); |
||
| 82 | } |
||
| 83 | if (property_exists($data, 'budgetNotificationHasBeenSent') && $data->{'budgetNotificationHasBeenSent'} !== null) { |
||
| 84 | $object->setBudgetNotificationHasBeenSent($data->{'budgetNotificationHasBeenSent'}); |
||
| 85 | } elseif (property_exists($data, 'budgetNotificationHasBeenSent') && $data->{'budgetNotificationHasBeenSent'} === null) { |
||
| 86 | $object->setBudgetNotificationHasBeenSent(null); |
||
| 87 | } |
||
| 88 | if (property_exists($data, 'clientId') && $data->{'clientId'} !== null) { |
||
| 89 | $object->setClientId($data->{'clientId'}); |
||
| 90 | } elseif (property_exists($data, 'clientId') && $data->{'clientId'} === null) { |
||
| 91 | $object->setClientId(null); |
||
| 92 | } |
||
| 93 | if (property_exists($data, 'invoiceStatus') && $data->{'invoiceStatus'} !== null) { |
||
| 94 | $object->setInvoiceStatus($data->{'invoiceStatus'}); |
||
| 95 | } elseif (property_exists($data, 'invoiceStatus') && $data->{'invoiceStatus'} === null) { |
||
| 96 | $object->setInvoiceStatus(null); |
||
| 97 | } |
||
| 98 | if (property_exists($data, 'invoiceId') && $data->{'invoiceId'} !== null) { |
||
| 99 | $object->setInvoiceId($data->{'invoiceId'}); |
||
| 100 | } elseif (property_exists($data, 'invoiceId') && $data->{'invoiceId'} === null) { |
||
| 101 | $object->setInvoiceId(null); |
||
| 102 | } |
||
| 103 | if (property_exists($data, 'color') && $data->{'color'} !== null) { |
||
| 104 | $object->setColor($data->{'color'}); |
||
| 105 | } elseif (property_exists($data, 'color') && $data->{'color'} === null) { |
||
| 106 | $object->setColor(null); |
||
| 107 | } |
||
| 108 | if (property_exists($data, 'visibleOnSchedule') && $data->{'visibleOnSchedule'} !== null) { |
||
| 109 | $object->setVisibleOnSchedule($data->{'visibleOnSchedule'}); |
||
| 110 | } elseif (property_exists($data, 'visibleOnSchedule') && $data->{'visibleOnSchedule'} === null) { |
||
| 111 | $object->setVisibleOnSchedule(null); |
||
| 112 | } |
||
| 113 | if (property_exists($data, 'externalUrl') && $data->{'externalUrl'} !== null) { |
||
| 114 | $object->setExternalUrl($data->{'externalUrl'}); |
||
| 115 | } elseif (property_exists($data, 'externalUrl') && $data->{'externalUrl'} === null) { |
||
| 116 | $object->setExternalUrl(null); |
||
| 117 | } |
||
| 118 | if (property_exists($data, 'externalName') && $data->{'externalName'} !== null) { |
||
| 119 | $object->setExternalName($data->{'externalName'}); |
||
| 120 | } elseif (property_exists($data, 'externalName') && $data->{'externalName'} === null) { |
||
| 121 | $object->setExternalName(null); |
||
| 122 | } |
||
| 123 | if (property_exists($data, 'invoiceReference') && $data->{'invoiceReference'} !== null) { |
||
| 124 | $object->setInvoiceReference($data->{'invoiceReference'}); |
||
| 125 | } elseif (property_exists($data, 'invoiceReference') && $data->{'invoiceReference'} === null) { |
||
| 126 | $object->setInvoiceReference(null); |
||
| 127 | } |
||
| 128 | if (property_exists($data, 'projectTasks') && $data->{'projectTasks'} !== null) { |
||
| 129 | $values_2 = []; |
||
| 130 | foreach ($data->{'projectTasks'} as $value_2) { |
||
| 131 | $values_2[] = $this->denormalizer->denormalize($value_2, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\ProjectTask', 'json', $context); |
||
| 132 | } |
||
| 133 | $object->setProjectTasks($values_2); |
||
| 134 | } elseif (property_exists($data, 'projectTasks') && $data->{'projectTasks'} === null) { |
||
| 135 | $object->setProjectTasks(null); |
||
| 136 | } |
||
| 137 | if (property_exists($data, 'projectUsers') && $data->{'projectUsers'} !== null) { |
||
| 138 | $values_3 = []; |
||
| 139 | foreach ($data->{'projectUsers'} as $value_3) { |
||
| 140 | $values_3[] = $this->denormalizer->denormalize($value_3, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\ProjectUser', 'json', $context); |
||
| 141 | } |
||
| 142 | $object->setProjectUsers($values_3); |
||
| 143 | } elseif (property_exists($data, 'projectUsers') && $data->{'projectUsers'} === null) { |
||
| 144 | $object->setProjectUsers(null); |
||
| 145 | } |
||
| 146 | if (property_exists($data, 'id') && $data->{'id'} !== null) { |
||
| 147 | $object->setId($data->{'id'}); |
||
| 148 | } elseif (property_exists($data, 'id') && $data->{'id'} === null) { |
||
| 149 | $object->setId(null); |
||
| 150 | } |
||
| 151 | if (property_exists($data, 'active') && $data->{'active'} !== null) { |
||
| 152 | $object->setActive($data->{'active'}); |
||
| 153 | } elseif (property_exists($data, 'active') && $data->{'active'} === null) { |
||
| 154 | $object->setActive(null); |
||
| 155 | } |
||
| 156 | if (property_exists($data, 'customerId') && $data->{'customerId'} !== null) { |
||
| 157 | $object->setCustomerId($data->{'customerId'}); |
||
| 158 | } elseif (property_exists($data, 'customerId') && $data->{'customerId'} === null) { |
||
| 159 | $object->setCustomerId(null); |
||
| 160 | } |
||
| 161 | if (property_exists($data, 'customerName') && $data->{'customerName'} !== null) { |
||
| 162 | $object->setCustomerName($data->{'customerName'}); |
||
| 163 | } elseif (property_exists($data, 'customerName') && $data->{'customerName'} === null) { |
||
| 164 | $object->setCustomerName(null); |
||
| 165 | } |
||
| 166 | if (property_exists($data, 'name') && $data->{'name'} !== null) { |
||
| 167 | $object->setName($data->{'name'}); |
||
| 168 | } elseif (property_exists($data, 'name') && $data->{'name'} === null) { |
||
| 169 | $object->setName(null); |
||
| 170 | } |
||
| 171 | if (property_exists($data, 'code') && $data->{'code'} !== null) { |
||
| 172 | $object->setCode($data->{'code'}); |
||
| 173 | } elseif (property_exists($data, 'code') && $data->{'code'} === null) { |
||
| 174 | $object->setCode(null); |
||
| 175 | } |
||
| 176 | if (property_exists($data, 'notes') && $data->{'notes'} !== null) { |
||
| 177 | $object->setNotes($data->{'notes'}); |
||
| 178 | } elseif (property_exists($data, 'notes') && $data->{'notes'} === null) { |
||
| 179 | $object->setNotes(null); |
||
| 180 | } |
||
| 181 | if (property_exists($data, 'invoiceMethod') && $data->{'invoiceMethod'} !== null) { |
||
| 182 | $object->setInvoiceMethod($data->{'invoiceMethod'}); |
||
| 183 | } elseif (property_exists($data, 'invoiceMethod') && $data->{'invoiceMethod'} === null) { |
||
| 184 | $object->setInvoiceMethod(null); |
||
| 185 | } |
||
| 186 | if (property_exists($data, 'hourlyRate') && $data->{'hourlyRate'} !== null) { |
||
| 187 | $object->setHourlyRate($data->{'hourlyRate'}); |
||
| 188 | } elseif (property_exists($data, 'hourlyRate') && $data->{'hourlyRate'} === null) { |
||
| 189 | $object->setHourlyRate(null); |
||
| 190 | } |
||
| 191 | if (property_exists($data, 'rate') && $data->{'rate'} !== null) { |
||
| 192 | $object->setRate($data->{'rate'}); |
||
| 193 | } elseif (property_exists($data, 'rate') && $data->{'rate'} === null) { |
||
| 194 | $object->setRate(null); |
||
| 195 | } |
||
| 196 | if (property_exists($data, 'budgetMethod') && $data->{'budgetMethod'} !== null) { |
||
| 197 | $object->setBudgetMethod($data->{'budgetMethod'}); |
||
| 198 | } elseif (property_exists($data, 'budgetMethod') && $data->{'budgetMethod'} === null) { |
||
| 199 | $object->setBudgetMethod(null); |
||
| 200 | } |
||
| 201 | if (property_exists($data, 'budgetRate') && $data->{'budgetRate'} !== null) { |
||
| 202 | $object->setBudgetRate($data->{'budgetRate'}); |
||
| 203 | } elseif (property_exists($data, 'budgetRate') && $data->{'budgetRate'} === null) { |
||
| 204 | $object->setBudgetRate(null); |
||
| 205 | } |
||
| 206 | if (property_exists($data, 'budgetHours') && $data->{'budgetHours'} !== null) { |
||
| 207 | $object->setBudgetHours($data->{'budgetHours'}); |
||
| 208 | } elseif (property_exists($data, 'budgetHours') && $data->{'budgetHours'} === null) { |
||
| 209 | $object->setBudgetHours(null); |
||
| 210 | } |
||
| 211 | if (property_exists($data, 'startDate') && $data->{'startDate'} !== null) { |
||
| 212 | $object->setStartDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'startDate'})); |
||
| 213 | } elseif (property_exists($data, 'startDate') && $data->{'startDate'} === null) { |
||
| 214 | $object->setStartDate(null); |
||
| 215 | } |
||
| 216 | if (property_exists($data, 'endDate') && $data->{'endDate'} !== null) { |
||
| 217 | $object->setEndDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'endDate'})); |
||
| 218 | } elseif (property_exists($data, 'endDate') && $data->{'endDate'} === null) { |
||
| 219 | $object->setEndDate(null); |
||
| 220 | } |
||
| 221 | if (property_exists($data, 'projectSubscription') && $data->{'projectSubscription'} !== null) { |
||
| 222 | $object->setProjectSubscription($this->denormalizer->denormalize($data->{'projectSubscription'}, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\ProjectSubscription', 'json', $context)); |
||
| 223 | } elseif (property_exists($data, 'projectSubscription') && $data->{'projectSubscription'} === null) { |
||
| 224 | $object->setProjectSubscription(null); |
||
| 225 | } |
||
| 226 | |||
| 227 | return $object; |
||
| 228 | } |
||
| 423 |
Loading history...