Harborn-digital /
timechimp-bundle
| Conditions | 111 |
| Total Lines | 147 |
| Code Lines | 115 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 12432 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 34 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 35 | { |
||
| 36 | if (!is_object($data)) { |
||
| 37 | return null; |
||
| 38 | } |
||
| 39 | $object = new \ConnectHolland\TimechimpBundle\Api\Model\Invoice(); |
||
| 40 | if (property_exists($data, 'id') && $data->{'id'} !== null) { |
||
| 41 | $object->setId($data->{'id'}); |
||
| 42 | } elseif (property_exists($data, 'id') && $data->{'id'} === null) { |
||
| 43 | $object->setId(null); |
||
| 44 | } |
||
| 45 | if (property_exists($data, 'clientId') && $data->{'clientId'} !== null) { |
||
| 46 | $object->setClientId($data->{'clientId'}); |
||
| 47 | } elseif (property_exists($data, 'clientId') && $data->{'clientId'} === null) { |
||
| 48 | $object->setClientId(null); |
||
| 49 | } |
||
| 50 | if (property_exists($data, 'companyInvoicePrefix') && $data->{'companyInvoicePrefix'} !== null) { |
||
| 51 | $object->setCompanyInvoicePrefix($data->{'companyInvoicePrefix'}); |
||
| 52 | } elseif (property_exists($data, 'companyInvoicePrefix') && $data->{'companyInvoicePrefix'} === null) { |
||
| 53 | $object->setCompanyInvoicePrefix(null); |
||
| 54 | } |
||
| 55 | if (property_exists($data, 'companyInvoiceId') && $data->{'companyInvoiceId'} !== null) { |
||
| 56 | $object->setCompanyInvoiceId($data->{'companyInvoiceId'}); |
||
| 57 | } elseif (property_exists($data, 'companyInvoiceId') && $data->{'companyInvoiceId'} === null) { |
||
| 58 | $object->setCompanyInvoiceId(null); |
||
| 59 | } |
||
| 60 | if (property_exists($data, 'customerId') && $data->{'customerId'} !== null) { |
||
| 61 | $object->setCustomerId($data->{'customerId'}); |
||
| 62 | } elseif (property_exists($data, 'customerId') && $data->{'customerId'} === null) { |
||
| 63 | $object->setCustomerId(null); |
||
| 64 | } |
||
| 65 | if (property_exists($data, 'status') && $data->{'status'} !== null) { |
||
| 66 | $object->setStatus($data->{'status'}); |
||
| 67 | } elseif (property_exists($data, 'status') && $data->{'status'} === null) { |
||
| 68 | $object->setStatus(null); |
||
| 69 | } |
||
| 70 | if (property_exists($data, 'customerRelationId') && $data->{'customerRelationId'} !== null) { |
||
| 71 | $object->setCustomerRelationId($data->{'customerRelationId'}); |
||
| 72 | } elseif (property_exists($data, 'customerRelationId') && $data->{'customerRelationId'} === null) { |
||
| 73 | $object->setCustomerRelationId(null); |
||
| 74 | } |
||
| 75 | if (property_exists($data, 'customerName') && $data->{'customerName'} !== null) { |
||
| 76 | $object->setCustomerName($data->{'customerName'}); |
||
| 77 | } elseif (property_exists($data, 'customerName') && $data->{'customerName'} === null) { |
||
| 78 | $object->setCustomerName(null); |
||
| 79 | } |
||
| 80 | if (property_exists($data, 'customerContactPerson') && $data->{'customerContactPerson'} !== null) { |
||
| 81 | $object->setCustomerContactPerson($data->{'customerContactPerson'}); |
||
| 82 | } elseif (property_exists($data, 'customerContactPerson') && $data->{'customerContactPerson'} === null) { |
||
| 83 | $object->setCustomerContactPerson(null); |
||
| 84 | } |
||
| 85 | if (property_exists($data, 'customerEmail') && $data->{'customerEmail'} !== null) { |
||
| 86 | $object->setCustomerEmail($data->{'customerEmail'}); |
||
| 87 | } elseif (property_exists($data, 'customerEmail') && $data->{'customerEmail'} === null) { |
||
| 88 | $object->setCustomerEmail(null); |
||
| 89 | } |
||
| 90 | if (property_exists($data, 'customerAddress') && $data->{'customerAddress'} !== null) { |
||
| 91 | $object->setCustomerAddress($data->{'customerAddress'}); |
||
| 92 | } elseif (property_exists($data, 'customerAddress') && $data->{'customerAddress'} === null) { |
||
| 93 | $object->setCustomerAddress(null); |
||
| 94 | } |
||
| 95 | if (property_exists($data, 'customerVatNumber') && $data->{'customerVatNumber'} !== null) { |
||
| 96 | $object->setCustomerVatNumber($data->{'customerVatNumber'}); |
||
| 97 | } elseif (property_exists($data, 'customerVatNumber') && $data->{'customerVatNumber'} === null) { |
||
| 98 | $object->setCustomerVatNumber(null); |
||
| 99 | } |
||
| 100 | if (property_exists($data, 'date') && $data->{'date'} !== null) { |
||
| 101 | $object->setDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'date'})); |
||
|
Bug
introduced
by
|
|||
| 102 | } elseif (property_exists($data, 'date') && $data->{'date'} === null) { |
||
| 103 | $object->setDate(null); |
||
| 104 | } |
||
| 105 | if (property_exists($data, 'dueDate') && $data->{'dueDate'} !== null) { |
||
| 106 | $object->setDueDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'dueDate'})); |
||
| 107 | } elseif (property_exists($data, 'dueDate') && $data->{'dueDate'} === null) { |
||
| 108 | $object->setDueDate(null); |
||
| 109 | } |
||
| 110 | if (property_exists($data, 'reference') && $data->{'reference'} !== null) { |
||
| 111 | $object->setReference($data->{'reference'}); |
||
| 112 | } elseif (property_exists($data, 'reference') && $data->{'reference'} === null) { |
||
| 113 | $object->setReference(null); |
||
| 114 | } |
||
| 115 | if (property_exists($data, 'notes') && $data->{'notes'} !== null) { |
||
| 116 | $object->setNotes($data->{'notes'}); |
||
| 117 | } elseif (property_exists($data, 'notes') && $data->{'notes'} === null) { |
||
| 118 | $object->setNotes(null); |
||
| 119 | } |
||
| 120 | if (property_exists($data, 'total') && $data->{'total'} !== null) { |
||
| 121 | $object->setTotal($data->{'total'}); |
||
| 122 | } elseif (property_exists($data, 'total') && $data->{'total'} === null) { |
||
| 123 | $object->setTotal(null); |
||
| 124 | } |
||
| 125 | if (property_exists($data, 'totalWithoutExchangeRate') && $data->{'totalWithoutExchangeRate'} !== null) { |
||
| 126 | $object->setTotalWithoutExchangeRate($data->{'totalWithoutExchangeRate'}); |
||
| 127 | } elseif (property_exists($data, 'totalWithoutExchangeRate') && $data->{'totalWithoutExchangeRate'} === null) { |
||
| 128 | $object->setTotalWithoutExchangeRate(null); |
||
| 129 | } |
||
| 130 | if (property_exists($data, 'totalExTax') && $data->{'totalExTax'} !== null) { |
||
| 131 | $object->setTotalExTax($data->{'totalExTax'}); |
||
| 132 | } elseif (property_exists($data, 'totalExTax') && $data->{'totalExTax'} === null) { |
||
| 133 | $object->setTotalExTax(null); |
||
| 134 | } |
||
| 135 | if (property_exists($data, 'totalExTaxWithoutExchangeRate') && $data->{'totalExTaxWithoutExchangeRate'} !== null) { |
||
| 136 | $object->setTotalExTaxWithoutExchangeRate($data->{'totalExTaxWithoutExchangeRate'}); |
||
| 137 | } elseif (property_exists($data, 'totalExTaxWithoutExchangeRate') && $data->{'totalExTaxWithoutExchangeRate'} === null) { |
||
| 138 | $object->setTotalExTaxWithoutExchangeRate(null); |
||
| 139 | } |
||
| 140 | if (property_exists($data, 'additionalNotes') && $data->{'additionalNotes'} !== null) { |
||
| 141 | $object->setAdditionalNotes($data->{'additionalNotes'}); |
||
| 142 | } elseif (property_exists($data, 'additionalNotes') && $data->{'additionalNotes'} === null) { |
||
| 143 | $object->setAdditionalNotes(null); |
||
| 144 | } |
||
| 145 | if (property_exists($data, 'internNotes') && $data->{'internNotes'} !== null) { |
||
| 146 | $object->setInternNotes($data->{'internNotes'}); |
||
| 147 | } elseif (property_exists($data, 'internNotes') && $data->{'internNotes'} === null) { |
||
| 148 | $object->setInternNotes(null); |
||
| 149 | } |
||
| 150 | if (property_exists($data, 'currency') && $data->{'currency'} !== null) { |
||
| 151 | $object->setCurrency($data->{'currency'}); |
||
| 152 | } elseif (property_exists($data, 'currency') && $data->{'currency'} === null) { |
||
| 153 | $object->setCurrency(null); |
||
| 154 | } |
||
| 155 | if (property_exists($data, 'language') && $data->{'language'} !== null) { |
||
| 156 | $object->setLanguage($data->{'language'}); |
||
| 157 | } elseif (property_exists($data, 'language') && $data->{'language'} === null) { |
||
| 158 | $object->setLanguage(null); |
||
| 159 | } |
||
| 160 | if (property_exists($data, 'exchangeRate') && $data->{'exchangeRate'} !== null) { |
||
| 161 | $object->setExchangeRate($data->{'exchangeRate'}); |
||
| 162 | } elseif (property_exists($data, 'exchangeRate') && $data->{'exchangeRate'} === null) { |
||
| 163 | $object->setExchangeRate(null); |
||
| 164 | } |
||
| 165 | if (property_exists($data, 'credit') && $data->{'credit'} !== null) { |
||
| 166 | $object->setCredit($data->{'credit'}); |
||
| 167 | } elseif (property_exists($data, 'credit') && $data->{'credit'} === null) { |
||
| 168 | $object->setCredit(null); |
||
| 169 | } |
||
| 170 | if (property_exists($data, 'invoiceRows') && $data->{'invoiceRows'} !== null) { |
||
| 171 | $values = []; |
||
| 172 | foreach ($data->{'invoiceRows'} as $value) { |
||
| 173 | $values[] = $this->denormalizer->denormalize($value, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\InvoiceRow', 'json', $context); |
||
| 174 | } |
||
| 175 | $object->setInvoiceRows($values); |
||
| 176 | } elseif (property_exists($data, 'invoiceRows') && $data->{'invoiceRows'} === null) { |
||
| 177 | $object->setInvoiceRows(null); |
||
| 178 | } |
||
| 179 | |||
| 180 | return $object; |
||
| 181 | } |
||
| 329 |
Loading history...