Harborn-digital /
timechimp-bundle
| Total Complexity | 130 |
| Total Lines | 286 |
| Duplicated Lines | 0 % |
| Coverage | 0% |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like TimeNormalizer often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use TimeNormalizer, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 19 | class TimeNormalizer implements DenormalizerInterface, NormalizerInterface, DenormalizerAwareInterface, NormalizerAwareInterface |
||
| 20 | { |
||
| 21 | use DenormalizerAwareTrait; |
||
| 22 | use NormalizerAwareTrait; |
||
| 23 | |||
| 24 | public function supportsDenormalization($data, $type, $format = null) |
||
| 25 | { |
||
| 26 | return $type === 'ConnectHolland\\TimechimpBundle\\Api\\Model\\Time'; |
||
| 27 | } |
||
| 28 | |||
| 29 | public function supportsNormalization($data, $format = null) |
||
| 30 | { |
||
| 31 | return is_object($data) && get_class($data) === 'ConnectHolland\\TimechimpBundle\\Api\\Model\\Time'; |
||
| 32 | } |
||
| 33 | |||
| 34 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 35 | { |
||
| 36 | if (!is_object($data)) { |
||
| 37 | return null; |
||
| 38 | } |
||
| 39 | $object = new \ConnectHolland\TimechimpBundle\Api\Model\Time(); |
||
| 40 | if (property_exists($data, 'id') && $data->{'id'} !== null) { |
||
| 41 | $object->setId($data->{'id'}); |
||
| 42 | } elseif (property_exists($data, 'id') && $data->{'id'} === null) { |
||
| 43 | $object->setId(null); |
||
| 44 | } |
||
| 45 | if (property_exists($data, 'customerId') && $data->{'customerId'} !== null) { |
||
| 46 | $object->setCustomerId($data->{'customerId'}); |
||
| 47 | } elseif (property_exists($data, 'customerId') && $data->{'customerId'} === null) { |
||
| 48 | $object->setCustomerId(null); |
||
| 49 | } |
||
| 50 | if (property_exists($data, 'customerName') && $data->{'customerName'} !== null) { |
||
| 51 | $object->setCustomerName($data->{'customerName'}); |
||
| 52 | } elseif (property_exists($data, 'customerName') && $data->{'customerName'} === null) { |
||
| 53 | $object->setCustomerName(null); |
||
| 54 | } |
||
| 55 | if (property_exists($data, 'projectId') && $data->{'projectId'} !== null) { |
||
| 56 | $object->setProjectId($data->{'projectId'}); |
||
| 57 | } elseif (property_exists($data, 'projectId') && $data->{'projectId'} === null) { |
||
| 58 | $object->setProjectId(null); |
||
| 59 | } |
||
| 60 | if (property_exists($data, 'projectName') && $data->{'projectName'} !== null) { |
||
| 61 | $object->setProjectName($data->{'projectName'}); |
||
| 62 | } elseif (property_exists($data, 'projectName') && $data->{'projectName'} === null) { |
||
| 63 | $object->setProjectName(null); |
||
| 64 | } |
||
| 65 | if (property_exists($data, 'projectTaskId') && $data->{'projectTaskId'} !== null) { |
||
| 66 | $object->setProjectTaskId($data->{'projectTaskId'}); |
||
| 67 | } elseif (property_exists($data, 'projectTaskId') && $data->{'projectTaskId'} === null) { |
||
| 68 | $object->setProjectTaskId(null); |
||
| 69 | } |
||
| 70 | if (property_exists($data, 'taskId') && $data->{'taskId'} !== null) { |
||
| 71 | $object->setTaskId($data->{'taskId'}); |
||
| 72 | } elseif (property_exists($data, 'taskId') && $data->{'taskId'} === null) { |
||
| 73 | $object->setTaskId(null); |
||
| 74 | } |
||
| 75 | if (property_exists($data, 'taskName') && $data->{'taskName'} !== null) { |
||
| 76 | $object->setTaskName($data->{'taskName'}); |
||
| 77 | } elseif (property_exists($data, 'taskName') && $data->{'taskName'} === null) { |
||
| 78 | $object->setTaskName(null); |
||
| 79 | } |
||
| 80 | if (property_exists($data, 'userId') && $data->{'userId'} !== null) { |
||
| 81 | $object->setUserId($data->{'userId'}); |
||
| 82 | } elseif (property_exists($data, 'userId') && $data->{'userId'} === null) { |
||
| 83 | $object->setUserId(null); |
||
| 84 | } |
||
| 85 | if (property_exists($data, 'userDisplayName') && $data->{'userDisplayName'} !== null) { |
||
| 86 | $object->setUserDisplayName($data->{'userDisplayName'}); |
||
| 87 | } elseif (property_exists($data, 'userDisplayName') && $data->{'userDisplayName'} === null) { |
||
| 88 | $object->setUserDisplayName(null); |
||
| 89 | } |
||
| 90 | if (property_exists($data, 'userTags') && $data->{'userTags'} !== null) { |
||
| 91 | $values = []; |
||
| 92 | foreach ($data->{'userTags'} as $value) { |
||
| 93 | $values[] = $value; |
||
| 94 | } |
||
| 95 | $object->setUserTags($values); |
||
| 96 | } elseif (property_exists($data, 'userTags') && $data->{'userTags'} === null) { |
||
| 97 | $object->setUserTags(null); |
||
| 98 | } |
||
| 99 | if (property_exists($data, 'date') && $data->{'date'} !== null) { |
||
| 100 | $object->setDate(\DateTime::createFromFormat('Y-m-d\\TH:i:s', $data->{'date'})); |
||
|
Bug
introduced
by
|
|||
| 101 | } elseif (property_exists($data, 'date') && $data->{'date'} === null) { |
||
| 102 | $object->setDate(null); |
||
| 103 | } |
||
| 104 | if (property_exists($data, 'hours') && $data->{'hours'} !== null) { |
||
| 105 | $object->setHours($data->{'hours'}); |
||
| 106 | } elseif (property_exists($data, 'hours') && $data->{'hours'} === null) { |
||
| 107 | $object->setHours(null); |
||
| 108 | } |
||
| 109 | if (property_exists($data, 'notes') && $data->{'notes'} !== null) { |
||
| 110 | $object->setNotes($data->{'notes'}); |
||
| 111 | } elseif (property_exists($data, 'notes') && $data->{'notes'} === null) { |
||
| 112 | $object->setNotes(null); |
||
| 113 | } |
||
| 114 | if (property_exists($data, 'status') && $data->{'status'} !== null) { |
||
| 115 | $object->setStatus($data->{'status'}); |
||
| 116 | } elseif (property_exists($data, 'status') && $data->{'status'} === null) { |
||
| 117 | $object->setStatus(null); |
||
| 118 | } |
||
| 119 | if (property_exists($data, 'startEnd') && $data->{'startEnd'} !== null) { |
||
| 120 | $object->setStartEnd($data->{'startEnd'}); |
||
| 121 | } elseif (property_exists($data, 'startEnd') && $data->{'startEnd'} === null) { |
||
| 122 | $object->setStartEnd(null); |
||
| 123 | } |
||
| 124 | if (property_exists($data, 'start') && $data->{'start'} !== null) { |
||
| 125 | $object->setStart($data->{'start'}); |
||
| 126 | } elseif (property_exists($data, 'start') && $data->{'start'} === null) { |
||
| 127 | $object->setStart(null); |
||
| 128 | } |
||
| 129 | if (property_exists($data, 'end') && $data->{'end'} !== null) { |
||
| 130 | $object->setEnd($data->{'end'}); |
||
| 131 | } elseif (property_exists($data, 'end') && $data->{'end'} === null) { |
||
| 132 | $object->setEnd(null); |
||
| 133 | } |
||
| 134 | if (property_exists($data, 'pause') && $data->{'pause'} !== null) { |
||
| 135 | $object->setPause($data->{'pause'}); |
||
| 136 | } elseif (property_exists($data, 'pause') && $data->{'pause'} === null) { |
||
| 137 | $object->setPause(null); |
||
| 138 | } |
||
| 139 | if (property_exists($data, 'externalName') && $data->{'externalName'} !== null) { |
||
| 140 | $object->setExternalName($data->{'externalName'}); |
||
| 141 | } elseif (property_exists($data, 'externalName') && $data->{'externalName'} === null) { |
||
| 142 | $object->setExternalName(null); |
||
| 143 | } |
||
| 144 | if (property_exists($data, 'externalUrl') && $data->{'externalUrl'} !== null) { |
||
| 145 | $object->setExternalUrl($data->{'externalUrl'}); |
||
| 146 | } elseif (property_exists($data, 'externalUrl') && $data->{'externalUrl'} === null) { |
||
| 147 | $object->setExternalUrl(null); |
||
| 148 | } |
||
| 149 | if (property_exists($data, 'statusIntern') && $data->{'statusIntern'} !== null) { |
||
| 150 | $object->setStatusIntern($data->{'statusIntern'}); |
||
| 151 | } elseif (property_exists($data, 'statusIntern') && $data->{'statusIntern'} === null) { |
||
| 152 | $object->setStatusIntern(null); |
||
| 153 | } |
||
| 154 | if (property_exists($data, 'statusExtern') && $data->{'statusExtern'} !== null) { |
||
| 155 | $object->setStatusExtern($data->{'statusExtern'}); |
||
| 156 | } elseif (property_exists($data, 'statusExtern') && $data->{'statusExtern'} === null) { |
||
| 157 | $object->setStatusExtern(null); |
||
| 158 | } |
||
| 159 | if (property_exists($data, 'tags') && $data->{'tags'} !== null) { |
||
| 160 | $values_1 = []; |
||
| 161 | foreach ($data->{'tags'} as $value_1) { |
||
| 162 | $values_1[] = $this->denormalizer->denormalize($value_1, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\Tag', 'json', $context); |
||
| 163 | } |
||
| 164 | $object->setTags($values_1); |
||
| 165 | } elseif (property_exists($data, 'tags') && $data->{'tags'} === null) { |
||
| 166 | $object->setTags(null); |
||
| 167 | } |
||
| 168 | |||
| 169 | return $object; |
||
| 170 | } |
||
| 171 | |||
| 172 | public function normalize($object, $format = null, array $context = []) |
||
| 305 | } |
||
| 306 | } |
||
| 307 |
Loading history...