Harborn-digital /
timechimp-bundle
| Conditions | 40 |
| Paths | 1 |
| Total Lines | 126 |
| Code Lines | 84 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 1640 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 35 | public function denormalize($data, $class, $format = null, array $context = []) |
||
| 36 | { |
||
| 37 | if (!is_object($data)) { |
||
| 38 | throw new InvalidArgumentException(sprintf('Given $data is not an object (%s given). We need an object in order to continue denormalize method.', gettype($data))); |
||
| 39 | } |
||
| 40 | $object = new \ConnectHolland\TimechimpBundle\Api\Model\Project(); |
||
| 41 | if (property_exists($data, 'remainingBudgetHours')) { |
||
| 42 | $object->setRemainingBudgetHours($data->{'remainingBudgetHours'}); |
||
| 43 | } |
||
| 44 | if (property_exists($data, 'tagIds')) { |
||
| 45 | $values = []; |
||
| 46 | foreach ($data->{'tagIds'} as $value) { |
||
| 47 | $values[] = $value; |
||
| 48 | } |
||
| 49 | $object->setTagIds($values); |
||
| 50 | } |
||
| 51 | if (property_exists($data, 'tagNames')) { |
||
| 52 | $values_1 = []; |
||
| 53 | foreach ($data->{'tagNames'} as $value_1) { |
||
| 54 | $values_1[] = $value_1; |
||
| 55 | } |
||
| 56 | $object->setTagNames($values_1); |
||
| 57 | } |
||
| 58 | if (property_exists($data, 'unspecified')) { |
||
| 59 | $object->setUnspecified($data->{'unspecified'}); |
||
| 60 | } |
||
| 61 | if (property_exists($data, 'invoiceDate')) { |
||
| 62 | $object->setInvoiceDate(\DateTime::createFromFormat('Y-m-d\\TH:i:sP', $data->{'invoiceDate'})); |
||
|
Bug
introduced
by
|
|||
| 63 | } |
||
| 64 | if (property_exists($data, 'invoiceInInstallments')) { |
||
| 65 | $object->setInvoiceInInstallments($data->{'invoiceInInstallments'}); |
||
| 66 | } |
||
| 67 | if (property_exists($data, 'budgetNotificationPercentage')) { |
||
| 68 | $object->setBudgetNotificationPercentage($data->{'budgetNotificationPercentage'}); |
||
| 69 | } |
||
| 70 | if (property_exists($data, 'budgetNotificationHasBeenSent')) { |
||
| 71 | $object->setBudgetNotificationHasBeenSent($data->{'budgetNotificationHasBeenSent'}); |
||
| 72 | } |
||
| 73 | if (property_exists($data, 'clientId')) { |
||
| 74 | $object->setClientId($data->{'clientId'}); |
||
| 75 | } |
||
| 76 | if (property_exists($data, 'invoiceStatus')) { |
||
| 77 | $object->setInvoiceStatus($data->{'invoiceStatus'}); |
||
| 78 | } |
||
| 79 | if (property_exists($data, 'invoiceId')) { |
||
| 80 | $object->setInvoiceId($data->{'invoiceId'}); |
||
| 81 | } |
||
| 82 | if (property_exists($data, 'color')) { |
||
| 83 | $object->setColor($data->{'color'}); |
||
| 84 | } |
||
| 85 | if (property_exists($data, 'visibleOnSchedule')) { |
||
| 86 | $object->setVisibleOnSchedule($data->{'visibleOnSchedule'}); |
||
| 87 | } |
||
| 88 | if (property_exists($data, 'externalUrl')) { |
||
| 89 | $object->setExternalUrl($data->{'externalUrl'}); |
||
| 90 | } |
||
| 91 | if (property_exists($data, 'externalName')) { |
||
| 92 | $object->setExternalName($data->{'externalName'}); |
||
| 93 | } |
||
| 94 | if (property_exists($data, 'invoiceReference')) { |
||
| 95 | $object->setInvoiceReference($data->{'invoiceReference'}); |
||
| 96 | } |
||
| 97 | if (property_exists($data, 'projectTasks')) { |
||
| 98 | $values_2 = []; |
||
| 99 | foreach ($data->{'projectTasks'} as $value_2) { |
||
| 100 | $values_2[] = $this->denormalizer->denormalize($value_2, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\ProjectTask', 'json', $context); |
||
| 101 | } |
||
| 102 | $object->setProjectTasks($values_2); |
||
| 103 | } |
||
| 104 | if (property_exists($data, 'projectUsers')) { |
||
| 105 | $values_3 = []; |
||
| 106 | foreach ($data->{'projectUsers'} as $value_3) { |
||
| 107 | $values_3[] = $this->denormalizer->denormalize($value_3, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\ProjectUser', 'json', $context); |
||
| 108 | } |
||
| 109 | $object->setProjectUsers($values_3); |
||
| 110 | } |
||
| 111 | if (property_exists($data, 'id')) { |
||
| 112 | $object->setId($data->{'id'}); |
||
| 113 | } |
||
| 114 | if (property_exists($data, 'active')) { |
||
| 115 | $object->setActive($data->{'active'}); |
||
| 116 | } |
||
| 117 | if (property_exists($data, 'customerId')) { |
||
| 118 | $object->setCustomerId($data->{'customerId'}); |
||
| 119 | } |
||
| 120 | if (property_exists($data, 'customerName')) { |
||
| 121 | $object->setCustomerName($data->{'customerName'}); |
||
| 122 | } |
||
| 123 | if (property_exists($data, 'name')) { |
||
| 124 | $object->setName($data->{'name'}); |
||
| 125 | } |
||
| 126 | if (property_exists($data, 'code')) { |
||
| 127 | $object->setCode($data->{'code'}); |
||
| 128 | } |
||
| 129 | if (property_exists($data, 'notes')) { |
||
| 130 | $object->setNotes($data->{'notes'}); |
||
| 131 | } |
||
| 132 | if (property_exists($data, 'invoiceMethod')) { |
||
| 133 | $object->setInvoiceMethod($data->{'invoiceMethod'}); |
||
| 134 | } |
||
| 135 | if (property_exists($data, 'hourlyRate')) { |
||
| 136 | $object->setHourlyRate($data->{'hourlyRate'}); |
||
| 137 | } |
||
| 138 | if (property_exists($data, 'rate')) { |
||
| 139 | $object->setRate($data->{'rate'}); |
||
| 140 | } |
||
| 141 | if (property_exists($data, 'budgetMethod')) { |
||
| 142 | $object->setBudgetMethod($data->{'budgetMethod'}); |
||
| 143 | } |
||
| 144 | if (property_exists($data, 'budgetRate')) { |
||
| 145 | $object->setBudgetRate($data->{'budgetRate'}); |
||
| 146 | } |
||
| 147 | if (property_exists($data, 'budgetHours')) { |
||
| 148 | $object->setBudgetHours($data->{'budgetHours'}); |
||
| 149 | } |
||
| 150 | if (property_exists($data, 'startDate')) { |
||
| 151 | $object->setStartDate(\DateTime::createFromFormat('Y-m-d\\TH:i:sP', $data->{'startDate'})); |
||
| 152 | } |
||
| 153 | if (property_exists($data, 'endDate')) { |
||
| 154 | $object->setEndDate(\DateTime::createFromFormat('Y-m-d\\TH:i:sP', $data->{'endDate'})); |
||
| 155 | } |
||
| 156 | if (property_exists($data, 'projectSubscription')) { |
||
| 157 | $object->setProjectSubscription($this->denormalizer->denormalize($data->{'projectSubscription'}, 'ConnectHolland\\TimechimpBundle\\Api\\Model\\ProjectSubscription', 'json', $context)); |
||
| 158 | } |
||
| 159 | |||
| 160 | return $object; |
||
| 161 | } |
||
| 288 |
Loading history...